diff options
author | erg <erg@chromium.org> | 2015-01-05 17:14:54 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-01-06 01:16:29 +0000 |
commit | a46fb4a0dc274b9ae9da4d793f7f38fc1ea1e7c1 (patch) | |
tree | ae8cb931f2f5d6fbec0e298d42ab8cf54f2afc1e | |
parent | a32f1fb46916344f3975c3b1eddef6e34a0cd9da (diff) | |
download | chromium_src-a46fb4a0dc274b9ae9da4d793f7f38fc1ea1e7c1.zip chromium_src-a46fb4a0dc274b9ae9da4d793f7f38fc1ea1e7c1.tar.gz chromium_src-a46fb4a0dc274b9ae9da4d793f7f38fc1ea1e7c1.tar.bz2 |
linux_aura: Reenable some browser tests.
BUG=163931
Review URL: https://codereview.chromium.org/840483002
Cr-Commit-Position: refs/heads/master@{#310024}
4 files changed, 5 insertions, 38 deletions
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc index 90c43a3..3a4fed6 100644 --- a/chrome/browser/apps/app_browsertest.cc +++ b/chrome/browser/apps/app_browsertest.cc @@ -361,14 +361,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, AppWithContextMenuClicked) { ASSERT_TRUE(onclicked_listener.WaitUntilSatisfied()); } -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) -// TODO(erg): linux_aura bringup: http://crbug.com/163931 -#define MAYBE_DisallowNavigation DISABLED_DisallowNavigation -#else -#define MAYBE_DisallowNavigation DisallowNavigation -#endif - -IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_DisallowNavigation) { +IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DisallowNavigation) { TabsAddedNotificationObserver observer(2); ASSERT_TRUE(StartEmbeddedTestServer()); @@ -538,17 +531,10 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, << message_; } -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) -// TODO(erg): linux_aura bringup: http://crbug.com/163931 -#define MAYBE_LaunchWithFileExtensionAndMimeType DISABLED_LaunchWithFileExtensionAndMimeType -#else -#define MAYBE_LaunchWithFileExtensionAndMimeType LaunchWithFileExtensionAndMimeType -#endif - // Tests that launch data is sent through if the file extension and MIME type // both match. IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, - MAYBE_LaunchWithFileExtensionAndMimeType) { + LaunchWithFileExtensionAndMimeType) { SetCommandLineArg(kTestFilePath); ASSERT_TRUE(RunPlatformAppTest( "platform_apps/launch_file_by_extension_and_type")) << message_; @@ -1104,15 +1090,9 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_Messaging) { EXPECT_TRUE(result_catcher.GetNextResult()); } -// TODO(linux_aura) http://crbug.com/163931 -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) -#define MAYBE_WebContentsHasFocus DISABLED_WebContentsHasFocus -#else // This test depends on focus and so needs to be in interactive_ui_tests. // http://crbug.com/227041 -#define MAYBE_WebContentsHasFocus DISABLED_WebContentsHasFocus -#endif -IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_WebContentsHasFocus) { +IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DISABLED_WebContentsHasFocus) { LoadAndLaunchPlatformApp("minimal", "Launched"); EXPECT_EQ(1LU, GetAppWindowCount()); diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc index 58d0241..977122a 100644 --- a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc +++ b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc @@ -114,18 +114,10 @@ IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest, } #endif // !defined(OS_MACOSX) -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) -// TODO(erg): linux_aura bringup: http://crbug.com/163931 -#define MAYBE_DeleteDelegateBeforePopupHidden \ - DISABLED_DeleteDelegateBeforePopupHidden -#else -#define MAYBE_DeleteDelegateBeforePopupHidden DeleteDelegateBeforePopupHidden -#endif - // This test checks that the browser doesn't crash if the delegate is deleted // before the popup is hidden. IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest, - MAYBE_DeleteDelegateBeforePopupHidden){ + DeleteDelegateBeforePopupHidden){ GenerateTestAutofillPopup(autofill_external_delegate_.get()); // Delete the external delegate here so that is gets deleted before popup is diff --git a/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc b/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc index ec50d22..a876f7f 100644 --- a/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc +++ b/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc @@ -647,7 +647,6 @@ IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest, ASSERT_TRUE(IsWindowFullscreenForTabOrPending()); } -// TODO(erg): linux_aura bringup: http://crbug.com/163931 // Flaky on Windows, Linux, CrOS: http://crbug.com/159000 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS) #define MAYBE_MouseLockSilentAfterTargetUnlock \ diff --git a/chrome/browser/ui/webui/bookmarks_ui_browsertest.cc b/chrome/browser/ui/webui/bookmarks_ui_browsertest.cc index c637169..c516033 100644 --- a/chrome/browser/ui/webui/bookmarks_ui_browsertest.cc +++ b/chrome/browser/ui/webui/bookmarks_ui_browsertest.cc @@ -58,12 +58,8 @@ IN_PROC_BROWSER_TEST_F(BookmarksTest, CommandOpensBookmarksTab) { AssertIsBookmarksPage(browser()->tab_strip_model()->GetActiveWebContents()); } -// TODO(linux_aura): http://crbug.com/163931 -#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) -#define MAYBE_CommandAgainGoesBackToBookmarksTab \ - DISABLED_CommandAgainGoesBackToBookmarksTab // Flaky on Mac: http://crbug.com/87200 -#elif defined(OS_MACOSX) +#if defined(OS_MACOSX) #define MAYBE_CommandAgainGoesBackToBookmarksTab \ DISABLED_CommandAgainGoesBackToBookmarksTab #else |