summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpkasting <pkasting@chromium.org>2015-04-09 18:42:26 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-10 01:42:55 +0000
commita9269aa44a5e71261a12bd576a7cc09466f0dd8e (patch)
tree366155c03672dbb16e6c8d41b9ba686208a6b030
parent3ba111306b6a43f51c4dfb97536b8d77eb523d69 (diff)
downloadchromium_src-a9269aa44a5e71261a12bd576a7cc09466f0dd8e.zip
chromium_src-a9269aa44a5e71261a12bd576a7cc09466f0dd8e.tar.gz
chromium_src-a9269aa44a5e71261a12bd576a7cc09466f0dd8e.tar.bz2
Modify instrumentation for various jank bugs, mostly removing outdated sites.
BUG=465458,424359,455952,456373,455942,456327 TEST=none TBR=jochen,rvargas Review URL: https://codereview.chromium.org/1073033002 Cr-Commit-Position: refs/heads/master@{#324568}
-rw-r--r--base/threading/thread.cc7
-rw-r--r--chrome/browser/devtools/devtools_network_transaction.cc6
-rw-r--r--content/browser/loader/resource_dispatcher_host_impl.cc13
-rw-r--r--net/cookies/cookie_monster.cc8
-rw-r--r--net/http/http_network_transaction.cc121
-rw-r--r--net/http/http_stream_parser.cc50
-rw-r--r--net/proxy/proxy_script_decider.cc5
-rw-r--r--net/proxy/proxy_service.cc19
-rw-r--r--net/url_request/url_fetcher_core.cc16
-rw-r--r--net/url_request/url_request.cc4
-rw-r--r--net/url_request/url_request_http_job.cc10
11 files changed, 166 insertions, 93 deletions
diff --git a/base/threading/thread.cc b/base/threading/thread.cc
index ea5b174..d42ba4d 100644
--- a/base/threading/thread.cc
+++ b/base/threading/thread.cc
@@ -95,11 +95,6 @@ bool Thread::Start() {
}
bool Thread::StartWithOptions(const Options& options) {
- // TODO(eroman): Remove once crbug.com/465458 is solved.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "465458 base::Thread::StartWithOptions"));
-
DCHECK(!message_loop_);
#if defined(OS_WIN)
DCHECK((com_status_ != STA) ||
@@ -117,7 +112,7 @@ bool Thread::StartWithOptions(const Options& options) {
return false;
}
- // TODO(eroman): Remove once crbug.com/465458 is solved.
+ // TODO(kinuko): Remove once crbug.com/465458 is solved.
tracked_objects::ScopedTracker tracking_profile_wait(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"465458 base::Thread::StartWithOptions (Wait)"));
diff --git a/chrome/browser/devtools/devtools_network_transaction.cc b/chrome/browser/devtools/devtools_network_transaction.cc
index 1f719c8..6a0f1b5 100644
--- a/chrome/browser/devtools/devtools_network_transaction.cc
+++ b/chrome/browser/devtools/devtools_network_transaction.cc
@@ -4,7 +4,6 @@
#include "chrome/browser/devtools/devtools_network_transaction.h"
-#include "base/profiler/scoped_tracker.h"
#include "chrome/browser/devtools/devtools_network_controller.h"
#include "chrome/browser/devtools/devtools_network_interceptor.h"
#include "net/base/net_errors.h"
@@ -53,11 +52,6 @@ void DevToolsNetworkTransaction::Throttle(int result) {
}
void DevToolsNetworkTransaction::OnCallback(int rv) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/424359 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "424359 DevToolsNetworkTransaction::OnCallback"));
-
if (failed_)
return;
DCHECK(!callback_.is_null());
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index 4f9f2f7..4c3a0cb 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -2172,20 +2172,15 @@ ResourceDispatcherHostImpl::GetLoadInfoForAllRoutes() {
}
void ResourceDispatcherHostImpl::UpdateLoadInfo() {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/455952 is
- // fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "455952 ResourceDispatcherHostImpl::UpdateLoadInfo"));
-
scoped_ptr<LoadInfoMap> info_map(GetLoadInfoForAllRoutes());
if (info_map->empty())
return;
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "455952 ResourceDispatcherHostImpl::UpdateLoadInfo2"));
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455952 is
+ // fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("455952 BrowserThread::PostTask()"));
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc
index 3b53969..e42d52a 100644
--- a/net/cookies/cookie_monster.cc
+++ b/net/cookies/cookie_monster.cc
@@ -766,10 +766,6 @@ class CookieMonster::SetCookieWithOptionsTask : public CookieMonsterTask {
};
void CookieMonster::SetCookieWithOptionsTask::Run() {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/456373 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "456373 CookieMonster::SetCookieWithOptionsTask::Run"));
bool result = this->cookie_monster()->SetCookieWithOptions(url_, cookie_line_,
options_);
if (!callback_.is_null()) {
@@ -848,7 +844,7 @@ class CookieMonster::GetCookiesWithOptionsTask : public CookieMonsterTask {
};
void CookieMonster::GetCookiesWithOptionsTask::Run() {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/456373 is fixed.
+ // TODO(mkwst): Remove ScopedTracker below once crbug.com/456373 is fixed.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"456373 CookieMonster::GetCookiesWithOptionsTask::Run"));
@@ -1812,7 +1808,7 @@ CookieMonster::CookieMap::iterator CookieMonster::InternalInsertCookie(
const std::string& key,
CanonicalCookie* cc,
bool sync_to_store) {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/456373 is fixed.
+ // TODO(mkwst): Remove ScopedTracker below once crbug.com/456373 is fixed.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"456373 CookieMonster::InternalInsertCookie"));
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 4af4cd64..b5e5d5c 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -602,23 +602,17 @@ void HttpNetworkTransaction::DoCallback(int rv) {
}
void HttpNetworkTransaction::OnIOComplete(int result) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/424359 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "424359 HttpNetworkTransaction::OnIOComplete 1"));
-
int rv = DoLoop(result);
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/424359 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "424359 HttpNetworkTransaction::OnIOComplete 2"));
-
if (rv != ERR_IO_PENDING)
DoCallback(rv);
}
int HttpNetworkTransaction::DoLoop(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoLoop"));
+
DCHECK(next_state_ != STATE_NONE);
int rv = result;
@@ -724,6 +718,11 @@ int HttpNetworkTransaction::DoLoop(int result) {
}
int HttpNetworkTransaction::DoNotifyBeforeCreateStream() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoNotifyBeforeCreateStream"));
+
next_state_ = STATE_CREATE_STREAM;
bool defer = false;
if (!before_network_start_callback_.is_null())
@@ -734,6 +733,11 @@ int HttpNetworkTransaction::DoNotifyBeforeCreateStream() {
}
int HttpNetworkTransaction::DoCreateStream() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoCreateStream"));
+
next_state_ = STATE_CREATE_STREAM_COMPLETE;
if (ForWebSocketHandshake()) {
stream_request_.reset(
@@ -761,6 +765,11 @@ int HttpNetworkTransaction::DoCreateStream() {
}
int HttpNetworkTransaction::DoCreateStreamComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoCreateStreamComplete"));
+
if (result == OK) {
next_state_ = STATE_INIT_STREAM;
DCHECK(stream_.get());
@@ -785,12 +794,22 @@ int HttpNetworkTransaction::DoCreateStreamComplete(int result) {
}
int HttpNetworkTransaction::DoInitStream() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoInitStream"));
+
DCHECK(stream_.get());
next_state_ = STATE_INIT_STREAM_COMPLETE;
return stream_->InitializeStream(request_, priority_, net_log_, io_callback_);
}
int HttpNetworkTransaction::DoInitStreamComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoInitStreamComplete"));
+
if (result == OK) {
next_state_ = STATE_GENERATE_PROXY_AUTH_TOKEN;
} else {
@@ -807,6 +826,11 @@ int HttpNetworkTransaction::DoInitStreamComplete(int result) {
}
int HttpNetworkTransaction::DoGenerateProxyAuthToken() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoGenerateProxyAuthToken"));
+
next_state_ = STATE_GENERATE_PROXY_AUTH_TOKEN_COMPLETE;
if (!ShouldApplyProxyAuth())
return OK;
@@ -823,6 +847,11 @@ int HttpNetworkTransaction::DoGenerateProxyAuthToken() {
}
int HttpNetworkTransaction::DoGenerateProxyAuthTokenComplete(int rv) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoGenerateProxyAuthTokenComplete"));
+
DCHECK_NE(ERR_IO_PENDING, rv);
if (rv == OK)
next_state_ = STATE_GENERATE_SERVER_AUTH_TOKEN;
@@ -830,6 +859,11 @@ int HttpNetworkTransaction::DoGenerateProxyAuthTokenComplete(int rv) {
}
int HttpNetworkTransaction::DoGenerateServerAuthToken() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoGenerateServerAuthToken"));
+
next_state_ = STATE_GENERATE_SERVER_AUTH_TOKEN_COMPLETE;
HttpAuth::Target target = HttpAuth::AUTH_SERVER;
if (!auth_controllers_[target].get()) {
@@ -849,6 +883,11 @@ int HttpNetworkTransaction::DoGenerateServerAuthToken() {
}
int HttpNetworkTransaction::DoGenerateServerAuthTokenComplete(int rv) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoGenerateServerAuthTokenComplete"));
+
DCHECK_NE(ERR_IO_PENDING, rv);
if (rv == OK)
next_state_ = STATE_INIT_REQUEST_BODY;
@@ -914,6 +953,11 @@ void HttpNetworkTransaction::BuildRequestHeaders(
}
int HttpNetworkTransaction::DoInitRequestBody() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoInitRequestBody"));
+
next_state_ = STATE_INIT_REQUEST_BODY_COMPLETE;
int rv = OK;
if (request_->upload_data_stream)
@@ -922,12 +966,22 @@ int HttpNetworkTransaction::DoInitRequestBody() {
}
int HttpNetworkTransaction::DoInitRequestBodyComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoInitRequestBodyComplete"));
+
if (result == OK)
next_state_ = STATE_BUILD_REQUEST;
return result;
}
int HttpNetworkTransaction::DoBuildRequest() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoBuildRequest"));
+
next_state_ = STATE_BUILD_REQUEST_COMPLETE;
headers_valid_ = false;
@@ -942,12 +996,22 @@ int HttpNetworkTransaction::DoBuildRequest() {
}
int HttpNetworkTransaction::DoBuildRequestComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoBuildRequestComplete"));
+
if (result == OK)
next_state_ = STATE_SEND_REQUEST;
return result;
}
int HttpNetworkTransaction::DoSendRequest() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoSendRequest"));
+
send_start_time_ = base::TimeTicks::Now();
next_state_ = STATE_SEND_REQUEST_COMPLETE;
@@ -955,6 +1019,11 @@ int HttpNetworkTransaction::DoSendRequest() {
}
int HttpNetworkTransaction::DoSendRequestComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoSendRequestComplete"));
+
send_end_time_ = base::TimeTicks::Now();
if (result < 0)
return HandleIOError(result);
@@ -964,11 +1033,21 @@ int HttpNetworkTransaction::DoSendRequestComplete(int result) {
}
int HttpNetworkTransaction::DoReadHeaders() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoReadHeaders"));
+
next_state_ = STATE_READ_HEADERS_COMPLETE;
return stream_->ReadResponseHeaders(io_callback_);
}
int HttpNetworkTransaction::DoReadHeadersComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoReadHeadersComplete"));
+
// We can get a certificate error or ERR_SSL_CLIENT_AUTH_CERT_NEEDED here
// due to SSL renegotiation.
if (IsCertificateError(result)) {
@@ -1070,6 +1149,11 @@ int HttpNetworkTransaction::DoReadHeadersComplete(int result) {
}
int HttpNetworkTransaction::DoReadBody() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoReadBody"));
+
DCHECK(read_buf_.get());
DCHECK_GT(read_buf_len_, 0);
DCHECK(stream_ != NULL);
@@ -1080,6 +1164,11 @@ int HttpNetworkTransaction::DoReadBody() {
}
int HttpNetworkTransaction::DoReadBodyComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoReadBodyComplete"));
+
// We are done with the Read call.
bool done = false;
if (result <= 0) {
@@ -1125,6 +1214,11 @@ int HttpNetworkTransaction::DoReadBodyComplete(int result) {
}
int HttpNetworkTransaction::DoDrainBodyForAuthRestart() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoDrainBodyForAuthRestart"));
+
// This method differs from DoReadBody only in the next_state_. So we just
// call DoReadBody and override the next_state_. Perhaps there is a more
// elegant way for these two methods to share code.
@@ -1137,6 +1231,11 @@ int HttpNetworkTransaction::DoDrainBodyForAuthRestart() {
// TODO(wtc): This method and the DoReadBodyComplete method are almost
// the same. Figure out a good way for these two methods to share code.
int HttpNetworkTransaction::DoDrainBodyForAuthRestartComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpNetworkTransaction::DoDrainBodyForAuthRestartComplete"));
+
// keep_alive defaults to true because the very reason we're draining the
// response body is to reuse the connection for auth restart.
bool done = false, keep_alive = true;
diff --git a/net/http/http_stream_parser.cc b/net/http/http_stream_parser.cc
index c8f7ecc..fc04a7d 100644
--- a/net/http/http_stream_parser.cc
+++ b/net/http/http_stream_parser.cc
@@ -363,11 +363,6 @@ void HttpStreamParser::OnIOComplete(int result) {
// The client callback can do anything, including destroying this class,
// so any pending callback must be issued after everything else is done.
if (result != ERR_IO_PENDING && !callback_.is_null()) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/424359 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "424359 HttpStreamParser::OnIOComplete callback"));
-
CompletionCallback c = callback_;
callback_.Reset();
c.Run(result);
@@ -375,7 +370,7 @@ void HttpStreamParser::OnIOComplete(int result) {
}
int HttpStreamParser::DoLoop(int result) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION("424359 HttpStreamParser::DoLoop"));
@@ -431,6 +426,11 @@ int HttpStreamParser::DoLoop(int result) {
}
int HttpStreamParser::DoSendHeaders() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpStreamParser::DoSendHeaders"));
+
int bytes_remaining = request_headers_->BytesRemaining();
DCHECK_GT(bytes_remaining, 0);
@@ -445,6 +445,11 @@ int HttpStreamParser::DoSendHeaders() {
}
int HttpStreamParser::DoSendHeadersComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpStreamParser::DoSendHeadersComplete"));
+
if (result < 0) {
// In the unlikely case that the headers and body were merged, all the
// the headers were sent, but not all of the body way, and |result| is
@@ -484,6 +489,10 @@ int HttpStreamParser::DoSendHeadersComplete(int result) {
}
int HttpStreamParser::DoSendBody() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("424359 HttpStreamParser::DoSendBody"));
+
if (request_body_send_buf_->BytesRemaining() > 0) {
io_state_ = STATE_SEND_BODY_COMPLETE;
return connection_->socket()
@@ -505,6 +514,11 @@ int HttpStreamParser::DoSendBody() {
}
int HttpStreamParser::DoSendBodyComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpStreamParser::DoSendBodyComplete"));
+
if (result < 0) {
// If |result| is an error that this should try reading after, stash the
// error for now and act like the request was successfully sent.
@@ -522,6 +536,11 @@ int HttpStreamParser::DoSendBodyComplete(int result) {
}
int HttpStreamParser::DoSendRequestReadBodyComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpStreamParser::DoSendRequestReadBodyComplete"));
+
// |result| is the result of read from the request body from the last call to
// DoSendBody().
DCHECK_GE(result, 0); // There won't be errors.
@@ -555,6 +574,11 @@ int HttpStreamParser::DoSendRequestReadBodyComplete(int result) {
}
int HttpStreamParser::DoReadHeaders() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpStreamParser::DoReadHeaders"));
+
io_state_ = STATE_READ_HEADERS_COMPLETE;
// Grow the read buffer if necessary.
@@ -570,6 +594,11 @@ int HttpStreamParser::DoReadHeaders() {
}
int HttpStreamParser::DoReadHeadersComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpStreamParser::DoReadHeadersComplete"));
+
result = HandleReadHeaderResult(result);
// TODO(mmenke): The code below is ugly and hacky. A much better and more
@@ -617,6 +646,10 @@ int HttpStreamParser::DoReadHeadersComplete(int result) {
}
int HttpStreamParser::DoReadBody() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("424359 HttpStreamParser::DoReadBody"));
+
io_state_ = STATE_READ_BODY_COMPLETE;
// There may be some data left over from reading the response headers.
@@ -650,6 +683,11 @@ int HttpStreamParser::DoReadBody() {
}
int HttpStreamParser::DoReadBodyComplete(int result) {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/424359 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "424359 HttpStreamParser::DoReadBodyComplete"));
+
// When the connection is closed, there are numerous ways to interpret it.
//
// - If a Content-Length header is present and the body contains exactly that
diff --git a/net/proxy/proxy_script_decider.cc b/net/proxy/proxy_script_decider.cc
index 53f2b43..27e7afb 100644
--- a/net/proxy/proxy_script_decider.cc
+++ b/net/proxy/proxy_script_decider.cc
@@ -10,7 +10,6 @@
#include "base/format_macros.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
@@ -88,10 +87,6 @@ ProxyScriptDecider::ProxyScriptDecider(
net_log_(BoundNetLog::Make(net_log, NetLog::SOURCE_PROXY_SCRIPT_DECIDER)),
fetch_pac_bytes_(false),
quick_check_enabled_(true) {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/455942 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "455942 ProxyScriptDecider::ProxyScriptDecider"));
if (proxy_script_fetcher &&
proxy_script_fetcher->GetRequestContext() &&
proxy_script_fetcher->GetRequestContext()->host_resolver()) {
diff --git a/net/proxy/proxy_service.cc b/net/proxy/proxy_service.cc
index 48cbadb..fe34f7b 100644
--- a/net/proxy/proxy_service.cc
+++ b/net/proxy/proxy_service.cc
@@ -393,11 +393,6 @@ class ProxyService::InitProxyResolver {
const ProxyConfig& config,
TimeDelta wait_delay,
const CompletionCallback& callback) {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/455942 is
- // fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "455942 ProxyService::InitProxyResolver::Start"));
DCHECK_EQ(STATE_NONE, next_state_);
proxy_resolver_ = proxy_resolver;
proxy_resolver_factory_ = proxy_resolver_factory;
@@ -505,8 +500,7 @@ class ProxyService::InitProxyResolver {
}
int DoDecideProxyScript() {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/455942 is
- // fixed.
+ // TODO(eroman): Remove ScopedTracker below once crbug.com/455942 is fixed.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"455942 ProxyService::InitProxyResolver::DoDecideProxyScript"));
@@ -519,12 +513,6 @@ class ProxyService::InitProxyResolver {
}
int DoDecideProxyScriptComplete(int result) {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/455942 is
- // fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "455942 "
- "ProxyService::InitProxyResolver::DoDecideProxyScriptComplete"));
if (result != OK)
return result;
@@ -536,11 +524,6 @@ class ProxyService::InitProxyResolver {
}
int DoSetPacScript() {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/455942 is
- // fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "455942 ProxyService::InitProxyResolver::DoSetPacScript"));
DCHECK(script_data_.get());
// TODO(eroman): Should log this latency to the NetLog.
next_state_ = STATE_SET_PAC_SCRIPT_COMPLETE;
diff --git a/net/url_request/url_fetcher_core.cc b/net/url_request/url_fetcher_core.cc
index 8bc81df..19ea48a 100644
--- a/net/url_request/url_fetcher_core.cc
+++ b/net/url_request/url_fetcher_core.cc
@@ -553,10 +553,6 @@ void URLFetcherCore::StartOnIOThread() {
}
void URLFetcherCore::StartURLRequest() {
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/456327 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "456327 URLFetcherCore::StartURLRequest1"));
DCHECK(network_task_runner_->BelongsToCurrentThread());
if (was_cancelled_) {
@@ -575,10 +571,6 @@ void URLFetcherCore::StartURLRequest() {
request_->set_stack_trace(stack_trace_);
int flags = request_->load_flags() | load_flags_;
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/456327 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "456327 URLFetcherCore::StartURLRequest2"));
if (is_chunked_upload_)
request_->EnableChunkedUpload();
request_->SetLoadFlags(flags);
@@ -591,10 +583,6 @@ void URLFetcherCore::StartURLRequest() {
url_request_create_data_callback_.Run());
}
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/456327 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "456327 URLFetcherCore::StartURLRequest3"));
switch (request_type_) {
case URLFetcher::GET:
break;
@@ -657,10 +645,6 @@ void URLFetcherCore::StartURLRequest() {
NOTREACHED();
}
- // TODO(pkasting): Remove ScopedTracker below once crbug.com/456327 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "456327 URLFetcherCore::StartURLRequest4"));
if (!extra_request_headers_.IsEmpty())
request_->SetExtraRequestHeaders(extra_request_headers_);
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 4a1e093..5786117 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -487,6 +487,10 @@ void URLRequest::set_delegate(Delegate* delegate) {
}
void URLRequest::Start() {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/456327 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("456327 URLRequest::Start"));
+
// Some values can be NULL, but the job factory must not be.
DCHECK(context_->job_factory());
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 890620a..33fb662 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -837,11 +837,6 @@ void URLRequestHttpJob::ProcessPublicKeyPinsHeader() {
}
void URLRequestHttpJob::OnStartCompleted(int result) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/424359 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "424359 URLRequestHttpJob::OnStartCompleted"));
-
RecordTimer();
// If the request was destroyed, then there is no more work to do.
@@ -944,11 +939,6 @@ void URLRequestHttpJob::OnHeadersReceivedCallback(int result) {
}
void URLRequestHttpJob::OnReadCompleted(int result) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/424359 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "424359 URLRequestHttpJob::OnReadCompleted"));
-
read_in_progress_ = false;
if (ShouldFixMismatchedContentLength(result))