diff options
| author | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-25 19:58:52 +0000 |
|---|---|---|
| committer | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-25 19:58:52 +0000 |
| commit | a9bbdd0a45deb6da08b59f89b11bc67aeb61ddb8 (patch) | |
| tree | 7c1b1bc96a202f0d05ea25260651e27212e30a15 | |
| parent | 670d793f195ae6bbe5521a8408ef213069579949 (diff) | |
| download | chromium_src-a9bbdd0a45deb6da08b59f89b11bc67aeb61ddb8.zip chromium_src-a9bbdd0a45deb6da08b59f89b11bc67aeb61ddb8.tar.gz chromium_src-a9bbdd0a45deb6da08b59f89b11bc67aeb61ddb8.tar.bz2 | |
Add histogram Net.QuicSession.SecureResourceSecureSession
to track request for secure resources over insecure connections.
R=jar@chromium.org
Review URL: https://codereview.chromium.org/211123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259310 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | net/quic/quic_http_stream.cc | 7 | ||||
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 8 |
2 files changed, 13 insertions, 2 deletions
diff --git a/net/quic/quic_http_stream.cc b/net/quic/quic_http_stream.cc index 3c96fbe..77bfc8d 100644 --- a/net/quic/quic_http_stream.cc +++ b/net/quic/quic_http_stream.cc @@ -5,6 +5,7 @@ #include "net/quic/quic_http_stream.h" #include "base/callback_helpers.h" +#include "base/metrics/histogram.h" #include "base/strings/stringprintf.h" #include "net/base/io_buffer.h" #include "net/base/net_errors.h" @@ -61,9 +62,11 @@ int QuicHttpStream::InitializeStream(const HttpRequestInfo* request_info, if (request_info->url.SchemeIsSecure()) { SSLInfo ssl_info; - if (!session_->GetSSLInfo(&ssl_info) || !ssl_info.cert) { + bool secure_session = session_->GetSSLInfo(&ssl_info) && ssl_info.cert; + UMA_HISTOGRAM_BOOLEAN("Net.QuicSession.SecureResourceSecureSession", + secure_session); + if (!secure_session) return ERR_REQUEST_FOR_SECURE_RESOURCE_OVER_INSECURE_QUIC; - } } stream_net_log_ = stream_net_log; diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index c1c5b5f..e8757fa 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -12570,6 +12570,14 @@ other types of suffix sets. </summary> </histogram> +<histogram name="Net.QuicSession.SecureResourceSecureSession"> + <owner>rch@chromium.org.</owner> + <summary> + The number of request for secure resources over QUIC sessions. True if the + session is secure, false if it is not. + </summary> +</histogram> + <histogram name="Net.QuicSession.TruncatedAcksReceived"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> <summary>The number of truncated ACK frames received.</summary> |