summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorglen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-24 17:41:11 +0000
committerglen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-24 17:41:11 +0000
commitab6513714d7bd8e5b13d99f89c2bff468b8dcce5 (patch)
tree8e55720052234726dd1402afaaa1577d1d4a170e
parentc9c4cc8c91f50175f5434c97142a9539bf3624f6 (diff)
downloadchromium_src-ab6513714d7bd8e5b13d99f89c2bff468b8dcce5.zip
chromium_src-ab6513714d7bd8e5b13d99f89c2bff468b8dcce5.tar.gz
chromium_src-ab6513714d7bd8e5b13d99f89c2bff468b8dcce5.tar.bz2
Remove the status bubble 1px overhang.
BUG=1015,1156722 Review URL: http://codereview.chromium.org/7907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3923 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/views/frame/browser_view.cc7
-rw-r--r--chrome/browser/views/frame/browser_view2.cc8
2 files changed, 9 insertions, 6 deletions
diff --git a/chrome/browser/views/frame/browser_view.cc b/chrome/browser/views/frame/browser_view.cc
index 038b26c..cc415ec 100644
--- a/chrome/browser/views/frame/browser_view.cc
+++ b/chrome/browser/views/frame/browser_view.cc
@@ -22,7 +22,8 @@
// Status Bubble metrics.
static const int kStatusBubbleHeight = 20;
-static const int kStatusBubbleOffset = 2;
+static const int kStatusBubbleHorizontalOffset = 3;
+static const int kStatusBubbleVerticalOffset = 2;
///////////////////////////////////////////////////////////////////////////////
// BrowserView, public:
@@ -42,9 +43,9 @@ BrowserView::~BrowserView() {
}
void BrowserView::LayoutStatusBubble(int status_bubble_y) {
- status_bubble_->SetBounds(kStatusBubbleOffset,
+ status_bubble_->SetBounds(kStatusBubbleHorizontalOffset,
status_bubble_y - kStatusBubbleHeight +
- kStatusBubbleOffset,
+ kStatusBubbleVerticalOffset,
width() / 3,
kStatusBubbleHeight);
}
diff --git a/chrome/browser/views/frame/browser_view2.cc b/chrome/browser/views/frame/browser_view2.cc
index c2474ba..0208185 100644
--- a/chrome/browser/views/frame/browser_view2.cc
+++ b/chrome/browser/views/frame/browser_view2.cc
@@ -48,7 +48,9 @@ static const int kTabShadowSize = 2;
// The height of the status bubble.
static const int kStatusBubbleHeight = 20;
// The distance of the status bubble from the left edge of the window.
-static const int kStatusBubbleOffset = 2;
+static const int kStatusBubbleHorizontalOffset = 3;
+// The distance of the status bubble from the bottom edge of the window.
+static const int kStatusBubbleVerticalOffset = 2;
// An offset distance between certain toolbars and the toolbar that preceded
// them in layout.
static const int kSeparationLineHeight = 1;
@@ -974,8 +976,8 @@ int BrowserView2::LayoutDownloadShelf() {
void BrowserView2::LayoutStatusBubble(int top) {
int status_bubble_y =
- top - kStatusBubbleHeight + kStatusBubbleOffset + y();
- status_bubble_->SetBounds(kStatusBubbleOffset, status_bubble_y,
+ top - kStatusBubbleHeight + kStatusBubbleVerticalOffset + y();
+ status_bubble_->SetBounds(kStatusBubbleHorizontalOffset, status_bubble_y,
width() / 3, kStatusBubbleHeight);
}