summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorcommit-queue@webkit.org <commit-queue@webkit.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538>2013-02-07 00:31:15 +0000
committercommit-queue@webkit.org <commit-queue@webkit.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538>2013-02-07 00:31:15 +0000
commitad26f4d55bf17930b434ceee11652db52c855a4e (patch)
tree66b88a5426a965e6bfe954b7c1e534af02f70bd6
parent0036cc8ff67949e0771b3ea549258d4b4e2b3005 (diff)
downloadchromium_src-ad26f4d55bf17930b434ceee11652db52c855a4e.zip
chromium_src-ad26f4d55bf17930b434ceee11652db52c855a4e.tar.gz
chromium_src-ad26f4d55bf17930b434ceee11652db52c855a4e.tar.bz2
Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-matching test
https://bugs.webkit.org/show_bug.cgi?id=109101 We check that the style matches a pseudo element by setting its height to 1px. Some user agents, like iOS, have default border styles that affect the minimum height, so we need to reset those. Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-06 Reviewed by Joseph Pecoraro. * fast/css/unknown-pseudo-element-matching.html: git-svn-id: svn://svn.chromium.org/blink/trunk@142052 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-rw-r--r--third_party/WebKit/LayoutTests/ChangeLog13
-rw-r--r--third_party/WebKit/LayoutTests/fast/css/unknown-pseudo-element-matching.html2
2 files changed, 14 insertions, 1 deletions
diff --git a/third_party/WebKit/LayoutTests/ChangeLog b/third_party/WebKit/LayoutTests/ChangeLog
index 74cb46d..9f7a535 100644
--- a/third_party/WebKit/LayoutTests/ChangeLog
+++ b/third_party/WebKit/LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
+2013-02-06 Dima Gorbik <dgorbik@apple.com>
+
+ Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-matching test
+ https://bugs.webkit.org/show_bug.cgi?id=109101
+
+ We check that the style matches a pseudo element by setting its height to 1px.
+ Some user agents, like iOS, have default border styles that affect the minimum height,
+ so we need to reset those.
+
+ Reviewed by Joseph Pecoraro.
+
+ * fast/css/unknown-pseudo-element-matching.html:
+
2013-02-06 Dirk Schulze <dschulze@adobe.com>
Context's currentPath should check for passed type
diff --git a/third_party/WebKit/LayoutTests/fast/css/unknown-pseudo-element-matching.html b/third_party/WebKit/LayoutTests/fast/css/unknown-pseudo-element-matching.html
index 790a1c7..e5675f0 100644
--- a/third_party/WebKit/LayoutTests/fast/css/unknown-pseudo-element-matching.html
+++ b/third_party/WebKit/LayoutTests/fast/css/unknown-pseudo-element-matching.html
@@ -15,7 +15,7 @@ var head;
var input;
var logDiv;
var NAMESPACE_DECLARATION = '@namespace "http://example.com/foo/namespace";\n@namespace html "http://www.w3.org/1999/xhtml";\n';
-var SELECTOR_TEST_PROPERTIES = ' { height: 1px; -webkit-appearance: none; }';
+var SELECTOR_TEST_PROPERTIES = ' { height: 1px; -webkit-appearance: none; border: none; }';
var SELECTORS = [
'::-webkit-slider-thumb',
'*::-webkit-slider-thumb',