diff options
| author | caseq@chromium.org <caseq@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-02 05:53:45 +0000 |
|---|---|---|
| committer | caseq@chromium.org <caseq@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-02 05:53:45 +0000 |
| commit | af2521c1b71a773058299cfee61ebd472fe32e54 (patch) | |
| tree | dd94214ead9ec51d215e168dbc1459d759ae94c6 | |
| parent | be78005c77e886ea03309074d4b7065427d2b9de (diff) | |
| download | chromium_src-af2521c1b71a773058299cfee61ebd472fe32e54.zip chromium_src-af2521c1b71a773058299cfee61ebd472fe32e54.tar.gz chromium_src-af2521c1b71a773058299cfee61ebd472fe32e54.tar.bz2 | |
Split trace messages into chunk based on size, not event count
base::StringPrintf() fails quietly for strings larger than 32M,
so we could send and empty message to the DevTools front-end,
Let's split trace event notifications into chunks based
on the chunk size rather than the event count as we used to do.
BUG=
Review URL: https://codereview.chromium.org/434113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287157 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | content/browser/devtools/devtools_tracing_handler.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/content/browser/devtools/devtools_tracing_handler.cc b/content/browser/devtools/devtools_tracing_handler.cc index 311775609..9b1f8e7 100644 --- a/content/browser/devtools/devtools_tracing_handler.cc +++ b/content/browser/devtools/devtools_tracing_handler.cc @@ -103,7 +103,8 @@ void DevToolsTracingHandler::ReadRecordingResult( if (buffer.size()) buffer.append(","); buffer.append(item); - if (i % 1000 == 0) { + const size_t kMessageSizeThreshold = 1024 * 1024; + if (buffer.size() > kMessageSizeThreshold) { OnTraceDataCollected(buffer); buffer.clear(); } |