diff options
| author | boliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-30 23:32:57 +0000 |
|---|---|---|
| committer | boliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-30 23:32:57 +0000 |
| commit | b23fe56a0060b9f3333f5e6168b35854bcea6e6c (patch) | |
| tree | 34de7fe6673ab775d48fc3efece04c2249ff9d53 | |
| parent | 846f1421d3f20955965f5ff608430aef41cce367 (diff) | |
| download | chromium_src-b23fe56a0060b9f3333f5e6168b35854bcea6e6c.zip chromium_src-b23fe56a0060b9f3333f5e6168b35854bcea6e6c.tar.gz chromium_src-b23fe56a0060b9f3333f5e6168b35854bcea6e6c.tar.bz2 | |
Merge 279144 "base: Default android version to 0.0.0"
> base: Default android version to 0.0.0
>
> If the android version string cannot be parsed for some reason, default
> the version to 0.0.0.
>
> BUG=387179
> TBR=ajwong@chromium.org
>
> Review URL: https://codereview.chromium.org/344113002
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/361813002
git-svn-id: svn://svn.chromium.org/chrome/branches/2062/src@280696 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | base/sys_info_android.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/base/sys_info_android.cc b/base/sys_info_android.cc index 577ca0e..12da23b 100644 --- a/base/sys_info_android.cc +++ b/base/sys_info_android.cc @@ -14,11 +14,10 @@ namespace { // Default version of Android to fall back to when actual version numbers -// cannot be acquired. -// TODO(dfalcantara): Keep this reasonably up to date with the latest publicly -// available version of Android. -const int kDefaultAndroidMajorVersion = 4; -const int kDefaultAndroidMinorVersion = 3; +// cannot be acquired. This is an obviously invalid version number. Code +// doing version comparison should treat it as so and fail all comparisons. +const int kDefaultAndroidMajorVersion = 0; +const int kDefaultAndroidMinorVersion = 0; const int kDefaultAndroidBugfixVersion = 0; // Parse out the OS version numbers from the system properties. |