diff options
author | rlp@chromium.org <rlp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-27 22:18:49 +0000 |
---|---|---|
committer | rlp@chromium.org <rlp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-27 22:18:49 +0000 |
commit | b39a8db3e8e31029e98075863a38f8c3b188529c (patch) | |
tree | d32bb808d0ef13061e2ce1e152e5bab6b686b283 | |
parent | 44dee133e0d388247a788476250be7987078c7e0 (diff) | |
download | chromium_src-b39a8db3e8e31029e98075863a38f8c3b188529c.zip chromium_src-b39a8db3e8e31029e98075863a38f8c3b188529c.tar.gz chromium_src-b39a8db3e8e31029e98075863a38f8c3b188529c.tar.bz2 |
Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS.
BUG=112525
TEST=unittests, manual
Review URL: https://chromiumcodereview.appspot.com/10823050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148830 0039d316-1c4b-4281-b951-d872f2087c98
4 files changed, 12 insertions, 6 deletions
diff --git a/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm b/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm index 5edb666..7a0d82d 100644 --- a/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm +++ b/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm @@ -1,10 +1,11 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #import "chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.h" #include "chrome/browser/bookmarks/bookmark_model.h" +#include "chrome/browser/bookmarks/bookmark_model_factory.h" @implementation FakeAppDelegate @@ -69,5 +70,5 @@ void BookmarkAppleScriptTest::SetUp() { } BookmarkModel& BookmarkAppleScriptTest::model() { - return *profile()->GetBookmarkModel(); + return *BookmarkModelFactory::GetForProfile(profile()); } diff --git a/chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm b/chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm index e238c4e..e0830b1 100644 --- a/chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm +++ b/chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -9,6 +9,7 @@ #include "base/sys_string_conversions.h" #import "chrome/browser/app_controller_mac.h" #include "chrome/browser/bookmarks/bookmark_model.h" +#include "chrome/browser/bookmarks/bookmark_model_factory.h" #import "chrome/browser/chrome_browser_application_mac.h" #include "chrome/browser/profiles/profile.h" #import "chrome/browser/ui/cocoa/applescript/bookmark_item_applescript.h" @@ -118,7 +119,7 @@ return NULL; } - BookmarkModel* model = lastProfile->GetBookmarkModel(); + BookmarkModel* model = BookmarkModelFactory::GetForProfile(lastProfile); if (!model->IsLoaded()) { AppleScript::SetError(AppleScript::errBookmarkModelLoad); return NULL; diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm index 4eb83c43..72d372b 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller.mm @@ -14,6 +14,7 @@ #include "base/sys_string_conversions.h" #include "chrome/app/chrome_command_ids.h" // IDC_* #include "chrome/browser/bookmarks/bookmark_editor.h" +#include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/instant/instant_controller.h" #include "chrome/browser/managed_mode.h" @@ -1603,7 +1604,8 @@ enum { - (void)showBookmarkBubbleForURL:(const GURL&)url alreadyBookmarked:(BOOL)alreadyMarked { if (!bookmarkBubbleController_) { - BookmarkModel* model = browser_->profile()->GetBookmarkModel(); + BookmarkModel* model = + BookmarkModelFactory::GetForProfile(browser_->profile()); const BookmarkNode* node = model->GetMostRecentlyAddedNodeForURL(url); bookmarkBubbleController_ = [[BookmarkBubbleController alloc] initWithParentWindow:[self window] diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm index 4ce3601..81ae699 100644 --- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm +++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm @@ -6,6 +6,7 @@ #include "base/command_line.h" #include "base/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model.h" +#include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/bookmarks/bookmark_utils.h" #include "chrome/browser/download/download_shelf.h" #include "chrome/browser/prefs/pref_service.h" @@ -55,7 +56,8 @@ class ViewIDTest : public InProcessBrowserTest { browser()->window()->GetDownloadShelf()->Show(); // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT - BookmarkModel* bookmark_model = browser()->profile()->GetBookmarkModel(); + BookmarkModel* bookmark_model = + BookmarkModelFactory::GetForProfile(browser()->profile()); if (bookmark_model) { if (!bookmark_model->IsLoaded()) ui_test_utils::WaitForBookmarkModelToLoad(bookmark_model); |