diff options
author | sohan.jyoti@samsung.com <sohan.jyoti@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-20 20:20:32 +0000 |
---|---|---|
committer | sohan.jyoti@samsung.com <sohan.jyoti@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-20 20:20:32 +0000 |
commit | b48a0b112aa819d9a5bf97a13f7a958c13a51f9a (patch) | |
tree | 55605310e31c82c495f9c6611098fdd02f93e182 | |
parent | bc1cb4d84ae9b54c98fcdb41070526ee34b475bc (diff) | |
download | chromium_src-b48a0b112aa819d9a5bf97a13f7a958c13a51f9a.zip chromium_src-b48a0b112aa819d9a5bf97a13f7a958c13a51f9a.tar.gz chromium_src-b48a0b112aa819d9a5bf97a13f7a958c13a51f9a.tar.bz2 |
cc: Pass scaled bounds to debug border quads for drawing.
As PictureLayerImpl now uses scaled rects, bounds and transforms for setting up
SQS, we need to pass the same to debug border quads too.
BUG=384623
Review URL: https://codereview.chromium.org/341023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278810 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | cc/layers/io_surface_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/layer_impl.cc | 12 | ||||
-rw-r--r-- | cc/layers/layer_impl.h | 2 | ||||
-rw-r--r-- | cc/layers/nine_patch_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/painted_scrollbar_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/picture_layer_impl.cc | 4 | ||||
-rw-r--r-- | cc/layers/solid_color_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/solid_color_scrollbar_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/surface_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/texture_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/tiled_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/ui_resource_layer_impl.cc | 3 | ||||
-rw-r--r-- | cc/layers/video_layer_impl.cc | 3 |
13 files changed, 34 insertions, 14 deletions
diff --git a/cc/layers/io_surface_layer_impl.cc b/cc/layers/io_surface_layer_impl.cc index 6d94c91..65fb6b2 100644 --- a/cc/layers/io_surface_layer_impl.cc +++ b/cc/layers/io_surface_layer_impl.cc @@ -69,7 +69,8 @@ void IOSurfaceLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); gfx::Rect quad_rect(content_bounds()); gfx::Rect opaque_rect(contents_opaque() ? quad_rect : gfx::Rect()); diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc index 570616e..fa68275 100644 --- a/cc/layers/layer_impl.cc +++ b/cc/layers/layer_impl.cc @@ -289,16 +289,22 @@ void LayerImpl::GetDebugBorderProperties(SkColor* color, float* width) const { void LayerImpl::AppendDebugBorderQuad( QuadSink* quad_sink, + const gfx::Size& content_bounds, const SharedQuadState* shared_quad_state, AppendQuadsData* append_quads_data) const { SkColor color; float width; GetDebugBorderProperties(&color, &width); - AppendDebugBorderQuad( - quad_sink, shared_quad_state, append_quads_data, color, width); + AppendDebugBorderQuad(quad_sink, + content_bounds, + shared_quad_state, + append_quads_data, + color, + width); } void LayerImpl::AppendDebugBorderQuad(QuadSink* quad_sink, + const gfx::Size& content_bounds, const SharedQuadState* shared_quad_state, AppendQuadsData* append_quads_data, SkColor color, @@ -306,7 +312,7 @@ void LayerImpl::AppendDebugBorderQuad(QuadSink* quad_sink, if (!ShowDebugBorders()) return; - gfx::Rect quad_rect(content_bounds()); + gfx::Rect quad_rect(content_bounds); gfx::Rect visible_quad_rect(quad_rect); scoped_ptr<DebugBorderDrawQuad> debug_border_quad = DebugBorderDrawQuad::Create(); diff --git a/cc/layers/layer_impl.h b/cc/layers/layer_impl.h index d77a461..cb18604 100644 --- a/cc/layers/layer_impl.h +++ b/cc/layers/layer_impl.h @@ -540,9 +540,11 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver, virtual void GetDebugBorderProperties(SkColor* color, float* width) const; void AppendDebugBorderQuad(QuadSink* quad_sink, + const gfx::Size& content_bounds, const SharedQuadState* shared_quad_state, AppendQuadsData* append_quads_data) const; void AppendDebugBorderQuad(QuadSink* quad_sink, + const gfx::Size& content_bounds, const SharedQuadState* shared_quad_state, AppendQuadsData* append_quads_data, SkColor color, diff --git a/cc/layers/nine_patch_layer_impl.cc b/cc/layers/nine_patch_layer_impl.cc index d0596ba..46bd333 100644 --- a/cc/layers/nine_patch_layer_impl.cc +++ b/cc/layers/nine_patch_layer_impl.cc @@ -86,7 +86,8 @@ void NinePatchLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); if (!ui_resource_id_) return; diff --git a/cc/layers/painted_scrollbar_layer_impl.cc b/cc/layers/painted_scrollbar_layer_impl.cc index ac6ce4a..b83419f 100644 --- a/cc/layers/painted_scrollbar_layer_impl.cc +++ b/cc/layers/painted_scrollbar_layer_impl.cc @@ -81,7 +81,8 @@ void PaintedScrollbarLayerImpl::AppendQuads( SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); gfx::Rect thumb_quad_rect = ComputeThumbQuadRect(); gfx::Rect visible_thumb_quad_rect = diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc index 5452941..624b90a 100644 --- a/cc/layers/picture_layer_impl.cc +++ b/cc/layers/picture_layer_impl.cc @@ -165,6 +165,7 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink, if (current_draw_mode_ == DRAW_MODE_RESOURCELESS_SOFTWARE) { AppendDebugBorderQuad( quad_sink, + scaled_content_bounds, shared_quad_state, append_quads_data, DebugColors::DirectPictureBorderColor(), @@ -197,7 +198,8 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink, return; } - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, scaled_content_bounds, shared_quad_state, append_quads_data); if (ShowDebugBorders()) { for (PictureLayerTilingSet::CoverageIterator iter( diff --git a/cc/layers/solid_color_layer_impl.cc b/cc/layers/solid_color_layer_impl.cc index e60edd1..1f44b38 100644 --- a/cc/layers/solid_color_layer_impl.cc +++ b/cc/layers/solid_color_layer_impl.cc @@ -27,7 +27,8 @@ void SolidColorLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); // We create a series of smaller quads instead of just one large one so that // the culler can reduce the total pixels drawn. diff --git a/cc/layers/solid_color_scrollbar_layer_impl.cc b/cc/layers/solid_color_scrollbar_layer_impl.cc index be2358c..1e255ab 100644 --- a/cc/layers/solid_color_scrollbar_layer_impl.cc +++ b/cc/layers/solid_color_scrollbar_layer_impl.cc @@ -99,7 +99,8 @@ void SolidColorScrollbarLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); gfx::Rect thumb_quad_rect(ComputeThumbQuadRect()); gfx::Rect visible_quad_rect = quad_sink->UnoccludedContentRect( diff --git a/cc/layers/surface_layer_impl.cc b/cc/layers/surface_layer_impl.cc index 6557e20..6891c14 100644 --- a/cc/layers/surface_layer_impl.cc +++ b/cc/layers/surface_layer_impl.cc @@ -41,7 +41,8 @@ void SurfaceLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); if (surface_id_.is_null()) return; diff --git a/cc/layers/texture_layer_impl.cc b/cc/layers/texture_layer_impl.cc index 5e65d72..abbab25 100644 --- a/cc/layers/texture_layer_impl.cc +++ b/cc/layers/texture_layer_impl.cc @@ -146,7 +146,8 @@ void TextureLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); SkColor bg_color = blend_background_color_ ? background_color() : SK_ColorTRANSPARENT; diff --git a/cc/layers/tiled_layer_impl.cc b/cc/layers/tiled_layer_impl.cc index a510883..6aacd1e 100644 --- a/cc/layers/tiled_layer_impl.cc +++ b/cc/layers/tiled_layer_impl.cc @@ -161,7 +161,8 @@ void TiledLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); int left, top, right, bottom; tiler_->ContentRectToTileIndices(content_rect, &left, &top, &right, &bottom); diff --git a/cc/layers/ui_resource_layer_impl.cc b/cc/layers/ui_resource_layer_impl.cc index a5b563f..d2ec1e4 100644 --- a/cc/layers/ui_resource_layer_impl.cc +++ b/cc/layers/ui_resource_layer_impl.cc @@ -96,7 +96,8 @@ void UIResourceLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); if (!ui_resource_id_) return; diff --git a/cc/layers/video_layer_impl.cc b/cc/layers/video_layer_impl.cc index dad3159..4abf85b 100644 --- a/cc/layers/video_layer_impl.cc +++ b/cc/layers/video_layer_impl.cc @@ -131,7 +131,8 @@ void VideoLayerImpl::AppendQuads(QuadSink* quad_sink, SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); PopulateSharedQuadState(shared_quad_state); - AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); + AppendDebugBorderQuad( + quad_sink, content_bounds(), shared_quad_state, append_quads_data); gfx::Rect quad_rect(content_bounds()); gfx::Rect opaque_rect(contents_opaque() ? quad_rect : gfx::Rect()); |