diff options
author | avi <avi@chromium.org> | 2015-12-24 19:11:15 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-25 03:12:02 +0000 |
commit | b533f5d784dfbd60e28a54fe37aa90a308d41cb9 (patch) | |
tree | 25058c6d524f9d8c2845cfc9e4d535a68264b8af | |
parent | a9aa7a848f31737de0509945071a61e65bd658d7 (diff) | |
download | chromium_src-b533f5d784dfbd60e28a54fe37aa90a308d41cb9.zip chromium_src-b533f5d784dfbd60e28a54fe37aa90a308d41cb9.tar.gz chromium_src-b533f5d784dfbd60e28a54fe37aa90a308d41cb9.tar.bz2 |
Switch to standard integer types in content/browser/renderer_host/.
BUG=138542
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1546123002
Cr-Commit-Position: refs/heads/master@{#366851}
244 files changed, 1048 insertions, 586 deletions
diff --git a/content/browser/renderer_host/begin_frame_observer_proxy.h b/content/browser/renderer_host/begin_frame_observer_proxy.h index 291d8bb..a5fa2e6 100644 --- a/content/browser/renderer_host/begin_frame_observer_proxy.h +++ b/content/browser/renderer_host/begin_frame_observer_proxy.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_ #define CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_ +#include "base/macros.h" #include "content/common/content_export.h" #include "ui/compositor/compositor.h" #include "ui/compositor/compositor_observer.h" diff --git a/content/browser/renderer_host/begin_frame_observer_proxy_unittest.cc b/content/browser/renderer_host/begin_frame_observer_proxy_unittest.cc index 77b00e9..9ba78c4 100644 --- a/content/browser/renderer_host/begin_frame_observer_proxy_unittest.cc +++ b/content/browser/renderer_host/begin_frame_observer_proxy_unittest.cc @@ -5,7 +5,6 @@ #include <algorithm> #include <list> -#include "base/basictypes.h" #include "base/compiler_specific.h" #include "base/memory/scoped_ptr.h" #include "base/test/test_simple_task_runner.h" diff --git a/content/browser/renderer_host/clipboard_message_filter.cc b/content/browser/renderer_host/clipboard_message_filter.cc index 35e7428..dea3d12 100644 --- a/content/browser/renderer_host/clipboard_message_filter.cc +++ b/content/browser/renderer_host/clipboard_message_filter.cc @@ -11,6 +11,7 @@ #include "base/memory/scoped_ptr.h" #include "base/pickle.h" #include "base/strings/utf_string_conversions.h" +#include "build/build_config.h" #include "content/common/clipboard_messages.h" #include "content/public/browser/browser_context.h" #include "ipc/ipc_message_macros.h" @@ -94,7 +95,7 @@ ClipboardMessageFilter::~ClipboardMessageFilter() { } void ClipboardMessageFilter::OnGetSequenceNumber(ui::ClipboardType type, - uint64* sequence_number) { + uint64_t* sequence_number) { *sequence_number = GetClipboard()->GetSequenceNumber(type); } @@ -156,8 +157,8 @@ void ClipboardMessageFilter::OnReadText(ui::ClipboardType type, void ClipboardMessageFilter::OnReadHTML(ui::ClipboardType type, base::string16* markup, GURL* url, - uint32* fragment_start, - uint32* fragment_end) { + uint32_t* fragment_start, + uint32_t* fragment_end) { std::string src_url_str; GetClipboard()->ReadHTML(type, markup, &src_url_str, fragment_start, fragment_end); @@ -186,7 +187,7 @@ void ClipboardMessageFilter::OnReadImage(ui::ClipboardType type, void ClipboardMessageFilter::OnReadImageReply( const SkBitmap& bitmap, IPC::Message* reply_msg) { base::SharedMemoryHandle image_handle = base::SharedMemory::NULLHandle(); - uint32 image_size = 0; + uint32_t image_size = 0; if (!bitmap.isNull()) { std::vector<unsigned char> png_data; if (gfx::PNGCodec::FastEncodeBGRASkBitmap(bitmap, false, &png_data)) { diff --git a/content/browser/renderer_host/clipboard_message_filter.h b/content/browser/renderer_host/clipboard_message_filter.h index f563ed5..9e9aabe 100644 --- a/content/browser/renderer_host/clipboard_message_filter.h +++ b/content/browser/renderer_host/clipboard_message_filter.h @@ -5,11 +5,14 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_CLIPBOARD_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_CLIPBOARD_MESSAGE_FILTER_H_ +#include <stdint.h> + #include <string> #include <vector> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/shared_memory.h" +#include "build/build_config.h" #include "content/common/clipboard_format.h" #include "content/common/content_export.h" #include "content/public/browser/browser_message_filter.h" @@ -39,7 +42,7 @@ class CONTENT_EXPORT ClipboardMessageFilter : public BrowserMessageFilter { ~ClipboardMessageFilter() override; void OnGetSequenceNumber(const ui::ClipboardType type, - uint64* sequence_number); + uint64_t* sequence_number); void OnIsFormatAvailable(ClipboardFormat format, ui::ClipboardType type, bool* result); @@ -51,8 +54,8 @@ class CONTENT_EXPORT ClipboardMessageFilter : public BrowserMessageFilter { void OnReadHTML(ui::ClipboardType type, base::string16* markup, GURL* url, - uint32* fragment_start, - uint32* fragment_end); + uint32_t* fragment_start, + uint32_t* fragment_end); void OnReadRTF(ui::ClipboardType type, std::string* result); void OnReadImage(ui::ClipboardType type, IPC::Message* reply_msg); void OnReadImageReply(const SkBitmap& bitmap, IPC::Message* reply_msg); diff --git a/content/browser/renderer_host/clipboard_message_filter_mac.mm b/content/browser/renderer_host/clipboard_message_filter_mac.mm index 3c59d31..18a908a 100644 --- a/content/browser/renderer_host/clipboard_message_filter_mac.mm +++ b/content/browser/renderer_host/clipboard_message_filter_mac.mm @@ -5,11 +5,12 @@ #include "content/browser/renderer_host/clipboard_message_filter.h" #import <Cocoa/Cocoa.h> +#include <stddef.h> -#include "base/basictypes.h" #include "base/bind.h" #include "base/bind_helpers.h" #include "base/mac/scoped_nsobject.h" +#include "base/macros.h" #include "base/strings/sys_string_conversions.h" #include "content/public/browser/browser_thread.h" #import "ui/base/cocoa/find_pasteboard.h" diff --git a/content/browser/renderer_host/clipboard_message_filter_unittest.cc b/content/browser/renderer_host/clipboard_message_filter_unittest.cc index ecaaf69..2f0c8ab 100644 --- a/content/browser/renderer_host/clipboard_message_filter_unittest.cc +++ b/content/browser/renderer_host/clipboard_message_filter_unittest.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/clipboard_message_filter.h" +#include <stddef.h> +#include <stdint.h> #include <string.h> #include "base/memory/ref_counted.h" diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc index 74a079b..c5cabc0 100644 --- a/content/browser/renderer_host/compositor_impl_android.cc +++ b/content/browser/renderer_host/compositor_impl_android.cc @@ -6,6 +6,7 @@ #include <android/bitmap.h> #include <android/native_window_jni.h> +#include <stdint.h> #include "base/android/jni_android.h" #include "base/android/scoped_java_ref.h" @@ -593,9 +594,9 @@ void CompositorImpl::RequestNewOutputSurface() { #if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER) || \ defined(SYZYASAN) || defined(CYGPROFILE_INSTRUMENTATION) - const int64 kGpuChannelTimeoutInSeconds = 40; + const int64_t kGpuChannelTimeoutInSeconds = 40; #else - const int64 kGpuChannelTimeoutInSeconds = 10; + const int64_t kGpuChannelTimeoutInSeconds = 10; #endif BrowserGpuChannelHostFactory* factory = diff --git a/content/browser/renderer_host/compositor_impl_android.h b/content/browser/renderer_host/compositor_impl_android.h index 7dc3837..0072979 100644 --- a/content/browser/renderer_host/compositor_impl_android.h +++ b/content/browser/renderer_host/compositor_impl_android.h @@ -5,9 +5,11 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_COMPOSITOR_IMPL_ANDROID_H_ #define CONTENT_BROWSER_RENDERER_HOST_COMPOSITOR_IMPL_ANDROID_H_ -#include "base/basictypes.h" +#include <stddef.h> + #include "base/cancelable_callback.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "base/timer/timer.h" diff --git a/content/browser/renderer_host/compositor_resize_lock_aura.h b/content/browser/renderer_host/compositor_resize_lock_aura.h index ad70690..981694f 100644 --- a/content/browser/renderer_host/compositor_resize_lock_aura.h +++ b/content/browser/renderer_host/compositor_resize_lock_aura.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_COMPOSITOR_RESIZE_LOCK_AURA_H_ #define CONTENT_BROWSER_RENDERER_HOST_COMPOSITOR_RESIZE_LOCK_AURA_H_ +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/weak_ptr.h" #include "base/time/time.h" diff --git a/content/browser/renderer_host/database_message_filter.cc b/content/browser/renderer_host/database_message_filter.cc index 5796de5..15d1a2a 100644 --- a/content/browser/renderer_host/database_message_filter.cc +++ b/content/browser/renderer_host/database_message_filter.cc @@ -12,6 +12,7 @@ #include "base/strings/utf_string_conversions.h" #include "base/threading/thread.h" #include "base/trace_event/trace_event.h" +#include "build/build_config.h" #include "content/browser/bad_message.h" #include "content/common/database_messages.h" #include "content/public/browser/user_metrics.h" @@ -227,7 +228,7 @@ void DatabaseMessageFilter::DatabaseDeleteFile( void DatabaseMessageFilter::OnDatabaseGetFileAttributes( const base::string16& vfs_file_name, - int32* attributes) { + int32_t* attributes) { DCHECK_CURRENTLY_ON(BrowserThread::FILE); *attributes = -1; base::FilePath db_file = @@ -238,7 +239,7 @@ void DatabaseMessageFilter::OnDatabaseGetFileAttributes( void DatabaseMessageFilter::OnDatabaseGetFileSize( const base::string16& vfs_file_name, - int64* size) { + int64_t* size) { DCHECK_CURRENTLY_ON(BrowserThread::FILE); *size = 0; base::FilePath db_file = @@ -257,7 +258,7 @@ void DatabaseMessageFilter::OnDatabaseGetSpaceAvailable( if (!quota_manager) { NOTREACHED(); // The system is shutting down, messages are unexpected. DatabaseHostMsg_GetSpaceAvailable::WriteReplyParams( - reply_msg, static_cast<int64>(0)); + reply_msg, static_cast<int64_t>(0)); Send(reply_msg); return; } @@ -275,9 +276,9 @@ void DatabaseMessageFilter::OnDatabaseGetSpaceAvailable( void DatabaseMessageFilter::OnDatabaseGetUsageAndQuota( IPC::Message* reply_msg, storage::QuotaStatusCode status, - int64 usage, - int64 quota) { - int64 available = 0; + int64_t usage, + int64_t quota) { + int64_t available = 0; if ((status == storage::kQuotaStatusOk) && (usage < quota)) available = quota - usage; DatabaseHostMsg_GetSpaceAvailable::WriteReplyParams(reply_msg, available); @@ -285,7 +286,9 @@ void DatabaseMessageFilter::OnDatabaseGetUsageAndQuota( } void DatabaseMessageFilter::OnDatabaseSetFileSize( - const base::string16& vfs_file_name, int64 size, bool* success) { + const base::string16& vfs_file_name, + int64_t size, + bool* success) { DCHECK_CURRENTLY_ON(BrowserThread::FILE); *success = false; base::FilePath db_file = @@ -298,7 +301,7 @@ void DatabaseMessageFilter::OnDatabaseOpened( const std::string& origin_identifier, const base::string16& database_name, const base::string16& description, - int64 estimated_size) { + int64_t estimated_size) { DCHECK_CURRENTLY_ON(BrowserThread::FILE); if (!DatabaseUtil::IsValidOriginIdentifier(origin_identifier)) { @@ -311,7 +314,7 @@ void DatabaseMessageFilter::OnDatabaseOpened( "websql.OpenDatabase", IsOriginSecure(storage::GetOriginFromIdentifier(origin_identifier))); - int64 database_size = 0; + int64_t database_size = 0; db_tracker_->DatabaseOpened(origin_identifier, database_name, description, estimated_size, &database_size); database_connections_.AddConnection(origin_identifier, database_name); @@ -365,7 +368,7 @@ void DatabaseMessageFilter::OnHandleSqliteError( void DatabaseMessageFilter::OnDatabaseSizeChanged( const std::string& origin_identifier, const base::string16& database_name, - int64 database_size) { + int64_t database_size) { DCHECK_CURRENTLY_ON(BrowserThread::FILE); if (database_connections_.IsOriginUsed(origin_identifier)) { Send(new DatabaseMsg_UpdateSize(origin_identifier, database_name, diff --git a/content/browser/renderer_host/database_message_filter.h b/content/browser/renderer_host/database_message_filter.h index 13f27bc..4cf4e92 100644 --- a/content/browser/renderer_host/database_message_filter.h +++ b/content/browser/renderer_host/database_message_filter.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_DATABASE_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_DATABASE_MESSAGE_FILTER_H_ +#include <stdint.h> + #include "base/containers/hash_tables.h" #include "base/strings/string16.h" #include "content/public/browser/browser_message_filter.h" @@ -46,11 +48,11 @@ class DatabaseMessageFilter : public BrowserMessageFilter, const bool& sync_dir, IPC::Message* reply_msg); void OnDatabaseGetFileAttributes(const base::string16& vfs_file_name, - int32* attributes); + int32_t* attributes); void OnDatabaseGetFileSize(const base::string16& vfs_file_name, - int64* size); + int64_t* size); void OnDatabaseSetFileSize(const base::string16& vfs_file_name, - int64 size, + int64_t size, bool* success); // Quota message handler (io thread) @@ -58,14 +60,14 @@ class DatabaseMessageFilter : public BrowserMessageFilter, IPC::Message* reply_msg); void OnDatabaseGetUsageAndQuota(IPC::Message* reply_msg, storage::QuotaStatusCode status, - int64 usage, - int64 quota); + int64_t usage, + int64_t quota); // Database tracker message handlers (file thread) void OnDatabaseOpened(const std::string& origin_identifier, const base::string16& database_name, const base::string16& description, - int64 estimated_size); + int64_t estimated_size); void OnDatabaseModified(const std::string& origin_identifier, const base::string16& database_name); void OnDatabaseClosed(const std::string& origin_identifier, @@ -77,7 +79,7 @@ class DatabaseMessageFilter : public BrowserMessageFilter, // DatabaseTracker::Observer callbacks (file thread) void OnDatabaseSizeChanged(const std::string& origin_identifier, const base::string16& database_name, - int64 database_size) override; + int64_t database_size) override; void OnDatabaseScheduledForDeletion( const std::string& origin_identifier, const base::string16& database_name) override; diff --git a/content/browser/renderer_host/delegated_frame_evictor.h b/content/browser/renderer_host/delegated_frame_evictor.h index 9e9f68a..c1bd50e 100644 --- a/content/browser/renderer_host/delegated_frame_evictor.h +++ b/content/browser/renderer_host/delegated_frame_evictor.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_EVICTOR_H_ #define CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_EVICTOR_H_ +#include "base/macros.h" #include "content/browser/renderer_host/renderer_frame_manager.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc b/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc index fedda0f..5d18642 100644 --- a/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc +++ b/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc @@ -6,6 +6,8 @@ #include <dwrite.h> #include <shlobj.h> +#include <stddef.h> +#include <stdint.h> #include <set> #include <utility> diff --git a/content/browser/renderer_host/file_utilities_message_filter.h b/content/browser/renderer_host/file_utilities_message_filter.h index 54a5830..ccbc739 100644 --- a/content/browser/renderer_host/file_utilities_message_filter.h +++ b/content/browser/renderer_host/file_utilities_message_filter.h @@ -5,9 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_FILE_UTILITIES_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_FILE_UTILITIES_MESSAGE_FILTER_H_ -#include "base/basictypes.h" #include "base/files/file.h" #include "base/files/file_path.h" +#include "base/macros.h" #include "content/public/browser/browser_message_filter.h" namespace IPC { diff --git a/content/browser/renderer_host/font_utils_linux.cc b/content/browser/renderer_host/font_utils_linux.cc index 2ee84e1..7f67a24 100644 --- a/content/browser/renderer_host/font_utils_linux.cc +++ b/content/browser/renderer_host/font_utils_linux.cc @@ -4,6 +4,7 @@ #include <fcntl.h> #include <fontconfig/fontconfig.h> +#include <stddef.h> #include <sys/stat.h> #include <sys/types.h> @@ -119,8 +120,8 @@ namespace content { int MatchFontFaceWithFallback(const std::string& face, bool is_bold, bool is_italic, - uint32 charset, - uint32 fallback_family) { + uint32_t charset, + uint32_t fallback_family) { FcLangSet* langset = FcLangSetCreate(); bool is_lgc = MSCharSetToFontconfig(langset, charset); FcPattern* pattern = FcPatternCreate(); diff --git a/content/browser/renderer_host/font_utils_linux.h b/content/browser/renderer_host/font_utils_linux.h index 669f816..33b31af 100644 --- a/content/browser/renderer_host/font_utils_linux.h +++ b/content/browser/renderer_host/font_utils_linux.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_FONT_UTILS_LINUX_H_ #define CONTENT_BROWSER_RENDERER_HOST_FONT_UTILS_LINUX_H_ +#include <stdint.h> + #include <string> namespace content { @@ -12,8 +14,8 @@ namespace content { int MatchFontFaceWithFallback(const std::string& face, bool is_bold, bool is_italic, - uint32 charset, - uint32 fallback_family); + uint32_t charset, + uint32_t fallback_family); } // namespace content diff --git a/content/browser/renderer_host/gamepad_browser_message_filter.h b/content/browser/renderer_host/gamepad_browser_message_filter.h index e5dc8ae..343c2ac 100644 --- a/content/browser/renderer_host/gamepad_browser_message_filter.h +++ b/content/browser/renderer_host/gamepad_browser_message_filter.h @@ -6,6 +6,7 @@ #define CONTENT_BROWSER_RENDERER_HOST_GAMEPAD_BROWSER_MESSAGE_FILTER_H_ #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/shared_memory.h" #include "content/browser/gamepad/gamepad_consumer.h" #include "content/public/browser/browser_message_filter.h" diff --git a/content/browser/renderer_host/gpu_message_filter.cc b/content/browser/renderer_host/gpu_message_filter.cc index b021192..c381a15 100644 --- a/content/browser/renderer_host/gpu_message_filter.cc +++ b/content/browser/renderer_host/gpu_message_filter.cc @@ -9,6 +9,7 @@ #include "content/browser/renderer_host/gpu_message_filter.h" #include "base/bind.h" +#include "build/build_config.h" #include "content/browser/gpu/gpu_data_manager_impl.h" #include "content/browser/gpu/gpu_process_host.h" #include "content/common/child_process_host_impl.h" diff --git a/content/browser/renderer_host/gpu_message_filter.h b/content/browser/renderer_host/gpu_message_filter.h index e1dd856..393d0ba 100644 --- a/content/browser/renderer_host/gpu_message_filter.h +++ b/content/browser/renderer_host/gpu_message_filter.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_GPU_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_GPU_MESSAGE_FILTER_H_ +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "content/common/gpu/gpu_process_launch_causes.h" diff --git a/content/browser/renderer_host/input/composited_scrolling_browsertest.cc b/content/browser/renderer_host/input/composited_scrolling_browsertest.cc index e776a8e..a23e509 100644 --- a/content/browser/renderer_host/input/composited_scrolling_browsertest.cc +++ b/content/browser/renderer_host/input/composited_scrolling_browsertest.cc @@ -4,8 +4,10 @@ #include "base/bind.h" #include "base/command_line.h" +#include "base/macros.h" #include "base/run_loop.h" #include "base/strings/utf_string_conversions.h" +#include "build/build_config.h" #include "cc/base/math_util.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" #include "content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h" diff --git a/content/browser/renderer_host/input/gesture_event_queue.h b/content/browser/renderer_host/input/gesture_event_queue.h index 2a4b452..457a9ec 100644 --- a/content/browser/renderer_host/input/gesture_event_queue.h +++ b/content/browser/renderer_host/input/gesture_event_queue.h @@ -5,9 +5,11 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_GESTURE_EVENT_QUEUE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_GESTURE_EVENT_QUEUE_H_ +#include <stddef.h> + #include <deque> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/timer/timer.h" #include "content/browser/renderer_host/event_with_latency_info.h" diff --git a/content/browser/renderer_host/input/gesture_event_queue_unittest.cc b/content/browser/renderer_host/input/gesture_event_queue_unittest.cc index 22c57e1..7e7c6e7 100644 --- a/content/browser/renderer_host/input/gesture_event_queue_unittest.cc +++ b/content/browser/renderer_host/input/gesture_event_queue_unittest.cc @@ -2,9 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> + #include <vector> -#include "base/basictypes.h" #include "base/location.h" #include "base/logging.h" #include "base/memory/scoped_ptr.h" diff --git a/content/browser/renderer_host/input/input_ack_handler.h b/content/browser/renderer_host/input/input_ack_handler.h index 14daa35..2268681 100644 --- a/content/browser/renderer_host/input/input_ack_handler.h +++ b/content/browser/renderer_host/input/input_ack_handler.h @@ -5,7 +5,6 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_INPUT_ACK_HANDLER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_INPUT_ACK_HANDLER_H_ -#include "base/basictypes.h" #include "content/browser/renderer_host/event_with_latency_info.h" #include "content/common/input/input_event_ack_state.h" #include "content/public/browser/native_web_keyboard_event.h" diff --git a/content/browser/renderer_host/input/input_router.h b/content/browser/renderer_host/input/input_router.h index b0b7ff7..5d64568 100644 --- a/content/browser/renderer_host/input/input_router.h +++ b/content/browser/renderer_host/input/input_router.h @@ -5,7 +5,6 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_INPUT_ROUTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_INPUT_ROUTER_H_ -#include "base/basictypes.h" #include "content/browser/renderer_host/event_with_latency_info.h" #include "content/common/input/input_event_ack_state.h" #include "content/public/browser/native_web_keyboard_event.h" diff --git a/content/browser/renderer_host/input/input_router_config_helper.cc b/content/browser/renderer_host/input/input_router_config_helper.cc index 24a4354a..53aaee3 100644 --- a/content/browser/renderer_host/input/input_router_config_helper.cc +++ b/content/browser/renderer_host/input/input_router_config_helper.cc @@ -5,6 +5,7 @@ #include "content/browser/renderer_host/input/input_router_config_helper.h" #include "base/command_line.h" +#include "build/build_config.h" #include "content/public/common/content_switches.h" #include "ui/events/gesture_detection/gesture_configuration.h" #include "ui/events/gesture_detection/gesture_detector.h" diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc index 32261f3..d88634d 100644 --- a/content/browser/renderer_host/input/input_router_impl.cc +++ b/content/browser/renderer_host/input/input_router_impl.cc @@ -515,7 +515,7 @@ void InputRouterImpl::OnDidStopFlinging() { void InputRouterImpl::ProcessInputEventAck(WebInputEvent::Type event_type, InputEventAckState ack_result, const ui::LatencyInfo& latency_info, - uint32 unique_touch_event_id, + uint32_t unique_touch_event_id, AckSource ack_source) { TRACE_EVENT2("input", "InputRouterImpl::ProcessInputEventAck", "type", WebInputEventTraits::GetName(event_type), @@ -630,7 +630,7 @@ void InputRouterImpl::ProcessGestureAck(WebInputEvent::Type type, void InputRouterImpl::ProcessTouchAck(InputEventAckState ack_result, const ui::LatencyInfo& latency, - uint32 unique_touch_event_id) { + uint32_t unique_touch_event_id) { // |touch_event_queue_| will forward to OnTouchEventAck when appropriate. touch_event_queue_.ProcessTouchAck(ack_result, latency, unique_touch_event_id); diff --git a/content/browser/renderer_host/input/input_router_impl.h b/content/browser/renderer_host/input/input_router_impl.h index d613289..36f62b2 100644 --- a/content/browser/renderer_host/input/input_router_impl.h +++ b/content/browser/renderer_host/input/input_router_impl.h @@ -5,9 +5,11 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_INPUT_ROUTER_IMPL_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_INPUT_ROUTER_IMPL_H_ +#include <stdint.h> + #include <queue> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/gesture_event_queue.h" @@ -137,7 +139,7 @@ private: void ProcessInputEventAck(blink::WebInputEvent::Type event_type, InputEventAckState ack_result, const ui::LatencyInfo& latency_info, - uint32 unique_touch_event_id, + uint32_t unique_touch_event_id, AckSource ack_source); // Dispatches the ack'ed event to |ack_handler_|. @@ -165,7 +167,7 @@ private: // dispatch of queued touch events, or the creation of gesture events. void ProcessTouchAck(InputEventAckState ack_result, const ui::LatencyInfo& latency, - uint32 unique_touch_event_id); + uint32_t unique_touch_event_id); // Called when a touch timeout-affecting bit has changed, in turn toggling the // touch ack timeout feature of the |touch_event_queue_| as appropriate. Input diff --git a/content/browser/renderer_host/input/input_router_impl_perftest.cc b/content/browser/renderer_host/input/input_router_impl_perftest.cc index be99261..edf67f1 100644 --- a/content/browser/renderer_host/input/input_router_impl_perftest.cc +++ b/content/browser/renderer_host/input/input_router_impl_perftest.cc @@ -2,7 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/basictypes.h" +#include <stddef.h> +#include <stdint.h> + +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/browser/renderer_host/input/input_ack_handler.h" #include "content/browser/renderer_host/input/input_router_client.h" @@ -172,7 +175,7 @@ Touches BuildTouchSequence(size_t steps, class InputEventTimer { public: - InputEventTimer(const char* test_name, int64 event_count) + InputEventTimer(const char* test_name, int64_t event_count) : test_name_(test_name), event_count_(event_count), start_(base::TimeTicks::Now()) {} @@ -190,7 +193,7 @@ class InputEventTimer { private: const char* test_name_; - int64 event_count_; + int64_t event_count_; base::TimeTicks start_; DISALLOW_COPY_AND_ASSIGN(InputEventTimer); }; @@ -256,7 +259,7 @@ class InputRouterImplPerfTest : public testing::Test { size_t AckCount() const { return ack_handler_->ack_count(); } - int64 NextLatencyID() { return ++last_input_id_; } + int64_t NextLatencyID() { return ++last_input_id_; } ui::LatencyInfo CreateLatencyInfo() { ui::LatencyInfo latency; @@ -329,7 +332,7 @@ class InputRouterImplPerfTest : public testing::Test { } private: - int64 last_input_id_; + int64_t last_input_id_; scoped_ptr<NullIPCSender> sender_; scoped_ptr<NullInputRouterClient> client_; scoped_ptr<NullInputAckHandler> ack_handler_; diff --git a/content/browser/renderer_host/input/input_router_impl_unittest.cc b/content/browser/renderer_host/input/input_router_impl_unittest.cc index b8f4cfb..365900e 100644 --- a/content/browser/renderer_host/input/input_router_impl_unittest.cc +++ b/content/browser/renderer_host/input/input_router_impl_unittest.cc @@ -3,14 +3,17 @@ // found in the LICENSE file. #include <math.h> +#include <stddef.h> +#include <stdint.h> -#include "base/basictypes.h" #include "base/command_line.h" #include "base/location.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/single_thread_task_runner.h" #include "base/strings/utf_string_conversions.h" #include "base/thread_task_runner_handle.h" +#include "build/build_config.h" #include "content/browser/renderer_host/input/gesture_event_queue.h" #include "content/browser/renderer_host/input/input_router_client.h" #include "content/browser/renderer_host/input/input_router_impl.h" @@ -246,8 +249,8 @@ class InputRouterImplTest : public testing::Test { touch_event_.SetTimestamp(timestamp); } - uint32 SendTouchEvent() { - uint32 touch_event_id = touch_event_.uniqueTouchEventId; + uint32_t SendTouchEvent() { + uint32_t touch_event_id = touch_event_.uniqueTouchEventId; input_router_->SendTouchEvent(TouchEventWithLatencyInfo(touch_event_)); touch_event_.ResetPoints(); return touch_event_id; @@ -278,7 +281,7 @@ class InputRouterImplTest : public testing::Test { void SendTouchEventACK(blink::WebInputEvent::Type type, InputEventAckState ack_result, - uint32 touch_event_id) { + uint32_t touch_event_id) { DCHECK(WebInputEvent::isTouchEventType(type)); InputEventAck ack(type, ack_result, touch_event_id); input_router_->OnMessageReceived(InputHostMsg_HandleInputEvent_ACK(0, ack)); @@ -776,14 +779,14 @@ TEST_F(InputRouterImplTest, TouchEventQueue) { OnHasTouchEventHandlers(true); PressTouchPoint(1, 1); - uint32 touch_press_event_id = SendTouchEvent(); + uint32_t touch_press_event_id = SendTouchEvent(); EXPECT_TRUE(client_->GetAndResetFilterEventCalled()); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); EXPECT_FALSE(TouchEventQueueEmpty()); // The second touch should not be sent since one is already in queue. MoveTouchPoint(0, 5, 5); - uint32 touch_move_event_id = SendTouchEvent(); + uint32_t touch_move_event_id = SendTouchEvent(); EXPECT_FALSE(client_->GetAndResetFilterEventCalled()); EXPECT_EQ(0U, GetSentMessageCountAndResetSink()); EXPECT_FALSE(TouchEventQueueEmpty()); @@ -816,7 +819,7 @@ TEST_F(InputRouterImplTest, TouchEventQueueFlush) { // Send a touch-press event. PressTouchPoint(1, 1); - uint32 touch_press_event_id = SendTouchEvent(); + uint32_t touch_press_event_id = SendTouchEvent(); MoveTouchPoint(0, 2, 2); MoveTouchPoint(0, 3, 3); EXPECT_FALSE(TouchEventQueueEmpty()); @@ -856,7 +859,7 @@ TEST_F(InputRouterImplTest, AckedTouchEventState) { // Press the first finger. PressTouchPoint(1, 1); SetTouchTimestamp(timestamp); - uint32 touch_press_event_id1 = SendTouchEvent(); + uint32_t touch_press_event_id1 = SendTouchEvent(); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); expected_events.push_back( new ui::TouchEvent(ui::ET_TOUCH_PRESSED, gfx::Point(1, 1), 0, timestamp)); @@ -865,7 +868,7 @@ TEST_F(InputRouterImplTest, AckedTouchEventState) { timestamp += base::TimeDelta::FromSeconds(10); MoveTouchPoint(0, 500, 500); SetTouchTimestamp(timestamp); - uint32 touch_move_event_id1 = SendTouchEvent(); + uint32_t touch_move_event_id1 = SendTouchEvent(); EXPECT_FALSE(TouchEventQueueEmpty()); expected_events.push_back(new ui::TouchEvent( ui::ET_TOUCH_MOVED, gfx::Point(500, 500), 0, timestamp)); @@ -874,7 +877,7 @@ TEST_F(InputRouterImplTest, AckedTouchEventState) { timestamp += base::TimeDelta::FromSeconds(10); PressTouchPoint(2, 2); SetTouchTimestamp(timestamp); - uint32 touch_press_event_id2 = SendTouchEvent(); + uint32_t touch_press_event_id2 = SendTouchEvent(); EXPECT_FALSE(TouchEventQueueEmpty()); expected_events.push_back( new ui::TouchEvent(ui::ET_TOUCH_PRESSED, gfx::Point(2, 2), 1, timestamp)); @@ -884,7 +887,7 @@ TEST_F(InputRouterImplTest, AckedTouchEventState) { MoveTouchPoint(0, 10, 10); MoveTouchPoint(1, 20, 20); SetTouchTimestamp(timestamp); - uint32 touch_move_event_id2 = SendTouchEvent(); + uint32_t touch_move_event_id2 = SendTouchEvent(); EXPECT_FALSE(TouchEventQueueEmpty()); expected_events.push_back( new ui::TouchEvent(ui::ET_TOUCH_MOVED, gfx::Point(10, 10), 0, timestamp)); @@ -898,10 +901,8 @@ TEST_F(InputRouterImplTest, AckedTouchEventState) { WebInputEvent::TouchStart, WebInputEvent::TouchMove }; - uint32 touch_event_ids[] = {touch_press_event_id1, - touch_move_event_id1, - touch_press_event_id2, - touch_move_event_id2}; + uint32_t touch_event_ids[] = {touch_press_event_id1, touch_move_event_id1, + touch_press_event_id2, touch_move_event_id2}; TouchEventCoordinateSystem coordinate_system = LOCAL_COORDINATES; #if !defined(OS_WIN) @@ -968,7 +969,7 @@ TEST_F(InputRouterImplTest, TouchTypesIgnoringAck) { // Precede the TouchCancel with an appropriate TouchStart; PressTouchPoint(1, 1); - uint32 touch_press_event_id = SendTouchEvent(); + uint32_t touch_press_event_id = SendTouchEvent(); SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED, touch_press_event_id); ASSERT_EQ(1U, GetSentMessageCountAndResetSink()); @@ -977,7 +978,7 @@ TEST_F(InputRouterImplTest, TouchTypesIgnoringAck) { // The TouchCancel ack is always ignored. CancelTouchPoint(0); - uint32 touch_cancel_event_id = SendTouchEvent(); + uint32_t touch_cancel_event_id = SendTouchEvent(); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount()); EXPECT_EQ(0, client_->in_flight_event_count()); @@ -1065,7 +1066,7 @@ TEST_F(InputRouterImplTest, MouseTypesIgnoringAck) { if (expected_in_flight_event_count) { SendInputEventACK(type, INPUT_EVENT_ACK_STATE_NOT_CONSUMED); EXPECT_EQ(0U, GetSentMessageCountAndResetSink()); - uint32 expected_ack_count = type == WebInputEvent::MouseMove ? 1 : 0; + uint32_t expected_ack_count = type == WebInputEvent::MouseMove ? 1 : 0; EXPECT_EQ(expected_ack_count, ack_handler_->GetAndResetAckCount()); EXPECT_EQ(0, client_->in_flight_event_count()); } @@ -1218,7 +1219,7 @@ TEST_F(InputRouterImplTest, TouchAckTimeoutConfigured) { // Verify that the touch ack timeout fires upon the delayed ack. PressTouchPoint(1, 1); - uint32 touch_press_event_id1 = SendTouchEvent(); + uint32_t touch_press_event_id1 = SendTouchEvent(); EXPECT_EQ(0U, ack_handler_->GetAndResetAckCount()); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); RunTasksAndWait(base::TimeDelta::FromMilliseconds(kDesktopTimeoutMs + 1)); @@ -1251,22 +1252,22 @@ TEST_F(InputRouterImplTest, TouchAckTimeoutConfigured) { // TOUCH_ACTION_NONE (and no other touch-action) should disable the timeout. OnHasTouchEventHandlers(true); PressTouchPoint(1, 1); - uint32 touch_press_event_id2 = SendTouchEvent(); + uint32_t touch_press_event_id2 = SendTouchEvent(); OnSetTouchAction(TOUCH_ACTION_PAN_Y); EXPECT_TRUE(TouchEventTimeoutEnabled()); ReleaseTouchPoint(0); - uint32 touch_release_event_id2 = SendTouchEvent(); + uint32_t touch_release_event_id2 = SendTouchEvent(); SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED, touch_press_event_id2); SendTouchEventACK(WebInputEvent::TouchEnd, INPUT_EVENT_ACK_STATE_CONSUMED, touch_release_event_id2); PressTouchPoint(1, 1); - uint32 touch_press_event_id3 = SendTouchEvent(); + uint32_t touch_press_event_id3 = SendTouchEvent(); OnSetTouchAction(TOUCH_ACTION_NONE); EXPECT_FALSE(TouchEventTimeoutEnabled()); ReleaseTouchPoint(0); - uint32 touch_release_event_id3 = SendTouchEvent(); + uint32_t touch_release_event_id3 = SendTouchEvent(); SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED, touch_press_event_id3); SendTouchEventACK(WebInputEvent::TouchEnd, INPUT_EVENT_ACK_STATE_CONSUMED, @@ -1291,7 +1292,7 @@ TEST_F(InputRouterImplTest, // Start a touch sequence. PressTouchPoint(1, 1); - uint32 touch_press_event_id = SendTouchEvent(); + uint32_t touch_press_event_id = SendTouchEvent(); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); // TOUCH_ACTION_NONE should disable the timeout. @@ -1302,7 +1303,7 @@ TEST_F(InputRouterImplTest, EXPECT_FALSE(TouchEventTimeoutEnabled()); MoveTouchPoint(0, 1, 2); - uint32 touch_move_event_id = SendTouchEvent(); + uint32_t touch_move_event_id = SendTouchEvent(); EXPECT_FALSE(TouchEventTimeoutEnabled()); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); @@ -1316,7 +1317,7 @@ TEST_F(InputRouterImplTest, // End the touch sequence. ReleaseTouchPoint(0); - uint32 touch_release_event_id = SendTouchEvent(); + uint32_t touch_release_event_id = SendTouchEvent(); SendTouchEventACK(WebInputEvent::TouchEnd, INPUT_EVENT_ACK_STATE_CONSUMED, touch_release_event_id); EXPECT_FALSE(TouchEventTimeoutEnabled()); @@ -1342,20 +1343,20 @@ TEST_F(InputRouterImplTest, TouchActionResetBeforeEventReachesRenderer) { // Sequence 1. PressTouchPoint(1, 1); - uint32 touch_press_event_id1 = SendTouchEvent(); + uint32_t touch_press_event_id1 = SendTouchEvent(); OnSetTouchAction(TOUCH_ACTION_NONE); MoveTouchPoint(0, 50, 50); - uint32 touch_move_event_id1 = SendTouchEvent(); + uint32_t touch_move_event_id1 = SendTouchEvent(); ReleaseTouchPoint(0); - uint32 touch_release_event_id1 = SendTouchEvent(); + uint32_t touch_release_event_id1 = SendTouchEvent(); // Sequence 2. PressTouchPoint(1, 1); - uint32 touch_press_event_id2 = SendTouchEvent(); + uint32_t touch_press_event_id2 = SendTouchEvent(); MoveTouchPoint(0, 50, 50); - uint32 touch_move_event_id2 = SendTouchEvent(); + uint32_t touch_move_event_id2 = SendTouchEvent(); ReleaseTouchPoint(0); - uint32 touch_release_event_id2 = SendTouchEvent(); + uint32_t touch_release_event_id2 = SendTouchEvent(); SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED, touch_press_event_id1); @@ -1400,9 +1401,9 @@ TEST_F(InputRouterImplTest, TouchActionResetWhenTouchHasNoConsumer) { // Sequence 1. PressTouchPoint(1, 1); - uint32 touch_press_event_id1 = SendTouchEvent(); + uint32_t touch_press_event_id1 = SendTouchEvent(); MoveTouchPoint(0, 50, 50); - uint32 touch_move_event_id1 = SendTouchEvent(); + uint32_t touch_move_event_id1 = SendTouchEvent(); OnSetTouchAction(TOUCH_ACTION_NONE); SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED, touch_press_event_id1); @@ -1410,11 +1411,11 @@ TEST_F(InputRouterImplTest, TouchActionResetWhenTouchHasNoConsumer) { touch_move_event_id1); ReleaseTouchPoint(0); - uint32 touch_release_event_id1 = SendTouchEvent(); + uint32_t touch_release_event_id1 = SendTouchEvent(); // Sequence 2 PressTouchPoint(1, 1); - uint32 touch_press_event_id2 = SendTouchEvent(); + uint32_t touch_press_event_id2 = SendTouchEvent(); MoveTouchPoint(0, 50, 50); SendTouchEvent(); ReleaseTouchPoint(0); @@ -1452,12 +1453,12 @@ TEST_F(InputRouterImplTest, TouchActionResetWhenTouchHandlerRemoved) { // Touch sequence with touch handler. OnHasTouchEventHandlers(true); PressTouchPoint(1, 1); - uint32 touch_press_event_id = SendTouchEvent(); + uint32_t touch_press_event_id = SendTouchEvent(); MoveTouchPoint(0, 50, 50); - uint32 touch_move_event_id = SendTouchEvent(); + uint32_t touch_move_event_id = SendTouchEvent(); OnSetTouchAction(TOUCH_ACTION_NONE); ReleaseTouchPoint(0); - uint32 touch_release_event_id = SendTouchEvent(); + uint32_t touch_release_event_id = SendTouchEvent(); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); // Ensure we have touch-action:none, suppressing scroll events. @@ -1498,17 +1499,17 @@ TEST_F(InputRouterImplTest, DoubleTapGestureDependsOnFirstTap) { // Sequence 1. PressTouchPoint(1, 1); - uint32 touch_press_event_id1 = SendTouchEvent(); + uint32_t touch_press_event_id1 = SendTouchEvent(); OnSetTouchAction(TOUCH_ACTION_NONE); SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED, touch_press_event_id1); ReleaseTouchPoint(0); - uint32 touch_release_event_id = SendTouchEvent(); + uint32_t touch_release_event_id = SendTouchEvent(); // Sequence 2 PressTouchPoint(1, 1); - uint32 touch_press_event_id2 = SendTouchEvent(); + uint32_t touch_press_event_id2 = SendTouchEvent(); // First tap. EXPECT_EQ(2U, GetSentMessageCountAndResetSink()); @@ -1572,7 +1573,7 @@ TEST_F(InputRouterImplTest, InputFlush) { // Queue a TouchStart. OnHasTouchEventHandlers(true); PressTouchPoint(1, 1); - uint32 touch_press_event_id = SendTouchEvent(); + uint32_t touch_press_event_id = SendTouchEvent(); EXPECT_TRUE(HasPendingEvents()); // DidFlush should be called only after the event is ack'ed. @@ -1585,7 +1586,7 @@ TEST_F(InputRouterImplTest, InputFlush) { // Ensure different types of enqueued events will prevent the DidFlush call // until all such events have been fully dispatched. MoveTouchPoint(0, 50, 50); - uint32 touch_move_event_id = SendTouchEvent(); + uint32_t touch_move_event_id = SendTouchEvent(); ASSERT_TRUE(HasPendingEvents()); SimulateGestureEvent(WebInputEvent::GestureScrollBegin, blink::WebGestureDeviceTouchscreen); @@ -1949,7 +1950,7 @@ class InputRouterImplScaleTouchEventTest } void FlushTouchEvent(WebInputEvent::Type type) { - uint32 touch_event_id = SendTouchEvent(); + uint32_t touch_event_id = SendTouchEvent(); SendTouchEventACK(type, INPUT_EVENT_ACK_STATE_CONSUMED, touch_event_id); ASSERT_TRUE(TouchEventQueueEmpty()); ASSERT_NE(0u, process_->sink().message_count()); diff --git a/content/browser/renderer_host/input/mock_input_ack_handler.h b/content/browser/renderer_host/input/mock_input_ack_handler.h index a4aaf7f..a0e1aa9 100644 --- a/content/browser/renderer_host/input/mock_input_ack_handler.h +++ b/content/browser/renderer_host/input/mock_input_ack_handler.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_MOCK_INPUT_ACK_HANDLER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_MOCK_INPUT_ACK_HANDLER_H_ +#include <stddef.h> + #include "base/memory/scoped_ptr.h" #include "content/browser/renderer_host/input/input_ack_handler.h" diff --git a/content/browser/renderer_host/input/mock_input_router_client.h b/content/browser/renderer_host/input/mock_input_router_client.h index 9ed300c..3ae8835 100644 --- a/content/browser/renderer_host/input/mock_input_router_client.h +++ b/content/browser/renderer_host/input/mock_input_router_client.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_MOCK_INPUT_ROUTER_CLIENT_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_MOCK_INPUT_ROUTER_CLIENT_H_ +#include <stddef.h> + #include "base/memory/scoped_ptr.h" #include "content/browser/renderer_host/input/input_router_client.h" #include "content/common/input/did_overscroll_params.h" diff --git a/content/browser/renderer_host/input/motion_event_web.cc b/content/browser/renderer_host/input/motion_event_web.cc index 30f141b..13dd027 100644 --- a/content/browser/renderer_host/input/motion_event_web.cc +++ b/content/browser/renderer_host/input/motion_event_web.cc @@ -71,7 +71,7 @@ MotionEventWeb::MotionEventWeb(const WebTouchEvent& event) MotionEventWeb::~MotionEventWeb() {} -uint32 MotionEventWeb::GetUniqueEventId() const { +uint32_t MotionEventWeb::GetUniqueEventId() const { return unique_event_id_; } diff --git a/content/browser/renderer_host/input/motion_event_web.h b/content/browser/renderer_host/input/motion_event_web.h index 1aac855..320e31b 100644 --- a/content/browser/renderer_host/input/motion_event_web.h +++ b/content/browser/renderer_host/input/motion_event_web.h @@ -5,6 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_MOTION_EVENT_WEB_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_MOTION_EVENT_WEB_H_ +#include <stddef.h> +#include <stdint.h> + +#include "base/macros.h" #include "content/common/content_export.h" #include "third_party/WebKit/public/web/WebInputEvent.h" #include "ui/events/gesture_detection/motion_event.h" @@ -18,7 +22,7 @@ class CONTENT_EXPORT MotionEventWeb : public ui::MotionEvent { ~MotionEventWeb() override; // ui::MotionEvent - uint32 GetUniqueEventId() const override; + uint32_t GetUniqueEventId() const override; Action GetAction() const override; int GetActionIndex() const override; size_t GetPointerCount() const override; @@ -41,7 +45,7 @@ class CONTENT_EXPORT MotionEventWeb : public ui::MotionEvent { blink::WebTouchEvent event_; Action cached_action_; int cached_action_index_; - const uint32 unique_event_id_; + const uint32_t unique_event_id_; DISALLOW_COPY_AND_ASSIGN(MotionEventWeb); }; diff --git a/content/browser/renderer_host/input/motion_event_web_unittest.cc b/content/browser/renderer_host/input/motion_event_web_unittest.cc index d126ea7..df2f230 100644 --- a/content/browser/renderer_host/input/motion_event_web_unittest.cc +++ b/content/browser/renderer_host/input/motion_event_web_unittest.cc @@ -5,6 +5,8 @@ // MSVC++ requires this to be set before any other includes to get M_PI. #define _USE_MATH_DEFINES +#include <stddef.h> + #include <cmath> #include "content/browser/renderer_host/input/motion_event_web.h" diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc index 8ce73ea..3e57259 100644 --- a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc +++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc @@ -4,8 +4,11 @@ #include "content/browser/renderer_host/input/render_widget_host_latency_tracker.h" +#include <stddef.h> + #include "base/logging.h" #include "base/metrics/histogram.h" +#include "build/build_config.h" #include "content/browser/renderer_host/render_widget_host_impl.h" using blink::WebGestureEvent; @@ -21,7 +24,7 @@ namespace { void UpdateLatencyCoordinatesImpl(const blink::WebTouchEvent& touch, LatencyInfo* latency, float device_scale_factor) { - for (uint32 i = 0; i < touch.touchesLength; ++i) { + for (uint32_t i = 0; i < touch.touchesLength; ++i) { LatencyInfo::InputCoordinate coordinate( touch.touches[i].position.x * device_scale_factor, touch.touches[i].position.y * device_scale_factor); @@ -73,7 +76,7 @@ void UpdateLatencyCoordinates(const WebInputEvent& event, } void ComputeInputLatencyHistograms(WebInputEvent::Type type, - int64 latency_component_id, + int64_t latency_component_id, const LatencyInfo& latency) { LatencyInfo::LatencyComponent rwh_component; if (!latency.FindLatency(ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, @@ -152,7 +155,7 @@ void ComputeInputLatencyHistograms(WebInputEvent::Type type, void ComputeScrollLatencyHistograms( const LatencyInfo::LatencyComponent& gpu_swap_begin_component, const LatencyInfo::LatencyComponent& gpu_swap_end_component, - int64 latency_component_id, + int64_t latency_component_id, const LatencyInfo& latency) { DCHECK(!gpu_swap_begin_component.event_time.is_null()); DCHECK(!gpu_swap_end_component.event_time.is_null()); @@ -256,8 +259,8 @@ void ComputeScrollLatencyHistograms( // provided to them by the browser process. This function adds the correct // component ID where necessary. void AddLatencyInfoComponentIds(LatencyInfo* latency, - int64 latency_component_id) { - std::vector<std::pair<ui::LatencyComponentType, int64>> new_components_key; + int64_t latency_component_id) { + std::vector<std::pair<ui::LatencyComponentType, int64_t>> new_components_key; std::vector<LatencyInfo::LatencyComponent> new_components_value; for (const auto& lc : latency->latency_components()) { ui::LatencyComponentType component_type = lc.first.first; @@ -299,7 +302,7 @@ void RenderWidgetHostLatencyTracker::Initialize(int routing_id, int process_id) { DCHECK_EQ(0, last_event_id_); DCHECK_EQ(0, latency_component_id_); - last_event_id_ = static_cast<int64>(process_id) << 32; + last_event_id_ = static_cast<int64_t>(process_id) << 32; latency_component_id_ = routing_id | last_event_id_; } diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker.h b/content/browser/renderer_host/input/render_widget_host_latency_tracker.h index 32537d1..6df155f 100644 --- a/content/browser/renderer_host/input/render_widget_host_latency_tracker.h +++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker.h @@ -5,9 +5,11 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_RENDER_WIDGET_HOST_LATENCY_TRACKER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_RENDER_WIDGET_HOST_LATENCY_TRACKER_H_ +#include <stdint.h> + #include <vector> -#include "base/basictypes.h" +#include "base/macros.h" #include "content/browser/renderer_host/event_with_latency_info.h" #include "content/common/content_export.h" #include "ui/events/latency_info.h" @@ -56,11 +58,11 @@ class CONTENT_EXPORT RenderWidgetHostLatencyTracker { // Returns the ID that uniquely describes this component to the latency // subsystem. - int64 latency_component_id() const { return latency_component_id_; } + int64_t latency_component_id() const { return latency_component_id_; } private: - int64 last_event_id_; - int64 latency_component_id_; + int64_t last_event_id_; + int64_t latency_component_id_; float device_scale_factor_; bool has_seent_first_gesture_scroll_update_; diff --git a/content/browser/renderer_host/input/synthetic_gesture.h b/content/browser/renderer_host/input/synthetic_gesture.h index f90b72c..626bd15 100644 --- a/content/browser/renderer_host/input/synthetic_gesture.h +++ b/content/browser/renderer_host/input/synthetic_gesture.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_H_ +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/time/time.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/input/synthetic_gesture_controller.h b/content/browser/renderer_host/input/synthetic_gesture_controller.h index 0a42f31..aeef18f 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_controller.h +++ b/content/browser/renderer_host/input/synthetic_gesture_controller.h @@ -9,6 +9,7 @@ #include <utility> #include "base/callback.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/scoped_vector.h" #include "base/time/time.h" diff --git a/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc b/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc index d0c41af..dccbbc3 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc +++ b/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> +#include <stdint.h> + #include "base/bind.h" #include "base/memory/scoped_ptr.h" #include "base/time/time.h" @@ -415,14 +418,14 @@ class MockSyntheticTapTouchTarget : public MockSyntheticTapGestureTarget { EXPECT_EQ(touch_event.type, WebInputEvent::TouchStart); position_ = gfx::PointF(touch_event.touches[0].position); start_time_ = base::TimeDelta::FromMilliseconds( - static_cast<int64>(touch_event.timeStampSeconds * 1000)); + static_cast<int64_t>(touch_event.timeStampSeconds * 1000)); state_ = STARTED; break; case STARTED: EXPECT_EQ(touch_event.type, WebInputEvent::TouchEnd); EXPECT_EQ(position_, gfx::PointF(touch_event.touches[0].position)); stop_time_ = base::TimeDelta::FromMilliseconds( - static_cast<int64>(touch_event.timeStampSeconds * 1000)); + static_cast<int64_t>(touch_event.timeStampSeconds * 1000)); state_ = FINISHED; break; case FINISHED: @@ -448,7 +451,7 @@ class MockSyntheticTapMouseTarget : public MockSyntheticTapGestureTarget { EXPECT_EQ(mouse_event.clickCount, 1); position_ = gfx::PointF(mouse_event.x, mouse_event.y); start_time_ = base::TimeDelta::FromMilliseconds( - static_cast<int64>(mouse_event.timeStampSeconds * 1000)); + static_cast<int64_t>(mouse_event.timeStampSeconds * 1000)); state_ = STARTED; break; case STARTED: @@ -457,7 +460,7 @@ class MockSyntheticTapMouseTarget : public MockSyntheticTapGestureTarget { EXPECT_EQ(mouse_event.clickCount, 1); EXPECT_EQ(position_, gfx::PointF(mouse_event.x, mouse_event.y)); stop_time_ = base::TimeDelta::FromMilliseconds( - static_cast<int64>(mouse_event.timeStampSeconds * 1000)); + static_cast<int64_t>(mouse_event.timeStampSeconds * 1000)); state_ = FINISHED; break; case FINISHED: diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_android.cc b/content/browser/renderer_host/input/synthetic_gesture_target_android.cc index aca0ab6..475f6c1 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_target_android.cc +++ b/content/browser/renderer_host/input/synthetic_gesture_target_android.cc @@ -44,8 +44,10 @@ void SyntheticGestureTargetAndroid::TouchSetScrollDeltas( env, touch_event_synthesizer_.obj(), x, y, dx, dy); } -void SyntheticGestureTargetAndroid::TouchInject( - JNIEnv* env, Action action, int pointer_count, int64 time_in_ms) { +void SyntheticGestureTargetAndroid::TouchInject(JNIEnv* env, + Action action, + int pointer_count, + int64_t time_in_ms) { TRACE_EVENT0("input", "SyntheticGestureTargetAndroid::TouchInject"); Java_MotionEventSynthesizer_inject(env, touch_event_synthesizer_.obj(), static_cast<int>(action), pointer_count, @@ -81,7 +83,7 @@ void SyntheticGestureTargetAndroid::DispatchWebTouchEventToPlatform( } TouchInject(env, action, num_touches, - static_cast<int64>(web_touch.timeStampSeconds * 1000.0)); + static_cast<int64_t>(web_touch.timeStampSeconds * 1000.0)); } void SyntheticGestureTargetAndroid::DispatchWebMouseWheelEventToPlatform( @@ -91,8 +93,8 @@ void SyntheticGestureTargetAndroid::DispatchWebMouseWheelEventToPlatform( web_wheel.deltaY); Java_MotionEventSynthesizer_inject( env, touch_event_synthesizer_.obj(), - static_cast<int>(SyntheticGestureTargetAndroid::ActionScroll), - 1, static_cast<int64>(web_wheel.timeStampSeconds * 1000.0)); + static_cast<int>(SyntheticGestureTargetAndroid::ActionScroll), 1, + static_cast<int64_t>(web_wheel.timeStampSeconds * 1000.0)); } void SyntheticGestureTargetAndroid::DispatchWebMouseEventToPlatform( diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_android.h b/content/browser/renderer_host/input/synthetic_gesture_target_android.h index aa1236d..1e00539 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_target_android.h +++ b/content/browser/renderer_host/input/synthetic_gesture_target_android.h @@ -5,7 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_ANDROID_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_ANDROID_H_ +#include <stdint.h> + #include "base/android/jni_android.h" +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture_target_base.h" @@ -57,7 +60,7 @@ class SyntheticGestureTargetAndroid : public SyntheticGestureTargetBase { void TouchInject(JNIEnv* env, Action action, int pointer_count, - int64 time_in_ms); + int64_t time_in_ms); base::android::ScopedJavaGlobalRef<jobject> touch_event_synthesizer_; diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc b/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc index 334a3d1..d7b47ba 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc +++ b/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/input/synthetic_gesture_target_aura.h" +#include <stddef.h> + #include "content/browser/renderer_host/render_widget_host_impl.h" #include "content/browser/renderer_host/render_widget_host_view_aura.h" #include "content/browser/renderer_host/ui_events_helper.h" diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_aura.h b/content/browser/renderer_host/input/synthetic_gesture_target_aura.h index 42303f2..a4964ba 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_target_aura.h +++ b/content/browser/renderer_host/input/synthetic_gesture_target_aura.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_AURA_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_AURA_H_ +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture_target_base.h" #include "content/common/input/synthetic_gesture_params.h" diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_base.h b/content/browser/renderer_host/input/synthetic_gesture_target_base.h index 8063ae0..3d01549 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_target_base.h +++ b/content/browser/renderer_host/input/synthetic_gesture_target_base.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_BASE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_BASE_H_ +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_mac.h b/content/browser/renderer_host/input/synthetic_gesture_target_mac.h index 87b2939..4ecf50f 100644 --- a/content/browser/renderer_host/input/synthetic_gesture_target_mac.h +++ b/content/browser/renderer_host/input/synthetic_gesture_target_mac.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_MAC_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_GESTURE_TARGET_MAC_H_ +#include "base/macros.h" #include "content/browser/renderer_host/input/synthetic_gesture_target_base.h" #include "content/browser/renderer_host/render_widget_host_view_mac.h" #include "content/common/input/synthetic_gesture_params.h" diff --git a/content/browser/renderer_host/input/synthetic_pinch_gesture.h b/content/browser/renderer_host/input/synthetic_pinch_gesture.h index e044443..970bd87 100644 --- a/content/browser/renderer_host/input/synthetic_pinch_gesture.h +++ b/content/browser/renderer_host/input/synthetic_pinch_gesture.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_PINCH_GESTURE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_PINCH_GESTURE_H_ +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" diff --git a/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc b/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc index ec7f3bc..f396ea6 100644 --- a/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc +++ b/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/input/synthetic_smooth_move_gesture.h" +#include <stdint.h> + #include "base/logging.h" #include "ui/gfx/geometry/point_f.h" @@ -308,7 +310,7 @@ gfx::Vector2dF SyntheticSmoothMoveGesture::GetPositionDeltaAtTime( void SyntheticSmoothMoveGesture::ComputeNextMoveSegment() { current_move_segment_++; DCHECK_LT(current_move_segment_, static_cast<int>(params_.distances.size())); - int64 total_duration_in_us = static_cast<int64>( + int64_t total_duration_in_us = static_cast<int64_t>( 1e6 * (params_.distances[current_move_segment_].Length() / params_.speed_in_pixels_s)); DCHECK_GT(total_duration_in_us, 0); diff --git a/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h b/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h index 931d2f4..577a8c0 100644 --- a/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h +++ b/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h @@ -7,6 +7,7 @@ #include <vector> +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" diff --git a/content/browser/renderer_host/input/synthetic_tap_gesture.h b/content/browser/renderer_host/input/synthetic_tap_gesture.h index b20c1ec..4f74630 100644 --- a/content/browser/renderer_host/input/synthetic_tap_gesture.h +++ b/content/browser/renderer_host/input/synthetic_tap_gesture.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_TAP_GESTURE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_TAP_GESTURE_H_ +#include "base/macros.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" #include "content/browser/renderer_host/input/synthetic_pointer.h" diff --git a/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.cc b/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.cc index 0bf75ac..c47694a 100644 --- a/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.cc +++ b/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h" namespace content { @@ -129,9 +131,9 @@ void SyntheticTouchpadPinchGesture::CalculateEndTime( float scale_factor_delta = (scale_factor - 1.0f) * kPixelsNeededToDoubleOrHalve; - int64 total_duration_in_us = - static_cast<int64>(1e6 * (static_cast<double>(scale_factor_delta) / - params_.relative_pointer_speed_in_pixels_s)); + int64_t total_duration_in_us = + static_cast<int64_t>(1e6 * (static_cast<double>(scale_factor_delta) / + params_.relative_pointer_speed_in_pixels_s)); DCHECK_GT(total_duration_in_us, 0); stop_time_ = start_time_ + base::TimeDelta::FromMicroseconds(total_duration_in_us); diff --git a/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h b/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h index b5a88c2..d2097634 100644 --- a/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h +++ b/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_TOUCHPAD_PINCH_GESTURE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_TOUCHPAD_PINCH_GESTURE_H_ +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" diff --git a/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc b/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc index 9d0ff71..3a31782 100644 --- a/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc +++ b/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h" +#include <stdint.h> + #include <cmath> #include "base/logging.h" @@ -136,7 +138,7 @@ void SyntheticTouchscreenPinchGesture::SetupCoordinatesAndStopTime( max_pointer_delta_0_ = initial_distance_to_anchor - final_distance_to_anchor; - int64 total_duration_in_us = static_cast<int64>( + int64_t total_duration_in_us = static_cast<int64_t>( 1e6 * (static_cast<double>(std::abs(2 * max_pointer_delta_0_)) / params_.relative_pointer_speed_in_pixels_s)); DCHECK_GT(total_duration_in_us, 0); diff --git a/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h b/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h index 73d2c41..c42e608 100644 --- a/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h +++ b/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_TOUCHSCREEN_PINCH_GESTURE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_SYNTHETIC_TOUCHSCREEN_PINCH_GESTURE_H_ +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" diff --git a/content/browser/renderer_host/input/tap_suppression_controller.h b/content/browser/renderer_host/input/tap_suppression_controller.h index bec962a..dc0def5 100644 --- a/content/browser/renderer_host/input/tap_suppression_controller.h +++ b/content/browser/renderer_host/input/tap_suppression_controller.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TAP_SUPPRESSION_CONTROLLER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TAP_SUPPRESSION_CONTROLLER_H_ +#include "base/macros.h" #include "base/time/time.h" #include "base/timer/timer.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/input/tap_suppression_controller_client.h b/content/browser/renderer_host/input/tap_suppression_controller_client.h index 075fa08..d55613c9 100644 --- a/content/browser/renderer_host/input/tap_suppression_controller_client.h +++ b/content/browser/renderer_host/input/tap_suppression_controller_client.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TAP_SUPPRESSION_CONTROLLER_CLIENT_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TAP_SUPPRESSION_CONTROLLER_CLIENT_H_ +#include "base/macros.h" + namespace content { // This class provides an interface for callbacks made by diff --git a/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc b/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc index 0c2e94f..c8e30c9 100644 --- a/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc +++ b/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/browser/renderer_host/input/tap_suppression_controller.h" #include "content/browser/renderer_host/input/tap_suppression_controller_client.h" diff --git a/content/browser/renderer_host/input/timeout_monitor.h b/content/browser/renderer_host/input/timeout_monitor.h index 4cccbec..f2d96f2 100644 --- a/content/browser/renderer_host/input/timeout_monitor.h +++ b/content/browser/renderer_host/input/timeout_monitor.h @@ -5,8 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TIMEOUT_MONITOR_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TIMEOUT_MONITOR_H_ -#include "base/basictypes.h" #include "base/callback.h" +#include "base/macros.h" #include "base/time/time.h" #include "base/timer/timer.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/input/touch_action_browsertest.cc b/content/browser/renderer_host/input/touch_action_browsertest.cc index 0fdb4f2..f8fc11a 100644 --- a/content/browser/renderer_host/input/touch_action_browsertest.cc +++ b/content/browser/renderer_host/input/touch_action_browsertest.cc @@ -5,8 +5,10 @@ #include "base/auto_reset.h" #include "base/bind.h" #include "base/command_line.h" +#include "base/macros.h" #include "base/run_loop.h" #include "base/strings/utf_string_conversions.h" +#include "build/build_config.h" #include "content/browser/renderer_host/input/synthetic_gesture.h" #include "content/browser/renderer_host/input/synthetic_gesture_controller.h" #include "content/browser/renderer_host/input/synthetic_gesture_target.h" diff --git a/content/browser/renderer_host/input/touch_action_filter.h b/content/browser/renderer_host/input/touch_action_filter.h index 4e27eaa..34e32d5 100644 --- a/content/browser/renderer_host/input/touch_action_filter.h +++ b/content/browser/renderer_host/input/touch_action_filter.h @@ -5,7 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_ACTION_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_ACTION_FILTER_H_ -#include "base/basictypes.h" +#include "base/macros.h" #include "content/common/content_export.h" #include "content/common/input/touch_action.h" diff --git a/content/browser/renderer_host/input/touch_emulator.cc b/content/browser/renderer_host/input/touch_emulator.cc index e095b9d..f966c14 100644 --- a/content/browser/renderer_host/input/touch_emulator.cc +++ b/content/browser/renderer_host/input/touch_emulator.cc @@ -4,6 +4,7 @@ #include "content/browser/renderer_host/input/touch_emulator.h" +#include "build/build_config.h" #include "content/browser/renderer_host/input/motion_event_web.h" #include "content/browser/renderer_host/input/web_input_event_util.h" #include "content/common/input/web_touch_event_traits.h" diff --git a/content/browser/renderer_host/input/touch_emulator.h b/content/browser/renderer_host/input/touch_emulator.h index e21287f..d024945 100644 --- a/content/browser/renderer_host/input/touch_emulator.h +++ b/content/browser/renderer_host/input/touch_emulator.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_EMULATOR_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_EMULATOR_H_ +#include "base/macros.h" #include "content/browser/renderer_host/input/touch_emulator_client.h" #include "content/common/cursors/webcursor.h" #include "content/common/input/input_event_ack_state.h" diff --git a/content/browser/renderer_host/input/touch_emulator_unittest.cc b/content/browser/renderer_host/input/touch_emulator_unittest.cc index f46703c..bc52448 100644 --- a/content/browser/renderer_host/input/touch_emulator_unittest.cc +++ b/content/browser/renderer_host/input/touch_emulator_unittest.cc @@ -2,9 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> + #include <vector> -#include "base/basictypes.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" #include "base/time/time.h" diff --git a/content/browser/renderer_host/input/touch_event_queue.cc b/content/browser/renderer_host/input/touch_event_queue.cc index 8f3a6a9..9397cf7 100644 --- a/content/browser/renderer_host/input/touch_event_queue.cc +++ b/content/browser/renderer_host/input/touch_event_queue.cc @@ -5,6 +5,7 @@ #include "content/browser/renderer_host/input/touch_event_queue.h" #include "base/auto_reset.h" +#include "base/macros.h" #include "base/metrics/histogram_macros.h" #include "base/stl_util.h" #include "base/trace_event/trace_event.h" @@ -490,7 +491,7 @@ void TouchEventQueue::QueueEvent(const TouchEventWithLatencyInfo& event) { void TouchEventQueue::ProcessTouchAck(InputEventAckState ack_result, const LatencyInfo& latency_info, - const uint32 unique_touch_event_id) { + const uint32_t unique_touch_event_id) { TRACE_EVENT0("input", "TouchEventQueue::ProcessTouchAck"); // We receive an ack for async touchmove from render. diff --git a/content/browser/renderer_host/input/touch_event_queue.h b/content/browser/renderer_host/input/touch_event_queue.h index 3a4bbdf..4b69d98 100644 --- a/content/browser/renderer_host/input/touch_event_queue.h +++ b/content/browser/renderer_host/input/touch_event_queue.h @@ -5,10 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_EVENT_QUEUE_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_EVENT_QUEUE_H_ +#include <stddef.h> +#include <stdint.h> + #include <deque> #include <map> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/time/time.h" #include "content/browser/renderer_host/event_with_latency_info.h" #include "content/common/content_export.h" @@ -71,7 +74,7 @@ class CONTENT_EXPORT TouchEventQueue { // more gesture events and/or additional queued touch-events to the renderer. void ProcessTouchAck(InputEventAckState ack_result, const ui::LatencyInfo& latency_info, - const uint32 unique_touch_event_id); + const uint32_t unique_touch_event_id); // When GestureScrollBegin is received, we send a touch cancel to renderer, // route all the following touch events directly to client, and ignore the @@ -230,7 +233,7 @@ class CONTENT_EXPORT TouchEventQueue { // uncancelable touchmoves which are still waiting for their acks back from // render. We do not put them back to the front the touch_event_queue any // more. - std::deque<uint32> ack_pending_async_touchmove_ids_; + std::deque<uint32_t> ack_pending_async_touchmove_ids_; double last_sent_touch_timestamp_sec_; diff --git a/content/browser/renderer_host/input/touch_event_queue_unittest.cc b/content/browser/renderer_host/input/touch_event_queue_unittest.cc index 6bb2a2a..392d822 100644 --- a/content/browser/renderer_host/input/touch_event_queue_unittest.cc +++ b/content/browser/renderer_host/input/touch_event_queue_unittest.cc @@ -2,7 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/basictypes.h" +#include <stddef.h> + #include "base/location.h" #include "base/logging.h" #include "base/memory/scoped_ptr.h" diff --git a/content/browser/renderer_host/input/touch_input_browsertest.cc b/content/browser/renderer_host/input/touch_input_browsertest.cc index 7cb9d54..2c68ac7 100644 --- a/content/browser/renderer_host/input/touch_input_browsertest.cc +++ b/content/browser/renderer_host/input/touch_input_browsertest.cc @@ -5,9 +5,11 @@ #include "base/auto_reset.h" #include "base/command_line.h" #include "base/location.h" +#include "base/macros.h" #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/thread_task_runner_handle.h" +#include "build/build_config.h" #include "content/browser/gpu/compositor_util.h" #include "content/browser/renderer_host/render_widget_host_impl.h" #include "content/browser/web_contents/web_contents_impl.h" diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc index 2cbc8a1..88e9663 100644 --- a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc +++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc @@ -4,6 +4,7 @@ #include "content/browser/renderer_host/input/touch_selection_controller_client_aura.h" +#include "base/macros.h" #include "content/browser/renderer_host/render_widget_host_delegate.h" #include "content/browser/renderer_host/render_widget_host_impl.h" #include "content/browser/renderer_host/render_widget_host_view_aura.h" diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura.h b/content/browser/renderer_host/input/touch_selection_controller_client_aura.h index ec9ffd5..feeefec 100644 --- a/content/browser/renderer_host/input/touch_selection_controller_client_aura.h +++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_SELECTION_CONTROLLER_CLIENT_AURA_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_SELECTION_CONTROLLER_CLIENT_AURA_H_ +#include "base/macros.h" #include "base/timer/timer.h" #include "content/common/content_export.h" #include "ui/touch_selection/touch_selection_controller.h" diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc b/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc index ac432e9..b59cc2b 100644 --- a/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc +++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc @@ -5,6 +5,7 @@ #include "content/browser/renderer_host/input/touch_selection_controller_client_aura.h" #include "base/json/json_reader.h" +#include "base/macros.h" #include "base/run_loop.h" #include "content/browser/renderer_host/render_widget_host_view_aura.h" #include "content/browser/web_contents/web_contents_impl.h" diff --git a/content/browser/renderer_host/input/touchpad_tap_suppression_controller.h b/content/browser/renderer_host/input/touchpad_tap_suppression_controller.h index 64e5d47..4971963 100644 --- a/content/browser/renderer_host/input/touchpad_tap_suppression_controller.h +++ b/content/browser/renderer_host/input/touchpad_tap_suppression_controller.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCHPAD_TAP_SUPPRESSION_CONTROLLER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCHPAD_TAP_SUPPRESSION_CONTROLLER_H_ +#include "base/macros.h" #include "content/browser/renderer_host/event_with_latency_info.h" #include "content/browser/renderer_host/input/tap_suppression_controller.h" #include "content/browser/renderer_host/input/tap_suppression_controller_client.h" diff --git a/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h b/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h index 35ff274..0f07f72 100644 --- a/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h +++ b/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCHSCREEN_TAP_SUPPRESSION_CONTROLLER_H_ #define CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCHSCREEN_TAP_SUPPRESSION_CONTROLLER_H_ +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/browser/renderer_host/event_with_latency_info.h" #include "content/browser/renderer_host/input/tap_suppression_controller.h" diff --git a/content/browser/renderer_host/input/web_input_event_builders_mac.mm b/content/browser/renderer_host/input/web_input_event_builders_mac.mm index 723b623..82386ed 100644 --- a/content/browser/renderer_host/input/web_input_event_builders_mac.mm +++ b/content/browser/renderer_host/input/web_input_event_builders_mac.mm @@ -33,6 +33,8 @@ #import <ApplicationServices/ApplicationServices.h> #import <Cocoa/Cocoa.h> +#include <stdint.h> + #include "base/mac/sdk_forward_declarations.h" #include "base/strings/string_util.h" #include "content/browser/renderer_host/input/web_input_event_util.h" diff --git a/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm b/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm index 2c550651..3c8c5a2 100644 --- a/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm +++ b/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm @@ -4,9 +4,11 @@ #include "content/browser/renderer_host/input/web_input_event_builders_mac.h" -#import <Cocoa/Cocoa.h> #include <Carbon/Carbon.h> +#import <Cocoa/Cocoa.h> +#include <stddef.h> +#include "base/macros.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/events/keycodes/dom/dom_code.h" #include "ui/events/keycodes/dom/dom_key.h" diff --git a/content/browser/renderer_host/input/web_input_event_unittest.cc b/content/browser/renderer_host/input/web_input_event_unittest.cc index ac000e8..677c54c 100644 --- a/content/browser/renderer_host/input/web_input_event_unittest.cc +++ b/content/browser/renderer_host/input/web_input_event_unittest.cc @@ -3,6 +3,7 @@ // found in the LICENSE file. #include "base/command_line.h" +#include "build/build_config.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/WebKit/public/web/WebInputEvent.h" #include "ui/events/event_constants.h" diff --git a/content/browser/renderer_host/input/web_input_event_util_unittest.cc b/content/browser/renderer_host/input/web_input_event_util_unittest.cc index d3dfb3c..7781030 100644 --- a/content/browser/renderer_host/input/web_input_event_util_unittest.cc +++ b/content/browser/renderer_host/input/web_input_event_util_unittest.cc @@ -7,6 +7,8 @@ #define _USE_MATH_DEFINES #endif +#include <stddef.h> + #include <cmath> #include "content/browser/renderer_host/input/web_input_event_util.h" diff --git a/content/browser/renderer_host/legacy_render_widget_host_win.h b/content/browser/renderer_host/legacy_render_widget_host_win.h index 7733fac..09b1d82 100644 --- a/content/browser/renderer_host/legacy_render_widget_host_win.h +++ b/content/browser/renderer_host/legacy_render_widget_host_win.h @@ -10,7 +10,7 @@ #include <atlcrack.h> #include <oleacc.h> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/win/scoped_comptr.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/media/audio_input_debug_writer.cc b/content/browser/renderer_host/media/audio_input_debug_writer.cc index 9bbbefe..39ba40d 100644 --- a/content/browser/renderer_host/media/audio_input_debug_writer.cc +++ b/content/browser/renderer_host/media/audio_input_debug_writer.cc @@ -34,7 +34,7 @@ void AudioInputDebugWriter::DoWrite(scoped_ptr<media::AudioBus> data) { // Convert to 16 bit audio and write to file. int data_size = data->frames() * data->channels(); if (!interleaved_data_ || interleaved_data_size_ < data_size) { - interleaved_data_.reset(new int16[data_size]); + interleaved_data_.reset(new int16_t[data_size]); interleaved_data_size_ = data_size; } data->ToInterleaved(data->frames(), sizeof(interleaved_data_[0]), diff --git a/content/browser/renderer_host/media/audio_input_debug_writer.h b/content/browser/renderer_host/media/audio_input_debug_writer.h index 6833211..1397775 100644 --- a/content/browser/renderer_host/media/audio_input_debug_writer.h +++ b/content/browser/renderer_host/media/audio_input_debug_writer.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_DEBUG_WRITER_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_DEBUG_WRITER_H_ +#include <stdint.h> + #include "base/files/file.h" #include "base/macros.h" #include "base/memory/ref_counted.h" @@ -43,7 +45,7 @@ class AudioInputDebugWriter : public media::AudioInputWriter { base::File file_; // Intermediate buffer to be written to file. Interleaved 16 bit audio data. - scoped_ptr<int16[]> interleaved_data_; + scoped_ptr<int16_t[]> interleaved_data_; int interleaved_data_size_; base::WeakPtrFactory<AudioInputDebugWriter> weak_factory_; diff --git a/content/browser/renderer_host/media/audio_input_device_manager.cc b/content/browser/renderer_host/media/audio_input_device_manager.cc index 5b231b0..65148e0 100644 --- a/content/browser/renderer_host/media/audio_input_device_manager.cc +++ b/content/browser/renderer_host/media/audio_input_device_manager.cc @@ -7,6 +7,7 @@ #include "base/bind.h" #include "base/memory/scoped_ptr.h" #include "base/metrics/histogram_macros.h" +#include "build/build_config.h" #include "content/public/browser/browser_thread.h" #include "content/public/common/media_stream_request.h" #include "media/audio/audio_input_ipc.h" diff --git a/content/browser/renderer_host/media/audio_input_device_manager.h b/content/browser/renderer_host/media/audio_input_device_manager.h index b123ce4..d3f01b3 100644 --- a/content/browser/renderer_host/media/audio_input_device_manager.h +++ b/content/browser/renderer_host/media/audio_input_device_manager.h @@ -15,9 +15,10 @@ #include <map> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/threading/thread.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/media_stream_provider.h" #include "content/common/content_export.h" #include "content/common/media/media_stream_options.h" diff --git a/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc b/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc index 498806b..4fac69d 100644 --- a/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc +++ b/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc @@ -2,14 +2,18 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> + #include <string> #include "base/bind.h" #include "base/location.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/single_thread_task_runner.h" #include "base/synchronization/waitable_event.h" +#include "build/build_config.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/renderer_host/media/audio_input_device_manager.h" #include "content/public/common/media_stream_request.h" diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.cc b/content/browser/renderer_host/media/audio_input_renderer_host.cc index d6011ff..bfbb182 100644 --- a/content/browser/renderer_host/media/audio_input_renderer_host.cc +++ b/content/browser/renderer_host/media/audio_input_renderer_host.cc @@ -13,6 +13,7 @@ #include "base/process/process.h" #include "base/strings/string_number_conversions.h" #include "base/strings/stringprintf.h" +#include "build/build_config.h" #include "content/browser/media/capture/web_contents_audio_input_stream.h" #include "content/browser/media/capture/web_contents_capture_util.h" #include "content/browser/media/media_internals.h" @@ -113,7 +114,7 @@ AudioInputRendererHost::AudioEntry::~AudioEntry() { AudioInputRendererHost::AudioInputRendererHost( int render_process_id, - int32 renderer_pid, + int32_t renderer_pid, media::AudioManager* audio_manager, MediaStreamManager* media_stream_manager, AudioMirroringManager* audio_mirroring_manager, @@ -211,7 +212,7 @@ void AudioInputRendererHost::OnLog(media::AudioInputController* controller, message)); } -void AudioInputRendererHost::set_renderer_pid(int32 renderer_pid) { +void AudioInputRendererHost::set_renderer_pid(int32_t renderer_pid) { DCHECK_CURRENTLY_ON(BrowserThread::IO); renderer_pid_ = renderer_pid; } @@ -409,14 +410,14 @@ void AudioInputRendererHost::DoCreateStream( // Create a new AudioEntry structure. scoped_ptr<AudioEntry> entry(new AudioEntry()); - const uint32 segment_size = + const uint32_t segment_size = (sizeof(media::AudioInputBufferParameters) + media::AudioBus::CalculateMemorySize(audio_params)); entry->shared_memory_segment_count = config.shared_memory_count; // Create the shared memory and share it with the renderer process // using a new SyncWriter object. - base::CheckedNumeric<uint32> size = segment_size; + base::CheckedNumeric<uint32_t> size = segment_size; size *= entry->shared_memory_segment_count; if (!size.IsValid() || !entry->shared_memory.CreateAndMapAnonymous(size.ValueOrDie())) { diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.h b/content/browser/renderer_host/media/audio_input_renderer_host.h index 586e4d9..dd54996 100644 --- a/content/browser/renderer_host/media/audio_input_renderer_host.h +++ b/content/browser/renderer_host/media/audio_input_renderer_host.h @@ -27,7 +27,10 @@ #include <map> #include <string> +#include <stdint.h> + #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" @@ -101,7 +104,7 @@ class CONTENT_EXPORT AudioInputRendererHost // Called from UI thread from the owner of this object. // |user_input_monitor| is used for typing detection and can be NULL. AudioInputRendererHost(int render_process_id, - int32 renderer_pid, + int32_t renderer_pid, media::AudioManager* audio_manager, MediaStreamManager* media_stream_manager, AudioMirroringManager* audio_mirroring_manager, @@ -130,7 +133,7 @@ class CONTENT_EXPORT AudioInputRendererHost // Sets the PID renderer. This is used for constructing the debug recording // filename. - void set_renderer_pid(int32 renderer_pid); + void set_renderer_pid(int32_t renderer_pid); private: // TODO(henrika): extend test suite (compare AudioRenderHost) @@ -240,7 +243,7 @@ class CONTENT_EXPORT AudioInputRendererHost // PID of the render process connected to the RenderProcessHost that owns this // instance. - int32 renderer_pid_; + int32_t renderer_pid_; // Used to create an AudioInputController. media::AudioManager* audio_manager_; diff --git a/content/browser/renderer_host/media/audio_input_sync_writer.cc b/content/browser/renderer_host/media/audio_input_sync_writer.cc index 22165b9..1ddc66c 100644 --- a/content/browser/renderer_host/media/audio_input_sync_writer.cc +++ b/content/browser/renderer_host/media/audio_input_sync_writer.cc @@ -8,6 +8,7 @@ #include "base/metrics/histogram.h" #include "base/strings/stringprintf.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/media_stream_manager.h" #include "content/public/browser/browser_thread.h" @@ -33,7 +34,7 @@ AudioInputSyncWriter::AudioInputSyncWriter(void* shared_memory, size_t shared_memory_size, int shared_memory_segment_count, const media::AudioParameters& params) - : shared_memory_(static_cast<uint8*>(shared_memory)), + : shared_memory_(static_cast<uint8_t*>(shared_memory)), shared_memory_segment_count_(shared_memory_segment_count), current_segment_id_(0), creation_time_(base::Time::Now()), @@ -55,7 +56,7 @@ AudioInputSyncWriter::AudioInputSyncWriter(void* shared_memory, DVLOG(1) << "audio_bus_memory_size: " << audio_bus_memory_size_; // Create vector of audio buses by wrapping existing blocks of memory. - uint8* ptr = shared_memory_; + uint8_t* ptr = shared_memory_; for (int i = 0; i < shared_memory_segment_count; ++i) { CHECK_EQ(0U, reinterpret_cast<uintptr_t>(ptr) & (AudioBus::kChannelAlignment - 1)); @@ -121,7 +122,7 @@ AudioInputSyncWriter::~AudioInputSyncWriter() { void AudioInputSyncWriter::Write(const AudioBus* data, double volume, bool key_pressed, - uint32 hardware_delay_bytes) { + uint32_t hardware_delay_bytes) { ++write_count_; CheckTimeSinceLastWrite(); @@ -226,11 +227,10 @@ void AudioInputSyncWriter::AddToNativeLog(const std::string& message) { MediaStreamManager::SendMessageToNativeLog(message); } -bool AudioInputSyncWriter::PushDataToFifo( - const AudioBus* data, - double volume, - bool key_pressed, - uint32 hardware_delay_bytes) { +bool AudioInputSyncWriter::PushDataToFifo(const AudioBus* data, + double volume, + bool key_pressed, + uint32_t hardware_delay_bytes) { if (overflow_buses_.size() == kMaxOverflowBusesSize) { const std::string error_message = "AISW: No room in fifo."; LOG(ERROR) << error_message; @@ -305,8 +305,8 @@ bool AudioInputSyncWriter::WriteDataFromFifoToSharedMemory() { void AudioInputSyncWriter::WriteParametersToCurrentSegment( double volume, bool key_pressed, - uint32 hardware_delay_bytes) { - uint8* ptr = shared_memory_; + uint32_t hardware_delay_bytes) { + uint8_t* ptr = shared_memory_; ptr += current_segment_id_ * shared_memory_segment_size_; AudioInputBuffer* buffer = reinterpret_cast<AudioInputBuffer*>(ptr); buffer->params.volume = volume; diff --git a/content/browser/renderer_host/media/audio_input_sync_writer.h b/content/browser/renderer_host/media/audio_input_sync_writer.h index d504959..8429e44 100644 --- a/content/browser/renderer_host/media/audio_input_sync_writer.h +++ b/content/browser/renderer_host/media/audio_input_sync_writer.h @@ -5,13 +5,18 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_SYNC_WRITER_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_SYNC_WRITER_H_ +#include <stddef.h> +#include <stdint.h> + #include <deque> #include "base/gtest_prod_util.h" +#include "base/macros.h" #include "base/memory/scoped_vector.h" #include "base/process/process.h" #include "base/sync_socket.h" #include "base/time/time.h" +#include "build/build_config.h" #include "content/common/content_export.h" #include "media/audio/audio_input_controller.h" #include "media/audio/audio_parameters.h" @@ -45,7 +50,7 @@ class CONTENT_EXPORT AudioInputSyncWriter void Write(const media::AudioBus* data, double volume, bool key_pressed, - uint32 hardware_delay_bytes) override; + uint32_t hardware_delay_bytes) override; void Close() override; bool Init(); @@ -78,7 +83,7 @@ class CONTENT_EXPORT AudioInputSyncWriter bool PushDataToFifo(const media::AudioBus* data, double volume, bool key_pressed, - uint32 hardware_delay_bytes); + uint32_t hardware_delay_bytes); // Writes as much data as possible from the fifo (|overflow_buses_|) to the // shared memory ring buffer. Returns true if all operations were successful, @@ -88,17 +93,17 @@ class CONTENT_EXPORT AudioInputSyncWriter // Write audio parameters to current segment in shared memory. void WriteParametersToCurrentSegment(double volume, bool key_pressed, - uint32 hardware_delay_bytes); + uint32_t hardware_delay_bytes); // Signals over the socket that data has been written to the current segment. // Updates counters and returns true if successful. Logs error and returns // false if failure. bool SignalDataWrittenAndUpdateCounters(); - uint8* shared_memory_; - uint32 shared_memory_segment_size_; - uint32 shared_memory_segment_count_; - uint32 current_segment_id_; + uint8_t* shared_memory_; + uint32_t shared_memory_segment_size_; + uint32_t shared_memory_segment_count_; + uint32_t current_segment_id_; // Socket to be used by the renderer. The reference is released after // PrepareForeignSocketHandle() is called and ran successfully. diff --git a/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc b/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc index d958c2b5..d691b22 100644 --- a/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc +++ b/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc @@ -2,10 +2,15 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> +#include <stdint.h> + #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/sync_socket.h" #include "base/time/time.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/audio_input_sync_writer.h" #include "content/public/test/test_browser_thread_bundle.h" #include "media/audio/audio_parameters.h" @@ -36,9 +41,9 @@ const int bits_per_sample = 16; #define DATA_ALIGNMENT 16 static_assert(AudioBus::kChannelAlignment == DATA_ALIGNMENT, "Data alignment not same as AudioBus"); -ALIGNAS(DATA_ALIGNMENT) uint8 data[kSegments * - (sizeof(media::AudioInputBufferParameters) + frames * channels * - sizeof(float))]; +ALIGNAS(DATA_ALIGNMENT) +uint8_t data[kSegments * (sizeof(media::AudioInputBufferParameters) + + frames * channels * sizeof(float))]; } // namespace @@ -137,9 +142,8 @@ class AudioInputSyncWriterTest : public testing::Test { AudioParameters::AUDIO_FAKE, layout, sampling_frequency_hz, bits_per_sample, frames); - const uint32 segment_size = - sizeof(media::AudioInputBufferParameters) + - AudioBus::CalculateMemorySize(audio_params); + const uint32_t segment_size = sizeof(media::AudioInputBufferParameters) + + AudioBus::CalculateMemorySize(audio_params); size_t data_size = kSegments * segment_size; EXPECT_LE(data_size, sizeof(data)); diff --git a/content/browser/renderer_host/media/audio_output_device_enumerator_unittest.cc b/content/browser/renderer_host/media/audio_output_device_enumerator_unittest.cc index d509153..de1aa34 100644 --- a/content/browser/renderer_host/media/audio_output_device_enumerator_unittest.cc +++ b/content/browser/renderer_host/media/audio_output_device_enumerator_unittest.cc @@ -6,6 +6,7 @@ #include "base/bind.h" #include "base/location.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/run_loop.h" diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc index 29c9d7f..3acc345 100644 --- a/content/browser/renderer_host/media/audio_renderer_host.cc +++ b/content/browser/renderer_host/media/audio_renderer_host.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/media/audio_renderer_host.h" +#include <stdint.h> + #include "base/bind.h" #include "base/bind_helpers.h" #include "base/lazy_instance.h" @@ -569,8 +571,8 @@ void AudioRendererHost::DoCreateStream(int stream_id, } // Create the shared memory and share with the renderer process. - uint32 shared_memory_size = sizeof(media::AudioOutputBufferParameters) + - AudioBus::CalculateMemorySize(params); + uint32_t shared_memory_size = sizeof(media::AudioOutputBufferParameters) + + AudioBus::CalculateMemorySize(params); scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory()); if (!shared_memory->CreateAndMapAnonymous(shared_memory_size)) { SendErrorMessage(stream_id); diff --git a/content/browser/renderer_host/media/audio_renderer_host.h b/content/browser/renderer_host/media/audio_renderer_host.h index daea0b1..ce32fb1 100644 --- a/content/browser/renderer_host/media/audio_renderer_host.h +++ b/content/browser/renderer_host/media/audio_renderer_host.h @@ -44,8 +44,11 @@ #include <string> #include <utility> +#include <stddef.h> + #include "base/atomic_ref_count.h" #include "base/gtest_prod_util.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/process/process.h" diff --git a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc index cedd48d..396d923 100644 --- a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc +++ b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc @@ -2,8 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/bind.h" #include "base/command_line.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/run_loop.h" #include "base/sync_socket.h" @@ -117,8 +120,10 @@ class MockAudioRendererHost : public AudioRendererHost { } void OnNotifyStreamCreated( - int stream_id, base::SharedMemoryHandle handle, - base::SyncSocket::TransitDescriptor socket_descriptor, uint32 length) { + int stream_id, + base::SharedMemoryHandle handle, + base::SyncSocket::TransitDescriptor socket_descriptor, + uint32_t length) { // Maps the shared memory. shared_memory_.reset(new base::SharedMemory(handle, false)); CHECK(shared_memory_->Map(length)); @@ -154,7 +159,7 @@ class MockAudioRendererHost : public AudioRendererHost { scoped_ptr<base::SharedMemory> shared_memory_; scoped_ptr<base::SyncSocket> sync_socket_; - uint32 shared_memory_length_; + uint32_t shared_memory_length_; DISALLOW_COPY_AND_ASSIGN(MockAudioRendererHost); }; diff --git a/content/browser/renderer_host/media/audio_sync_reader.cc b/content/browser/renderer_host/media/audio_sync_reader.cc index ea794a2..85b13f8 100644 --- a/content/browser/renderer_host/media/audio_sync_reader.cc +++ b/content/browser/renderer_host/media/audio_sync_reader.cc @@ -10,6 +10,7 @@ #include "base/memory/shared_memory.h" #include "base/metrics/histogram.h" #include "base/strings/stringprintf.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/media_stream_manager.h" #include "content/public/common/content_switches.h" #include "media/audio/audio_parameters.h" @@ -159,7 +160,7 @@ bool AudioSyncReader::WaitUntilDataIsReady() { // catch up at some point, which means discarding counter values read from the // SyncSocket which don't match our current buffer index. size_t bytes_received = 0; - uint32 renderer_buffer_index = 0; + uint32_t renderer_buffer_index = 0; while (timeout.InMicroseconds() > 0) { bytes_received = socket_->ReceiveWithTimeout( &renderer_buffer_index, sizeof(renderer_buffer_index), timeout); diff --git a/content/browser/renderer_host/media/audio_sync_reader.h b/content/browser/renderer_host/media/audio_sync_reader.h index bb6c327..6e07e51 100644 --- a/content/browser/renderer_host/media/audio_sync_reader.h +++ b/content/browser/renderer_host/media/audio_sync_reader.h @@ -5,10 +5,15 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_SYNC_READER_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_SYNC_READER_H_ +#include <stddef.h> +#include <stdint.h> + +#include "base/macros.h" #include "base/process/process.h" #include "base/sync_socket.h" #include "base/synchronization/lock.h" #include "base/time/time.h" +#include "build/build_config.h" #include "media/audio/audio_output_controller.h" #include "media/base/audio_bus.h" @@ -77,7 +82,7 @@ class AudioSyncReader : public media::AudioOutputController::SyncReader { // The index of the audio buffer we're expecting to be sent from the renderer; // used to block with timeout for audio data. - uint32 buffer_index_; + uint32_t buffer_index_; DISALLOW_COPY_AND_ASSIGN(AudioSyncReader); }; diff --git a/content/browser/renderer_host/media/media_capture_devices_impl.h b/content/browser/renderer_host/media/media_capture_devices_impl.h index d40a34c..28d155c 100644 --- a/content/browser/renderer_host/media/media_capture_devices_impl.h +++ b/content/browser/renderer_host/media/media_capture_devices_impl.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_CAPTURE_DEVICES_IMPL_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_CAPTURE_DEVICES_IMPL_H_ +#include "base/macros.h" #include "base/memory/singleton.h" #include "content/public/browser/media_capture_devices.h" diff --git a/content/browser/renderer_host/media/media_stream_dispatcher_host.h b/content/browser/renderer_host/media/media_stream_dispatcher_host.h index 697fbae..a101067c 100644 --- a/content/browser/renderer_host/media/media_stream_dispatcher_host.h +++ b/content/browser/renderer_host/media/media_stream_dispatcher_host.h @@ -9,6 +9,7 @@ #include <string> #include <utility> +#include "base/macros.h" #include "content/browser/renderer_host/media/media_stream_manager.h" #include "content/browser/renderer_host/media/media_stream_requester.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc index db4edad..c262606 100644 --- a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc +++ b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> + #include <queue> #include <string> @@ -12,6 +14,7 @@ #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/thread_task_runner_handle.h" +#include "build/build_config.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/renderer_host/media/audio_input_device_manager.h" #include "content/browser/renderer_host/media/media_stream_dispatcher_host.h" diff --git a/content/browser/renderer_host/media/media_stream_manager.cc b/content/browser/renderer_host/media/media_stream_manager.cc index 0f71c8b..331142b 100644 --- a/content/browser/renderer_host/media/media_stream_manager.cc +++ b/content/browser/renderer_host/media/media_stream_manager.cc @@ -4,6 +4,9 @@ #include "content/browser/renderer_host/media/media_stream_manager.h" +#include <stddef.h> +#include <stdint.h> + #include <cctype> #include <list> #include <vector> @@ -12,6 +15,7 @@ #include "base/command_line.h" #include "base/compiler_specific.h" #include "base/logging.h" +#include "base/macros.h" #include "base/power_monitor/power_monitor.h" #include "base/profiler/scoped_tracker.h" #include "base/rand_util.h" @@ -21,6 +25,7 @@ #include "base/strings/stringprintf.h" #include "base/threading/thread.h" #include "base/threading/thread_local.h" +#include "build/build_config.h" #include "content/browser/browser_main_loop.h" #include "content/browser/media/capture/web_contents_capture_util.h" #include "content/browser/renderer_host/media/audio_input_device_manager.h" @@ -2052,7 +2057,7 @@ std::string MediaStreamManager::GetHMACForMediaDeviceID( crypto::HMAC hmac(crypto::HMAC::SHA256); const size_t digest_length = hmac.DigestLength(); - std::vector<uint8> digest(digest_length); + std::vector<uint8_t> digest(digest_length); std::string salt = sc.Run(); bool result = hmac.Init(security_origin.spec()) && hmac.Sign(raw_unique_id + salt, &digest[0], digest.size()); diff --git a/content/browser/renderer_host/media/media_stream_manager.h b/content/browser/renderer_host/media/media_stream_manager.h index 2da984c..21d4f2f 100644 --- a/content/browser/renderer_host/media/media_stream_manager.h +++ b/content/browser/renderer_host/media/media_stream_manager.h @@ -31,13 +31,14 @@ #include <string> #include <utility> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" #include "base/power_monitor/power_observer.h" #include "base/system_monitor/system_monitor.h" #include "base/threading/thread.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/audio_output_device_enumerator.h" #include "content/browser/renderer_host/media/media_stream_provider.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/media/media_stream_manager_unittest.cc b/content/browser/renderer_host/media/media_stream_manager_unittest.cc index 0be6883..9f7fadb 100644 --- a/content/browser/renderer_host/media/media_stream_manager_unittest.cc +++ b/content/browser/renderer_host/media/media_stream_manager_unittest.cc @@ -2,15 +2,19 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> + #include <string> #include "base/bind.h" #include "base/command_line.h" #include "base/location.h" +#include "base/macros.h" #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/strings/string_number_conversions.h" #include "base/thread_task_runner_handle.h" +#include "build/build_config.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/renderer_host/media/media_stream_manager.h" #include "content/browser/renderer_host/media/media_stream_requester.h" diff --git a/content/browser/renderer_host/media/media_stream_track_metrics_host.cc b/content/browser/renderer_host/media/media_stream_track_metrics_host.cc index 328d60e..3b74b40 100644 --- a/content/browser/renderer_host/media/media_stream_track_metrics_host.cc +++ b/content/browser/renderer_host/media/media_stream_track_metrics_host.cc @@ -46,7 +46,7 @@ bool MediaStreamTrackMetricsHost::OnMessageReceived( return handled; } -void MediaStreamTrackMetricsHost::OnAddTrack(uint64 id, +void MediaStreamTrackMetricsHost::OnAddTrack(uint64_t id, bool is_audio, bool is_remote) { if (tracks_.find(id) != tracks_.end()) @@ -56,7 +56,7 @@ void MediaStreamTrackMetricsHost::OnAddTrack(uint64 id, tracks_[id] = info; } -void MediaStreamTrackMetricsHost::OnRemoveTrack(uint64 id) { +void MediaStreamTrackMetricsHost::OnRemoveTrack(uint64_t id) { if (tracks_.find(id) == tracks_.end()) return; diff --git a/content/browser/renderer_host/media/media_stream_track_metrics_host.h b/content/browser/renderer_host/media/media_stream_track_metrics_host.h index 35235db..c800f3a 100644 --- a/content/browser/renderer_host/media/media_stream_track_metrics_host.h +++ b/content/browser/renderer_host/media/media_stream_track_metrics_host.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_TRACK_METRICS_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_TRACK_METRICS_HOST_H_ +#include <stdint.h> + #include <map> #include <string> @@ -37,8 +39,8 @@ class MediaStreamTrackMetricsHost bool OnMessageReceived(const IPC::Message& message) override; private: - void OnAddTrack(uint64 id, bool is_audio, bool is_remote); - void OnRemoveTrack(uint64 id); + void OnAddTrack(uint64_t id, bool is_audio, bool is_remote); + void OnRemoveTrack(uint64_t id); // Information for a track we're keeping in |tracks_|. |is_audio| // specifies whether it's an audio or video track, |is_remote| @@ -54,7 +56,7 @@ class MediaStreamTrackMetricsHost void ReportDuration(const TrackInfo& info); // Values are unique (per renderer) track IDs. - typedef std::map<uint64, TrackInfo> TrackMap; + typedef std::map<uint64_t, TrackInfo> TrackMap; TrackMap tracks_; }; diff --git a/content/browser/renderer_host/media/media_stream_ui_controller_unittest.cc b/content/browser/renderer_host/media/media_stream_ui_controller_unittest.cc index 990471f..f21618f 100644 --- a/content/browser/renderer_host/media/media_stream_ui_controller_unittest.cc +++ b/content/browser/renderer_host/media/media_stream_ui_controller_unittest.cc @@ -5,6 +5,7 @@ #include <string> #include "base/bind.h" +#include "base/macros.h" #include "base/message_loop/message_loop.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/renderer_host/media/media_stream_settings_requester.h" diff --git a/content/browser/renderer_host/media/media_stream_ui_proxy.cc b/content/browser/renderer_host/media/media_stream_ui_proxy.cc index 6d79ab4..4e4f442 100644 --- a/content/browser/renderer_host/media/media_stream_ui_proxy.cc +++ b/content/browser/renderer_host/media/media_stream_ui_proxy.cc @@ -5,6 +5,7 @@ #include "content/browser/renderer_host/media/media_stream_ui_proxy.h" #include "base/command_line.h" +#include "base/macros.h" #include "content/browser/frame_host/frame_tree_node.h" #include "content/browser/frame_host/render_frame_host_delegate.h" #include "content/browser/frame_host/render_frame_host_impl.h" diff --git a/content/browser/renderer_host/media/media_stream_ui_proxy.h b/content/browser/renderer_host/media/media_stream_ui_proxy.h index 117f7c4..0c2eaea 100644 --- a/content/browser/renderer_host/media/media_stream_ui_proxy.h +++ b/content/browser/renderer_host/media/media_stream_ui_proxy.h @@ -5,8 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_UI_PROXY_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_UI_PROXY_H_ -#include "base/basictypes.h" #include "base/callback.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "content/public/browser/browser_thread.h" diff --git a/content/browser/renderer_host/media/peer_connection_tracker_host.cc b/content/browser/renderer_host/media/peer_connection_tracker_host.cc index e3acceb..41580ebe 100644 --- a/content/browser/renderer_host/media/peer_connection_tracker_host.cc +++ b/content/browser/renderer_host/media/peer_connection_tracker_host.cc @@ -41,7 +41,7 @@ void PeerConnectionTrackerHost::OverrideThreadForMessage( PeerConnectionTrackerHost::~PeerConnectionTrackerHost() { } -void PeerConnectionTrackerHost::OnChannelConnected(int32 peer_pid) { +void PeerConnectionTrackerHost::OnChannelConnected(int32_t peer_pid) { DCHECK_CURRENTLY_ON(BrowserThread::IO); // Add PowerMonitor when connected to channel rather than in constructor due // to thread safety concerns. Observers of PowerMonitor must be added and diff --git a/content/browser/renderer_host/media/peer_connection_tracker_host.h b/content/browser/renderer_host/media/peer_connection_tracker_host.h index 788af93..53a9630 100644 --- a/content/browser/renderer_host/media/peer_connection_tracker_host.h +++ b/content/browser/renderer_host/media/peer_connection_tracker_host.h @@ -5,6 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_PEER_CONNECTION_TRACKER_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_PEER_CONNECTION_TRACKER_HOST_H_ +#include <stdint.h> + +#include "base/macros.h" #include "base/power_monitor/power_observer.h" #include "content/public/browser/browser_message_filter.h" @@ -29,7 +32,7 @@ class PeerConnectionTrackerHost : public BrowserMessageFilter, bool OnMessageReceived(const IPC::Message& message) override; void OverrideThreadForMessage(const IPC::Message& message, BrowserThread::ID* thread) override; - void OnChannelConnected(int32 peer_pid) override; + void OnChannelConnected(int32_t peer_pid) override; void OnChannelClosing() override; // base::PowerObserver override. diff --git a/content/browser/renderer_host/media/video_capture_buffer_pool.cc b/content/browser/renderer_host/media/video_capture_buffer_pool.cc index 0d66428..a934a40c 100644 --- a/content/browser/renderer_host/media/video_capture_buffer_pool.cc +++ b/content/browser/renderer_host/media/video_capture_buffer_pool.cc @@ -7,6 +7,7 @@ #include "base/logging.h" #include "base/memory/scoped_ptr.h" #include "base/stl_util.h" +#include "build/build_config.h" #include "content/browser/gpu/browser_gpu_memory_buffer_manager.h" #include "content/public/browser/browser_thread.h" #include "ui/gfx/buffer_format_util.h" diff --git a/content/browser/renderer_host/media/video_capture_buffer_pool.h b/content/browser/renderer_host/media/video_capture_buffer_pool.h index 9a46808..c69a842 100644 --- a/content/browser/renderer_host/media/video_capture_buffer_pool.h +++ b/content/browser/renderer_host/media/video_capture_buffer_pool.h @@ -5,14 +5,17 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_BUFFER_POOL_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_BUFFER_POOL_H_ +#include <stddef.h> + #include <map> -#include "base/basictypes.h" #include "base/files/file.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/shared_memory.h" #include "base/process/process.h" #include "base/synchronization/lock.h" +#include "build/build_config.h" #include "content/common/content_export.h" #include "media/base/video_capture_types.h" #include "media/base/video_frame.h" diff --git a/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc b/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc index 5ebb610..3aafd9f 100644 --- a/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc +++ b/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc @@ -6,10 +6,15 @@ #include "content/browser/renderer_host/media/video_capture_buffer_pool.h" +#include <stddef.h> +#include <stdint.h> + #include "base/bind.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" +#include "build/build_config.h" #include "cc/test/test_context_provider.h" #include "cc/test/test_web_graphics_context_3d.h" #include "content/browser/compositor/buffer_queue.h" @@ -46,7 +51,9 @@ class VideoCaptureBufferPoolTest class MockGpuMemoryBuffer : public gfx::GpuMemoryBuffer { public: explicit MockGpuMemoryBuffer(const gfx::Size& size) - : size_(size), data_(new uint8[size_.GetArea() * 4]), mapped_(false) {} + : size_(size), + data_(new uint8_t[size_.GetArea() * 4]), + mapped_(false) {} ~MockGpuMemoryBuffer() override { delete[] data_; } bool Map() override { @@ -81,7 +88,7 @@ class VideoCaptureBufferPoolTest private: const gfx::Size size_; - uint8* const data_; + uint8_t* const data_; bool mapped_; }; diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc index 72a7a62..6cde5f0 100644 --- a/content/browser/renderer_host/media/video_capture_controller.cc +++ b/content/browser/renderer_host/media/video_capture_controller.cc @@ -4,6 +4,9 @@ #include "content/browser/renderer_host/media/video_capture_controller.h" +#include <stddef.h> +#include <stdint.h> + #include <map> #include <set> @@ -12,6 +15,7 @@ #include "base/metrics/histogram.h" #include "base/metrics/sparse_histogram.h" #include "base/stl_util.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/media_stream_manager.h" #include "content/browser/renderer_host/media/video_capture_buffer_pool.h" #include "content/browser/renderer_host/media/video_capture_device_client.h" @@ -367,8 +371,8 @@ void VideoCaptureController::DoIncomingCapturedVideoFrameOnIOThread( media::VideoFrame::STORAGE_GPU_MEMORY_BUFFERS)); DCHECK(frame->data(media::VideoFrame::kYPlane) >= buffer->data(0) && (frame->data(media::VideoFrame::kYPlane) < - (reinterpret_cast<const uint8*>(buffer->data(0)) + - buffer->mapped_size()))) + (reinterpret_cast<const uint8_t*>(buffer->data(0)) + + buffer->mapped_size()))) << "VideoFrame does not appear to be backed by Buffer"; for (const auto& client : controller_clients_) { diff --git a/content/browser/renderer_host/media/video_capture_controller.h b/content/browser/renderer_host/media/video_capture_controller.h index 9f97ad3..6661144 100644 --- a/content/browser/renderer_host/media/video_capture_controller.h +++ b/content/browser/renderer_host/media/video_capture_controller.h @@ -43,6 +43,7 @@ #include <list> #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" diff --git a/content/browser/renderer_host/media/video_capture_controller_unittest.cc b/content/browser/renderer_host/media/video_capture_controller_unittest.cc index 9af6feea..626b376 100644 --- a/content/browser/renderer_host/media/video_capture_controller_unittest.cc +++ b/content/browser/renderer_host/media/video_capture_controller_unittest.cc @@ -4,11 +4,14 @@ // Unit test for VideoCaptureController. +#include <stdint.h> + #include <string> #include "base/bind.h" #include "base/bind_helpers.h" #include "base/location.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/run_loop.h" @@ -116,7 +119,7 @@ class VideoCaptureControllerTest : public testing::Test { void TearDown() override { base::RunLoop().RunUntilIdle(); } scoped_refptr<media::VideoFrame> WrapI420Buffer(gfx::Size dimensions, - uint8* data) { + uint8_t* data) { return media::VideoFrame::WrapExternalSharedMemory( media::PIXEL_FORMAT_I420, dimensions, gfx::Rect(dimensions), dimensions, data, @@ -280,7 +283,7 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) { // Now, simulate an incoming captured buffer from the capture device. As a // side effect this will cause the first buffer to be shared with clients. - uint8 buffer_no = 1; + uint8_t buffer_no = 1; ASSERT_EQ(0.0, device_->GetBufferPoolUtilization()); scoped_ptr<media::VideoCaptureDevice::Client::Buffer> buffer( device_->ReserveOutputBuffer(capture_resolution, @@ -311,7 +314,7 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) { .Times(1); } scoped_refptr<media::VideoFrame> video_frame = - WrapI420Buffer(capture_resolution, static_cast<uint8*>(buffer->data())); + WrapI420Buffer(capture_resolution, static_cast<uint8_t*>(buffer->data())); ASSERT_FALSE(video_frame->metadata()->HasKey( media::VideoFrameMetadata::RESOURCE_UTILIZATION)); client_a_->resource_utilization_ = 0.5; @@ -339,8 +342,8 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) { media::PIXEL_STORAGE_CPU); ASSERT_TRUE(buffer2.get()); memset(buffer2->data(), buffer_no++, buffer2->mapped_size()); - video_frame = - WrapI420Buffer(capture_resolution, static_cast<uint8*>(buffer2->data())); + video_frame = WrapI420Buffer(capture_resolution, + static_cast<uint8_t*>(buffer2->data())); ASSERT_FALSE(video_frame->metadata()->HasKey( media::VideoFrameMetadata::RESOURCE_UTILIZATION)); client_a_->resource_utilization_ = 0.5; @@ -385,8 +388,8 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) { media::PIXEL_STORAGE_CPU); ASSERT_TRUE(buffer.get()); memset(buffer->data(), buffer_no++, buffer->mapped_size()); - video_frame = - WrapI420Buffer(capture_resolution, static_cast<uint8*>(buffer->data())); + video_frame = WrapI420Buffer(capture_resolution, + static_cast<uint8_t*>(buffer->data())); device_->OnIncomingCapturedVideoFrame(buffer.Pass(), video_frame, base::TimeTicks()); } @@ -433,8 +436,8 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) { media::PIXEL_STORAGE_CPU); ASSERT_TRUE(buffer3.get()); memset(buffer3->data(), buffer_no++, buffer3->mapped_size()); - video_frame = - WrapI420Buffer(capture_resolution, static_cast<uint8*>(buffer3->data())); + video_frame = WrapI420Buffer(capture_resolution, + static_cast<uint8_t*>(buffer3->data())); device_->OnIncomingCapturedVideoFrame(buffer3.Pass(), video_frame, base::TimeTicks()); @@ -450,8 +453,8 @@ TEST_F(VideoCaptureControllerTest, NormalCaptureMultipleClients) { } ASSERT_TRUE(buffer4.get()); memset(buffer4->data(), buffer_no++, buffer4->mapped_size()); - video_frame = - WrapI420Buffer(capture_resolution, static_cast<uint8*>(buffer4->data())); + video_frame = WrapI420Buffer(capture_resolution, + static_cast<uint8_t*>(buffer4->data())); device_->OnIncomingCapturedVideoFrame(buffer4.Pass(), video_frame, base::TimeTicks()); // B2 is the only client left, and is the only one that should @@ -499,7 +502,7 @@ TEST_F(VideoCaptureControllerTest, ErrorBeforeDeviceCreation) { media::PIXEL_STORAGE_CPU)); ASSERT_TRUE(buffer.get()); scoped_refptr<media::VideoFrame> video_frame = - WrapI420Buffer(capture_resolution, static_cast<uint8*>(buffer->data())); + WrapI420Buffer(capture_resolution, static_cast<uint8_t*>(buffer->data())); device_->OnIncomingCapturedVideoFrame(buffer.Pass(), video_frame, base::TimeTicks()); @@ -536,7 +539,7 @@ TEST_F(VideoCaptureControllerTest, ErrorAfterDeviceCreation) { ASSERT_TRUE(buffer.get()); scoped_refptr<media::VideoFrame> video_frame = - WrapI420Buffer(dims, static_cast<uint8*>(buffer->data())); + WrapI420Buffer(dims, static_cast<uint8_t*>(buffer->data())); device_->OnError(FROM_HERE, "Test Error"); device_->OnIncomingCapturedVideoFrame(buffer.Pass(), video_frame, base::TimeTicks()); diff --git a/content/browser/renderer_host/media/video_capture_device_client.cc b/content/browser/renderer_host/media/video_capture_device_client.cc index 4b6c4b3..2bb27e8 100644 --- a/content/browser/renderer_host/media/video_capture_device_client.cc +++ b/content/browser/renderer_host/media/video_capture_device_client.cc @@ -11,6 +11,7 @@ #include "base/location.h" #include "base/strings/stringprintf.h" #include "base/trace_event/trace_event.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/video_capture_buffer_pool.h" #include "content/browser/renderer_host/media/video_capture_controller.h" #include "content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h" @@ -78,7 +79,7 @@ VideoCaptureDeviceClient::~VideoCaptureDeviceClient() { } void VideoCaptureDeviceClient::OnIncomingCapturedData( - const uint8* data, + const uint8_t* data, int length, const VideoCaptureFormat& frame_format, int rotation, @@ -130,7 +131,7 @@ void VideoCaptureDeviceClient::OnIncomingCapturedData( const media::VideoPixelStorage output_pixel_storage = use_gpu_memory_buffers_ ? media::PIXEL_STORAGE_GPUMEMORYBUFFER : media::PIXEL_STORAGE_CPU; - uint8 *y_plane_data, *u_plane_data, *v_plane_data; + uint8_t *y_plane_data, *u_plane_data, *v_plane_data; scoped_ptr<Buffer> buffer( ReserveI420OutputBuffer(dimensions, output_pixel_storage, &y_plane_data, &u_plane_data, &v_plane_data)); @@ -254,11 +255,10 @@ void VideoCaptureDeviceClient::OnIncomingCapturedData( OnIncomingCapturedBuffer(buffer.Pass(), output_format, timestamp); } -void -VideoCaptureDeviceClient::OnIncomingCapturedYuvData( - const uint8* y_data, - const uint8* u_data, - const uint8* v_data, +void VideoCaptureDeviceClient::OnIncomingCapturedYuvData( + const uint8_t* y_data, + const uint8_t* u_data, + const uint8_t* v_data, size_t y_stride, size_t u_stride, size_t v_stride, @@ -270,7 +270,7 @@ VideoCaptureDeviceClient::OnIncomingCapturedYuvData( DCHECK_EQ(media::PIXEL_STORAGE_CPU, frame_format.pixel_storage); DCHECK_EQ(0, clockwise_rotation) << "Rotation not supported"; - uint8 *y_plane_data, *u_plane_data, *v_plane_data; + uint8_t *y_plane_data, *u_plane_data, *v_plane_data; scoped_ptr<Buffer> buffer(ReserveI420OutputBuffer( frame_format.frame_size, frame_format.pixel_storage, &y_plane_data, &u_plane_data, &v_plane_data)); @@ -351,9 +351,9 @@ void VideoCaptureDeviceClient::OnIncomingCapturedBuffer( frame = VideoFrame::WrapExternalYuvGpuMemoryBuffers( media::PIXEL_FORMAT_I420, frame_format.frame_size, gfx::Rect(frame_format.frame_size), frame_format.frame_size, 0, 0, 0, - reinterpret_cast<uint8*>(buffer->data(media::VideoFrame::kYPlane)), - reinterpret_cast<uint8*>(buffer->data(media::VideoFrame::kUPlane)), - reinterpret_cast<uint8*>(buffer->data(media::VideoFrame::kVPlane)), + reinterpret_cast<uint8_t*>(buffer->data(media::VideoFrame::kYPlane)), + reinterpret_cast<uint8_t*>(buffer->data(media::VideoFrame::kUPlane)), + reinterpret_cast<uint8_t*>(buffer->data(media::VideoFrame::kVPlane)), handle, handle, handle, base::TimeDelta()); break; } @@ -361,7 +361,7 @@ void VideoCaptureDeviceClient::OnIncomingCapturedBuffer( frame = VideoFrame::WrapExternalSharedMemory( media::PIXEL_FORMAT_I420, frame_format.frame_size, gfx::Rect(frame_format.frame_size), frame_format.frame_size, - reinterpret_cast<uint8*>(buffer->data()), + reinterpret_cast<uint8_t*>(buffer->data()), VideoFrame::AllocationSize(media::PIXEL_FORMAT_I420, frame_format.frame_size), base::SharedMemory::NULLHandle(), 0u, base::TimeDelta()); @@ -419,9 +419,9 @@ scoped_ptr<media::VideoCaptureDevice::Client::Buffer> VideoCaptureDeviceClient::ReserveI420OutputBuffer( const gfx::Size& dimensions, media::VideoPixelStorage storage, - uint8** y_plane_data, - uint8** u_plane_data, - uint8** v_plane_data) { + uint8_t** y_plane_data, + uint8_t** u_plane_data, + uint8_t** v_plane_data) { DCHECK(storage == media::PIXEL_STORAGE_GPUMEMORYBUFFER || storage == media::PIXEL_STORAGE_CPU); DCHECK(dimensions.height()); @@ -437,7 +437,7 @@ VideoCaptureDeviceClient::ReserveI420OutputBuffer( case media::PIXEL_STORAGE_CPU: // TODO(emircan): See http://crbug.com/521068, move this pointer // arithmetic inside Buffer::data() when this bug is resolved. - *y_plane_data = reinterpret_cast<uint8*>(buffer->data()); + *y_plane_data = reinterpret_cast<uint8_t*>(buffer->data()); *u_plane_data = *y_plane_data + VideoFrame::PlaneSize(format, VideoFrame::kYPlane, dimensions) @@ -449,11 +449,11 @@ VideoCaptureDeviceClient::ReserveI420OutputBuffer( return buffer.Pass(); case media::PIXEL_STORAGE_GPUMEMORYBUFFER: *y_plane_data = - reinterpret_cast<uint8*>(buffer->data(VideoFrame::kYPlane)); + reinterpret_cast<uint8_t*>(buffer->data(VideoFrame::kYPlane)); *u_plane_data = - reinterpret_cast<uint8*>(buffer->data(VideoFrame::kUPlane)); + reinterpret_cast<uint8_t*>(buffer->data(VideoFrame::kUPlane)); *v_plane_data = - reinterpret_cast<uint8*>(buffer->data(VideoFrame::kVPlane)); + reinterpret_cast<uint8_t*>(buffer->data(VideoFrame::kVPlane)); return buffer.Pass(); } NOTREACHED(); diff --git a/content/browser/renderer_host/media/video_capture_device_client.h b/content/browser/renderer_host/media/video_capture_device_client.h index 111839c..8215f564 100644 --- a/content/browser/renderer_host/media/video_capture_device_client.h +++ b/content/browser/renderer_host/media/video_capture_device_client.h @@ -5,6 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_DEVICE_CLIENT_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_DEVICE_CLIENT_H_ +#include <stddef.h> +#include <stdint.h> + +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" @@ -40,14 +44,14 @@ class CONTENT_EXPORT VideoCaptureDeviceClient ~VideoCaptureDeviceClient() override; // VideoCaptureDevice::Client implementation. - void OnIncomingCapturedData(const uint8* data, + void OnIncomingCapturedData(const uint8_t* data, int length, const media::VideoCaptureFormat& frame_format, int rotation, const base::TimeTicks& timestamp) override; - void OnIncomingCapturedYuvData(const uint8* y_data, - const uint8* u_data, - const uint8* v_data, + void OnIncomingCapturedYuvData(const uint8_t* y_data, + const uint8_t* u_data, + const uint8_t* v_data, size_t y_stride, size_t u_stride, size_t v_stride, @@ -85,9 +89,9 @@ class CONTENT_EXPORT VideoCaptureDeviceClient // are destroyed or returned. scoped_ptr<Buffer> ReserveI420OutputBuffer(const gfx::Size& dimensions, media::VideoPixelStorage storage, - uint8** y_plane_data, - uint8** u_plane_data, - uint8** v_plane_data); + uint8_t** y_plane_data, + uint8_t** u_plane_data, + uint8_t** v_plane_data); // The controller to which we post events. const base::WeakPtr<VideoCaptureController> controller_; diff --git a/content/browser/renderer_host/media/video_capture_device_client_unittest.cc b/content/browser/renderer_host/media/video_capture_device_client_unittest.cc index 0918974..56c0a12 100644 --- a/content/browser/renderer_host/media/video_capture_device_client_unittest.cc +++ b/content/browser/renderer_host/media/video_capture_device_client_unittest.cc @@ -2,11 +2,15 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> + #include "base/bind.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/thread_task_runner_handle.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/video_capture_buffer_pool.h" #include "content/browser/renderer_host/media/video_capture_controller.h" #include "content/browser/renderer_host/media/video_capture_device_client.h" diff --git a/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc b/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc index a370ccf..c48181a 100644 --- a/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc +++ b/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc @@ -14,6 +14,7 @@ #include "base/strings/stringprintf.h" #include "base/thread_task_runner_handle.h" #include "base/trace_event/trace_event.h" +#include "build/build_config.h" #include "content/browser/gpu/browser_gpu_channel_host_factory.h" #include "content/common/gpu/client/gpu_jpeg_decode_accelerator_host.h" #include "content/public/browser/browser_thread.h" diff --git a/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h b/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h index f87c288b..554cb10 100644 --- a/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h +++ b/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h @@ -5,9 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_GPU_JPEG_DECODER_H_ #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_GPU_JPEG_DECODER_H_ +#include <stddef.h> +#include <stdint.h> + #include <string> #include "base/callback.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" diff --git a/content/browser/renderer_host/media/video_capture_host.h b/content/browser/renderer_host/media/video_capture_host.h index b7bb275..c35153f 100644 --- a/content/browser/renderer_host/media/video_capture_host.h +++ b/content/browser/renderer_host/media/video_capture_host.h @@ -53,6 +53,7 @@ #include <map> +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/weak_ptr.h" #include "base/sequenced_task_runner_helpers.h" diff --git a/content/browser/renderer_host/media/video_capture_host_unittest.cc b/content/browser/renderer_host/media/video_capture_host_unittest.cc index a26a9c3..b1d991a 100644 --- a/content/browser/renderer_host/media/video_capture_host_unittest.cc +++ b/content/browser/renderer_host/media/video_capture_host_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include <map> #include <string> @@ -10,12 +12,14 @@ #include "base/files/file_util.h" #include "base/files/scoped_file.h" #include "base/location.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/stl_util.h" #include "base/strings/stringprintf.h" #include "base/thread_task_runner_handle.h" +#include "build/build_config.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/renderer_host/media/media_stream_manager.h" #include "content/browser/renderer_host/media/media_stream_requester.h" @@ -199,7 +203,7 @@ class MockVideoCaptureHost : public VideoCaptureHost { // These handler methods do minimal things and delegate to the mock methods. void OnNewBufferCreatedDispatch(int device_id, base::SharedMemoryHandle handle, - uint32 length, + uint32_t length, int buffer_id) { OnNewBufferCreated(device_id, handle, length, buffer_id); base::SharedMemory* dib = new base::SharedMemory(handle, false); diff --git a/content/browser/renderer_host/media/video_capture_manager.cc b/content/browser/renderer_host/media/video_capture_manager.cc index 82af565..7c1da94 100644 --- a/content/browser/renderer_host/media/video_capture_manager.cc +++ b/content/browser/renderer_host/media/video_capture_manager.cc @@ -19,6 +19,7 @@ #include "base/task_runner_util.h" #include "base/thread_task_runner_handle.h" #include "base/threading/sequenced_worker_pool.h" +#include "build/build_config.h" #include "content/browser/media/capture/web_contents_video_capture_device.h" #include "content/browser/media/media_internals.h" #include "content/browser/renderer_host/media/video_capture_controller.h" diff --git a/content/browser/renderer_host/media/video_capture_manager.h b/content/browser/renderer_host/media/video_capture_manager.h index 54bd1ff..6a5fc9c 100644 --- a/content/browser/renderer_host/media/video_capture_manager.h +++ b/content/browser/renderer_host/media/video_capture_manager.h @@ -17,6 +17,7 @@ #include <set> #include <string> +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_vector.h" #include "base/memory/weak_ptr.h" @@ -24,6 +25,7 @@ #include "base/process/process_handle.h" #include "base/threading/thread_checker.h" #include "base/timer/elapsed_timer.h" +#include "build/build_config.h" #include "content/browser/renderer_host/media/media_stream_provider.h" #include "content/browser/renderer_host/media/video_capture_controller_event_handler.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/media/video_capture_manager_unittest.cc b/content/browser/renderer_host/media/video_capture_manager_unittest.cc index 53fa76d..954544c 100644 --- a/content/browser/renderer_host/media/video_capture_manager_unittest.cc +++ b/content/browser/renderer_host/media/video_capture_manager_unittest.cc @@ -4,9 +4,12 @@ // Unit test for VideoCaptureManager. +#include <stdint.h> + #include <string> #include "base/bind.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/run_loop.h" @@ -83,7 +86,7 @@ class VideoCaptureManagerTest : public testing::Test { video_capture_device_factory_ = static_cast<media::FakeVideoCaptureDeviceFactory*>( vcm_->video_capture_device_factory()); - const int32 kNumberOfFakeDevices = 2; + const int32_t kNumberOfFakeDevices = 2; video_capture_device_factory_->set_number_of_devices(kNumberOfFakeDevices); vcm_->Register(listener_.get(), message_loop_->task_runner().get()); frame_observer_.reset(new MockFrameObserver()); diff --git a/content/browser/renderer_host/media/webrtc_identity_service_host.h b/content/browser/renderer_host/media/webrtc_identity_service_host.h index 2b2a4af..51744f4 100644 --- a/content/browser/renderer_host/media/webrtc_identity_service_host.h +++ b/content/browser/renderer_host/media/webrtc_identity_service_host.h @@ -7,7 +7,7 @@ #include <string> -#include "base/basictypes.h" +#include "base/macros.h" #include "content/common/content_export.h" #include "content/public/browser/browser_message_filter.h" diff --git a/content/browser/renderer_host/memory_benchmark_message_filter.cc b/content/browser/renderer_host/memory_benchmark_message_filter.cc index 6073253..9125a8c 100644 --- a/content/browser/renderer_host/memory_benchmark_message_filter.cc +++ b/content/browser/renderer_host/memory_benchmark_message_filter.cc @@ -4,6 +4,7 @@ #include "content/browser/renderer_host/memory_benchmark_message_filter.h" +#include "build/build_config.h" #include "content/common/memory_benchmark_messages.h" #if defined(USE_TCMALLOC) && (defined(OS_LINUX) || defined(OS_ANDROID)) diff --git a/content/browser/renderer_host/memory_benchmark_message_filter.h b/content/browser/renderer_host/memory_benchmark_message_filter.h index d30e3a7..0bafa73 100644 --- a/content/browser/renderer_host/memory_benchmark_message_filter.h +++ b/content/browser/renderer_host/memory_benchmark_message_filter.h @@ -7,6 +7,7 @@ #include <string> +#include "base/macros.h" #include "content/public/browser/browser_message_filter.h" namespace content { diff --git a/content/browser/renderer_host/overscroll_controller.h b/content/browser/renderer_host/overscroll_controller.h index 6ea77e6..92fa093 100644 --- a/content/browser/renderer_host/overscroll_controller.h +++ b/content/browser/renderer_host/overscroll_controller.h @@ -5,8 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_OVERSCROLL_CONTROLLER_H_ #define CONTENT_BROWSER_RENDERER_HOST_OVERSCROLL_CONTROLLER_H_ -#include "base/basictypes.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "third_party/WebKit/public/web/WebInputEvent.h" namespace ui { diff --git a/content/browser/renderer_host/overscroll_controller_delegate.h b/content/browser/renderer_host/overscroll_controller_delegate.h index b3d4757..0533cde 100644 --- a/content/browser/renderer_host/overscroll_controller_delegate.h +++ b/content/browser/renderer_host/overscroll_controller_delegate.h @@ -5,8 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_OVERSCROLL_CONTROLLER_DELEGATE_H_ #define CONTENT_BROWSER_RENDERER_HOST_OVERSCROLL_CONTROLLER_DELEGATE_H_ -#include "base/basictypes.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "content/browser/renderer_host/overscroll_controller.h" #include "content/common/content_export.h" #include "ui/gfx/geometry/rect.h" diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc index df0224d..784a808 100644 --- a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc +++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/p2p/socket_dispatcher_host.h" +#include <stddef.h> + #include "base/bind.h" #include "base/stl_util.h" #include "content/browser/renderer_host/p2p/socket_host.h" @@ -44,10 +46,8 @@ class P2PSocketDispatcherHost::DnsRequest { public: typedef base::Callback<void(const net::IPAddressList&)> DoneCallback; - DnsRequest(int32 request_id, net::HostResolver* host_resolver) - : request_id_(request_id), - resolver_(host_resolver) { - } + DnsRequest(int32_t request_id, net::HostResolver* host_resolver) + : request_id_(request_id), resolver_(host_resolver) {} void Resolve(const std::string& host_name, const DoneCallback& done_callback) { @@ -80,7 +80,7 @@ class P2PSocketDispatcherHost::DnsRequest { OnDone(result); } - int32 request_id() { return request_id_; } + int32_t request_id() { return request_id_; } private: void OnDone(int result) { @@ -100,7 +100,7 @@ class P2PSocketDispatcherHost::DnsRequest { done_callback_.Run(list); } - int32 request_id_; + int32_t request_id_; net::AddressList addresses_; std::string host_name_; @@ -228,7 +228,7 @@ void P2PSocketDispatcherHost::OnStopNetworkNotifications() { } void P2PSocketDispatcherHost::OnGetHostAddress(const std::string& host_name, - int32 request_id) { + int32_t request_id) { DnsRequest* request = new DnsRequest(request_id, resource_context_->GetHostResolver()); dns_requests_.insert(request); @@ -292,7 +292,7 @@ void P2PSocketDispatcherHost::OnSend(int socket_id, const net::IPEndPoint& socket_address, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) { + uint64_t packet_id) { P2PSocketHost* socket = LookupSocket(socket_id); if (!socket) { LOG(ERROR) << "Received P2PHostMsg_Send for invalid socket_id."; diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.h b/content/browser/renderer_host/p2p/socket_dispatcher_host.h index ec19453..d783e1f 100644 --- a/content/browser/renderer_host/p2p/socket_dispatcher_host.h +++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.h @@ -5,11 +5,14 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_DISPATCHER_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_DISPATCHER_HOST_H_ +#include <stdint.h> + #include <map> #include <set> #include <string> #include <vector> +#include "base/macros.h" #include "content/browser/renderer_host/p2p/socket_host_throttler.h" #include "content/common/p2p_socket_type.h" #include "content/public/browser/browser_message_filter.h" @@ -71,8 +74,7 @@ class P2PSocketDispatcherHost // Handlers for the messages coming from the renderer. void OnStartNetworkNotifications(); void OnStopNetworkNotifications(); - void OnGetHostAddress(const std::string& host_name, - int32 request_id); + void OnGetHostAddress(const std::string& host_name, int32_t request_id); void OnCreateSocket(P2PSocketType type, int socket_id, @@ -85,7 +87,7 @@ class P2PSocketDispatcherHost const net::IPEndPoint& socket_address, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id); + uint64_t packet_id); void OnSetOption(int socket_id, P2PSocketOption option, int value); void OnDestroySocket(int socket_id); diff --git a/content/browser/renderer_host/p2p/socket_host.cc b/content/browser/renderer_host/p2p/socket_host.cc index fefc4a5..ef6b588 100644 --- a/content/browser/renderer_host/p2p/socket_host.cc +++ b/content/browser/renderer_host/p2p/socket_host.cc @@ -19,7 +19,7 @@ namespace { -const uint32 kStunMagicCookie = 0x2112A442; +const uint32_t kStunMagicCookie = 0x2112A442; const size_t kMinRtpHeaderLength = 12; const size_t kMinRtcpHeaderLength = 8; const size_t kRtpExtensionHeaderLength = 4; @@ -41,7 +41,7 @@ bool IsTurnChannelData(const char* data, size_t length) { } bool IsDtlsPacket(const char* data, size_t length) { - const uint8* u = reinterpret_cast<const uint8*>(data); + const uint8_t* u = reinterpret_cast<const uint8_t*>(data); return (length >= kDtlsRecordHeaderLength && (u[0] > 19 && u[0] < 64)); } @@ -50,7 +50,7 @@ bool IsRtcpPacket(const char* data, size_t length) { return false; } - int type = (static_cast<uint8>(data[1]) & 0x7F); + int type = (static_cast<uint8_t>(data[1]) & 0x7F); return (type >= 64 && type < 96); } @@ -59,7 +59,7 @@ bool IsTurnSendIndicationPacket(const char* data, size_t length) { return false; } - uint16 type = rtc::GetBE16(data); + uint16_t type = rtc::GetBE16(data); return (type == cricket::TURN_SEND_INDICATION); } @@ -100,7 +100,7 @@ bool ValidateRtpHeader(const char* rtp, size_t length, size_t* header_length) { // Getting extension profile length. // Length is in 32 bit words. - uint16 extension_length_in_32bits = rtc::GetBE16(rtp + 2); + uint16_t extension_length_in_32bits = rtc::GetBE16(rtp + 2); size_t extension_length = extension_length_in_32bits * 4; size_t rtp_header_length = extension_length + @@ -120,7 +120,7 @@ bool ValidateRtpHeader(const char* rtp, size_t length, size_t* header_length) { void UpdateAbsSendTimeExtensionValue(char* extension_data, size_t length, - uint32 abs_send_time) { + uint32_t abs_send_time) { // Absolute send time in RTP streams. // // The absolute send time is signaled to the receiver in-band using the @@ -142,18 +142,18 @@ void UpdateAbsSendTimeExtensionValue(char* extension_data, } // Now() has resolution ~1-15ms - uint32 now_second = abs_send_time; + uint32_t now_second = abs_send_time; if (!now_second) { - uint64 now_us = + uint64_t now_us = (base::TimeTicks::Now() - base::TimeTicks()).InMicroseconds(); // Convert second to 24-bit unsigned with 18 bit fractional part now_second = ((now_us << 18) / base::Time::kMicrosecondsPerSecond) & 0x00FFFFFF; } // TODO(mallinath) - Add SetBE24 to byteorder.h in libjingle. - extension_data[0] = static_cast<uint8>(now_second >> 16); - extension_data[1] = static_cast<uint8>(now_second >> 8); - extension_data[2] = static_cast<uint8>(now_second); + extension_data[0] = static_cast<uint8_t>(now_second >> 16); + extension_data[1] = static_cast<uint8_t>(now_second >> 8); + extension_data[2] = static_cast<uint8_t>(now_second); } // Assumes |length| is actual packet length + tag length. Updates HMAC at end of @@ -218,7 +218,7 @@ namespace packet_processing_helpers { bool ApplyPacketOptions(char* data, size_t length, const rtc::PacketOptions& options, - uint32 abs_send_time) { + uint32_t abs_send_time) { DCHECK(data != NULL); DCHECK(length > 0); // if there is no valid |rtp_sendtime_extension_id| and |srtp_auth_key| in @@ -311,7 +311,7 @@ bool GetRtpPacketStartPositionAndLength(const char* packet, // is not a multiple of 4 bytes are padded with 1, 2, or 3 bytes of // padding so that its value contains a multiple of 4 bytes. The // padding bits are ignored, and may be any value. - uint16 attr_type, attr_length; + uint16_t attr_type, attr_length; const int kAttrHeaderLength = sizeof(attr_type) + sizeof(attr_length); if (length < rtp_begin + kAttrHeaderLength) { @@ -372,7 +372,7 @@ bool GetRtpPacketStartPositionAndLength(const char* packet, bool UpdateRtpAbsSendTimeExtension(char* rtp, size_t length, int extension_id, - uint32 abs_send_time) { + uint32_t abs_send_time) { // 0 1 2 3 // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ @@ -397,9 +397,9 @@ bool UpdateRtpAbsSendTimeExtension(char* rtp, rtp += header_length_without_extension; // Getting extension profile ID and length. - uint16 profile_id = rtc::GetBE16(rtp); + uint16_t profile_id = rtc::GetBE16(rtp); // Length is in 32 bit words. - uint16 extension_length_in_32bits = rtc::GetBE16(rtp + 2); + uint16_t extension_length_in_32bits = rtc::GetBE16(rtp + 2); size_t extension_length = extension_length_in_32bits * 4; rtp += kRtpExtensionHeaderLength; // Moving past extension header. @@ -500,17 +500,20 @@ bool P2PSocketHost::GetStunPacketType( return false; } - uint32 cookie = base::NetToHost32(*reinterpret_cast<const uint32*>(data + 4)); + uint32_t cookie = + base::NetToHost32(*reinterpret_cast<const uint32_t*>(data + 4)); if (cookie != kStunMagicCookie) { return false; } - uint16 length = base::NetToHost16(*reinterpret_cast<const uint16*>(data + 2)); + uint16_t length = + base::NetToHost16(*reinterpret_cast<const uint16_t*>(data + 2)); if (length != data_size - kStunHeaderSize) { return false; } - int message_type = base::NetToHost16(*reinterpret_cast<const uint16*>(data)); + int message_type = + base::NetToHost16(*reinterpret_cast<const uint16_t*>(data)); // Verify that the type is known: switch (message_type) { @@ -633,7 +636,7 @@ void P2PSocketHost::DumpRtpPacket(const char* packet, return; } - scoped_ptr<uint8[]> header_buffer(new uint8[header_length]); + scoped_ptr<uint8_t[]> header_buffer(new uint8_t[header_length]); memcpy(header_buffer.get(), packet, header_length); // Posts to the IO thread as the data members should be accessed on the IO @@ -645,7 +648,7 @@ void P2PSocketHost::DumpRtpPacket(const char* packet, header_length, rtp_packet_length, incoming)); } -void P2PSocketHost::DumpRtpPacketOnIOThread(scoped_ptr<uint8[]> packet_header, +void P2PSocketHost::DumpRtpPacketOnIOThread(scoped_ptr<uint8_t[]> packet_header, size_t header_length, size_t packet_length, bool incoming) { @@ -672,14 +675,14 @@ void P2PSocketHost::IncrementTotalSentPackets() { send_packets_total_++; } -void P2PSocketHost::IncrementDelayedBytes(uint32 size) { +void P2PSocketHost::IncrementDelayedBytes(uint32_t size) { send_bytes_delayed_cur_ += size; if (send_bytes_delayed_cur_ > send_bytes_delayed_max_) { send_bytes_delayed_max_ = send_bytes_delayed_cur_; } } -void P2PSocketHost::DecrementDelayedBytes(uint32 size) { +void P2PSocketHost::DecrementDelayedBytes(uint32_t size) { send_bytes_delayed_cur_ -= size; DCHECK_GE(send_bytes_delayed_cur_, 0); } diff --git a/content/browser/renderer_host/p2p/socket_host.h b/content/browser/renderer_host/p2p/socket_host.h index b569a0a..37ffddb 100644 --- a/content/browser/renderer_host/p2p/socket_host.h +++ b/content/browser/renderer_host/p2p/socket_host.h @@ -5,6 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_ +#include <stddef.h> +#include <stdint.h> + +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/common/content_export.h" #include "content/common/p2p_socket_type.h" @@ -36,7 +40,7 @@ namespace packet_processing_helpers { CONTENT_EXPORT bool ApplyPacketOptions(char* data, size_t length, const rtc::PacketOptions& options, - uint32 abs_send_time); + uint32_t abs_send_time); // Helper method which finds RTP ofset and length if the packet is encapsulated // in a TURN Channel Message or TURN Send Indication message. @@ -50,7 +54,7 @@ CONTENT_EXPORT bool GetRtpPacketStartPositionAndLength( CONTENT_EXPORT bool UpdateRtpAbsSendTimeExtension(char* rtp, size_t length, int extension_id, - uint32 abs_send_time); + uint32_t abs_send_time); } // packet_processing_helpers @@ -75,7 +79,7 @@ class CONTENT_EXPORT P2PSocketHost { virtual void Send(const net::IPEndPoint& to, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) = 0; + uint64_t packet_id) = 0; virtual P2PSocketHost* AcceptIncomingTcpConnection( const net::IPEndPoint& remote_address, int id) = 0; @@ -142,7 +146,7 @@ class CONTENT_EXPORT P2PSocketHost { void DumpRtpPacket(const char* packet, size_t length, bool incoming); // A helper to dump the packet on the IO thread. - void DumpRtpPacketOnIOThread(scoped_ptr<uint8[]> packet_header, + void DumpRtpPacketOnIOThread(scoped_ptr<uint8_t[]> packet_header, size_t header_length, size_t packet_length, bool incoming); @@ -150,8 +154,8 @@ class CONTENT_EXPORT P2PSocketHost { // Used by subclasses to track the metrics of delayed bytes and packets. void IncrementDelayedPackets(); void IncrementTotalSentPackets(); - void IncrementDelayedBytes(uint32 size); - void DecrementDelayedBytes(uint32 size); + void IncrementDelayedBytes(uint32_t size); + void DecrementDelayedBytes(uint32_t size); IPC::Sender* message_sender_; int id_; @@ -165,13 +169,13 @@ class CONTENT_EXPORT P2PSocketHost { private: // Track total delayed packets for calculating how many packets are // delayed by system at the end of call. - uint32 send_packets_delayed_total_; - uint32 send_packets_total_; + uint32_t send_packets_delayed_total_; + uint32_t send_packets_total_; // Track the maximum of consecutive delayed bytes caused by system's // EWOULDBLOCK. - int32 send_bytes_delayed_max_; - int32 send_bytes_delayed_cur_; + int32_t send_bytes_delayed_max_; + int32_t send_bytes_delayed_cur_; base::WeakPtrFactory<P2PSocketHost> weak_ptr_factory_; diff --git a/content/browser/renderer_host/p2p/socket_host_tcp.cc b/content/browser/renderer_host/p2p/socket_host_tcp.cc index cb4d60d..3570847 100644 --- a/content/browser/renderer_host/p2p/socket_host_tcp.cc +++ b/content/browser/renderer_host/p2p/socket_host_tcp.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/p2p/socket_host_tcp.h" +#include <stddef.h> + #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/sys_byteorder.h" @@ -24,7 +26,7 @@ namespace { -typedef uint16 PacketLength; +typedef uint16_t PacketLength; const int kPacketHeaderSize = sizeof(PacketLength); const int kReadBufferSize = 4096; const int kPacketLengthOffset = 2; @@ -349,7 +351,7 @@ void P2PSocketHostTcpBase::OnPacket(const std::vector<char>& data) { void P2PSocketHostTcpBase::Send(const net::IPEndPoint& to, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) { + uint64_t packet_id) { if (!socket_) { // The Send message may be sent after the an OnError message was // sent by hasn't been processed the renderer. @@ -504,7 +506,7 @@ P2PSocketHostTcp::~P2PSocketHostTcp() { int P2PSocketHostTcp::ProcessInput(char* input, int input_len) { if (input_len < kPacketHeaderSize) return 0; - int packet_size = base::NetToHost16(*reinterpret_cast<uint16*>(input)); + int packet_size = base::NetToHost16(*reinterpret_cast<uint16_t*>(input)); if (input_len < packet_size + kPacketHeaderSize) return 0; @@ -522,7 +524,7 @@ void P2PSocketHostTcp::DoSend(const net::IPEndPoint& to, int size = kPacketHeaderSize + data.size(); scoped_refptr<net::DrainableIOBuffer> buffer = new net::DrainableIOBuffer(new net::IOBuffer(size), size); - *reinterpret_cast<uint16*>(buffer->data()) = base::HostToNet16(data.size()); + *reinterpret_cast<uint16_t*>(buffer->data()) = base::HostToNet16(data.size()); memcpy(buffer->data() + kPacketHeaderSize, &data[0], data.size()); packet_processing_helpers::ApplyPacketOptions( @@ -616,11 +618,12 @@ int P2PSocketHostStunTcp::GetExpectedPacketSize( const char* data, int len, int* pad_bytes) { DCHECK_LE(kTurnChannelDataHeaderSize, len); // Both stun and turn had length at offset 2. - int packet_size = base::NetToHost16(*reinterpret_cast<const uint16*>( - data + kPacketLengthOffset)); + int packet_size = base::NetToHost16( + *reinterpret_cast<const uint16_t*>(data + kPacketLengthOffset)); // Get packet type (STUN or TURN). - uint16 msg_type = base::NetToHost16(*reinterpret_cast<const uint16*>(data)); + uint16_t msg_type = + base::NetToHost16(*reinterpret_cast<const uint16_t*>(data)); *pad_bytes = 0; // Add heder length to packet length. diff --git a/content/browser/renderer_host/p2p/socket_host_tcp.h b/content/browser/renderer_host/p2p/socket_host_tcp.h index 4c2bb31..fb4b995 100644 --- a/content/browser/renderer_host/p2p/socket_host_tcp.h +++ b/content/browser/renderer_host/p2p/socket_host_tcp.h @@ -5,10 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_TCP_H_ #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_TCP_H_ +#include <stdint.h> + #include <queue> #include <vector> #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" @@ -43,7 +46,7 @@ class CONTENT_EXPORT P2PSocketHostTcpBase : public P2PSocketHost { void Send(const net::IPEndPoint& to, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) override; + uint64_t packet_id) override; P2PSocketHost* AcceptIncomingTcpConnection( const net::IPEndPoint& remote_address, int id) override; diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_server.cc b/content/browser/renderer_host/p2p/socket_host_tcp_server.cc index 0976b22..dc49bfd 100644 --- a/content/browser/renderer_host/p2p/socket_host_tcp_server.cc +++ b/content/browser/renderer_host/p2p/socket_host_tcp_server.cc @@ -120,7 +120,7 @@ void P2PSocketHostTcpServer::OnAccepted(int result) { void P2PSocketHostTcpServer::Send(const net::IPEndPoint& to, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) { + uint64_t packet_id) { NOTREACHED(); OnError(); } diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_server.h b/content/browser/renderer_host/p2p/socket_host_tcp_server.h index df20532..c709177 100644 --- a/content/browser/renderer_host/p2p/socket_host_tcp_server.h +++ b/content/browser/renderer_host/p2p/socket_host_tcp_server.h @@ -5,10 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_TCP_SERVER_H_ #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_TCP_SERVER_H_ +#include <stdint.h> + #include <map> #include <vector> #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" #include "content/browser/renderer_host/p2p/socket_host.h" @@ -39,7 +42,7 @@ class CONTENT_EXPORT P2PSocketHostTcpServer : public P2PSocketHost { void Send(const net::IPEndPoint& to, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) override; + uint64_t packet_id) override; P2PSocketHost* AcceptIncomingTcpConnection( const net::IPEndPoint& remote_address, int id) override; diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc b/content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc index 64b420b..e11c0c0 100644 --- a/content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc +++ b/content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/p2p/socket_host_tcp_server.h" +#include <stdint.h> + #include <list> #include "content/browser/renderer_host/p2p/socket_host_tcp.h" @@ -95,8 +97,9 @@ class P2PSocketHostTcpServerTest : public testing::Test { new P2PSocketHostTcpServer(&sender_, 0, P2P_SOCKET_TCP_CLIENT)); socket_host_->socket_.reset(socket_); - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSocketCreated::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSocketCreated::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); P2PHostAndIPEndPoint dest; diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc b/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc index cd5a909..59aa336 100644 --- a/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc +++ b/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc @@ -4,8 +4,12 @@ #include "content/browser/renderer_host/p2p/socket_host_tcp.h" +#include <stddef.h> +#include <stdint.h> + #include <deque> +#include "base/macros.h" #include "base/sys_byteorder.h" #include "content/browser/renderer_host/p2p/socket_host_test_utils.h" #include "net/socket/stream_socket.h" @@ -26,8 +30,9 @@ class P2PSocketHostTcpTestBase : public testing::Test { } void SetUp() override { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSocketCreated::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSocketCreated::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); if (socket_type_ == P2P_SOCKET_TCP_CLIENT) { @@ -53,7 +58,7 @@ class P2PSocketHostTcpTestBase : public testing::Test { std::string IntToSize(int size) { std::string result; - uint16 size16 = base::HostToNet16(size); + uint16_t size16 = base::HostToNet16(size); result.resize(sizeof(size16)); memcpy(&result[0], &size16, sizeof(size16)); return result; @@ -84,8 +89,9 @@ class P2PSocketHostStunTcpTest : public P2PSocketHostTcpTestBase { // Verify that we can send STUN message and that they are formatted // properly. TEST_F(P2PSocketHostTcpTest, SendStunNoAuth) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(3) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); @@ -116,8 +122,9 @@ TEST_F(P2PSocketHostTcpTest, SendStunNoAuth) { // Verify that we can receive STUN messages from the socket, and that // the messages are parsed properly. TEST_F(P2PSocketHostTcpTest, ReceiveStun) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(3) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); @@ -164,8 +171,8 @@ TEST_F(P2PSocketHostTcpTest, ReceiveStun) { // Verify that we can't send data before we've received STUN response // from the other side. TEST_F(P2PSocketHostTcpTest, SendDataNoAuth) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnError::ID)))) + EXPECT_CALL(sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnError::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); rtc::PacketOptions options; @@ -187,8 +194,9 @@ TEST_F(P2PSocketHostTcpTest, SendAfterStunRequest) { received_data.append(IntToSize(request_packet.size())); received_data.append(request_packet.begin(), request_packet.end()); - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); EXPECT_CALL(sender_, Send(MatchPacketMessage(request_packet))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); @@ -213,8 +221,9 @@ TEST_F(P2PSocketHostTcpTest, AsyncWrites) { socket_->set_async_write(true); - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(2) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); @@ -247,8 +256,9 @@ TEST_F(P2PSocketHostTcpTest, SendDataWithPacketOptions) { received_data.append(IntToSize(request_packet.size())); received_data.append(request_packet.begin(), request_packet.end()); - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); EXPECT_CALL(sender_, Send(MatchPacketMessage(request_packet))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); @@ -260,7 +270,7 @@ TEST_F(P2PSocketHostTcpTest, SendDataWithPacketOptions) { std::vector<char> packet; CreateRandomPacket(&packet); // Make it a RTP packet. - *reinterpret_cast<uint16*>(&*packet.begin()) = base::HostToNet16(0x8000); + *reinterpret_cast<uint16_t*>(&*packet.begin()) = base::HostToNet16(0x8000); socket_host_->Send(dest_.ip_address, packet, options, 0); std::string expected_data; @@ -273,8 +283,9 @@ TEST_F(P2PSocketHostTcpTest, SendDataWithPacketOptions) { // Verify that we can send STUN message and that they are formatted // properly. TEST_F(P2PSocketHostStunTcpTest, SendStunNoAuth) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(3) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); @@ -302,8 +313,9 @@ TEST_F(P2PSocketHostStunTcpTest, SendStunNoAuth) { // Verify that we can receive STUN messages from the socket, and that // the messages are parsed properly. TEST_F(P2PSocketHostStunTcpTest, ReceiveStun) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(3) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); @@ -347,8 +359,8 @@ TEST_F(P2PSocketHostStunTcpTest, ReceiveStun) { // Verify that we can't send data before we've received STUN response // from the other side. TEST_F(P2PSocketHostStunTcpTest, SendDataNoAuth) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnError::ID)))) + EXPECT_CALL(sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnError::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); rtc::PacketOptions options; @@ -365,8 +377,9 @@ TEST_F(P2PSocketHostStunTcpTest, AsyncWrites) { socket_->set_async_write(true); - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(2) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); diff --git a/content/browser/renderer_host/p2p/socket_host_test_utils.cc b/content/browser/renderer_host/p2p/socket_host_test_utils.cc index 1f56903..dce2bd6 100644 --- a/content/browser/renderer_host/p2p/socket_host_test_utils.cc +++ b/content/browser/renderer_host/p2p/socket_host_test_utils.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/p2p/socket_host_test_utils.h" +#include <stddef.h> + #include "base/logging.h" #include "base/sys_byteorder.h" #include "base/thread_task_runner_handle.h" @@ -11,10 +13,10 @@ #include "net/base/io_buffer.h" const int kStunHeaderSize = 20; -const uint16 kStunBindingRequest = 0x0001; -const uint16 kStunBindingResponse = 0x0102; -const uint16 kStunBindingError = 0x0111; -const uint32 kStunMagicCookie = 0x2112A442; +const uint16_t kStunBindingRequest = 0x0001; +const uint16_t kStunBindingResponse = 0x0102; +const uint16_t kStunBindingError = 0x0111; +const uint32_t kStunMagicCookie = 0x2112A442; MockIPCSender::MockIPCSender() { } MockIPCSender::~MockIPCSender() { } @@ -104,12 +106,12 @@ void FakeSocket::DoAsyncWrite(scoped_refptr<net::IOBuffer> buf, int buf_len, callback.Run(buf_len); } -int FakeSocket::SetReceiveBufferSize(int32 size) { +int FakeSocket::SetReceiveBufferSize(int32_t size) { NOTIMPLEMENTED(); return net::ERR_NOT_IMPLEMENTED; } -int FakeSocket::SetSendBufferSize(int32 size) { +int FakeSocket::SetSendBufferSize(int32_t size) { NOTIMPLEMENTED(); return net::ERR_NOT_IMPLEMENTED; } @@ -193,12 +195,12 @@ void CreateRandomPacket(std::vector<char>* packet) { (*packet)[0] = (*packet)[0] | 0x80; } -static void CreateStunPacket(std::vector<char>* packet, uint16 type) { +static void CreateStunPacket(std::vector<char>* packet, uint16_t type) { CreateRandomPacket(packet); - *reinterpret_cast<uint16*>(&*packet->begin()) = base::HostToNet16(type); - *reinterpret_cast<uint16*>(&*packet->begin() + 2) = + *reinterpret_cast<uint16_t*>(&*packet->begin()) = base::HostToNet16(type); + *reinterpret_cast<uint16_t*>(&*packet->begin() + 2) = base::HostToNet16(packet->size() - kStunHeaderSize); - *reinterpret_cast<uint32*>(&*packet->begin() + 4) = + *reinterpret_cast<uint32_t*>(&*packet->begin() + 4) = base::HostToNet32(kStunMagicCookie); } @@ -214,7 +216,7 @@ void CreateStunError(std::vector<char>* packet) { CreateStunPacket(packet, kStunBindingError); } -net::IPEndPoint ParseAddress(const std::string& ip_str, uint16 port) { +net::IPEndPoint ParseAddress(const std::string& ip_str, uint16_t port) { net::IPAddressNumber ip; EXPECT_TRUE(net::ParseIPLiteralToNumber(ip_str, &ip)); return net::IPEndPoint(ip, port); diff --git a/content/browser/renderer_host/p2p/socket_host_test_utils.h b/content/browser/renderer_host/p2p/socket_host_test_utils.h index 497b672..77a8319 100644 --- a/content/browser/renderer_host/p2p/socket_host_test_utils.h +++ b/content/browser/renderer_host/p2p/socket_host_test_utils.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_TEST_UTILS_H_ #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_TEST_UTILS_H_ +#include <stdint.h> + #include <vector> #include "content/common/p2p_messages.h" @@ -16,9 +18,9 @@ const char kTestLocalIpAddress[] = "123.44.22.4"; const char kTestIpAddress1[] = "123.44.22.31"; -const uint16 kTestPort1 = 234; +const uint16_t kTestPort1 = 234; const char kTestIpAddress2[] = "133.11.22.33"; -const uint16 kTestPort2 = 543; +const uint16_t kTestPort2 = 543; class MockIPCSender : public IPC::Sender { public: @@ -47,8 +49,8 @@ class FakeSocket : public net::StreamSocket { int Write(net::IOBuffer* buf, int buf_len, const net::CompletionCallback& callback) override; - int SetReceiveBufferSize(int32 size) override; - int SetSendBufferSize(int32 size) override; + int SetReceiveBufferSize(int32_t size) override; + int SetSendBufferSize(int32_t size) override; int Connect(const net::CompletionCallback& callback) override; void Disconnect() override; bool IsConnected() const override; @@ -96,7 +98,7 @@ void CreateStunRequest(std::vector<char>* packet); void CreateStunResponse(std::vector<char>* packet); void CreateStunError(std::vector<char>* packet); -net::IPEndPoint ParseAddress(const std::string& ip_str, uint16 port); +net::IPEndPoint ParseAddress(const std::string& ip_str, uint16_t port); MATCHER_P(MatchMessage, type, "") { return arg->type() == type; diff --git a/content/browser/renderer_host/p2p/socket_host_throttler.h b/content/browser/renderer_host/p2p/socket_host_throttler.h index a28a588..0ab1e9db 100644 --- a/content/browser/renderer_host/p2p/socket_host_throttler.h +++ b/content/browser/renderer_host/p2p/socket_host_throttler.h @@ -5,6 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_THROTTLER_H_ #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_THROTTLER_H_ +#include <stddef.h> + +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/p2p/socket_host_udp.cc b/content/browser/renderer_host/p2p/socket_host_udp.cc index a40c451..0dbfcec 100644 --- a/content/browser/renderer_host/p2p/socket_host_udp.cc +++ b/content/browser/renderer_host/p2p/socket_host_udp.cc @@ -10,6 +10,7 @@ #include "base/stl_util.h" #include "base/strings/string_number_conversions.h" #include "base/trace_event/trace_event.h" +#include "build/build_config.h" #include "content/browser/renderer_host/p2p/socket_host_throttler.h" #include "content/common/p2p_messages.h" #include "content/public/browser/content_browser_client.h" @@ -75,7 +76,7 @@ P2PSocketHostUdp::PendingPacket::PendingPacket( const net::IPEndPoint& to, const std::vector<char>& content, const rtc::PacketOptions& options, - uint64 id) + uint64_t id) : to(to), data(new net::IOBuffer(content.size())), size(content.size()), @@ -233,7 +234,7 @@ void P2PSocketHostUdp::HandleReadResult(int result) { void P2PSocketHostUdp::Send(const net::IPEndPoint& to, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) { + uint64_t packet_id) { if (!socket_) { // The Send message may be sent after the an OnError message was // sent by hasn't been processed the renderer. diff --git a/content/browser/renderer_host/p2p/socket_host_udp.h b/content/browser/renderer_host/p2p/socket_host_udp.h index fff23a5..93fb633 100644 --- a/content/browser/renderer_host/p2p/socket_host_udp.h +++ b/content/browser/renderer_host/p2p/socket_host_udp.h @@ -5,11 +5,15 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_UDP_H_ #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_UDP_H_ +#include <stddef.h> +#include <stdint.h> + #include <deque> #include <set> #include <vector> #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" @@ -38,7 +42,7 @@ class CONTENT_EXPORT P2PSocketHostUdp : public P2PSocketHost { void Send(const net::IPEndPoint& to, const std::vector<char>& data, const rtc::PacketOptions& options, - uint64 packet_id) override; + uint64_t packet_id) override; P2PSocketHost* AcceptIncomingTcpConnection( const net::IPEndPoint& remote_address, int id) override; @@ -53,13 +57,13 @@ class CONTENT_EXPORT P2PSocketHostUdp : public P2PSocketHost { PendingPacket(const net::IPEndPoint& to, const std::vector<char>& content, const rtc::PacketOptions& options, - uint64 id); + uint64_t id); ~PendingPacket(); net::IPEndPoint to; scoped_refptr<net::IOBuffer> data; int size; rtc::PacketOptions packet_options; - uint64 id; + uint64_t id; }; void OnError(); diff --git a/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc b/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc index 5d67a24..7258eaf 100644 --- a/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc +++ b/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/p2p/socket_host_udp.h" +#include <stdint.h> + #include <deque> #include <vector> @@ -95,9 +97,9 @@ class FakeDatagramServerSocket : public net::DatagramServerSocket { return buf_len; } - int SetReceiveBufferSize(int32 size) override { return net::OK; } + int SetReceiveBufferSize(int32_t size) override { return net::OK; } - int SetSendBufferSize(int32 size) override { return net::OK; } + int SetSendBufferSize(int32_t size) override { return net::OK; } void ReceivePacket(const net::IPEndPoint& address, std::vector<char> data) { if (!recv_callback_.is_null()) { @@ -129,7 +131,7 @@ class FakeDatagramServerSocket : public net::DatagramServerSocket { return net::ERR_NOT_IMPLEMENTED; } - int SetMulticastInterface(uint32 interface_index) override { + int SetMulticastInterface(uint32_t interface_index) override { NOTIMPLEMENTED(); return net::ERR_NOT_IMPLEMENTED; } @@ -170,8 +172,9 @@ namespace content { class P2PSocketHostUdpTest : public testing::Test { protected: void SetUp() override { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSocketCreated::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSocketCreated::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); socket_host_.reset(new P2PSocketHostUdp(&sender_, 0, &throttler_)); @@ -203,8 +206,9 @@ class P2PSocketHostUdpTest : public testing::Test { // Verify that we can send STUN messages before we receive anything // from the other side. TEST_F(P2PSocketHostUdpTest, SendStunNoAuth) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(3) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); @@ -230,8 +234,8 @@ TEST_F(P2PSocketHostUdpTest, SendStunNoAuth) { // Verify that no data packets can be sent before STUN binding has // finished. TEST_F(P2PSocketHostUdpTest, SendDataNoAuth) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnError::ID)))) + EXPECT_CALL(sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnError::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); rtc::PacketOptions options; @@ -254,8 +258,9 @@ TEST_F(P2PSocketHostUdpTest, SendAfterStunRequest) { socket_->ReceivePacket(dest1_, request_packet); // Now we should be able to send any data to |dest1_|. - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); rtc::PacketOptions options; @@ -279,8 +284,9 @@ TEST_F(P2PSocketHostUdpTest, SendAfterStunResponse) { socket_->ReceivePacket(dest1_, request_packet); // Now we should be able to send any data to |dest1_|. - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); rtc::PacketOptions options; @@ -307,8 +313,8 @@ TEST_F(P2PSocketHostUdpTest, SendAfterStunResponseDifferentHost) { rtc::PacketOptions options; std::vector<char> packet; CreateRandomPacket(&packet); - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnError::ID)))) + EXPECT_CALL(sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnError::ID)))) .WillOnce(DoAll(DeleteArg<0>(), Return(true))); socket_host_->Send(dest2_, packet, options, 0); } @@ -316,8 +322,9 @@ TEST_F(P2PSocketHostUdpTest, SendAfterStunResponseDifferentHost) { // Verify throttler not allowing unlimited sending of ICE messages to // any destination. TEST_F(P2PSocketHostUdpTest, ThrottleAfterLimit) { - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(2) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); @@ -345,8 +352,9 @@ TEST_F(P2PSocketHostUdpTest, ThrottleAfterLimitAfterReceive) { .WillOnce(DoAll(DeleteArg<0>(), Return(true))); socket_->ReceivePacket(dest1_, request_packet); - EXPECT_CALL(sender_, Send( - MatchMessage(static_cast<uint32>(P2PMsg_OnSendComplete::ID)))) + EXPECT_CALL( + sender_, + Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID)))) .Times(4) .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true))); diff --git a/content/browser/renderer_host/p2p/socket_host_unittest.cc b/content/browser/renderer_host/p2p/socket_host_unittest.cc index 7e9393f..c92e9d7 100644 --- a/content/browser/renderer_host/p2p/socket_host_unittest.cc +++ b/content/browser/renderer_host/p2p/socket_host_unittest.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/p2p/socket_host.h" +#include <stddef.h> + #include <vector> #include "base/memory/scoped_ptr.h" diff --git a/content/browser/renderer_host/pepper/browser_ppapi_host_impl.h b/content/browser/renderer_host/pepper/browser_ppapi_host_impl.h index d851434..dd112390 100644 --- a/content/browser/renderer_host/pepper/browser_ppapi_host_impl.h +++ b/content/browser/renderer_host/pepper/browser_ppapi_host_impl.h @@ -8,10 +8,10 @@ #include <map> #include <string> -#include "base/basictypes.h" #include "base/compiler_specific.h" #include "base/containers/scoped_ptr_hash_map.h" #include "base/files/file_path.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/weak_ptr.h" #include "base/observer_list.h" diff --git a/content/browser/renderer_host/pepper/browser_ppapi_host_test.h b/content/browser/renderer_host/pepper/browser_ppapi_host_test.h index 3f375ee..b7ca9d4 100644 --- a/content/browser/renderer_host/pepper/browser_ppapi_host_test.h +++ b/content/browser/renderer_host/pepper/browser_ppapi_host_test.h @@ -5,7 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_BROWSER_PPAPI_HOST_TEST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_BROWSER_PPAPI_HOST_TEST_H_ -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/public/browser/browser_ppapi_host.h" #include "ppapi/proxy/resource_message_test_sink.h" diff --git a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc index f52a201..79f7f56 100644 --- a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc +++ b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h" +#include <stddef.h> + #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" #include "content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.h" #include "content/browser/renderer_host/pepper/pepper_file_io_host.h" diff --git a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h index dffa7fe..c8e98fa 100644 --- a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h +++ b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h @@ -6,6 +6,7 @@ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_CONTENT_BROWSER_PEPPER_HOST_FACTORY_H_ #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "net/socket/tcp_socket.h" diff --git a/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.cc b/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.cc index e2c909c..5a4db23 100644 --- a/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.cc +++ b/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.cc @@ -4,6 +4,10 @@ #include "content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.h" +#include <stddef.h> +#include <stdint.h> + +#include "base/macros.h" #include "base/threading/sequenced_worker_pool.h" #include "base/values.h" #include "content/common/font_list.h" diff --git a/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.h b/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.h index 643be70..b438e00 100644 --- a/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.h +++ b/content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.h @@ -5,7 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_BROWSER_FONT_SINGLETON_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_BROWSER_FONT_SINGLETON_HOST_H_ -#include "base/basictypes.h" +#include "base/macros.h" #include "ppapi/host/resource_host.h" namespace content { diff --git a/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.h b/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.h index f3c3c94..2a95284 100644 --- a/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.h +++ b/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.h @@ -5,10 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_EXTERNAL_FILE_REF_BACKEND_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_EXTERNAL_FILE_REF_BACKEND_H_ +#include <stdint.h> + #include <string> #include "base/files/file.h" #include "base/files/file_path.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/task_runner.h" #include "content/browser/renderer_host/pepper/pepper_file_ref_host.h" diff --git a/content/browser/renderer_host/pepper/pepper_file_io_host.h b/content/browser/renderer_host/pepper/pepper_file_io_host.h index bae9a54..90de1da 100644 --- a/content/browser/renderer_host/pepper/pepper_file_io_host.h +++ b/content/browser/renderer_host/pepper/pepper_file_io_host.h @@ -5,12 +5,14 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FILE_IO_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FILE_IO_HOST_H_ +#include <stdint.h> + #include <string> -#include "base/basictypes.h" #include "base/callback_forward.h" #include "base/files/file.h" #include "base/files/file_proxy.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" #include "ipc/ipc_listener.h" diff --git a/content/browser/renderer_host/pepper/pepper_file_ref_host.h b/content/browser/renderer_host/pepper/pepper_file_ref_host.h index 5f6d11e..cd8f67b 100644 --- a/content/browser/renderer_host/pepper/pepper_file_ref_host.h +++ b/content/browser/renderer_host/pepper/pepper_file_ref_host.h @@ -5,8 +5,11 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FILE_REF_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FILE_REF_HOST_H_ +#include <stdint.h> + #include <string> +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/public/browser/browser_ppapi_host.h" #include "ppapi/c/pp_file_info.h" diff --git a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc index bdb2514..70e29a7 100644 --- a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc +++ b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc @@ -233,7 +233,7 @@ void PepperFileSystemBrowserHost::OpenFileSystemComplete( const GURL& root, const std::string& /* unused */, base::File::Error error) { - int32 pp_error = ppapi::FileErrorToPepperError(error); + int32_t pp_error = ppapi::FileErrorToPepperError(error); if (pp_error == PP_OK) { opened_ = true; root_url_ = root; @@ -319,7 +319,7 @@ void PepperFileSystemBrowserHost::OpenPluginPrivateFileSystemComplete( ppapi::host::ReplyMessageContext reply_context, const std::string& fsid, base::File::Error error) { - int32 pp_error = ppapi::FileErrorToPepperError(error); + int32_t pp_error = ppapi::FileErrorToPepperError(error); if (pp_error == PP_OK) opened_ = true; SendReplyForIsolatedFileSystem(reply_context, fsid, pp_error); diff --git a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.h b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.h index 669adde..bf56a1a 100644 --- a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.h +++ b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.h @@ -5,12 +5,14 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FILE_SYSTEM_BROWSER_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FILE_SYSTEM_BROWSER_HOST_H_ +#include <stdint.h> + #include <queue> #include <string> #include <vector> -#include "base/basictypes.h" #include "base/callback.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/browser/renderer_host/pepper/quota_reservation.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc b/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc index ccc9c61..bbc5a14 100644 --- a/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc +++ b/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc @@ -6,7 +6,7 @@ #include <string> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_test.h" #include "ppapi/c/pp_instance.h" diff --git a/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h b/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h index fa6bb6f..a488a55 100644 --- a/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h +++ b/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h @@ -5,9 +5,12 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FLASH_FILE_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_FLASH_FILE_MESSAGE_FILTER_H_ +#include <stdint.h> + #include "base/callback_forward.h" #include "base/compiler_specific.h" #include "base/files/file_path.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/process/process.h" #include "ppapi/c/pp_instance.h" diff --git a/content/browser/renderer_host/pepper/pepper_gamepad_host.h b/content/browser/renderer_host/pepper/pepper_gamepad_host.h index 8d6ee73..963f790 100644 --- a/content/browser/renderer_host/pepper/pepper_gamepad_host.h +++ b/content/browser/renderer_host/pepper/pepper_gamepad_host.h @@ -5,7 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_GAMEPAD_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_GAMEPAD_HOST_H_ +#include <stdint.h> + #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/browser/gamepad/gamepad_consumer.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc index ca94c7f..a325e7a 100644 --- a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc +++ b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc @@ -2,10 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> #include <string.h> +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" +#include "build/build_config.h" #include "content/browser/gamepad/gamepad_test_helpers.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_test.h" #include "content/browser/renderer_host/pepper/pepper_gamepad_host.h" diff --git a/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc b/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc index 3789ffa..c841981 100644 --- a/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc +++ b/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h" +#include <stddef.h> + #include "base/logging.h" #include "base/memory/scoped_ptr.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" diff --git a/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h b/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h index a532184..42f7569 100644 --- a/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h +++ b/content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h @@ -5,11 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_HOST_RESOLVER_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_HOST_RESOLVER_MESSAGE_FILTER_H_ +#include <stdint.h> + #include <string> #include <vector> -#include "base/basictypes.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "content/common/content_export.h" #include "content/public/common/process_type.h" #include "ppapi/c/pp_instance.h" diff --git a/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.h b/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.h index e210763..95734fe 100644 --- a/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.h +++ b/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.h @@ -5,8 +5,11 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_INTERNAL_FILE_REF_BACKEND_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_INTERNAL_FILE_REF_BACKEND_H_ +#include <stdint.h> + #include <string> +#include "base/macros.h" #include "content/browser/renderer_host/pepper/pepper_file_ref_host.h" #include "ppapi/c/pp_instance.h" #include "ppapi/c/pp_resource.h" diff --git a/content/browser/renderer_host/pepper/pepper_lookup_request.h b/content/browser/renderer_host/pepper/pepper_lookup_request.h index b36bd5e..ecbf646 100644 --- a/content/browser/renderer_host/pepper/pepper_lookup_request.h +++ b/content/browser/renderer_host/pepper/pepper_lookup_request.h @@ -6,6 +6,7 @@ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_LOOKUP_REQUEST_H_ #include "base/callback.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "net/base/address_list.h" #include "net/base/net_errors.h" diff --git a/content/browser/renderer_host/pepper/pepper_message_filter.h b/content/browser/renderer_host/pepper/pepper_message_filter.h index 02a89ad..04cd120 100644 --- a/content/browser/renderer_host/pepper/pepper_message_filter.h +++ b/content/browser/renderer_host/pepper/pepper_message_filter.h @@ -7,8 +7,8 @@ #include <vector> -#include "base/basictypes.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/public/browser/browser_message_filter.h" diff --git a/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc b/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc index bc5795b..d14603a 100644 --- a/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc +++ b/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/pepper/pepper_network_monitor_host.h" +#include <stddef.h> + #include "base/task_runner_util.h" #include "base/threading/sequenced_worker_pool.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" diff --git a/content/browser/renderer_host/pepper/pepper_network_monitor_host.h b/content/browser/renderer_host/pepper/pepper_network_monitor_host.h index 2225a93..ef1b305 100644 --- a/content/browser/renderer_host/pepper/pepper_network_monitor_host.h +++ b/content/browser/renderer_host/pepper/pepper_network_monitor_host.h @@ -6,6 +6,7 @@ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_NETWORK_MONITOR_HOST_H_ #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/common/content_export.h" #include "net/base/network_change_notifier.h" diff --git a/content/browser/renderer_host/pepper/pepper_network_proxy_host.h b/content/browser/renderer_host/pepper/pepper_network_proxy_host.h index eddbc89..0992c9f 100644 --- a/content/browser/renderer_host/pepper/pepper_network_proxy_host.h +++ b/content/browser/renderer_host/pepper/pepper_network_proxy_host.h @@ -5,10 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_NETWORK_PROXY_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_NETWORK_PROXY_HOST_H_ +#include <stdint.h> + #include <queue> #include <string> #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/common/content_export.h" #include "net/proxy/proxy_service.h" diff --git a/content/browser/renderer_host/pepper/pepper_print_settings_manager.h b/content/browser/renderer_host/pepper/pepper_print_settings_manager.h index 9199e72..8c53ede 100644 --- a/content/browser/renderer_host/pepper/pepper_print_settings_manager.h +++ b/content/browser/renderer_host/pepper/pepper_print_settings_manager.h @@ -5,8 +5,11 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_PRINT_SETTINGS_MANAGER_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_PRINT_SETTINGS_MANAGER_H_ +#include <stdint.h> + #include "base/bind.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "content/common/content_export.h" #include "ppapi/c/dev/pp_print_settings_dev.h" diff --git a/content/browser/renderer_host/pepper/pepper_printing_host.h b/content/browser/renderer_host/pepper/pepper_printing_host.h index fb2536d..fc022f1 100644 --- a/content/browser/renderer_host/pepper/pepper_printing_host.h +++ b/content/browser/renderer_host/pepper/pepper_printing_host.h @@ -5,7 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_PRINTING_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_PRINTING_HOST_H_ +#include <stdint.h> + #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "content/browser/renderer_host/pepper/pepper_print_settings_manager.h" diff --git a/content/browser/renderer_host/pepper/pepper_printing_host_unittest.cc b/content/browser/renderer_host/pepper/pepper_printing_host_unittest.cc index e61f75f..7bc8af9 100644 --- a/content/browser/renderer_host/pepper/pepper_printing_host_unittest.cc +++ b/content/browser/renderer_host/pepper/pepper_printing_host_unittest.cc @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + +#include "base/macros.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_test.h" #include "content/browser/renderer_host/pepper/pepper_print_settings_manager.h" #include "content/browser/renderer_host/pepper/pepper_printing_host.h" @@ -86,7 +89,7 @@ TEST_F(PepperPrintingHostTest, GetDefaultPrintSettings) { // Simulate a message being received. ppapi::proxy::ResourceMessageCallParams call_params(pp_resource, 1); ppapi::host::HostMessageContext context(call_params); - int32 result = printing.OnResourceMessageReceived( + int32_t result = printing.OnResourceMessageReceived( PpapiHostMsg_Printing_GetDefaultPrintSettings(), &context); EXPECT_EQ(PP_OK_COMPLETIONPENDING, result); diff --git a/content/browser/renderer_host/pepper/pepper_renderer_connection.cc b/content/browser/renderer_host/pepper/pepper_renderer_connection.cc index 1e03a84..bbce590 100644 --- a/content/browser/renderer_host/pepper/pepper_renderer_connection.cc +++ b/content/browser/renderer_host/pepper/pepper_renderer_connection.cc @@ -4,15 +4,19 @@ #include "content/browser/renderer_host/pepper/pepper_renderer_connection.h" +#include <stddef.h> +#include <stdint.h> + #include "base/bind.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "content/browser/browser_child_process_host_impl.h" #include "content/browser/ppapi_plugin_process_host.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" -#include "content/common/frame_messages.h" -#include "content/common/pepper_renderer_instance_data.h" #include "content/browser/renderer_host/pepper/pepper_file_ref_host.h" #include "content/browser/renderer_host/pepper/pepper_file_system_browser_host.h" +#include "content/common/frame_messages.h" +#include "content/common/pepper_renderer_instance_data.h" #include "content/public/browser/content_browser_client.h" #include "content/public/common/content_client.h" #include "ipc/ipc_message_macros.h" @@ -25,9 +29,8 @@ namespace content { namespace { -const uint32 kFilteredMessageClasses[] = { - PpapiMsgStart, - FrameMsgStart, +const uint32_t kFilteredMessageClasses[] = { + PpapiMsgStart, FrameMsgStart, }; // Responsible for creating the pending resource hosts, holding their IDs until diff --git a/content/browser/renderer_host/pepper/pepper_renderer_connection.h b/content/browser/renderer_host/pepper/pepper_renderer_connection.h index 109da1f..37c5a07 100644 --- a/content/browser/renderer_host/pepper/pepper_renderer_connection.h +++ b/content/browser/renderer_host/pepper/pepper_renderer_connection.h @@ -7,8 +7,8 @@ #include <vector> -#include "base/basictypes.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "content/public/browser/browser_message_filter.h" #include "ppapi/c/pp_instance.h" diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.cc b/content/browser/renderer_host/pepper/pepper_socket_utils.cc index 4b70ded..c421fe2 100644 --- a/content/browser/renderer_host/pepper/pepper_socket_utils.cc +++ b/content/browser/renderer_host/pepper/pepper_socket_utils.cc @@ -10,6 +10,7 @@ #include "base/logging.h" #include "base/memory/ref_counted.h" #include "base/strings/string_util.h" +#include "build/build_config.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/content_browser_client.h" #include "content/public/browser/render_frame_host.h" @@ -33,7 +34,7 @@ SocketPermissionRequest CreateSocketPermissionRequest( const PP_NetAddress_Private& net_addr) { std::string host = ppapi::NetAddressPrivateImpl::DescribeNetAddress(net_addr, false); - uint16 port = 0; + uint16_t port = 0; std::vector<unsigned char> address; ppapi::NetAddressPrivateImpl::NetAddressToIPEndPoint( net_addr, &address, &port); diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.h b/content/browser/renderer_host/pepper/pepper_socket_utils.h index 6061cc3..ce33b02 100644 --- a/content/browser/renderer_host/pepper/pepper_socket_utils.h +++ b/content/browser/renderer_host/pepper/pepper_socket_utils.h @@ -5,6 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_SOCKET_UTILS_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_SOCKET_UTILS_H_ +#include "build/build_config.h" #include "content/public/common/socket_permission_request.h" #include "ppapi/c/pp_stdint.h" diff --git a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc index 93e1804..34db559 100644 --- a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc +++ b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc @@ -7,6 +7,7 @@ #include "base/bind.h" #include "base/bind_helpers.h" #include "base/logging.h" +#include "build/build_config.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" #include "content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h" #include "content/browser/renderer_host/pepper/pepper_socket_utils.h" @@ -170,7 +171,7 @@ void PepperTCPServerSocketMessageFilter::DoListen( DCHECK_CURRENTLY_ON(BrowserThread::IO); net::IPAddressNumber address; - uint16 port; + uint16_t port; if (state_ != STATE_BEFORE_LISTENING || !NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &address, &port)) { SendListenError(context, PP_ERROR_FAILED); diff --git a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.h b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.h index eded1be..f633ccb 100644 --- a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.h +++ b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.h @@ -5,10 +5,14 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TCP_SERVER_SOCKET_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TCP_SERVER_SOCKET_MESSAGE_FILTER_H_ -#include "base/basictypes.h" +#include <stddef.h> +#include <stdint.h> + #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" +#include "build/build_config.h" #include "content/common/content_export.h" #include "net/base/ip_endpoint.h" #include "net/socket/tcp_socket.h" diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc index 7f98861..0fcbc10 100644 --- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc +++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc @@ -575,7 +575,7 @@ void PepperTCPSocketMessageFilter::DoBind( int pp_result = PP_OK; do { net::IPAddressNumber address; - uint16 port; + uint16_t port; if (!NetAddressPrivateImpl::NetAddressToIPEndPoint( net_addr, &address, &port)) { pp_result = PP_ERROR_ADDRESS_INVALID; @@ -665,7 +665,7 @@ void PepperTCPSocketMessageFilter::DoConnectWithNetAddress( state_.SetPendingTransition(TCPSocketState::CONNECT); net::IPAddressNumber address; - uint16 port; + uint16_t port; if (!NetAddressPrivateImpl::NetAddressToIPEndPoint( net_addr, &address, &port)) { state_.CompletePendingTransition(false); diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h index 51443eb..8fe42c1 100644 --- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h +++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h @@ -5,13 +5,17 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TCP_SOCKET_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TCP_SOCKET_MESSAGE_FILTER_H_ +#include <stddef.h> +#include <stdint.h> + #include <string> #include <vector> -#include "base/basictypes.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" +#include "build/build_config.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" #include "content/browser/renderer_host/pepper/ssl_context_helper.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font.h b/content/browser/renderer_host/pepper/pepper_truetype_font.h index f26b9bd..63ed2c6 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font.h +++ b/content/browser/renderer_host/pepper/pepper_truetype_font.h @@ -5,6 +5,8 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TRUETYPE_FONT_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TRUETYPE_FONT_H_ +#include <stdint.h> + #include <string> #include <vector> diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_host.h b/content/browser/renderer_host/pepper/pepper_truetype_font_host.h index b449547..f574c31 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font_host.h +++ b/content/browser/renderer_host/pepper/pepper_truetype_font_host.h @@ -5,10 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TRUETYPE_FONT_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TRUETYPE_FONT_HOST_H_ +#include <stdint.h> + #include <string> #include <vector> #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "base/sequenced_task_runner.h" diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc b/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc index ebfacb8..4c51d6f 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc +++ b/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc @@ -2,8 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> +#include <stdint.h> + #include "base/compiler_specific.h" #include "base/files/scoped_file.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/numerics/safe_conversions.h" #include "base/sys_byteorder.h" diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc b/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc index 3730724..4c72d4d 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc +++ b/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc @@ -4,8 +4,11 @@ #include "content/browser/renderer_host/pepper/pepper_truetype_font_list_host.h" +#include <stdint.h> + #include <algorithm> +#include "base/macros.h" #include "base/numerics/safe_conversions.h" #include "base/threading/sequenced_worker_pool.h" #include "content/browser/renderer_host/pepper/pepper_truetype_font_list.h" diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.h b/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.h index 19999ca..46a975b 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.h +++ b/content/browser/renderer_host/pepper/pepper_truetype_font_list_host.h @@ -5,7 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TRUETYPE_FONT_LIST_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_TRUETYPE_FONT_LIST_HOST_H_ -#include "base/basictypes.h" +#include "base/macros.h" #include "ppapi/host/resource_host.h" namespace content { diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_list_mac.mm b/content/browser/renderer_host/pepper/pepper_truetype_font_list_mac.mm index 7615723..c59c4a8 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font_list_mac.mm +++ b/content/browser/renderer_host/pepper/pepper_truetype_font_list_mac.mm @@ -7,6 +7,7 @@ #import <Cocoa/Cocoa.h> #include "base/mac/scoped_nsautorelease_pool.h" +#include "base/macros.h" #include "base/strings/sys_string_conversions.h" #include "ppapi/c/dev/ppb_truetype_font_dev.h" #include "ppapi/proxy/serialized_structs.h" diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm b/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm index 1e52e17..db8a8b5 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm +++ b/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm @@ -5,6 +5,8 @@ #include "content/browser/renderer_host/pepper/pepper_truetype_font.h" #import <ApplicationServices/ApplicationServices.h> +#include <stddef.h> +#include <stdint.h> #include <stdio.h> @@ -12,6 +14,7 @@ #include "base/mac/foundation_util.h" #include "base/mac/scoped_cftyperef.h" #include "base/mac/scoped_nsautorelease_pool.h" +#include "base/macros.h" #include "base/numerics/safe_conversions.h" #include "base/strings/sys_string_conversions.h" #include "base/sys_byteorder.h" diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_win.cc b/content/browser/renderer_host/pepper/pepper_truetype_font_win.cc index 59119cd..194decd 100644 --- a/content/browser/renderer_host/pepper/pepper_truetype_font_win.cc +++ b/content/browser/renderer_host/pepper/pepper_truetype_font_win.cc @@ -5,10 +5,12 @@ #include "content/browser/renderer_host/pepper/pepper_truetype_font.h" #include <windows.h> +#include <stdint.h> #include <algorithm> #include <set> #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/strings/utf_string_conversions.h" #include "base/sys_byteorder.h" diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc index 5474831..278ed63 100644 --- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc +++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc @@ -9,6 +9,7 @@ #include "base/compiler_specific.h" #include "base/logging.h" #include "base/metrics/histogram_macros.h" +#include "build/build_config.h" #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h" #include "content/browser/renderer_host/pepper/pepper_socket_utils.h" #include "content/public/browser/browser_thread.h" @@ -361,7 +362,7 @@ int32_t PepperUDPSocketMessageFilter::OnMsgJoinGroup( return PP_ERROR_FAILED; net::IPAddressNumber group; - uint16 port; + uint16_t port; if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &group, &port)) return PP_ERROR_ADDRESS_INVALID; @@ -382,7 +383,7 @@ int32_t PepperUDPSocketMessageFilter::OnMsgLeaveGroup( return PP_ERROR_FAILED; net::IPAddressNumber group; - uint16 port; + uint16_t port; if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &group, &port)) return PP_ERROR_ADDRESS_INVALID; @@ -405,7 +406,7 @@ void PepperUDPSocketMessageFilter::DoBind( NULL, net::NetLog::Source())); net::IPAddressNumber address; - uint16 port; + uint16_t port; if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &address, &port)) { SendBindError(context, PP_ERROR_ADDRESS_INVALID); return; @@ -585,7 +586,7 @@ void PepperUDPSocketMessageFilter::DoSendTo( } net::IPAddressNumber address; - uint16 port; + uint16_t port; if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &address, &port)) { SendSendToError(context, PP_ERROR_ADDRESS_INVALID); return; diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h index a4ea58c..42d84c0 100644 --- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h +++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h @@ -5,14 +5,17 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UDP_SOCKET_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UDP_SOCKET_MESSAGE_FILTER_H_ +#include <stddef.h> + #include <queue> #include <string> -#include "base/basictypes.h" #include "base/callback.h" #include "base/compiler_specific.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" +#include "build/build_config.h" #include "content/common/content_export.h" #include "content/public/common/process_type.h" #include "net/base/completion_callback.h" diff --git a/content/browser/renderer_host/pepper/quota_reservation.h b/content/browser/renderer_host/pepper/quota_reservation.h index 7ea637c..84a5f90 100644 --- a/content/browser/renderer_host/pepper/quota_reservation.h +++ b/content/browser/renderer_host/pepper/quota_reservation.h @@ -7,8 +7,8 @@ #include <map> -#include "base/basictypes.h" #include "base/callback.h" +#include "base/macros.h" #include "content/common/content_export.h" #include "ppapi/c/pp_stdint.h" // For int64_t on Windows. #include "ppapi/shared_impl/file_growth.h" diff --git a/content/browser/renderer_host/pepper/quota_reservation_unittest.cc b/content/browser/renderer_host/pepper/quota_reservation_unittest.cc index 5d7445b..c1068db 100644 --- a/content/browser/renderer_host/pepper/quota_reservation_unittest.cc +++ b/content/browser/renderer_host/pepper/quota_reservation_unittest.cc @@ -4,12 +4,15 @@ #include "content/browser/renderer_host/pepper/quota_reservation.h" +#include <stdint.h> + #include "base/bind.h" #include "base/bind_helpers.h" #include "base/files/file.h" #include "base/files/file_util.h" #include "base/files/scoped_temp_dir.h" #include "base/location.h" +#include "base/macros.h" #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/thread_task_runner_handle.h" @@ -40,7 +43,7 @@ class FakeBackend : public QuotaReservationManager::QuotaBackend { void ReserveQuota( const GURL& origin, storage::FileSystemType type, - int64 delta, + int64_t delta, const QuotaReservationManager::ReserveQuotaCallback& callback) override { base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, @@ -49,11 +52,11 @@ class FakeBackend : public QuotaReservationManager::QuotaBackend { void ReleaseReservedQuota(const GURL& origin, storage::FileSystemType type, - int64 size) override {} + int64_t size) override {} void CommitQuotaUsage(const GURL& origin, storage::FileSystemType type, - int64 delta) override {} + int64_t delta) override {} void IncrementDirtyCount(const GURL& origin, storage::FileSystemType type) override {} @@ -102,7 +105,7 @@ class QuotaReservationTest : public testing::Test { new QuotaReservation(reservation, origin, type)); } - void SetFileSize(const base::FilePath::StringType& file_name, int64 size) { + void SetFileSize(const base::FilePath::StringType& file_name, int64_t size) { base::File file(MakeFilePath(file_name), base::File::FLAG_OPEN_ALWAYS | base::File::FLAG_WRITE); ASSERT_TRUE(file.IsValid()); @@ -121,9 +124,9 @@ class QuotaReservationTest : public testing::Test { DISALLOW_COPY_AND_ASSIGN(QuotaReservationTest); }; -void GotReservedQuota(int64* reserved_quota_ptr, +void GotReservedQuota(int64_t* reserved_quota_ptr, ppapi::FileGrowthMap* file_growths_ptr, - int64 reserved_quota, + int64_t reserved_quota, const ppapi::FileSizeMap& maximum_written_offsets) { *reserved_quota_ptr = reserved_quota; @@ -135,8 +138,8 @@ void GotReservedQuota(int64* reserved_quota_ptr, } void ReserveQuota(scoped_refptr<QuotaReservation> quota_reservation, - int64 amount, - int64* reserved_quota, + int64_t amount, + int64_t* reserved_quota, ppapi::FileGrowthMap* file_growths) { quota_reservation->ReserveQuota( amount, @@ -158,17 +161,17 @@ TEST_F(QuotaReservationTest, ReserveQuota) { CreateQuotaReservation(reservation, origin, type); // Reserve quota with no files open. - int64 amount = 100; - int64 reserved_quota; + int64_t amount = 100; + int64_t reserved_quota; ppapi::FileGrowthMap file_growths; ReserveQuota(test, amount, &reserved_quota, &file_growths); EXPECT_EQ(amount, reserved_quota); EXPECT_EQ(0U, file_growths.size()); // Open a file, refresh the reservation, extend the file, and close it. - int64 file_size = 10; + int64_t file_size = 10; SetFileSize(file1_name, file_size); - int64 open_file_size = + int64_t open_file_size = test->OpenFile(kFile1ID, MakeFileSystemURL(file1_name)); EXPECT_EQ(file_size, open_file_size); @@ -178,7 +181,7 @@ TEST_F(QuotaReservationTest, ReserveQuota) { EXPECT_EQ(1U, file_growths.size()); EXPECT_EQ(file_size, file_growths[kFile1ID].max_written_offset); - int64 new_file_size = 30; + int64_t new_file_size = 30; SetFileSize(file1_name, new_file_size); EXPECT_EQ(amount, reservation->remaining_quota()); @@ -199,25 +202,25 @@ TEST_F(QuotaReservationTest, MultipleFiles) { CreateQuotaReservation(reservation, origin, type); // Open some files of different sizes. - int64 file1_size = 10; + int64_t file1_size = 10; SetFileSize(file1_name, file1_size); - int64 open_file1_size = + int64_t open_file1_size = test->OpenFile(kFile1ID, MakeFileSystemURL(file1_name)); EXPECT_EQ(file1_size, open_file1_size); - int64 file2_size = 20; + int64_t file2_size = 20; SetFileSize(file2_name, file2_size); - int64 open_file2_size = + int64_t open_file2_size = test->OpenFile(kFile2ID, MakeFileSystemURL(file2_name)); EXPECT_EQ(file2_size, open_file2_size); - int64 file3_size = 30; + int64_t file3_size = 30; SetFileSize(file3_name, file3_size); - int64 open_file3_size = + int64_t open_file3_size = test->OpenFile(kFile3ID, MakeFileSystemURL(file3_name)); EXPECT_EQ(file3_size, open_file3_size); // Reserve quota. - int64 amount = 100; - int64 reserved_quota; + int64_t amount = 100; + int64_t reserved_quota; ppapi::FileGrowthMap file_growths; file_growths[kFile1ID] = ppapi::FileGrowth(file1_size, 0); // 3 files open. file_growths[kFile2ID] = ppapi::FileGrowth(file2_size, 0); diff --git a/content/browser/renderer_host/pepper/ssl_context_helper.h b/content/browser/renderer_host/pepper/ssl_context_helper.h index f1da2a6..f979529 100644 --- a/content/browser/renderer_host/pepper/ssl_context_helper.h +++ b/content/browser/renderer_host/pepper/ssl_context_helper.h @@ -5,7 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_SSL_CONTEXT_HELPER_H_ #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_SSL_CONTEXT_HELPER_H_ -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "net/ssl/ssl_config_service.h" diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc index 3ffdc89..215c09d 100644 --- a/content/browser/renderer_host/render_message_filter.cc +++ b/content/browser/renderer_host/render_message_filter.cc @@ -13,11 +13,13 @@ #include "base/bind_helpers.h" #include "base/command_line.h" #include "base/debug/alias.h" +#include "base/macros.h" #include "base/numerics/safe_math.h" #include "base/strings/sys_string_conversions.h" #include "base/strings/utf_string_conversions.h" #include "base/threading/thread.h" #include "base/threading/worker_pool.h" +#include "build/build_config.h" #include "content/browser/browser_main_loop.h" #include "content/browser/dom_storage/dom_storage_context_wrapper.h" #include "content/browser/dom_storage/session_storage_namespace_impl.h" @@ -87,10 +89,8 @@ namespace content { namespace { -const uint32 kFilteredMessageClasses[] = { - ChildProcessMsgStart, - RenderProcessMsgStart, - ViewMsgStart, +const uint32_t kFilteredMessageClasses[] = { + ChildProcessMsgStart, RenderProcessMsgStart, ViewMsgStart, }; #if defined(OS_WIN) @@ -430,7 +430,7 @@ void RenderMessageFilter::OnSaveImageFromDataURL(int render_view_id, } void RenderMessageFilter::AllocateSharedMemoryOnFileThread( - uint32 buffer_size, + uint32_t buffer_size, IPC::Message* reply_msg) { base::SharedMemoryHandle handle; ChildProcessHostImpl::AllocateSharedMemory(buffer_size, PeerHandle(), @@ -440,7 +440,7 @@ void RenderMessageFilter::AllocateSharedMemoryOnFileThread( Send(reply_msg); } -void RenderMessageFilter::OnAllocateSharedMemory(uint32 buffer_size, +void RenderMessageFilter::OnAllocateSharedMemory(uint32_t buffer_size, IPC::Message* reply_msg) { BrowserThread::PostTask( BrowserThread::FILE_USER_BLOCKING, FROM_HERE, @@ -449,7 +449,7 @@ void RenderMessageFilter::OnAllocateSharedMemory(uint32 buffer_size, } void RenderMessageFilter::AllocateSharedBitmapOnFileThread( - uint32 buffer_size, + uint32_t buffer_size, const cc::SharedBitmapId& id, IPC::Message* reply_msg) { base::SharedMemoryHandle handle; @@ -460,7 +460,7 @@ void RenderMessageFilter::AllocateSharedBitmapOnFileThread( Send(reply_msg); } -void RenderMessageFilter::OnAllocateSharedBitmap(uint32 buffer_size, +void RenderMessageFilter::OnAllocateSharedBitmap(uint32_t buffer_size, const cc::SharedBitmapId& id, IPC::Message* reply_msg) { BrowserThread::PostTask( @@ -486,7 +486,7 @@ void RenderMessageFilter::OnDeletedSharedBitmap(const cc::SharedBitmapId& id) { } void RenderMessageFilter::AllocateLockedDiscardableSharedMemoryOnFileThread( - uint32 size, + uint32_t size, DiscardableSharedMemoryId id, IPC::Message* reply_msg) { base::SharedMemoryHandle handle; @@ -499,7 +499,7 @@ void RenderMessageFilter::AllocateLockedDiscardableSharedMemoryOnFileThread( } void RenderMessageFilter::OnAllocateLockedDiscardableSharedMemory( - uint32 size, + uint32_t size, DiscardableSharedMemoryId id, IPC::Message* reply_msg) { BrowserThread::PostTask( @@ -546,7 +546,7 @@ void RenderMessageFilter::OnCacheableMetadataAvailable( data.size()); } -void RenderMessageFilter::OnKeygen(uint32 key_size_index, +void RenderMessageFilter::OnKeygen(uint32_t key_size_index, const std::string& challenge_string, const GURL& url, IPC::Message* reply_msg) { @@ -644,8 +644,8 @@ void RenderMessageFilter::OnWebAudioMediaCodec( #endif void RenderMessageFilter::OnAllocateGpuMemoryBuffer(gfx::GpuMemoryBufferId id, - uint32 width, - uint32 height, + uint32_t width, + uint32_t height, gfx::BufferFormat format, gfx::BufferUsage usage, IPC::Message* reply) { diff --git a/content/browser/renderer_host/render_message_filter.h b/content/browser/renderer_host/render_message_filter.h index da1f387..b87ad3f 100644 --- a/content/browser/renderer_host/render_message_filter.h +++ b/content/browser/renderer_host/render_message_filter.h @@ -5,14 +5,14 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_MESSAGE_FILTER_H_ -#if defined(OS_WIN) -#include <windows.h> -#endif +#include <stddef.h> +#include <stdint.h> #include <string> #include <vector> #include "base/files/file_path.h" +#include "base/macros.h" #include "base/memory/linked_ptr.h" #include "base/memory/shared_memory.h" #include "base/sequenced_task_runner_helpers.h" @@ -31,6 +31,10 @@ #include "ui/gfx/native_widget_types.h" #include "ui/surface/transport_dib.h" +#if defined(OS_WIN) +#include <windows.h> +#endif + #if defined(OS_MACOSX) #include <IOSurface/IOSurface.h> #include "content/common/mac/font_loader.h" @@ -159,13 +163,13 @@ class CONTENT_EXPORT RenderMessageFilter : public BrowserMessageFilter { // Used to ask the browser to allocate a block of shared memory for the // renderer to send back data in, since shared memory can't be created // in the renderer on POSIX due to the sandbox. - void AllocateSharedMemoryOnFileThread(uint32 buffer_size, + void AllocateSharedMemoryOnFileThread(uint32_t buffer_size, IPC::Message* reply_msg); - void OnAllocateSharedMemory(uint32 buffer_size, IPC::Message* reply_msg); - void AllocateSharedBitmapOnFileThread(uint32 buffer_size, + void OnAllocateSharedMemory(uint32_t buffer_size, IPC::Message* reply_msg); + void AllocateSharedBitmapOnFileThread(uint32_t buffer_size, const cc::SharedBitmapId& id, IPC::Message* reply_msg); - void OnAllocateSharedBitmap(uint32 buffer_size, + void OnAllocateSharedBitmap(uint32_t buffer_size, const cc::SharedBitmapId& id, IPC::Message* reply_msg); void OnAllocatedSharedBitmap(size_t buffer_size, @@ -176,10 +180,10 @@ class CONTENT_EXPORT RenderMessageFilter : public BrowserMessageFilter { // Browser side discardable shared memory allocation. void AllocateLockedDiscardableSharedMemoryOnFileThread( - uint32 size, + uint32_t size, DiscardableSharedMemoryId id, IPC::Message* reply_message); - void OnAllocateLockedDiscardableSharedMemory(uint32 size, + void OnAllocateLockedDiscardableSharedMemory(uint32_t size, DiscardableSharedMemoryId id, IPC::Message* reply_message); void DeletedDiscardableSharedMemoryOnFileThread(DiscardableSharedMemoryId id); @@ -188,8 +192,10 @@ class CONTENT_EXPORT RenderMessageFilter : public BrowserMessageFilter { void OnCacheableMetadataAvailable(const GURL& url, base::Time expected_response_time, const std::vector<char>& data); - void OnKeygen(uint32 key_size_index, const std::string& challenge_string, - const GURL& url, IPC::Message* reply_msg); + void OnKeygen(uint32_t key_size_index, + const std::string& challenge_string, + const GURL& url, + IPC::Message* reply_msg); void PostKeygenToWorkerThread(IPC::Message* reply_msg, scoped_ptr<net::KeygenHandler> keygen_handler); void OnKeygenOnWorkerThread(scoped_ptr<net::KeygenHandler> keygen_handler, @@ -206,8 +212,8 @@ class CONTENT_EXPORT RenderMessageFilter : public BrowserMessageFilter { #endif void OnAllocateGpuMemoryBuffer(gfx::GpuMemoryBufferId id, - uint32 width, - uint32 height, + uint32_t width, + uint32_t height, gfx::BufferFormat format, gfx::BufferUsage usage, IPC::Message* reply); diff --git a/content/browser/renderer_host/render_process_host_browsertest.cc b/content/browser/renderer_host/render_process_host_browsertest.cc index 96a5803..e0c4d27 100644 --- a/content/browser/renderer_host/render_process_host_browsertest.cc +++ b/content/browser/renderer_host/render_process_host_browsertest.cc @@ -3,6 +3,7 @@ // found in the LICENSE file. #include "base/command_line.h" +#include "build/build_config.h" #include "content/browser/renderer_host/render_process_host_impl.h" #include "content/common/child_process_messages.h" #include "content/public/browser/render_process_host.h" diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc index a7d4c3f..23ca20d 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc @@ -23,6 +23,7 @@ #include "base/lazy_instance.h" #include "base/location.h" #include "base/logging.h" +#include "base/macros.h" #include "base/metrics/field_trial.h" #include "base/metrics/histogram.h" #include "base/process/process_handle.h" @@ -36,6 +37,7 @@ #include "base/threading/thread_restrictions.h" #include "base/trace_event/trace_event.h" #include "base/tracked_objects.h" +#include "build/build_config.h" #include "cc/base/switches.h" #include "components/scheduler/common/scheduler_switches.h" #include "components/tracing/tracing_switches.h" @@ -245,11 +247,11 @@ const base::FilePath::CharType kEventLogFileNameAddition[] = FILE_PATH_LITERAL("event_log"); #endif -void CacheShaderInfo(int32 id, base::FilePath path) { +void CacheShaderInfo(int32_t id, base::FilePath path) { ShaderCacheFactory::GetInstance()->SetCacheInfo(id, path); } -void RemoveShaderInfo(int32 id) { +void RemoveShaderInfo(int32_t id) { ShaderCacheFactory::GetInstance()->RemoveCacheInfo(id); } @@ -1148,14 +1150,14 @@ void RenderProcessHostImpl::DecrementWorkerRefCount() { Cleanup(); } -void RenderProcessHostImpl::AddRoute(int32 routing_id, +void RenderProcessHostImpl::AddRoute(int32_t routing_id, IPC::Listener* listener) { CHECK(!listeners_.Lookup(routing_id)) << "Found Routing ID Conflict: " << routing_id; listeners_.AddWithID(listener, routing_id); } -void RenderProcessHostImpl::RemoveRoute(int32 routing_id) { +void RenderProcessHostImpl::RemoveRoute(int32_t routing_id) { DCHECK(listeners_.Lookup(routing_id) != NULL); listeners_.Remove(routing_id); @@ -1708,7 +1710,7 @@ bool RenderProcessHostImpl::OnMessageReceived(const IPC::Message& msg) { return listener->OnMessageReceived(msg); } -void RenderProcessHostImpl::OnChannelConnected(int32 peer_pid) { +void RenderProcessHostImpl::OnChannelConnected(int32_t peer_pid) { channel_connected_ = true; if (IsReady()) { DCHECK(!sent_render_process_ready_); diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h index 6120527..c9cc5ac 100644 --- a/content/browser/renderer_host/render_process_host_impl.h +++ b/content/browser/renderer_host/render_process_host_impl.h @@ -5,14 +5,19 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_ +#include <stddef.h> +#include <stdint.h> + #include <map> #include <queue> #include <string> +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/observer_list.h" #include "base/process/process.h" #include "base/synchronization/waitable_event.h" +#include "build/build_config.h" #include "content/browser/child_process_launcher.h" #include "content/browser/dom_storage/session_storage_namespace_impl.h" #include "content/browser/power_monitor_message_broadcaster.h" @@ -106,8 +111,8 @@ class CONTENT_EXPORT RenderProcessHostImpl void EnableSendQueue() override; bool Init() override; int GetNextRoutingID() override; - void AddRoute(int32 routing_id, IPC::Listener* listener) override; - void RemoveRoute(int32 routing_id) override; + void AddRoute(int32_t routing_id, IPC::Listener* listener) override; + void RemoveRoute(int32_t routing_id) override; void AddObserver(RenderProcessHostObserver* observer) override; void RemoveObserver(RenderProcessHostObserver* observer) override; void ShutdownForBadMessage() override; @@ -173,7 +178,7 @@ class CONTENT_EXPORT RenderProcessHostImpl // IPC::Listener via RenderProcessHost. bool OnMessageReceived(const IPC::Message& msg) override; - void OnChannelConnected(int32 peer_pid) override; + void OnChannelConnected(int32_t peer_pid) override; void OnChannelError() override; void OnBadMessageReceived(const IPC::Message& message) override; @@ -280,7 +285,7 @@ class CONTENT_EXPORT RenderProcessHostImpl // The count of currently swapped out but pending RenderViews. We have // started to swap these in, so the renderer process should not exit if // this count is non-zero. - int32 pending_views_; + int32_t pending_views_; private: friend class VisitRelayingRenderProcessHost; @@ -354,7 +359,7 @@ class CONTENT_EXPORT RenderProcessHostImpl // The count of currently visible widgets. Since the host can be a container // for multiple widgets, it uses this count to determine when it should be // backgrounded. - int32 visible_widgets_; + int32_t visible_widgets_; // Whether this process currently has backgrounded priority. Tracked so that // UpdateProcessPriority() can avoid redundantly setting the priority. diff --git a/content/browser/renderer_host/render_process_host_unittest.cc b/content/browser/renderer_host/render_process_host_unittest.cc index ee2395c..019cae6 100644 --- a/content/browser/renderer_host/render_process_host_unittest.cc +++ b/content/browser/renderer_host/render_process_host_unittest.cc @@ -2,8 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stddef.h> + #include <limits> +#include "build/build_config.h" #include "content/public/common/content_constants.h" #include "content/public/test/mock_render_process_host.h" #include "content/public/test/test_utils.h" diff --git a/content/browser/renderer_host/render_sandbox_host_linux.h b/content/browser/renderer_host/render_sandbox_host_linux.h index a9f8a02..b9fad88 100644 --- a/content/browser/renderer_host/render_sandbox_host_linux.h +++ b/content/browser/renderer_host/render_sandbox_host_linux.h @@ -8,6 +8,7 @@ #include <string> #include "base/logging.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/threading/simple_thread.h" #include "content/browser/renderer_host/sandbox_ipc_linux.h" diff --git a/content/browser/renderer_host/render_view_host_browsertest.cc b/content/browser/renderer_host/render_view_host_browsertest.cc index 3e16cdfb..5e14d47 100644 --- a/content/browser/renderer_host/render_view_host_browsertest.cc +++ b/content/browser/renderer_host/render_view_host_browsertest.cc @@ -2,10 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include "base/macros.h" #include "base/path_service.h" #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "base/values.h" +#include "build/build_config.h" #include "content/browser/frame_host/render_frame_host_impl.h" #include "content/browser/renderer_host/render_view_host_impl.h" #include "content/browser/web_contents/web_contents_impl.h" diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h index 2ea9fdd2..8fc436c 100644 --- a/content/browser/renderer_host/render_view_host_delegate.h +++ b/content/browser/renderer_host/render_view_host_delegate.h @@ -5,9 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ +#include <stdint.h> + #include <string> -#include "base/basictypes.h" #include "base/callback.h" #include "base/process/kill.h" #include "base/strings/string16.h" @@ -101,7 +102,7 @@ class CONTENT_EXPORT RenderViewHostDelegate { // The state for the page changed and should be updated. virtual void UpdateState(RenderViewHost* render_view_host, - int32 page_id, + int32_t page_id, const PageState& state) {} // The destination URL has changed should be updated. @@ -138,8 +139,8 @@ class CONTENT_EXPORT RenderViewHostDelegate { // Notification that the RenderViewHost's load state changed. virtual void LoadStateChanged(const GURL& url, const net::LoadStateWithParam& load_state, - uint64 upload_position, - uint64 upload_size) {} + uint64_t upload_position, + uint64_t upload_size) {} // The page wants the hosting window to activate itself (it called the // JavaScript window.focus() method). @@ -184,13 +185,13 @@ class CONTENT_EXPORT RenderViewHostDelegate { // happen in response to ShowCreatedWidget. // |popup_type| indicates if the widget is a popup and what kind of popup it // is (select, autofill...). - virtual void CreateNewWidget(int32 render_process_id, - int32 route_id, + virtual void CreateNewWidget(int32_t render_process_id, + int32_t route_id, blink::WebPopupType popup_type) {} // Creates a full screen RenderWidget. Similar to above. - virtual void CreateNewFullscreenWidget(int32 render_process_id, - int32 route_id) {} + virtual void CreateNewFullscreenWidget(int32_t render_process_id, + int32_t route_id) {} // Show a previously created page with the specified disposition and bounds. // The window is identified by the route_id passed to CreateNewWindow. diff --git a/content/browser/renderer_host/render_view_host_delegate_view.h b/content/browser/renderer_host/render_view_host_delegate_view.h index 4c24912..1e05290 100644 --- a/content/browser/renderer_host/render_view_host_delegate_view.h +++ b/content/browser/renderer_host/render_view_host_delegate_view.h @@ -7,8 +7,8 @@ #include <vector> -#include "base/basictypes.h" #include "base/callback.h" +#include "build/build_config.h" #include "content/common/content_export.h" #include "content/common/drag_event_source_info.h" #include "third_party/WebKit/public/web/WebDragOperation.h" diff --git a/content/browser/renderer_host/render_view_host_factory.cc b/content/browser/renderer_host/render_view_host_factory.cc index 2e166c4..7fa252a 100644 --- a/content/browser/renderer_host/render_view_host_factory.cc +++ b/content/browser/renderer_host/render_view_host_factory.cc @@ -17,8 +17,8 @@ RenderViewHost* RenderViewHostFactory::Create( SiteInstance* instance, RenderViewHostDelegate* delegate, RenderWidgetHostDelegate* widget_delegate, - int32 routing_id, - int32 main_frame_routing_id, + int32_t routing_id, + int32_t main_frame_routing_id, bool swapped_out, bool hidden) { // RenderViewHost creation can be either browser-driven (by the user opening a diff --git a/content/browser/renderer_host/render_view_host_factory.h b/content/browser/renderer_host/render_view_host_factory.h index be2aae5..62b2390 100644 --- a/content/browser/renderer_host/render_view_host_factory.h +++ b/content/browser/renderer_host/render_view_host_factory.h @@ -5,7 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_FACTORY_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_FACTORY_H_ -#include "base/basictypes.h" +#include <stdint.h> + +#include "base/macros.h" #include "content/common/content_export.h" namespace content { @@ -27,8 +29,8 @@ class RenderViewHostFactory { static RenderViewHost* Create(SiteInstance* instance, RenderViewHostDelegate* delegate, RenderWidgetHostDelegate* widget_delegate, - int32 routing_id, - int32 main_frame_routing_id, + int32_t routing_id, + int32_t main_frame_routing_id, bool swapped_out, bool hidden); @@ -47,8 +49,8 @@ class RenderViewHostFactory { SiteInstance* instance, RenderViewHostDelegate* delegate, RenderWidgetHostDelegate* widget_delegate, - int32 routing_id, - int32 main_frame_routing_id, + int32_t routing_id, + int32_t main_frame_routing_id, bool swapped_out) = 0; // Registers your factory to be called when new RenderViewHosts are created. diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc index ceaa92b..76596b6 100644 --- a/content/browser/renderer_host/render_view_host_impl.cc +++ b/content/browser/renderer_host/render_view_host_impl.cc @@ -23,6 +23,7 @@ #include "base/time/time.h" #include "base/trace_event/trace_event.h" #include "base/values.h" +#include "build/build_config.h" #include "cc/base/switches.h" #include "content/browser/bad_message.h" #include "content/browser/child_process_security_policy_impl.h" @@ -163,7 +164,7 @@ void GetWindowsSpecificPrefs(RendererPreferences* prefs) { } // namespace // static -const int64 RenderViewHostImpl::kUnloadTimeoutMS = 1000; +const int64_t RenderViewHostImpl::kUnloadTimeoutMS = 1000; /////////////////////////////////////////////////////////////////////////////// // RenderViewHost, public: @@ -208,8 +209,8 @@ RenderViewHostImpl::RenderViewHostImpl( SiteInstance* instance, RenderViewHostDelegate* delegate, RenderWidgetHostDelegate* widget_delegate, - int32 routing_id, - int32 main_frame_routing_id, + int32_t routing_id, + int32_t main_frame_routing_id, bool swapped_out, bool hidden, bool has_initialized_audio_host) @@ -286,7 +287,7 @@ SiteInstanceImpl* RenderViewHostImpl::GetSiteInstance() const { bool RenderViewHostImpl::CreateRenderView( int opener_frame_route_id, int proxy_route_id, - int32 max_page_id, + int32_t max_page_id, const FrameReplicationState& replicated_frame_state, bool window_was_created_with_opener) { TRACE_EVENT0("renderer_host,navigation", @@ -308,7 +309,7 @@ bool RenderViewHostImpl::CreateRenderView( // Ensure the RenderView starts with a next_page_id larger than any existing // page ID it might be asked to render. - int32 next_page_id = 1; + int32_t next_page_id = 1; if (max_page_id > -1) next_page_id = max_page_id + 1; @@ -884,8 +885,8 @@ void RenderViewHostImpl::RenderWidgetWillSetIsLoading(bool is_loading) { void RenderViewHostImpl::LoadStateChanged( const GURL& url, const net::LoadStateWithParam& load_state, - uint64 upload_position, - uint64 upload_size) { + uint64_t upload_position, + uint64_t upload_size) { delegate_->LoadStateChanged(url, load_state, upload_position, upload_size); } @@ -1010,12 +1011,12 @@ void RenderViewHostImpl::CreateNewWindow( session_storage_namespace); } -void RenderViewHostImpl::CreateNewWidget(int32 route_id, +void RenderViewHostImpl::CreateNewWidget(int32_t route_id, blink::WebPopupType popup_type) { delegate_->CreateNewWidget(GetProcess()->GetID(), route_id, popup_type); } -void RenderViewHostImpl::CreateNewFullscreenWidget(int32 route_id) { +void RenderViewHostImpl::CreateNewFullscreenWidget(int32_t route_id) { delegate_->CreateNewFullscreenWidget(GetProcess()->GetID(), route_id); } @@ -1048,7 +1049,8 @@ void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) { // decoupled. } -void RenderViewHostImpl::OnUpdateState(int32 page_id, const PageState& state) { +void RenderViewHostImpl::OnUpdateState(int32_t page_id, + const PageState& state) { // If the following DCHECK fails, you have encountered a tricky edge-case that // has evaded reproduction for a very long time. Please report what you were // doing on http://crbug.com/407376, whether or not you can reproduce the diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h index 4e8afe0..396747b 100644 --- a/content/browser/renderer_host/render_view_host_impl.h +++ b/content/browser/renderer_host/render_view_host_impl.h @@ -5,6 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ +#include <stddef.h> +#include <stdint.h> + #include <map> #include <string> #include <vector> @@ -13,8 +16,10 @@ #include "base/compiler_specific.h" #include "base/gtest_prod_util.h" #include "base/logging.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/process/kill.h" +#include "build/build_config.h" #include "content/browser/renderer_host/render_widget_host_impl.h" #include "content/browser/renderer_host/render_widget_host_owner_delegate.h" #include "content/browser/site_instance_impl.h" @@ -99,8 +104,8 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, RenderViewHostImpl(SiteInstance* instance, RenderViewHostDelegate* delegate, RenderWidgetHostDelegate* widget_delegate, - int32 routing_id, - int32 main_frame_routing_id, + int32_t routing_id, + int32_t main_frame_routing_id, bool swapped_out, bool hidden, bool has_initialized_audio_host); @@ -199,7 +204,7 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, virtual bool CreateRenderView( int opener_frame_route_id, int proxy_route_id, - int32 max_page_id, + int32_t max_page_id, const FrameReplicationState& replicated_frame_state, bool window_was_created_with_opener); @@ -253,8 +258,8 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, // Notifies the RenderViewHost that its load state changed. void LoadStateChanged(const GURL& url, const net::LoadStateWithParam& load_state, - uint64 upload_position, - uint64 upload_size); + uint64_t upload_position, + uint64_t upload_size); bool SuddenTerminationAllowed() const; void set_sudden_termination_allowed(bool enabled) { @@ -273,11 +278,10 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, // Creates a new RenderWidget with the given route id. |popup_type| indicates // if this widget is a popup and what kind of popup it is (select, autofill). - void CreateNewWidget(int32 route_id, - blink::WebPopupType popup_type); + void CreateNewWidget(int32_t route_id, blink::WebPopupType popup_type); // Creates a full screen RenderWidget. - void CreateNewFullscreenWidget(int32 route_id); + void CreateNewFullscreenWidget(int32_t route_id); void set_main_frame_routing_id(int routing_id) { main_frame_routing_id_ = routing_id; @@ -327,7 +331,7 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, void OnShowWidget(int route_id, const gfx::Rect& initial_rect); void OnShowFullscreenWidget(int route_id); void OnRenderProcessGone(int status, int error_code); - void OnUpdateState(int32 page_id, const PageState& state); + void OnUpdateState(int32_t page_id, const PageState& state); void OnUpdateTargetURL(const GURL& url); void OnClose(); void OnRequestMove(const gfx::Rect& pos); @@ -367,7 +371,7 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, // TODO(creis): Move to a private namespace on RenderFrameHostImpl. // Delay to wait on closing the WebContents for a beforeunload/unload handler // to fire. - static const int64 kUnloadTimeoutMS; + static const int64_t kUnloadTimeoutMS; // Returns the content specific prefs for this RenderViewHost. // TODO(creis): Move most of this method to RenderProcessHost, since it's @@ -407,7 +411,7 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, // The most recent page ID we've heard from the renderer process. This is // used as context when other session history related IPCs arrive. // TODO(creis): Allocate this in WebContents/NavigationController instead. - int32 page_id_; + int32_t page_id_; // Tracks whether this RenderViewHost is in an active state. False if the // main frame is pending swap out, pending deletion, or swapped out, because diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc index 00b7b3d..fc7d722 100644 --- a/content/browser/renderer_host/render_view_host_unittest.cc +++ b/content/browser/renderer_host/render_view_host_unittest.cc @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + +#include "base/macros.h" #include "base/path_service.h" #include "base/strings/utf_string_conversions.h" #include "content/browser/child_process_security_policy_impl.h" @@ -74,7 +77,7 @@ TEST_F(RenderViewHostTest, FilterAbout) { // Create a full screen popup RenderWidgetHost and View. TEST_F(RenderViewHostTest, CreateFullscreenWidget) { - int32 routing_id = process()->GetNextRoutingID(); + int32_t routing_id = process()->GetNextRoutingID(); test_rvh()->CreateNewFullscreenWidget(routing_id); } diff --git a/content/browser/renderer_host/render_widget_helper.cc b/content/browser/renderer_host/render_widget_helper.cc index 4a37ca5..9328373 100644 --- a/content/browser/renderer_host/render_widget_helper.cc +++ b/content/browser/renderer_host/render_widget_helper.cc @@ -172,8 +172,8 @@ void RenderWidgetHelper::CreateNewFullscreenWidget(int opener_id, opener_id, *route_id)); } -void RenderWidgetHelper::OnCreateWidgetOnUI(int32 opener_id, - int32 route_id, +void RenderWidgetHelper::OnCreateWidgetOnUI(int32_t opener_id, + int32_t route_id, blink::WebPopupType popup_type) { RenderViewHostImpl* host = RenderViewHostImpl::FromID( render_process_id_, opener_id); @@ -181,8 +181,8 @@ void RenderWidgetHelper::OnCreateWidgetOnUI(int32 opener_id, host->CreateNewWidget(route_id, popup_type); } -void RenderWidgetHelper::OnCreateFullscreenWidgetOnUI(int32 opener_id, - int32 route_id) { +void RenderWidgetHelper::OnCreateFullscreenWidgetOnUI(int32_t opener_id, + int32_t route_id) { RenderViewHostImpl* host = RenderViewHostImpl::FromID( render_process_id_, opener_id); if (host) diff --git a/content/browser/renderer_host/render_widget_helper.h b/content/browser/renderer_host/render_widget_helper.h index 881dd50..c4b8baf 100644 --- a/content/browser/renderer_host/render_widget_helper.h +++ b/content/browser/renderer_host/render_widget_helper.h @@ -5,10 +5,13 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HELPER_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HELPER_H_ +#include <stdint.h> + #include <map> #include "base/atomic_sequence_num.h" #include "base/containers/hash_tables.h" +#include "base/macros.h" #include "base/memory/ref_counted.h" #include "base/process/process.h" #include "content/public/browser/browser_thread.h" @@ -129,12 +132,12 @@ class RenderWidgetHelper void OnResumeRequestsForView(int route_id); // Called on the UI thread to finish creating a widget. - void OnCreateWidgetOnUI(int32 opener_id, - int32 route_id, + void OnCreateWidgetOnUI(int32_t opener_id, + int32_t route_id, blink::WebPopupType popup_type); // Called on the UI thread to create a fullscreen widget. - void OnCreateFullscreenWidgetOnUI(int32 opener_id, int32 route_id); + void OnCreateFullscreenWidgetOnUI(int32_t opener_id, int32_t route_id); // Called on the IO thread to resume a paused navigation in the network // stack without transferring it to a new renderer process. diff --git a/content/browser/renderer_host/render_widget_host_delegate.cc b/content/browser/renderer_host/render_widget_host_delegate.cc index 0609826f..c158a41 100644 --- a/content/browser/renderer_host/render_widget_host_delegate.cc +++ b/content/browser/renderer_host/render_widget_host_delegate.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/basictypes.h" +#include "build/build_config.h" #include "content/browser/renderer_host/render_widget_host_delegate.h" #include "ui/gfx/geometry/rect.h" diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h index b4e4169..f7fbb0e 100644 --- a/content/browser/renderer_host/render_widget_host_delegate.h +++ b/content/browser/renderer_host/render_widget_host_delegate.h @@ -5,9 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ +#include <stdint.h> + #include <vector> -#include "base/basictypes.h" #include "build/build_config.h" #include "content/common/content_export.h" #include "third_party/WebKit/public/platform/WebDisplayMode.h" diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc index 026bf20..81d89aa 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc @@ -15,6 +15,7 @@ #include "base/i18n/rtl.h" #include "base/lazy_instance.h" #include "base/location.h" +#include "base/macros.h" #include "base/metrics/field_trial.h" #include "base/metrics/histogram.h" #include "base/single_thread_task_runner.h" @@ -22,6 +23,7 @@ #include "base/strings/utf_string_conversions.h" #include "base/thread_task_runner_handle.h" #include "base/trace_event/trace_event.h" +#include "build/build_config.h" #include "cc/base/switches.h" #include "cc/output/compositor_frame.h" #include "cc/output/compositor_frame_ack.h" diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h index 0f017b4..48c2a90 100644 --- a/content/browser/renderer_host/render_widget_host_impl.h +++ b/content/browser/renderer_host/render_widget_host_impl.h @@ -5,6 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ +#include <stddef.h> +#include <stdint.h> + #include <list> #include <map> #include <string> @@ -12,6 +15,7 @@ #include <vector> #include "base/callback.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "base/observer_list.h" diff --git a/content/browser/renderer_host/render_widget_host_input_event_router.h b/content/browser/renderer_host/render_widget_host_input_event_router.h index 062b3f3..0c01a6c 100644 --- a/content/browser/renderer_host/render_widget_host_input_event_router.h +++ b/content/browser/renderer_host/render_widget_host_input_event_router.h @@ -8,6 +8,7 @@ #include <stdint.h> #include "base/containers/hash_tables.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/render_widget_host_unittest.cc b/content/browser/renderer_host/render_widget_host_unittest.cc index 83b3d6f..49fa2d4 100644 --- a/content/browser/renderer_host/render_widget_host_unittest.cc +++ b/content/browser/renderer_host/render_widget_host_unittest.cc @@ -2,14 +2,18 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/basictypes.h" +#include <stddef.h> +#include <stdint.h> + #include "base/bind.h" #include "base/command_line.h" #include "base/location.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/single_thread_task_runner.h" #include "base/thread_task_runner_handle.h" #include "base/timer/timer.h" +#include "build/build_config.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/gpu/compositor_util.h" #include "content/browser/gpu/gpu_surface_tracker.h" @@ -498,9 +502,7 @@ class RenderWidgetHostTest : public testing::Test { virtual void ConfigureView(TestView* view) { } - int64 GetLatencyComponentId() { - return host_->GetLatencyComponentId(); - } + int64_t GetLatencyComponentId() { return host_->GetLatencyComponentId(); } void SendInputEventACK(WebInputEvent::Type type, InputEventAckState ack_result) { @@ -588,8 +590,8 @@ class RenderWidgetHostTest : public testing::Test { // Sends a touch event (irrespective of whether the page has a touch-event // handler or not). - uint32 SendTouchEvent() { - uint32 touch_event_id = touch_event_.uniqueTouchEventId; + uint32_t SendTouchEvent() { + uint32_t touch_event_id = touch_event_.uniqueTouchEventId; host_->ForwardTouchEventWithLatencyInfo(touch_event_, ui::LatencyInfo()); touch_event_.ResetPoints(); @@ -1528,7 +1530,7 @@ ui::LatencyInfo GetLatencyInfoFromInputEvent(RenderWidgetHostProcess* process) { } void CheckLatencyInfoComponentInMessage(RenderWidgetHostProcess* process, - int64 component_id, + int64_t component_id, WebInputEvent::Type input_type) { ui::LatencyInfo latency_info = GetLatencyInfoFromInputEvent(process); EXPECT_TRUE(latency_info.FindLatency( @@ -1587,7 +1589,7 @@ TEST_F(RenderWidgetHostTest, InputEventRWHLatencyComponent) { // Tests RWHI::ForwardTouchEventWithLatencyInfo(). PressTouchPoint(0, 1); - uint32 touch_event_id = SendTouchEvent(); + uint32_t touch_event_id = SendTouchEvent(); InputEventAck ack(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED, touch_event_id); host_->OnMessageReceived(InputHostMsg_HandleInputEvent_ACK(0, ack)); diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc index 9994db5..76f0195 100644 --- a/content/browser/renderer_host/render_widget_host_view_android.cc +++ b/content/browser/renderer_host/render_widget_host_view_android.cc @@ -7,11 +7,11 @@ #include <android/bitmap.h> #include "base/android/build_info.h" -#include "base/basictypes.h" #include "base/bind.h" #include "base/callback_helpers.h" #include "base/command_line.h" #include "base/logging.h" +#include "base/macros.h" #include "base/message_loop/message_loop.h" #include "base/metrics/histogram.h" #include "base/strings/utf_string_conversions.h" @@ -296,7 +296,7 @@ gfx::RectF GetSelectionRect(const ui::TouchSelectionController& controller) { } // anonymous namespace RenderWidgetHostViewAndroid::LastFrameInfo::LastFrameInfo( - uint32 output_id, + uint32_t output_id, scoped_ptr<cc::CompositorFrame> output_frame) : output_surface_id(output_id), frame(output_frame.Pass()) {} @@ -950,7 +950,7 @@ RenderWidgetHostViewAndroid::CreateSyntheticGestureTarget() { } void RenderWidgetHostViewAndroid::SendDelegatedFrameAck( - uint32 output_surface_id) { + uint32_t output_surface_id) { DCHECK(host_); cc::CompositorFrameAck ack; if (!surface_returned_resources_.empty()) @@ -962,7 +962,7 @@ void RenderWidgetHostViewAndroid::SendDelegatedFrameAck( } void RenderWidgetHostViewAndroid::SendReturnedDelegatedResources( - uint32 output_surface_id) { + uint32_t output_surface_id) { DCHECK(host_); cc::CompositorFrameAck ack; if (!surface_returned_resources_.empty()) { @@ -1011,7 +1011,7 @@ void RenderWidgetHostViewAndroid::DestroyDelegatedContent() { } void RenderWidgetHostViewAndroid::CheckOutputSurfaceChanged( - uint32 output_surface_id) { + uint32_t output_surface_id) { if (output_surface_id == last_output_surface_id_) return; // Drop the cc::DelegatedFrameResourceCollection so that we will not return @@ -1083,7 +1083,7 @@ void RenderWidgetHostViewAndroid::SubmitCompositorFrame( } void RenderWidgetHostViewAndroid::SwapDelegatedFrame( - uint32 output_surface_id, + uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) { CheckOutputSurfaceChanged(output_surface_id); bool has_content = !texture_size_in_layer_.IsEmpty(); @@ -1120,7 +1120,7 @@ void RenderWidgetHostViewAndroid::SwapDelegatedFrame( } void RenderWidgetHostViewAndroid::InternalSwapCompositorFrame( - uint32 output_surface_id, + uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) { last_scroll_offset_ = frame->metadata.root_scroll_offset; if (!frame->delegated_frame_data) { @@ -1160,7 +1160,7 @@ void RenderWidgetHostViewAndroid::InternalSwapCompositorFrame( } void RenderWidgetHostViewAndroid::OnSwapCompositorFrame( - uint32 output_surface_id, + uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) { InternalSwapCompositorFrame(output_surface_id, frame.Pass()); } @@ -1170,7 +1170,7 @@ void RenderWidgetHostViewAndroid::ClearCompositorFrame() { } void RenderWidgetHostViewAndroid::RetainFrame( - uint32 output_surface_id, + uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) { DCHECK(locks_on_frame_count_); @@ -1457,7 +1457,7 @@ void RenderWidgetHostViewAndroid::RemoveLayers() { content_view_core_->RemoveLayer(layer_); } -void RenderWidgetHostViewAndroid::RequestVSyncUpdate(uint32 requests) { +void RenderWidgetHostViewAndroid::RequestVSyncUpdate(uint32_t requests) { bool should_request_vsync = !outstanding_vsync_requests_ && requests; outstanding_vsync_requests_ |= requests; @@ -1483,7 +1483,7 @@ void RenderWidgetHostViewAndroid::StartObservingRootWindow() { content_view_core_window_android_->AddObserver(this); // Clear existing vsync requests to allow a request to the new window. - uint32 outstanding_vsync_requests = outstanding_vsync_requests_; + uint32_t outstanding_vsync_requests = outstanding_vsync_requests_; outstanding_vsync_requests_ = 0; RequestVSyncUpdate(outstanding_vsync_requests); } @@ -1916,7 +1916,7 @@ void RenderWidgetHostViewAndroid::OnVSync(base::TimeTicks frame_time, // This allows for SendBeginFrame and FlushInput to modify // outstanding_vsync_requests. - uint32 outstanding_vsync_requests = outstanding_vsync_requests_; + uint32_t outstanding_vsync_requests = outstanding_vsync_requests_; outstanding_vsync_requests_ = 0; RequestVSyncUpdate(outstanding_vsync_requests); } @@ -2000,7 +2000,7 @@ void RenderWidgetHostViewAndroid::PrepareTextureCopyOutputResult( scoped_ptr<SkAutoLockPixels> bitmap_pixels_lock( new SkAutoLockPixels(*bitmap)); - uint8* pixels = static_cast<uint8*>(bitmap->getPixels()); + uint8_t* pixels = static_cast<uint8_t*>(bitmap->getPixels()); cc::TextureMailbox texture_mailbox; scoped_ptr<cc::SingleReleaseCallback> release_callback; diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h index 49d7a61..0d51b70 100644 --- a/content/browser/renderer_host/render_widget_host_view_android.h +++ b/content/browser/renderer_host/render_widget_host_view_android.h @@ -5,12 +5,16 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_ +#include <stddef.h> +#include <stdint.h> + #include <map> #include <queue> #include "base/callback.h" #include "base/compiler_specific.h" #include "base/i18n/rtl.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "base/process/process.h" @@ -26,8 +30,8 @@ #include "content/common/content_export.h" #include "content/public/browser/readback_types.h" #include "gpu/command_buffer/common/mailbox.h" -#include "third_party/skia/include/core/SkColor.h" #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h" +#include "third_party/skia/include/core/SkColor.h" #include "ui/android/window_android_observer.h" #include "ui/events/gesture_detection/filtered_gesture_provider.h" #include "ui/gfx/geometry/size.h" @@ -148,7 +152,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid BrowserAccessibilityDelegate* delegate) override; bool LockMouse() override; void UnlockMouse() override; - void OnSwapCompositorFrame(uint32 output_surface_id, + void OnSwapCompositorFrame(uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) override; void ClearCompositorFrame() override; void DidOverscroll(const DidOverscrollParams& params) override; @@ -262,12 +266,12 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid void RunAckCallbacks(cc::SurfaceDrawStatus status); void DestroyDelegatedContent(); - void CheckOutputSurfaceChanged(uint32 output_surface_id); + void CheckOutputSurfaceChanged(uint32_t output_surface_id); void SubmitCompositorFrame(scoped_ptr<cc::CompositorFrame> frame_data); - void SwapDelegatedFrame(uint32 output_surface_id, + void SwapDelegatedFrame(uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame_data); - void SendDelegatedFrameAck(uint32 output_surface_id); - void SendReturnedDelegatedResources(uint32 output_surface_id); + void SendDelegatedFrameAck(uint32_t output_surface_id); + void SendReturnedDelegatedResources(uint32_t output_surface_id); void OnFrameMetadataUpdated( const cc::CompositorFrameMetadata& frame_metadata); @@ -308,10 +312,10 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid // Drop any incoming frames from the renderer when there are locks on the // current frame. - void RetainFrame(uint32 output_surface_id, + void RetainFrame(uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame); - void InternalSwapCompositorFrame(uint32 output_surface_id, + void InternalSwapCompositorFrame(uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame); void OnLostResources(); @@ -320,7 +324,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid BEGIN_FRAME = 1 << 1, PERSISTENT_BEGIN_FRAME = 1 << 2 }; - void RequestVSyncUpdate(uint32 requests); + void RequestVSyncUpdate(uint32_t requests); void StartObservingRootWindow(); void StopObservingRootWindow(); void SendBeginFrame(base::TimeTicks frame_time, base::TimeDelta vsync_period); @@ -335,7 +339,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid bool use_surfaces_; // Used to control action dispatch at the next |OnVSync()| call. - uint32 outstanding_vsync_requests_; + uint32_t outstanding_vsync_requests_; bool is_showing_; @@ -405,10 +409,10 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid bool observing_root_window_; struct LastFrameInfo { - LastFrameInfo(uint32 output_id, + LastFrameInfo(uint32_t output_id, scoped_ptr<cc::CompositorFrame> output_frame); ~LastFrameInfo(); - uint32 output_surface_id; + uint32_t output_surface_id; scoped_ptr<cc::CompositorFrame> frame; }; diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc index 954549e..9834f89 100644 --- a/content/browser/renderer_host/render_widget_host_view_aura.cc +++ b/content/browser/renderer_host/render_widget_host_view_aura.cc @@ -8,14 +8,15 @@ #include <utility> #include "base/auto_reset.h" -#include "base/basictypes.h" #include "base/bind.h" #include "base/callback_helpers.h" #include "base/command_line.h" #include "base/logging.h" +#include "base/macros.h" #include "base/message_loop/message_loop.h" #include "base/strings/string_number_conversions.h" #include "base/trace_event/trace_event.h" +#include "build/build_config.h" #include "cc/layers/layer.h" #include "cc/output/copy_output_request.h" #include "cc/output/copy_output_result.h" @@ -1206,7 +1207,7 @@ void RenderWidgetHostViewAura::OnLegacyWindowDestroyed() { #endif void RenderWidgetHostViewAura::OnSwapCompositorFrame( - uint32 output_surface_id, + uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) { TRACE_EVENT0("content", "RenderWidgetHostViewAura::OnSwapCompositorFrame"); @@ -1729,7 +1730,7 @@ gfx::Rect RenderWidgetHostViewAura::GetCaretBounds() const { } bool RenderWidgetHostViewAura::GetCompositionCharacterBounds( - uint32 index, + uint32_t index, gfx::Rect* rect) const { DCHECK(rect); if (index >= composition_character_bounds_.size()) diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h index 6617b4b..e5d4b23 100644 --- a/content/browser/renderer_host/render_widget_host_view_aura.h +++ b/content/browser/renderer_host/render_widget_host_view_aura.h @@ -5,6 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ +#include <stddef.h> +#include <stdint.h> + #include <map> #include <set> #include <string> @@ -12,10 +15,12 @@ #include "base/callback.h" #include "base/gtest_prod_util.h" +#include "base/macros.h" #include "base/memory/linked_ptr.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" +#include "build/build_config.h" #include "content/browser/accessibility/browser_accessibility_manager.h" #include "content/browser/compositor/delegated_frame_host.h" #include "content/browser/compositor/image_transport_factory.h" @@ -180,7 +185,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura const SkBitmap& zoomed_bitmap) override; bool LockMouse() override; void UnlockMouse() override; - void OnSwapCompositorFrame(uint32 output_surface_id, + void OnSwapCompositorFrame(uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) override; void ClearCompositorFrame() override; void DidStopFlinging() override; @@ -215,7 +220,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura int GetTextInputFlags() const override; bool CanComposeInline() const override; gfx::Rect GetCaretBounds() const override; - bool GetCompositionCharacterBounds(uint32 index, + bool GetCompositionCharacterBounds(uint32_t index, gfx::Rect* rect) const override; bool HasCompositionText() const override; bool GetTextRange(gfx::Range* range) const override; diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc index bab8c0c..8de1e73 100644 --- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc +++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc @@ -4,13 +4,17 @@ #include "content/browser/renderer_host/render_widget_host_view_aura.h" -#include "base/basictypes.h" +#include <stddef.h> +#include <stdint.h> + #include "base/command_line.h" +#include "base/macros.h" #include "base/memory/shared_memory.h" #include "base/message_loop/message_loop.h" #include "base/run_loop.h" #include "base/strings/utf_string_conversions.h" #include "base/test/simple_test_tick_clock.h" +#include "build/build_config.h" #include "cc/output/begin_frame_args.h" #include "cc/output/compositor_frame.h" #include "cc/output/compositor_frame_metadata.h" @@ -235,7 +239,7 @@ class FakeWindowEventDispatcher : public aura::WindowEventDispatcher { : WindowEventDispatcher(host), processed_touch_event_count_(0) {} - void ProcessedTouchEvent(uint32 unique_event_id, + void ProcessedTouchEvent(uint32_t unique_event_id, aura::Window* window, ui::EventResult result) override { WindowEventDispatcher::ProcessedTouchEvent(unique_event_id, window, result); @@ -396,7 +400,7 @@ class RenderWidgetHostViewAuraTest : public testing::Test { sink_ = &process_host_->sink(); - int32 routing_id = process_host_->GetNextRoutingID(); + int32_t routing_id = process_host_->GetNextRoutingID(); parent_host_ = new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false); parent_view_ = new RenderWidgetHostViewAura(parent_host_, @@ -474,7 +478,7 @@ class RenderWidgetHostViewAuraTest : public testing::Test { void SendTouchEventACK(WebInputEvent::Type type, InputEventAckState ack_result, - uint32 event_id) { + uint32_t event_id) { DCHECK(WebInputEvent::isTouchEventType(type)); InputEventAck ack(type, ack_result, event_id); InputHostMsg_HandleInputEvent_ACK response(0, ack); @@ -734,8 +738,8 @@ class RenderWidgetHostViewAuraOverscrollTest return overscroll_delegate_.get(); } - uint32 SendTouchEvent() { - uint32 touch_event_id = touch_event_.uniqueTouchEventId; + uint32_t SendTouchEvent() { + uint32_t touch_event_id = touch_event_.uniqueTouchEventId; widget_host_->ForwardTouchEventWithLatencyInfo(touch_event_, ui::LatencyInfo()); touch_event_.ResetPoints(); @@ -1726,7 +1730,7 @@ TEST_F(RenderWidgetHostViewAuraTest, Resize) { root_window->GetHost()->compositor()); bool has_resize = false; - for (uint32 i = 0; i < sink_->message_count(); ++i) { + for (uint32_t i = 0; i < sink_->message_count(); ++i) { const IPC::Message* msg = sink_->GetMessageAt(i); switch (msg->type()) { case InputMsg_HandleInputEvent::ID: { @@ -1913,7 +1917,7 @@ TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFrames) { // Create a bunch of renderers. for (size_t i = 0; i < renderer_count; ++i) { - int32 routing_id = process_host_->GetNextRoutingID(); + int32_t routing_id = process_host_->GetNextRoutingID(); hosts[i] = new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false); hosts[i]->Init(); @@ -2077,7 +2081,7 @@ TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFramesWithLocking) { // Create a bunch of renderers. for (size_t i = 0; i < renderer_count; ++i) { - int32 routing_id = process_host_->GetNextRoutingID(); + int32_t routing_id = process_host_->GetNextRoutingID(); hosts[i] = new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false); hosts[i]->Init(); @@ -2146,7 +2150,7 @@ TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFramesWithMemoryPressure) { // Create a bunch of renderers. for (size_t i = 0; i < renderer_count; ++i) { - int32 routing_id = process_host_->GetNextRoutingID(); + int32_t routing_id = process_host_->GetNextRoutingID(); hosts[i] = new RenderWidgetHostImpl(&delegate_, process_host_, routing_id, false); hosts[i]->Init(); @@ -3015,13 +3019,13 @@ TEST_F(RenderWidgetHostViewAuraOverscrollTest, OverscrollWithTouchEvents) { // The test sends an intermingled sequence of touch and gesture events. PressTouchPoint(0, 1); - uint32 touch_press_event_id1 = SendTouchEvent(); + uint32_t touch_press_event_id1 = SendTouchEvent(); SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_NOT_CONSUMED, touch_press_event_id1); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); MoveTouchPoint(0, 20, 5); - uint32 touch_move_event_id1 = SendTouchEvent(); + uint32_t touch_move_event_id1 = SendTouchEvent(); SendTouchEventACK(WebInputEvent::TouchMove, INPUT_EVENT_ACK_STATE_NOT_CONSUMED, touch_move_event_id1); EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc index 1c07d7d..a2a0884 100644 --- a/content/browser/renderer_host/render_widget_host_view_base.cc +++ b/content/browser/renderer_host/render_widget_host_view_base.cc @@ -5,6 +5,7 @@ #include "content/browser/renderer_host/render_widget_host_view_base.h" #include "base/logging.h" +#include "build/build_config.h" #include "content/browser/accessibility/browser_accessibility_manager.h" #include "content/browser/gpu/gpu_data_manager_impl.h" #include "content/browser/renderer_host/input/synthetic_gesture_target_base.h" @@ -568,7 +569,7 @@ void RenderWidgetHostViewBase::EndFrameSubscription() { NOTREACHED(); } -uint32 RenderWidgetHostViewBase::RendererFrameNumber() { +uint32_t RenderWidgetHostViewBase::RendererFrameNumber() { return renderer_frame_number_; } diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h index 33d3b67..d714137 100644 --- a/content/browser/renderer_host/render_widget_host_view_base.h +++ b/content/browser/renderer_host/render_widget_host_view_base.h @@ -5,13 +5,18 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ +#include <stddef.h> +#include <stdint.h> + #include <string> #include <vector> #include "base/callback_forward.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/process/kill.h" #include "base/timer/timer.h" +#include "build/build_config.h" #include "cc/output/compositor_frame.h" #include "content/browser/renderer_host/event_with_latency_info.h" #include "content/common/content_export.h" @@ -92,7 +97,7 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView, // Return a value that is incremented each time the renderer swaps a new frame // to the view. - uint32 RendererFrameNumber(); + uint32_t RendererFrameNumber(); // Called each time the RenderWidgetHost receives a new frame for display from // the renderer. @@ -162,7 +167,7 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView, // Informs that the focused DOM node has changed. virtual void FocusedNodeChanged(bool is_editable_node) {} - virtual void OnSwapCompositorFrame(uint32 output_surface_id, + virtual void OnSwapCompositorFrame(uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) {} // This method exists to allow removing of displayed graphics, after a new @@ -438,7 +443,7 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView, gfx::Rect current_display_area_; - uint32 renderer_frame_number_; + uint32_t renderer_frame_number_; base::OneShotTimer flush_input_timer_; diff --git a/content/browser/renderer_host/render_widget_host_view_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_browsertest.cc index 794d8ce..1c33876 100644 --- a/content/browser/renderer_host/render_widget_host_view_browsertest.cc +++ b/content/browser/renderer_host/render_widget_host_view_browsertest.cc @@ -2,13 +2,17 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/barrier_closure.h" #include "base/command_line.h" #include "base/location.h" +#include "base/macros.h" #include "base/path_service.h" #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/thread_task_runner_handle.h" +#include "build/build_config.h" #include "content/browser/gpu/compositor_util.h" #include "content/browser/gpu/gpu_data_manager_impl.h" #include "content/browser/renderer_host/dip_util.h" @@ -584,7 +588,7 @@ class CompositingRenderWidgetHostViewBrowserTestTabCapture // is allowed to transiently fail. The purpose of these tests is to // confirm correct cropping/scaling behavior; and not that every // readback must succeed. http://crbug.com/444237 - uint32 last_frame_number = 0; + uint32_t last_frame_number = 0; do { // Wait for renderer to provide the next frame. while (!GetRenderWidgetHost()->ScheduleComposite()) diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h index 0bdce70..63b4209 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.h +++ b/content/browser/renderer_host/render_widget_host_view_mac.h @@ -7,6 +7,8 @@ #import <Cocoa/Cocoa.h> #include <IOSurface/IOSurface.h> +#include <stddef.h> +#include <stdint.h> #include <list> #include <map> #include <set> @@ -322,7 +324,7 @@ class CONTENT_EXPORT RenderWidgetHostViewMac void BeginFrameSubscription( scoped_ptr<RenderWidgetHostViewFrameSubscriber> subscriber) override; void EndFrameSubscription() override; - void OnSwapCompositorFrame(uint32 output_surface_id, + void OnSwapCompositorFrame(uint32_t output_surface_id, scoped_ptr<cc::CompositorFrame> frame) override; void ClearCompositorFrame() override; BrowserAccessibilityManager* CreateBrowserAccessibilityManager( diff --git a/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h b/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h index 4a94d9f..71deadb 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h +++ b/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h @@ -5,7 +5,7 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_DICTIONARY_HELPER_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_DICTIONARY_HELPER_H_ -#include "base/basictypes.h" +#include "base/macros.h" #include "ui/gfx/geometry/vector2d.h" namespace content { diff --git a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h index 9ba16b3..9cdb0aa 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h +++ b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h @@ -7,9 +7,9 @@ #import <Cocoa/Cocoa.h> -#include "base/basictypes.h" #include "base/containers/hash_tables.h" #include "base/gtest_prod_util.h" +#include "base/macros.h" #include "content/browser/renderer_host/render_widget_host_view_mac.h" namespace content { diff --git a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm index 14ee158..25dbcfe 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm @@ -5,7 +5,9 @@ #import "content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h" #import <objc/runtime.h> +#include <stddef.h> +#include "base/macros.h" #include "content/browser/renderer_host/render_widget_host_impl.h" #import "content/browser/renderer_host/render_widget_host_view_mac.h" diff --git a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm index a6af135..dfa92c1 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm @@ -5,6 +5,8 @@ #import "content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h" #import <Cocoa/Cocoa.h> +#include <stddef.h> +#include <stdint.h> #include "base/mac/scoped_nsautorelease_pool.h" #include "base/message_loop/message_loop.h" @@ -86,7 +88,7 @@ class RenderWidgetHostEditCommandCounter : public RenderWidgetHostImpl { public: RenderWidgetHostEditCommandCounter(RenderWidgetHostDelegate* delegate, RenderProcessHost* process, - int32 routing_id) + int32_t routing_id) : RenderWidgetHostImpl(delegate, process, routing_id, false), edit_command_message_count_(0) {} @@ -124,7 +126,7 @@ TEST_F(RenderWidgetHostViewMacEditCommandHelperTest, supported_factors.push_back(ui::SCALE_FACTOR_100P); ui::test::ScopedSetSupportedScaleFactors scoped_supported(supported_factors); - int32 routing_id = process_host.GetNextRoutingID(); + int32_t routing_id = process_host.GetNextRoutingID(); RenderWidgetHostEditCommandCounter* render_widget = new RenderWidgetHostEditCommandCounter(&delegate, &process_host, routing_id); diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm index db7b5e7..ac3cb94 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm @@ -5,10 +5,13 @@ #include "content/browser/renderer_host/render_widget_host_view_mac.h" #include <Cocoa/Cocoa.h> +#include <stddef.h> +#include <stdint.h> #include "base/mac/mac_util.h" #include "base/mac/scoped_nsautorelease_pool.h" #include "base/mac/sdk_forward_declarations.h" +#include "base/macros.h" #include "base/strings/utf_string_conversions.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/compositor/test/no_transport_image_transport_factory.h" @@ -146,7 +149,7 @@ class MockRenderWidgetHostImpl : public RenderWidgetHostImpl { public: MockRenderWidgetHostImpl(RenderWidgetHostDelegate* delegate, RenderProcessHost* process, - int32 routing_id) + int32_t routing_id) : RenderWidgetHostImpl(delegate, process, routing_id, false) {} MOCK_METHOD0(Focus, void()); @@ -292,7 +295,7 @@ TEST_F(RenderWidgetHostViewMacTest, FullscreenCloseOnEscape) { TestBrowserContext browser_context; MockRenderProcessHost* process_host = new MockRenderProcessHost(&browser_context); - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); // Owned by its |cocoa_view()|. RenderWidgetHostImpl* rwh = new RenderWidgetHostImpl(&delegate, process_host, routing_id, false); @@ -326,7 +329,7 @@ TEST_F(RenderWidgetHostViewMacTest, AcceleratorDestroy) { TestBrowserContext browser_context; MockRenderProcessHost* process_host = new MockRenderProcessHost(&browser_context); - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); // Owned by its |cocoa_view()|. RenderWidgetHostImpl* rwh = new RenderWidgetHostImpl(&delegate, process_host, routing_id, false); @@ -355,7 +358,7 @@ TEST_F(RenderWidgetHostViewMacTest, FilterNonPrintableCharacter) { new MockRenderProcessHost(&browser_context); process_host->Init(); MockRenderWidgetHostDelegate delegate; - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); MockRenderWidgetHostImpl* host = new MockRenderWidgetHostImpl(&delegate, process_host, routing_id); RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false); @@ -753,7 +756,7 @@ TEST_F(RenderWidgetHostViewMacTest, BlurAndFocusOnSetActive) { new MockRenderProcessHost(&browser_context); // Owned by its |cocoa_view()|. - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); MockRenderWidgetHostImpl* rwh = new MockRenderWidgetHostImpl(&delegate, process_host, routing_id); RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(rwh, false); @@ -801,7 +804,7 @@ TEST_F(RenderWidgetHostViewMacTest, ScrollWheelEndEventDelivery) { new MockRenderProcessHost(&browser_context); process_host->Init(); MockRenderWidgetHostDelegate delegate; - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); MockRenderWidgetHostImpl* host = new MockRenderWidgetHostImpl(&delegate, process_host, routing_id); RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false); @@ -842,7 +845,7 @@ TEST_F(RenderWidgetHostViewMacTest, IgnoreEmptyUnhandledWheelEvent) { new MockRenderProcessHost(&browser_context); process_host->Init(); MockRenderWidgetHostDelegate delegate; - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); MockRenderWidgetHostImpl* host = new MockRenderWidgetHostImpl(&delegate, process_host, routing_id); RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false); @@ -893,7 +896,7 @@ TEST_F(RenderWidgetHostViewMacTest, GuestViewDoesNotLeak) { TestBrowserContext browser_context; MockRenderProcessHost* process_host = new MockRenderProcessHost(&browser_context); - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); // Owned by its |cocoa_view()|. MockRenderWidgetHostImpl* rwh = @@ -936,7 +939,7 @@ TEST_F(RenderWidgetHostViewMacTest, Background) { MockRenderProcessHost* process_host = new MockRenderProcessHost(&browser_context); MockRenderWidgetHostDelegate delegate; - int32 routing_id = process_host->GetNextRoutingID(); + int32_t routing_id = process_host->GetNextRoutingID(); MockRenderWidgetHostImpl* host = new MockRenderWidgetHostImpl(&delegate, process_host, routing_id); RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false); @@ -1013,7 +1016,7 @@ TEST_F(RenderWidgetHostViewMacPinchTest, PinchThresholding) { process_host_ = new MockRenderProcessHost(&browser_context); process_host_->Init(); MockRenderWidgetHostDelegate delegate; - int32 routing_id = process_host_->GetNextRoutingID(); + int32_t routing_id = process_host_->GetNextRoutingID(); MockRenderWidgetHostImpl* host = new MockRenderWidgetHostImpl(&delegate, process_host_, routing_id); RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false); diff --git a/content/browser/renderer_host/render_widget_host_view_mus.cc b/content/browser/renderer_host/render_widget_host_view_mus.cc index b1822ef..cb35976 100644 --- a/content/browser/renderer_host/render_widget_host_view_mus.cc +++ b/content/browser/renderer_host/render_widget_host_view_mus.cc @@ -4,6 +4,7 @@ #include "content/browser/renderer_host/render_widget_host_view_mus.h" +#include "build/build_config.h" #include "components/mus/public/cpp/window.h" #include "components/mus/public/cpp/window_tree_connection.h" #include "content/browser/mojo/mojo_shell_client_host.h" diff --git a/content/browser/renderer_host/render_widget_host_view_mus.h b/content/browser/renderer_host/render_widget_host_view_mus.h index ca110e8..0db6d73 100644 --- a/content/browser/renderer_host/render_widget_host_view_mus.h +++ b/content/browser/renderer_host/render_widget_host_view_mus.h @@ -5,7 +5,10 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MUS_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MUS_H_ +#include <stddef.h> + #include "base/macros.h" +#include "build/build_config.h" #include "components/mus/public/cpp/scoped_window_ptr.h" #include "components/mus/public/cpp/window.h" #include "content/browser/renderer_host/render_widget_host_view_base.h" diff --git a/content/browser/renderer_host/renderer_frame_manager.cc b/content/browser/renderer_host/renderer_frame_manager.cc index 3467781..3f2281f 100644 --- a/content/browser/renderer_host/renderer_frame_manager.cc +++ b/content/browser/renderer_host/renderer_frame_manager.cc @@ -12,6 +12,7 @@ #include "base/memory/memory_pressure_monitor.h" #include "base/memory/shared_memory.h" #include "base/sys_info.h" +#include "build/build_config.h" #include "content/common/host_shared_bitmap_manager.h" namespace content { diff --git a/content/browser/renderer_host/renderer_frame_manager.h b/content/browser/renderer_host/renderer_frame_manager.h index f8d4a9c..8738548 100644 --- a/content/browser/renderer_host/renderer_frame_manager.h +++ b/content/browser/renderer_host/renderer_frame_manager.h @@ -5,10 +5,12 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDERER_FRAME_MANAGER_H_ #define CONTENT_BROWSER_RENDERER_HOST_RENDERER_FRAME_MANAGER_H_ +#include <stddef.h> + #include <list> #include <map> -#include "base/basictypes.h" +#include "base/macros.h" #include "base/memory/memory_pressure_listener.h" #include "base/memory/singleton.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/sandbox_ipc_linux.cc b/content/browser/renderer_host/sandbox_ipc_linux.cc index b77ec14..3603d1f 100644 --- a/content/browser/renderer_host/sandbox_ipc_linux.cc +++ b/content/browser/renderer_host/sandbox_ipc_linux.cc @@ -5,11 +5,12 @@ #include "content/browser/renderer_host/sandbox_ipc_linux.h" #include <fcntl.h> +#include <stddef.h> +#include <stdint.h> #include <sys/poll.h> #include <sys/socket.h> #include <sys/stat.h> -#include "base/basictypes.h" #include "base/command_line.h" #include "base/files/scoped_file.h" #include "base/linux_util.h" @@ -286,7 +287,7 @@ void SandboxIPCHandler::HandleGetStyleForStrike( const std::vector<base::ScopedFD>& fds) { std::string family; bool bold, italic; - uint16 pixel_size; + uint16_t pixel_size; if (!iter.ReadString(&family) || !iter.ReadBool(&bold) || @@ -373,7 +374,7 @@ void SandboxIPCHandler::HandleMatchWithFallback( const std::vector<base::ScopedFD>& fds) { std::string face; bool is_bold, is_italic; - uint32 charset, fallback_family; + uint32_t charset, fallback_family; if (!iter.ReadString(&face) || face.empty() || !iter.ReadBool(&is_bold) || diff --git a/content/browser/renderer_host/sandbox_ipc_linux.h b/content/browser/renderer_host/sandbox_ipc_linux.h index 0d647049..a11a878 100644 --- a/content/browser/renderer_host/sandbox_ipc_linux.h +++ b/content/browser/renderer_host/sandbox_ipc_linux.h @@ -10,6 +10,7 @@ #include <vector> #include "base/files/scoped_file.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/pickle.h" #include "base/threading/simple_thread.h" diff --git a/content/browser/renderer_host/text_input_client_mac.h b/content/browser/renderer_host/text_input_client_mac.h index 4f03a93..eeb48a8 100644 --- a/content/browser/renderer_host/text_input_client_mac.h +++ b/content/browser/renderer_host/text_input_client_mac.h @@ -9,6 +9,7 @@ #include "base/mac/scoped_block.h" #include "base/mac/scoped_nsobject.h" +#include "base/macros.h" #include "base/synchronization/condition_variable.h" #include "base/synchronization/lock.h" #include "content/common/content_export.h" diff --git a/content/browser/renderer_host/text_input_client_mac_unittest.mm b/content/browser/renderer_host/text_input_client_mac_unittest.mm index 7078266..aa265fca 100644 --- a/content/browser/renderer_host/text_input_client_mac_unittest.mm +++ b/content/browser/renderer_host/text_input_client_mac_unittest.mm @@ -4,6 +4,9 @@ #import "content/browser/renderer_host/text_input_client_mac.h" +#include <stddef.h> +#include <stdint.h> + #include "base/bind.h" #include "base/message_loop/message_loop.h" #include "base/threading/thread.h" @@ -21,7 +24,7 @@ namespace content { namespace { -const int64 kTaskDelayMs = 200; +const int64_t kTaskDelayMs = 200; class MockRenderWidgetHostDelegate : public RenderWidgetHostDelegate { public: @@ -47,7 +50,7 @@ class TextInputClientMacTest : public testing::Test { thread_("TextInputClientMacTestThread") { RenderProcessHost* rph = process_factory_.CreateRenderProcessHost(&browser_context_, nullptr); - int32 routing_id = rph->GetNextRoutingID(); + int32_t routing_id = rph->GetNextRoutingID(); widget_.reset(new RenderWidgetHostImpl(&delegate_, rph, routing_id, false)); } diff --git a/content/browser/renderer_host/text_input_client_message_filter.h b/content/browser/renderer_host/text_input_client_message_filter.h index 992a9a2..9400065 100644 --- a/content/browser/renderer_host/text_input_client_message_filter.h +++ b/content/browser/renderer_host/text_input_client_message_filter.h @@ -5,6 +5,9 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_CLIENT_MESSAGE_FILTER_H_ #define CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_CLIENT_MESSAGE_FILTER_H_ +#include <stddef.h> + +#include "base/macros.h" #include "content/common/mac/attributed_string_coder.h" #include "content/public/browser/browser_message_filter.h" diff --git a/content/browser/renderer_host/ui_events_helper.cc b/content/browser/renderer_host/ui_events_helper.cc index e3dc565..a062303 100644 --- a/content/browser/renderer_host/ui_events_helper.cc +++ b/content/browser/renderer_host/ui_events_helper.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/ui_events_helper.h" +#include <stdint.h> + #include "content/browser/renderer_host/input/web_input_event_util.h" #include "content/common/input/web_touch_event_traits.h" #include "third_party/WebKit/public/web/WebInputEvent.h" @@ -63,7 +65,7 @@ bool MakeUITouchEventsFromWebTouchEvents( int flags = WebEventModifiersToEventFlags(touch.modifiers); base::TimeDelta timestamp = base::TimeDelta::FromMicroseconds( - static_cast<int64>(touch.timeStampSeconds * 1000000)); + static_cast<int64_t>(touch.timeStampSeconds * 1000000)); for (unsigned i = 0; i < touch.touchesLength; ++i) { const blink::WebTouchPoint& point = touch.touches[i]; if (WebTouchPointStateToEventType(point.state) != type) diff --git a/content/browser/renderer_host/web_input_event_aura.cc b/content/browser/renderer_host/web_input_event_aura.cc index 7d67025a..79dda38 100644 --- a/content/browser/renderer_host/web_input_event_aura.cc +++ b/content/browser/renderer_host/web_input_event_aura.cc @@ -4,6 +4,7 @@ #include "content/browser/renderer_host/web_input_event_aura.h" +#include "build/build_config.h" #include "content/browser/renderer_host/input/web_input_event_util.h" #include "content/browser/renderer_host/ui_events_helper.h" #include "ui/aura/client/screen_position_client.h" diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc index ae4a99c..2d46dfb 100644 --- a/content/browser/renderer_host/web_input_event_aura_unittest.cc +++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc @@ -4,7 +4,11 @@ #include "content/browser/renderer_host/web_input_event_aura.h" -#include "base/basictypes.h" +#include <stddef.h> +#include <stdint.h> + +#include "base/macros.h" +#include "build/build_config.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/events/blink/blink_event_util.h" #include "ui/events/event.h" @@ -161,7 +165,7 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEventKeyPadKeyCode) { struct TestCase { ui::DomCode dom_code; // The physical key (location). ui::KeyboardCode ui_keycode; // The virtual key code. - uint32 x_keysym; // The X11 keysym. + uint32_t x_keysym; // The X11 keysym. bool expected_result; // true if the event has "isKeyPad" modifier. } kTesCases[] = { {ui::DomCode::DIGIT0, ui::VKEY_0, XK(0), false}, diff --git a/content/browser/renderer_host/webmenurunner_mac.mm b/content/browser/renderer_host/webmenurunner_mac.mm index 94e77453..0e189be 100644 --- a/content/browser/renderer_host/webmenurunner_mac.mm +++ b/content/browser/renderer_host/webmenurunner_mac.mm @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/webmenurunner_mac.h" +#include <stddef.h> + #include "base/strings/sys_string_conversions.h" @interface WebMenuRunner (PrivateAPI) diff --git a/content/browser/renderer_host/websocket_dispatcher_host.cc b/content/browser/renderer_host/websocket_dispatcher_host.cc index ab4e68b..0cdf663 100644 --- a/content/browser/renderer_host/websocket_dispatcher_host.cc +++ b/content/browser/renderer_host/websocket_dispatcher_host.cc @@ -4,6 +4,8 @@ #include "content/browser/renderer_host/websocket_dispatcher_host.h" +#include <stddef.h> + #include <string> #include <vector> @@ -131,8 +133,8 @@ WebSocketHost* WebSocketDispatcherHost::GetHost(int routing_id) const { } WebSocketHostState WebSocketDispatcherHost::SendOrDrop(IPC::Message* message) { - const uint32 message_type = message->type(); - const int32 message_routing_id = message->routing_id(); + const uint32_t message_type = message->type(); + const int32_t message_routing_id = message->routing_id(); if (!Send(message)) { message = NULL; DVLOG(1) << "Sending of message type " << message_type @@ -168,7 +170,7 @@ WebSocketHostState WebSocketDispatcherHost::SendFrame( } WebSocketHostState WebSocketDispatcherHost::SendFlowControl(int routing_id, - int64 quota) { + int64_t quota) { return SendOrDrop(new WebSocketMsg_FlowControl(routing_id, quota)); } @@ -203,7 +205,7 @@ WebSocketHostState WebSocketDispatcherHost::NotifyFailure( WebSocketHostState WebSocketDispatcherHost::DoDropChannel( int routing_id, bool was_clean, - uint16 code, + uint16_t code, const std::string& reason) { if (SendOrDrop( new WebSocketMsg_DropChannel(routing_id, was_clean, code, reason)) == diff --git a/content/browser/renderer_host/websocket_dispatcher_host.h b/content/browser/renderer_host/websocket_dispatcher_host.h index 5039078..56c5f3a 100644 --- a/content/browser/renderer_host/websocket_dispatcher_host.h +++ b/content/browser/renderer_host/websocket_dispatcher_host.h @@ -12,6 +12,7 @@ #include "base/callback.h" #include "base/compiler_specific.h" #include "base/containers/hash_tables.h" +#include "base/macros.h" #include "base/time/time.h" #include "base/timer/timer.h" #include "content/common/content_export.h" @@ -74,7 +75,7 @@ class CONTENT_EXPORT WebSocketDispatcherHost : public BrowserMessageFilter { // Sends a WebSocketMsg_FlowControl IPC. WebSocketHostState SendFlowControl(int routing_id, - int64 quota) WARN_UNUSED_RESULT; + int64_t quota) WARN_UNUSED_RESULT; // Sends a WebSocketMsg_NotifyClosing IPC WebSocketHostState NotifyClosingHandshake(int routing_id) WARN_UNUSED_RESULT; @@ -97,11 +98,11 @@ class CONTENT_EXPORT WebSocketDispatcherHost : public BrowserMessageFilter { // Sends a WebSocketMsg_DropChannel IPC and deletes and unregisters the // channel. - WebSocketHostState DoDropChannel( - int routing_id, - bool was_clean, - uint16 code, - const std::string& reason) WARN_UNUSED_RESULT; + WebSocketHostState DoDropChannel(int routing_id, + bool was_clean, + uint16_t code, + const std::string& reason) + WARN_UNUSED_RESULT; // Returns whether the associated renderer process can read raw cookies. bool CanReadRawCookies() const; diff --git a/content/browser/renderer_host/websocket_host.cc b/content/browser/renderer_host/websocket_host.cc index 8c04e04..f032282 100644 --- a/content/browser/renderer_host/websocket_host.cc +++ b/content/browser/renderer_host/websocket_host.cc @@ -4,8 +4,8 @@ #include "content/browser/renderer_host/websocket_host.h" -#include "base/basictypes.h" #include "base/location.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "base/single_thread_task_runner.h" #include "base/strings/string_util.h" @@ -102,9 +102,9 @@ class WebSocketEventHandler : public net::WebSocketEventInterface { WebSocketMessageType type, const std::vector<char>& data) override; ChannelState OnClosingHandshake() override; - ChannelState OnFlowControl(int64 quota) override; + ChannelState OnFlowControl(int64_t quota) override; ChannelState OnDropChannel(bool was_clean, - uint16 code, + uint16_t code, const std::string& reason) override; ChannelState OnFailChannel(const std::string& message) override; ChannelState OnStartOpeningHandshake( @@ -189,7 +189,7 @@ ChannelState WebSocketEventHandler::OnClosingHandshake() { return StateCast(dispatcher_->NotifyClosingHandshake(routing_id_)); } -ChannelState WebSocketEventHandler::OnFlowControl(int64 quota) { +ChannelState WebSocketEventHandler::OnFlowControl(int64_t quota) { DVLOG(3) << "WebSocketEventHandler::OnFlowControl" << " routing_id=" << routing_id_ << " quota=" << quota; @@ -197,7 +197,7 @@ ChannelState WebSocketEventHandler::OnFlowControl(int64 quota) { } ChannelState WebSocketEventHandler::OnDropChannel(bool was_clean, - uint16 code, + uint16_t code, const std::string& reason) { DVLOG(3) << "WebSocketEventHandler::OnDropChannel" << " routing_id=" << routing_id_ << " was_clean=" << was_clean @@ -327,7 +327,8 @@ WebSocketHost::WebSocketHost(int routing_id, WebSocketHost::~WebSocketHost() {} void WebSocketHost::GoAway() { - OnDropChannel(false, static_cast<uint16>(net::kWebSocketErrorGoingAway), ""); + OnDropChannel(false, static_cast<uint16_t>(net::kWebSocketErrorGoingAway), + ""); } bool WebSocketHost::OnMessageReceived(const IPC::Message& message) { @@ -412,7 +413,7 @@ void WebSocketHost::OnSendFrame(bool fin, channel_->SendFrame(fin, MessageTypeToOpCode(type), data); } -void WebSocketHost::OnFlowControl(int64 quota) { +void WebSocketHost::OnFlowControl(int64_t quota) { DVLOG(3) << "WebSocketHost::OnFlowControl" << " routing_id=" << routing_id_ << " quota=" << quota; @@ -428,7 +429,7 @@ void WebSocketHost::OnFlowControl(int64 quota) { } void WebSocketHost::OnDropChannel(bool was_clean, - uint16 code, + uint16_t code, const std::string& reason) { DVLOG(3) << "WebSocketHost::OnDropChannel" << " routing_id=" << routing_id_ << " was_clean=" << was_clean diff --git a/content/browser/renderer_host/websocket_host.h b/content/browser/renderer_host/websocket_host.h index 89b3686..efdc9d1 100644 --- a/content/browser/renderer_host/websocket_host.h +++ b/content/browser/renderer_host/websocket_host.h @@ -5,9 +5,12 @@ #ifndef CONTENT_BROWSER_RENDERER_HOST_WEBSOCKET_HOST_H_ #define CONTENT_BROWSER_RENDERER_HOST_WEBSOCKET_HOST_H_ +#include <stdint.h> + #include <string> #include <vector> +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "base/time/time.h" @@ -74,9 +77,9 @@ class CONTENT_EXPORT WebSocketHost { WebSocketMessageType type, const std::vector<char>& data); - void OnFlowControl(int64 quota); + void OnFlowControl(int64_t quota); - void OnDropChannel(bool was_clean, uint16 code, const std::string& reason); + void OnDropChannel(bool was_clean, uint16_t code, const std::string& reason); // The channel we use to send events to the network. scoped_ptr<net::WebSocketChannel> channel_; |