diff options
author | scr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 01:50:24 +0000 |
---|---|---|
committer | scr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 01:50:24 +0000 |
commit | b57736b2025221e88d2083e32e169589371b0898 (patch) | |
tree | 9a77e0453364d4ce98629fc555b3ad628fb8737f | |
parent | bf9cd1217599a49ba1ec9591d043b4efe8b6cb3b (diff) | |
download | chromium_src-b57736b2025221e88d2083e32e169589371b0898.zip chromium_src-b57736b2025221e88d2083e32e169589371b0898.tar.gz chromium_src-b57736b2025221e88d2083e32e169589371b0898.tar.bz2 |
Coverity Fixlets: CHECKED_RETURNs
CID=15628,1968,3877
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6674006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77754 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/sessions/session_backend.cc | 8 | ||||
-rw-r--r-- | chrome/renderer/net/predictor_queue.cc | 6 | ||||
-rw-r--r-- | chrome/renderer/net/predictor_queue.h | 6 | ||||
-rw-r--r-- | chrome/renderer/pepper_platform_context_3d_impl.cc | 6 |
4 files changed, 13 insertions, 13 deletions
diff --git a/chrome/browser/sessions/session_backend.cc b/chrome/browser/sessions/session_backend.cc index 314e427..bcdb8fc 100644 --- a/chrome/browser/sessions/session_backend.cc +++ b/chrome/browser/sessions/session_backend.cc @@ -10,6 +10,7 @@ #include "base/metrics/histogram.h" #include "base/scoped_vector.h" #include "net/base/file_stream.h" +#include "net/base/net_errors.h" using base::TimeTicks; @@ -365,10 +366,9 @@ void SessionBackend::ResetFile() { net::FileStream* SessionBackend::OpenAndWriteHeader(const FilePath& path) { DCHECK(!path.empty()); scoped_ptr<net::FileStream> file(new net::FileStream()); - file->Open(path, base::PLATFORM_FILE_CREATE_ALWAYS | - base::PLATFORM_FILE_WRITE | base::PLATFORM_FILE_EXCLUSIVE_WRITE | - base::PLATFORM_FILE_EXCLUSIVE_READ); - if (!file->IsOpen()) + if (file->Open(path, base::PLATFORM_FILE_CREATE_ALWAYS | + base::PLATFORM_FILE_WRITE | base::PLATFORM_FILE_EXCLUSIVE_WRITE | + base::PLATFORM_FILE_EXCLUSIVE_READ) != net::OK) return NULL; FileHeader header; header.signature = kFileSignature; diff --git a/chrome/renderer/net/predictor_queue.cc b/chrome/renderer/net/predictor_queue.cc index 4f680ba..35023ef 100644 --- a/chrome/renderer/net/predictor_queue.cc +++ b/chrome/renderer/net/predictor_queue.cc @@ -22,6 +22,12 @@ DnsQueue::DnsQueue(BufferSize size) DnsQueue::~DnsQueue(void) { } +void DnsQueue::Clear() { + size_ = 0; + readable_ = writeable_; + DCHECK(Validate()); +} + // Push takes an unterminated string plus its length. // The string must not contain a null terminator. // Exactly length chars are written, or nothing is written. diff --git a/chrome/renderer/net/predictor_queue.h b/chrome/renderer/net/predictor_queue.h index 9e39d47..dc6fb90 100644 --- a/chrome/renderer/net/predictor_queue.h +++ b/chrome/renderer/net/predictor_queue.h @@ -48,11 +48,7 @@ class DnsQueue { ~DnsQueue(void); size_t Size() const { return size_; } - void Clear() { - size_ = 0; - readable_ = writeable_; - Validate(); - } + void Clear(); // Push takes an unterminated string of the given length // and inserts it into the queue for later diff --git a/chrome/renderer/pepper_platform_context_3d_impl.cc b/chrome/renderer/pepper_platform_context_3d_impl.cc index f48b771..95afd35 100644 --- a/chrome/renderer/pepper_platform_context_3d_impl.cc +++ b/chrome/renderer/pepper_platform_context_3d_impl.cc @@ -74,11 +74,10 @@ bool PlatformContext3DImpl::Init() { "*", attribs, parent_texture_id_); - command_buffer_->SetChannelErrorCallback(callback_factory_.NewCallback( - &PlatformContext3DImpl::OnContextLost)); - if (!command_buffer_) return false; + command_buffer_->SetChannelErrorCallback(callback_factory_.NewCallback( + &PlatformContext3DImpl::OnContextLost)); return true; } @@ -113,4 +112,3 @@ void PlatformContext3DImpl::OnContextLost() { } #endif // ENABLE_GPU - |