diff options
author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-12 01:53:30 +0000 |
---|---|---|
committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-12 01:53:30 +0000 |
commit | b62084b5b4cc4923e8007495a482839a94c3704f (patch) | |
tree | 0af405b028f7af0e751301d18cf7c8c674a8aa36 | |
parent | 6be34a67b24aef48908eeaa99643a180359309dc (diff) | |
download | chromium_src-b62084b5b4cc4923e8007495a482839a94c3704f.zip chromium_src-b62084b5b4cc4923e8007495a482839a94c3704f.tar.gz chromium_src-b62084b5b4cc4923e8007495a482839a94c3704f.tar.bz2 |
TabContentsWrapper -> TabContents, part 12.
Extensions.
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10535077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141590 0039d316-1c4b-4281-b951-d872f2087c98
68 files changed, 290 insertions, 311 deletions
diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc index 2a1c281..a139d5d 100644 --- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc +++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc @@ -14,7 +14,7 @@ #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/url_constants.h" diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc index 3eb8730..032b41f 100644 --- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc +++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc @@ -80,7 +80,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, Basic) { service->toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL); // Verify the command worked. - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); bool result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( tab->GetRenderViewHost(), L"", @@ -196,7 +196,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, BrowserActionAddPopup) { const Extension* extension = GetSingleLoadedExtension(); ASSERT_TRUE(extension) << message_; - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionAction* browser_action = extension->browser_action(); ASSERT_TRUE(browser_action) @@ -251,7 +251,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, BrowserActionRemovePopup) { const Extension* extension = GetSingleLoadedExtension(); ASSERT_TRUE(extension) << message_; - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionAction* browser_action = extension->browser_action(); ASSERT_TRUE(browser_action) diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc index 9410fc9..f5fca15 100644 --- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc +++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc @@ -13,7 +13,7 @@ #include "chrome/browser/extensions/extension_tab_helper.h" #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/profiles/profile.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_action.h" @@ -84,7 +84,7 @@ bool ExtensionActionFunction::RunImpl() { } } - // Find the TabContentsWrapper that contains this tab id if one is required. + // Find the TabContents that contains this tab id if one is required. if (tab_id_ == ExtensionAction::kDefaultTabId) { EXTENSION_FUNCTION_VALIDATE(GetExtension()->browser_action()); } else { diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.h b/chrome/browser/extensions/api/extension_action/extension_actions_api.h index f9e86d4..0f26136 100644 --- a/chrome/browser/extensions/api/extension_action/extension_actions_api.h +++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.h @@ -13,7 +13,6 @@ namespace base { class DictionaryValue; } class TabContents; -typedef TabContents TabContentsWrapper; // Implementation of both the browserAction and pageAction APIs. // @@ -45,7 +44,7 @@ class ExtensionActionFunction : public SyncExtensionFunction { int tab_id_; // Tab content for |tab_id_| if one exists. - TabContentsWrapper* contents_; + TabContents* contents_; // The extension action for the current extension. ExtensionAction* extension_action_; diff --git a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc index 52f4dd5..a5a9cbb 100644 --- a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc +++ b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc @@ -13,7 +13,7 @@ #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser_list.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_action.h" #include "chrome/common/extensions/extension_error_utils.h" @@ -75,8 +75,8 @@ bool PageActionsFunction::SetPageActionEnabled(bool enable) { return false; } - // Find the TabContentsWrapper that contains this tab id. - TabContentsWrapper* contents = NULL; + // Find the TabContents that contains this tab id. + TabContents* contents = NULL; bool result = ExtensionTabUtil::GetTabById( tab_id, profile(), include_incognito(), NULL, NULL, &contents, NULL); if (!result || !contents) { diff --git a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc index a221047..d8c2b55 100644 --- a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc +++ b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc @@ -11,7 +11,7 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/omnibox/location_bar.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_action.h" #include "chrome/test/base/ui_test_utils.h" @@ -33,7 +33,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageAction) { } // Test that we received the changes. - int tab_id = browser()->GetSelectedTabContentsWrapper()-> + int tab_id = browser()->GetActiveTabContents()-> restore_tab_helper()->session_id().id(); ExtensionAction* action = extension->page_action(); ASSERT_TRUE(action); @@ -43,7 +43,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageAction) { // Simulate the page action being clicked. ResultCatcher catcher; int tab_id = - ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionService* service = browser()->profile()->GetExtensionService(); service->browser_event_router()->PageActionExecuted( browser()->profile(), extension->id(), "", tab_id, "", 0); @@ -59,7 +59,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageAction) { } // Test that we received the changes. - tab_id = browser()->GetSelectedTabContentsWrapper()->restore_tab_helper()-> + tab_id = browser()->GetActiveTabContents()->restore_tab_helper()-> session_id().id(); EXPECT_FALSE(action->GetIcon(tab_id).isNull()); } @@ -71,7 +71,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageActionAddPopup) { const Extension* extension = GetSingleLoadedExtension(); ASSERT_TRUE(extension) << message_; - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionAction* page_action = extension->page_action(); ASSERT_TRUE(page_action) @@ -117,7 +117,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageActionRemovePopup) { const Extension* extension = GetSingleLoadedExtension(); ASSERT_TRUE(extension) << message_; - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionAction* page_action = extension->page_action(); ASSERT_TRUE(page_action) @@ -158,7 +158,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OldPageActions) { { ResultCatcher catcher; int tab_id = - ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionService* service = browser()->profile()->GetExtensionService(); service->browser_event_router()->PageActionExecuted( browser()->profile(), extension->id(), "action", tab_id, "", 1); diff --git a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc index 430596c..073138a 100644 --- a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc +++ b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc @@ -14,7 +14,7 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/omnibox/location_bar.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_action.h" @@ -72,7 +72,7 @@ IN_PROC_BROWSER_TEST_F(PageAsBrowserActionApiTest, Basic) { } // Test that we received the changes. - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionAction* action = extension->browser_action(); ASSERT_TRUE(action); EXPECT_EQ("Modified", action->GetTitle(tab_id)); @@ -104,7 +104,7 @@ IN_PROC_BROWSER_TEST_F(PageAsBrowserActionApiTest, AddPopup) { const Extension* extension = GetSingleLoadedExtension(); ASSERT_TRUE(extension) << message_; - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionAction* page_action = extension->browser_action(); ASSERT_TRUE(page_action) @@ -149,7 +149,7 @@ IN_PROC_BROWSER_TEST_F(PageAsBrowserActionApiTest, RemovePopup) { const Extension* extension = GetSingleLoadedExtension(); ASSERT_TRUE(extension) << message_; - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); ExtensionAction* page_action = extension->browser_action(); ASSERT_TRUE(page_action) diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc index 04dd125..5bb8c84 100644 --- a/chrome/browser/extensions/api/identity/identity_api.cc +++ b/chrome/browser/extensions/api/identity/identity_api.cc @@ -9,7 +9,7 @@ #include "chrome/browser/signin/token_service.h" #include "chrome/browser/signin/token_service_factory.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/extensions/extension.h" #include "googleurl/src/gurl.h" diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc index ffc8797..a5e8c17 100644 --- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc +++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc @@ -26,7 +26,7 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_window.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/window_sizer.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" @@ -67,8 +67,8 @@ class OffscreenTab : public content::NotificationObserver { Profile* profile, ParentTab* parent_tab); - TabContentsWrapper* tab_contents() const { - return tab_contents_wrapper_.get(); + TabContents* tab_contents() const { + return tab_contents_.get(); } WebContents* web_contents() const { return tab_contents()->web_contents(); @@ -98,7 +98,7 @@ class OffscreenTab : public content::NotificationObserver { const NotificationDetails& details) OVERRIDE; content::NotificationRegistrar registrar_; - scoped_ptr<TabContentsWrapper> tab_contents_wrapper_; + scoped_ptr<TabContents> tab_contents_; ParentTab* parent_tab_; DISALLOW_COPY_AND_ASSIGN(OffscreenTab); @@ -116,7 +116,7 @@ class ParentTab : public content::NotificationObserver { void Init(WebContents* web_contents, const std::string& extension_id); - TabContentsWrapper* tab_contents() { return tab_contents_wrapper_; } + TabContents* tab_contents() { return tab_contents_; } int GetID() { return ExtensionTabUtil::GetTabId(web_contents()); } WebContents* web_contents() { return tab_contents()->web_contents(); @@ -140,7 +140,7 @@ class ParentTab : public content::NotificationObserver { content::NotificationRegistrar registrar_; - TabContentsWrapper* tab_contents_wrapper_; + TabContents* tab_contents_; OffscreenTabs offscreen_tabs_; std::string extension_id_; @@ -228,7 +228,7 @@ void OffscreenTab::Init(const GURL& url, // Create the offscreen tab. WebContents* web_contents = WebContents::Create( profile, NULL, MSG_ROUTING_NONE, NULL, NULL); - tab_contents_wrapper_.reset(new TabContentsWrapper(web_contents)); + tab_contents_.reset(new TabContents(web_contents)); // Setting the size starts the renderer. SetSize(width, height); @@ -279,7 +279,7 @@ void OffscreenTab::Observe(int type, events::kOnOffscreenTabUpdated, json_args, profile, GURL()); } -ParentTab::ParentTab() : tab_contents_wrapper_(NULL) {} +ParentTab::ParentTab() : tab_contents_(NULL) {} ParentTab::~ParentTab() {} void ParentTab::Init(WebContents* web_contents, @@ -287,10 +287,9 @@ void ParentTab::Init(WebContents* web_contents, CHECK(web_contents); extension_id_ = extension_id; - tab_contents_wrapper_ = - TabContentsWrapper::GetCurrentWrapperForContents(web_contents); + tab_contents_ = TabContents::FromWebContents(web_contents); - CHECK(tab_contents_wrapper_); + CHECK(tab_contents_); // Register for tab notifications. registrar_.Add( @@ -768,7 +767,7 @@ ToDataUrlOffscreenTabFunction::ToDataUrlOffscreenTabFunction() {} ToDataUrlOffscreenTabFunction::~ToDataUrlOffscreenTabFunction() {} bool ToDataUrlOffscreenTabFunction::GetTabToCapture( - WebContents** web_contents, TabContentsWrapper** wrapper) { + WebContents** web_contents, TabContents** tab_contents) { int offscreen_tab_id; EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &offscreen_tab_id)); @@ -781,7 +780,7 @@ bool ToDataUrlOffscreenTabFunction::GetTabToCapture( return false; *web_contents = offscreen_tab->web_contents(); - *wrapper = offscreen_tab->tab_contents(); + *tab_contents = offscreen_tab->tab_contents(); return true; } diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h index 85d9d56d..844d2e3 100644 --- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h +++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h @@ -29,7 +29,6 @@ class BackingStore; class SkBitmap; class TabContents; -typedef TabContents TabContentsWrapper; namespace content { class WebContents; } // namespace content @@ -154,7 +153,7 @@ class ToDataUrlOffscreenTabFunction : public CaptureVisibleTabFunction { // CaptureVisibleTabFunction: virtual bool GetTabToCapture(content::WebContents** web_contents, - TabContentsWrapper** wrapper) OVERRIDE; + TabContents** tab_contents) OVERRIDE; private: DISALLOW_COPY_AND_ASSIGN(ToDataUrlOffscreenTabFunction); diff --git a/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc b/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc index d2e7dbc..9cd9c3f 100644 --- a/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc +++ b/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc @@ -16,7 +16,7 @@ #include "chrome/browser/extensions/script_executor.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/extensions/extension_error_utils.h" @@ -62,7 +62,7 @@ bool ExecuteCodeInTabFunction::RunImpl() { execute_tab_id_ = -1; Browser* browser = NULL; - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; // If |tab_id| is specified, look for it. Otherwise default to selected tab // in the current window. @@ -220,7 +220,7 @@ void ExecuteCodeInTabFunction::DidLoadAndLocalizeFile(bool success, } bool ExecuteCodeInTabFunction::Execute(const std::string& code_string) { - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; Browser* browser = NULL; bool success = ExtensionTabUtil::GetTabById( diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc index 96c9413..77eb4df 100644 --- a/chrome/browser/extensions/api/tabs/tabs.cc +++ b/chrome/browser/extensions/api/tabs/tabs.cc @@ -41,7 +41,7 @@ #include "chrome/browser/ui/extensions/shell_window.h" #include "chrome/browser/ui/panels/panel_manager.h" #include "chrome/browser/ui/snapshot_tab_helper.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/window_sizer.h" #include "chrome/browser/web_applications/web_app.h" @@ -181,7 +181,7 @@ bool GetTabById(int tab_id, bool include_incognito, Browser** browser, TabStripModel** tab_strip, - TabContentsWrapper** contents, + TabContents** contents, int* tab_index, std::string* error_message) { if (ExtensionTabUtil::GetTabById(tab_id, profile, include_incognito, @@ -391,7 +391,7 @@ bool CreateWindowFunction::ShouldOpenIncognitoWindow( bool CreateWindowFunction::RunImpl() { DictionaryValue* args = NULL; std::vector<GURL> urls; - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; if (HasOptionalArgument(0)) EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &args)); @@ -605,7 +605,7 @@ bool CreateWindowFunction::RunImpl() { extension_id); for (std::vector<GURL>::iterator i = urls.begin(); i != urls.end(); ++i) { - TabContentsWrapper* tab = new_window->AddSelectedTabWithURL( + TabContents* tab = new_window->AddSelectedTabWithURL( *i, content::PAGE_TRANSITION_LINK); if (window_type == Browser::TYPE_PANEL) tab->extension_tab_helper()->SetExtensionAppIconById(extension_id); @@ -807,7 +807,7 @@ bool GetSelectedTabFunction::RunImpl() { return false; TabStripModel* tab_strip = browser->tab_strip_model(); - TabContentsWrapper* contents = tab_strip->GetActiveTabContents(); + TabContents* contents = tab_strip->GetActiveTabContents(); if (!contents) { error_ = keys::kNoSelectedTabError; return false; @@ -977,7 +977,7 @@ bool CreateTabFunction::RunImpl() { EXTENSION_FUNCTION_VALIDATE(args->GetInteger( keys::kOpenerTabIdKey, &opener_id)); - TabContentsWrapper* opener_contents = NULL; + TabContents* opener_contents = NULL; if (!ExtensionTabUtil::GetTabById( opener_id, profile(), include_incognito(), NULL, NULL, &opener_contents, NULL)) @@ -1088,7 +1088,7 @@ bool GetTabFunction::RunImpl() { EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &tab_id)); TabStripModel* tab_strip = NULL; - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; int tab_index = -1; if (!GetTabById(tab_id, profile(), include_incognito(), NULL, &tab_strip, &contents, &tab_index, &error_)) @@ -1179,7 +1179,7 @@ bool UpdateTabFunction::RunImpl() { } int tab_id = -1; - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; if (tab_value == NULL || tab_value->IsType(Value::TYPE_NULL)) { Browser* browser = GetCurrentBrowser(); if (!browser) { @@ -1257,7 +1257,7 @@ bool UpdateTabFunction::RunImpl() { EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger( keys::kOpenerTabIdKey, &opener_id)); - TabContentsWrapper* opener_contents = NULL; + TabContents* opener_contents = NULL; if (!ExtensionTabUtil::GetTabById( opener_id, profile(), include_incognito(), NULL, NULL, &opener_contents, NULL)) @@ -1372,7 +1372,7 @@ bool MoveTabsFunction::RunImpl() { for (size_t i = 0; i < tab_ids.size(); ++i) { Browser* source_browser = NULL; TabStripModel* source_tab_strip = NULL; - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; int tab_index = -1; if (!GetTabById(tab_ids[i], profile(), include_incognito(), &source_browser, &source_tab_strip, &contents, @@ -1482,7 +1482,7 @@ bool ReloadTabFunction::RunImpl() { } } - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; // If |tab_id| is specified, look for it. Otherwise default to selected tab // in the current window. @@ -1535,7 +1535,7 @@ bool RemoveTabsFunction::RunImpl() { for (size_t i = 0; i < tab_ids.size(); ++i) { Browser* browser = NULL; - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; if (!GetTabById(tab_ids[i], profile(), include_incognito(), &browser, NULL, &contents, NULL, &error_)) return false; @@ -1555,7 +1555,7 @@ bool RemoveTabsFunction::RunImpl() { } bool CaptureVisibleTabFunction::GetTabToCapture( - WebContents** web_contents, TabContentsWrapper** wrapper) { + WebContents** web_contents, TabContents** tab_contents) { Browser* browser = NULL; // windowId defaults to "current" window. int window_id = extension_misc::kCurrentWindowId; @@ -1566,21 +1566,21 @@ bool CaptureVisibleTabFunction::GetTabToCapture( if (!GetBrowserFromWindowID(this, window_id, &browser)) return false; - *web_contents = browser->GetSelectedWebContents(); + *web_contents = browser->GetActiveWebContents(); if (*web_contents == NULL) { error_ = keys::kInternalVisibleTabCaptureError; return false; } - *wrapper = browser->GetSelectedTabContentsWrapper(); + *tab_contents = browser->GetActiveTabContents(); return true; }; bool CaptureVisibleTabFunction::RunImpl() { WebContents* web_contents = NULL; - TabContentsWrapper* wrapper = NULL; - if (!GetTabToCapture(&web_contents, &wrapper)) + TabContents* tab_contents = NULL; + if (!GetTabToCapture(&web_contents, &tab_contents)) return false; image_format_ = FORMAT_JPEG; // Default format is JPEG. @@ -1644,8 +1644,8 @@ void CaptureVisibleTabFunction::CopyFromBackingStoreComplete( } WebContents* web_contents = NULL; - TabContentsWrapper* wrapper = NULL; - if (!GetTabToCapture(&web_contents, &wrapper)) { + TabContents* tab_contents = NULL; + if (!GetTabToCapture(&web_contents, &tab_contents)) { error_ = keys::kInternalVisibleTabCaptureError; SendResponse(false); return; @@ -1656,7 +1656,7 @@ void CaptureVisibleTabFunction::CopyFromBackingStoreComplete( chrome::NOTIFICATION_TAB_SNAPSHOT_TAKEN, content::Source<WebContents>(web_contents)); AddRef(); // Balanced in CaptureVisibleTabFunction::Observe(). - wrapper->snapshot_tab_helper()->CaptureSnapshot(); + tab_contents->snapshot_tab_helper()->CaptureSnapshot(); } // If a backing store was not available in CaptureVisibleTabFunction::RunImpl, @@ -1734,7 +1734,7 @@ void CaptureVisibleTabFunction::SendResultFromBitmap( bool DetectTabLanguageFunction::RunImpl() { int tab_id = 0; Browser* browser = NULL; - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; // If |tab_id| is specified, look for it. Otherwise default to selected tab // in the current window. diff --git a/chrome/browser/extensions/api/tabs/tabs.h b/chrome/browser/extensions/api/tabs/tabs.h index fab0124..0fe56f8 100644 --- a/chrome/browser/extensions/api/tabs/tabs.h +++ b/chrome/browser/extensions/api/tabs/tabs.h @@ -19,7 +19,6 @@ class BackingStore; class GURL; class SkBitmap; class TabContents; -typedef TabContents TabContentsWrapper; namespace base { class DictionaryValue; @@ -125,7 +124,7 @@ class UpdateTabFunction : public AsyncExtensionFunction { bool* is_async); virtual void PopulateResult(); - TabContentsWrapper* tab_contents_; + TabContents* tab_contents_; private: virtual bool RunImpl() OVERRIDE; @@ -177,7 +176,7 @@ class CaptureVisibleTabFunction : public AsyncExtensionFunction, virtual ~CaptureVisibleTabFunction() {} virtual bool RunImpl() OVERRIDE; virtual bool GetTabToCapture(content::WebContents** web_contents, - TabContentsWrapper** wrapper); + TabContents** tab_contents); virtual void Observe(int type, const content::NotificationSource& source, const content::NotificationDetails& details) OVERRIDE; diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc index a637e34..998130d 100644 --- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc +++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc @@ -16,7 +16,7 @@ #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/tab_contents/retargeting_details.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/view_type_utils.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/url_constants.h" @@ -458,11 +458,10 @@ void WebNavigationEventRouter::Retargeting(const RetargetingDetails* details) { return; // If the WebContents was created as a response to an IPC from a renderer - // (and therefore doesn't yet have a wrapper), or if it isn't yet inserted + // (and therefore doesn't yet have a TabContents), or if it isn't yet inserted // into a tab strip, we need to delay the extension event until the // WebContents is fully initialized. - if ((TabContentsWrapper::GetCurrentWrapperForContents( - details->target_web_contents) == NULL) || + if (TabContents::FromWebContents(details->target_web_contents) == NULL || details->not_yet_in_tabstrip) { pending_web_contents_[details->target_web_contents] = PendingWebContents( @@ -731,14 +730,18 @@ bool GetFrameFunction::RunImpl() { result_.reset(Value::CreateNullValue()); - TabContentsWrapper* wrapper; - if (!ExtensionTabUtil::GetTabById( - tab_id, profile(), include_incognito(), NULL, NULL, &wrapper, NULL) || - !wrapper) { + TabContents* tab_contents; + if (!ExtensionTabUtil::GetTabById(tab_id, + profile(), + include_incognito(), + NULL, NULL, + &tab_contents, + NULL) || + !tab_contents) { return true; } - WebContents* web_contents = wrapper->web_contents(); + WebContents* web_contents = tab_contents->web_contents(); WebNavigationTabObserver* observer = WebNavigationTabObserver::Get(web_contents); DCHECK(observer); @@ -774,14 +777,18 @@ bool GetAllFramesFunction::RunImpl() { result_.reset(Value::CreateNullValue()); - TabContentsWrapper* wrapper; - if (!ExtensionTabUtil::GetTabById( - tab_id, profile(), include_incognito(), NULL, NULL, &wrapper, NULL) || - !wrapper) { + TabContents* tab_contents; + if (!ExtensionTabUtil::GetTabById(tab_id, + profile(), + include_incognito(), + NULL, NULL, + &tab_contents, + NULL) || + !tab_contents) { return true; } - WebContents* web_contents = wrapper->web_contents(); + WebContents* web_contents = tab_contents->web_contents(); WebNavigationTabObserver* observer = WebNavigationTabObserver::Get(web_contents); DCHECK(observer); diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc index fef3a5b..1ebf8bb 100644 --- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc +++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc @@ -183,7 +183,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationUserAction) { ASSERT_TRUE( RunExtensionSubtest("webnavigation", "test_userAction.html")) << message_; - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); ui_test_utils::WaitForLoadStop(tab); ResultCatcher catcher; @@ -221,7 +221,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationRequestOpenTab) { ASSERT_TRUE(RunExtensionSubtest("webnavigation", "test_requestOpenTab.html")) << message_; - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); ui_test_utils::WaitForLoadStop(tab); ResultCatcher catcher; @@ -258,7 +258,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationTargetBlank) { ASSERT_TRUE(RunExtensionSubtest("webnavigation", "test_targetBlank.html")) << message_; - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); ui_test_utils::WaitForLoadStop(tab); ResultCatcher catcher; @@ -304,7 +304,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationTargetBlankIncognito) { ui_test_utils::OpenURLOffTheRecord(browser()->profile(), url); WebContents* tab = browser::FindTabbedBrowser( browser()->profile()->GetOffTheRecordProfile(), false)-> - GetSelectedWebContents(); + GetActiveWebContents(); // There's a link with target=_blank on a.html. Click on it to open it in a // new tab. diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc index 45a4ca9..f5c6df2 100644 --- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc +++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc @@ -99,7 +99,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestNewTab) { ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_newTab.html")) << message_; - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); ui_test_utils::WaitForLoadStop(tab); ResultCatcher catcher; diff --git a/chrome/browser/extensions/app_notify_channel_ui.cc b/chrome/browser/extensions/app_notify_channel_ui.cc index f50f4df..5a0b588 100644 --- a/chrome/browser/extensions/app_notify_channel_ui.cc +++ b/chrome/browser/extensions/app_notify_channel_ui.cc @@ -14,7 +14,7 @@ #include "chrome/browser/tab_contents/confirm_infobar_delegate.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_finder.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/webui/signin/login_ui_service.h" #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h" #include "chrome/common/url_constants.h" @@ -91,11 +91,11 @@ void AppNotifyChannelUIImpl::InfoBar::InfoBarDismissed() { AppNotifyChannelUIImpl::AppNotifyChannelUIImpl( Profile* profile, - TabContentsWrapper* wrapper, + TabContents* tab_contents, const std::string& app_name, AppNotifyChannelUI::UIType ui_type) : profile_(profile->GetOriginalProfile()), - wrapper_(wrapper), + tab_contents_(tab_contents), app_name_(app_name), ui_type_(ui_type), delegate_(NULL), @@ -125,7 +125,7 @@ void AppNotifyChannelUIImpl::PromptSyncSetup( return; } - InfoBarTabHelper* helper = wrapper_->infobar_tab_helper(); + InfoBarTabHelper* helper = tab_contents_->infobar_tab_helper(); helper->AddInfoBar(new AppNotifyChannelUIImpl::InfoBar( this, helper, app_name_)); } diff --git a/chrome/browser/extensions/app_notify_channel_ui.h b/chrome/browser/extensions/app_notify_channel_ui.h index 45209a6..9e18e44 100644 --- a/chrome/browser/extensions/app_notify_channel_ui.h +++ b/chrome/browser/extensions/app_notify_channel_ui.h @@ -13,7 +13,6 @@ class Profile; class TabContents; -typedef TabContents TabContentsWrapper; // An interface for prompting a user to sign in to sync so that we can create // an app notification channel for one of their apps. @@ -47,7 +46,7 @@ class AppNotifyChannelUIImpl : public AppNotifyChannelUI, public ProfileSyncServiceObserver { public: AppNotifyChannelUIImpl(Profile* profile, - TabContentsWrapper* wrapper, + TabContents* tab_contents, const std::string& app_name, AppNotifyChannelUI::UIType ui_type); virtual ~AppNotifyChannelUIImpl(); @@ -57,7 +56,7 @@ class AppNotifyChannelUIImpl : public AppNotifyChannelUI, protected: // A private class we use to put up an infobar - its lifetime is managed by - // |wrapper_|, so we don't have one as an instance variable. + // |tab_contents_|, so we don't have one as an instance variable. class InfoBar; friend class AppNotifyChannelUIImpl::InfoBar; @@ -72,7 +71,7 @@ class AppNotifyChannelUIImpl : public AppNotifyChannelUI, void StopObservingSync(); Profile* profile_; - TabContentsWrapper* wrapper_; + TabContents* tab_contents_; std::string app_name_; AppNotifyChannelUI::UIType ui_type_; AppNotifyChannelUI::Delegate* delegate_; diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc index 78481ba..1c23037 100644 --- a/chrome/browser/extensions/app_process_apitest.cc +++ b/chrome/browser/extensions/app_process_apitest.cc @@ -11,7 +11,7 @@ #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" @@ -386,8 +386,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_ReloadIntoAppProcess) { ui_test_utils::WindowedNotificationObserver reload_observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); browser()->Reload(CURRENT_TAB); reload_observer.Wait(); EXPECT_TRUE(process_map->Contains( @@ -398,8 +397,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_ReloadIntoAppProcess) { ui_test_utils::WindowedNotificationObserver reload_observer2( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); browser()->Reload(CURRENT_TAB); reload_observer2.Wait(); EXPECT_FALSE(process_map->Contains( @@ -410,8 +408,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_ReloadIntoAppProcess) { ui_test_utils::WindowedNotificationObserver js_reload_observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); ASSERT_TRUE(ui_test_utils::ExecuteJavaScript(contents->GetRenderViewHost(), L"", L"location.reload();")); js_reload_observer.Wait(); @@ -423,8 +420,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_ReloadIntoAppProcess) { ui_test_utils::WindowedNotificationObserver js_reload_observer2( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); ASSERT_TRUE(ui_test_utils::ExecuteJavaScript(contents->GetRenderViewHost(), L"", L"location = location;")); js_reload_observer2.Wait(); @@ -502,7 +498,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, OpenAppFromExtension) { // App has loaded, and chrome.app.isInstalled should be true. bool is_installed = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(chrome.app.isInstalled)", &is_installed)); ASSERT_TRUE(is_installed); @@ -577,12 +573,11 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_ReloadAppAfterCrash) { ASSERT_TRUE(is_installed); // Crash the tab and reload it, chrome.app.isInstalled should still be true. - ui_test_utils::CrashTab(browser()->GetSelectedWebContents()); + ui_test_utils::CrashTab(browser()->GetActiveWebContents()); ui_test_utils::WindowedNotificationObserver observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); browser()->Reload(CURRENT_TAB); observer.Wait(); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( diff --git a/chrome/browser/extensions/chrome_app_api_browsertest.cc b/chrome/browser/extensions/chrome_app_api_browsertest.cc index c0b3eae..0374221 100644 --- a/chrome/browser/extensions/chrome_app_api_browsertest.cc +++ b/chrome/browser/extensions/chrome_app_api_browsertest.cc @@ -32,7 +32,7 @@ class ChromeAppAPITest : public ExtensionBrowserTest { bool result; CHECK( ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), frame_xpath, get_app_is_installed, &result)); return result; } @@ -45,7 +45,7 @@ class ChromeAppAPITest : public ExtensionBrowserTest { std::string result; CHECK( ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), frame_xpath, get_app_install_state, &result)); return result; } @@ -58,7 +58,7 @@ class ChromeAppAPITest : public ExtensionBrowserTest { std::string result; CHECK( ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), frame_xpath, get_app_install_state, &result)); return result; } @@ -112,7 +112,7 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) { std::string result; ASSERT_TRUE( ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", get_app_details, &result)); EXPECT_EQ("null", result); @@ -125,7 +125,7 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) { ui_test_utils::NavigateToURL(browser(), app_url); ASSERT_TRUE( ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", get_app_details, &result)); scoped_ptr<DictionaryValue> app_details( static_cast<DictionaryValue*>(base::JSONReader::Read(result))); @@ -138,7 +138,7 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) { // that isInstalled should have the initial value. ASSERT_TRUE( ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(" L" function() {" @@ -189,7 +189,7 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, GetDetailsForFrame) { bool result = false; ASSERT_TRUE( ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", test_unsuccessful_access, &result)); EXPECT_TRUE(result); @@ -202,7 +202,7 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, GetDetailsForFrame) { std::string json; ASSERT_TRUE( ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", get_details_for_frame, &json)); scoped_ptr<DictionaryValue> app_details( diff --git a/chrome/browser/extensions/content_script_apitest.cc b/chrome/browser/extensions/content_script_apitest.cc index 0d1c901..6a108ac 100644 --- a/chrome/browser/extensions/content_script_apitest.cc +++ b/chrome/browser/extensions/content_script_apitest.cc @@ -107,7 +107,7 @@ IN_PROC_BROWSER_TEST_F( // And check that its styles were affected by the styles that just got loaded. bool styles_injected; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(" L"document.defaultView.getComputedStyle(document.body, null)." L"getPropertyValue('background-color') == 'rgb(255, 0, 0)')", diff --git a/chrome/browser/extensions/extension_browser_event_router.cc b/chrome/browser/extensions/extension_browser_event_router.cc index a545e32..bd7b9118 100644 --- a/chrome/browser/extensions/extension_browser_event_router.cc +++ b/chrome/browser/extensions/extension_browser_event_router.cc @@ -15,7 +15,7 @@ #include "chrome/browser/extensions/extension_window_controller.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" @@ -97,8 +97,7 @@ void ExtensionBrowserEventRouter::Init() { Browser* browser = *iter; if (browser->tab_strip_model()) { for (int i = 0; i < browser->tab_strip_model()->count(); ++i) { - WebContents* contents = - browser->GetTabContentsWrapperAt(i)->web_contents(); + WebContents* contents = browser->GetTabContentsAt(i)->web_contents(); int tab_id = ExtensionTabUtil::GetTabId(contents); tab_entries_[tab_id] = TabEntry(); } @@ -144,7 +143,7 @@ void ExtensionBrowserEventRouter::RegisterForBrowserNotifications( for (int i = 0; i < browser->tab_strip_model()->count(); ++i) { RegisterForTabNotifications( - browser->GetTabContentsWrapperAt(i)->web_contents()); + browser->GetTabContentsAt(i)->web_contents()); } } @@ -266,7 +265,7 @@ void ExtensionBrowserEventRouter::TabCreatedAt(WebContents* contents, RegisterForTabNotifications(contents); } -void ExtensionBrowserEventRouter::TabInsertedAt(TabContentsWrapper* contents, +void ExtensionBrowserEventRouter::TabInsertedAt(TabContents* contents, int index, bool active) { // If tab is new, send created event. @@ -294,7 +293,7 @@ void ExtensionBrowserEventRouter::TabInsertedAt(TabContentsWrapper* contents, DispatchEvent(contents->profile(), events::kOnTabAttached, json_args); } -void ExtensionBrowserEventRouter::TabDetachedAt(TabContentsWrapper* contents, +void ExtensionBrowserEventRouter::TabDetachedAt(TabContents* contents, int index) { if (!GetTabEntry(contents->web_contents())) { // The tab was removed. Don't send detach event. @@ -319,7 +318,7 @@ void ExtensionBrowserEventRouter::TabDetachedAt(TabContentsWrapper* contents, } void ExtensionBrowserEventRouter::TabClosingAt(TabStripModel* tab_strip_model, - TabContentsWrapper* contents, + TabContents* contents, int index) { int tab_id = ExtensionTabUtil::GetTabId(contents->web_contents()); @@ -343,8 +342,8 @@ void ExtensionBrowserEventRouter::TabClosingAt(TabStripModel* tab_strip_model, } void ExtensionBrowserEventRouter::ActiveTabChanged( - TabContentsWrapper* old_contents, - TabContentsWrapper* new_contents, + TabContents* old_contents, + TabContents* new_contents, int index, bool user_gesture) { ListValue args; @@ -382,7 +381,7 @@ void ExtensionBrowserEventRouter::TabSelectionChanged( for (size_t i = 0; i < new_selection.size(); ++i) { int index = new_selection[i]; - TabContentsWrapper* contents = tab_strip_model->GetTabContentsAt(index); + TabContents* contents = tab_strip_model->GetTabContentsAt(index); if (!contents) break; int tab_id = ExtensionTabUtil::GetTabId(contents->web_contents()); @@ -407,7 +406,7 @@ void ExtensionBrowserEventRouter::TabSelectionChanged( DispatchEvent(profile, events::kOnTabHighlighted, json_args); } -void ExtensionBrowserEventRouter::TabMoved(TabContentsWrapper* contents, +void ExtensionBrowserEventRouter::TabMoved(TabContents* contents, int from_index, int to_index) { ListValue args; @@ -575,7 +574,7 @@ void ExtensionBrowserEventRouter::Observe( } } -void ExtensionBrowserEventRouter::TabChangedAt(TabContentsWrapper* contents, +void ExtensionBrowserEventRouter::TabChangedAt(TabContents* contents, int index, TabChangeType change_type) { TabUpdated(contents->web_contents(), false); @@ -583,15 +582,15 @@ void ExtensionBrowserEventRouter::TabChangedAt(TabContentsWrapper* contents, void ExtensionBrowserEventRouter::TabReplacedAt( TabStripModel* tab_strip_model, - TabContentsWrapper* old_contents, - TabContentsWrapper* new_contents, + TabContents* old_contents, + TabContents* new_contents, int index) { TabClosingAt(tab_strip_model, old_contents, index); TabInsertedAt(new_contents, index, tab_strip_model->active_index() == index); } void ExtensionBrowserEventRouter::TabPinnedStateChanged( - TabContentsWrapper* contents, + TabContents* contents, int index) { TabStripModel* tab_strip = NULL; int tab_index; @@ -632,7 +631,7 @@ void ExtensionBrowserEventRouter::DispatchOldPageActionEvent( void ExtensionBrowserEventRouter::BrowserActionExecuted( const std::string& extension_id, Browser* browser) { Profile* profile = browser->profile(); - TabContentsWrapper* tab_contents = NULL; + TabContents* tab_contents = NULL; int tab_id = 0; if (!ExtensionTabUtil::GetDefaultTab(browser, &tab_contents, &tab_id)) return; @@ -648,7 +647,7 @@ void ExtensionBrowserEventRouter::PageActionExecuted( int button) { DispatchOldPageActionEvent(profile, extension_id, page_action_id, tab_id, url, button); - TabContentsWrapper* tab_contents = NULL; + TabContents* tab_contents = NULL; if (!ExtensionTabUtil::GetTabById(tab_id, profile, profile->IsOffTheRecord(), NULL, NULL, &tab_contents, NULL)) { return; @@ -674,7 +673,7 @@ void ExtensionBrowserEventRouter::CommandExecuted( void ExtensionBrowserEventRouter::ExtensionActionExecuted( Profile* profile, const std::string& extension_id, - TabContentsWrapper* tab_contents) { + TabContents* tab_contents) { const extensions::Extension* extension = profile->GetExtensionService()->GetExtensionById(extension_id, false); if (!extension) diff --git a/chrome/browser/extensions/extension_browser_event_router.h b/chrome/browser/extensions/extension_browser_event_router.h index 484798b..219bb9c 100644 --- a/chrome/browser/extensions/extension_browser_event_router.h +++ b/chrome/browser/extensions/extension_browser_event_router.h @@ -63,28 +63,28 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver, void OnBrowserWindowReady(Browser* browser); // TabStripModelObserver - virtual void TabInsertedAt(TabContentsWrapper* contents, int index, + virtual void TabInsertedAt(TabContents* contents, int index, bool active) OVERRIDE; virtual void TabClosingAt(TabStripModel* tab_strip_model, - TabContentsWrapper* contents, + TabContents* contents, int index) OVERRIDE; - virtual void TabDetachedAt(TabContentsWrapper* contents, int index) OVERRIDE; - virtual void ActiveTabChanged(TabContentsWrapper* old_contents, - TabContentsWrapper* new_contents, + virtual void TabDetachedAt(TabContents* contents, int index) OVERRIDE; + virtual void ActiveTabChanged(TabContents* old_contents, + TabContents* new_contents, int index, bool user_gesture) OVERRIDE; virtual void TabSelectionChanged( TabStripModel* tab_strip_model, const TabStripSelectionModel& old_model) OVERRIDE; - virtual void TabMoved(TabContentsWrapper* contents, int from_index, + virtual void TabMoved(TabContents* contents, int from_index, int to_index) OVERRIDE; - virtual void TabChangedAt(TabContentsWrapper* contents, int index, + virtual void TabChangedAt(TabContents* contents, int index, TabChangeType change_type) OVERRIDE; virtual void TabReplacedAt(TabStripModel* tab_strip_model, - TabContentsWrapper* old_contents, - TabContentsWrapper* new_contents, + TabContents* old_contents, + TabContents* new_contents, int index) OVERRIDE; - virtual void TabPinnedStateChanged(TabContentsWrapper* contents, + virtual void TabPinnedStateChanged(TabContents* contents, int index) OVERRIDE; virtual void TabStripEmpty() OVERRIDE; @@ -216,7 +216,7 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver, // event to send based on what the extension wants. void ExtensionActionExecuted(Profile* profile, const std::string& extension_id, - TabContentsWrapper* tab_contents); + TabContents* tab_contents); std::map<int, TabEntry> tab_entries_; diff --git a/chrome/browser/extensions/extension_browsertests_misc.cc b/chrome/browser/extensions/extension_browsertests_misc.cc index 4342514..cafeef2 100644 --- a/chrome/browser/extensions/extension_browsertests_misc.cc +++ b/chrome/browser/extensions/extension_browsertests_misc.cc @@ -17,7 +17,7 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_list.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/chrome_switches.h" @@ -98,7 +98,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WebContents) { bool result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"testTabsAPI()", &result)); EXPECT_TRUE(result); @@ -110,7 +110,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WebContents) { GURL("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/page.html")); result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"testTabsAPI()", &result)); EXPECT_TRUE(result); } @@ -304,7 +304,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, TitleLocalizationBrowserAction) { extension->description().c_str()); EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur is my name").c_str(), extension->name().c_str()); - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur").c_str(), extension->browser_action()->GetTitle(tab_id).c_str()); } @@ -333,7 +333,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, TitleLocalizationPageAction) { extension->description().c_str()); EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur is my name").c_str(), extension->name().c_str()); - int tab_id = ExtensionTabUtil::GetTabId(browser()->GetSelectedWebContents()); + int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents()); EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur").c_str(), extension->page_action()->GetTitle(tab_id).c_str()); } @@ -418,7 +418,7 @@ void NavigateToFeedAndValidate(net::TestServer* server, ui_test_utils::NavigateToURL(browser, GetFeedUrl(server, url, true, extension_id)); - WebContents* tab = browser->GetSelectedWebContents(); + WebContents* tab = browser->GetActiveWebContents(); ASSERT_TRUE(ValidatePageElement(tab, L"", jscript_feed_title, @@ -661,7 +661,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenExtension) { last_loaded_extension_id_ + "/test.html"); ui_test_utils::NavigateToURL(browser(), start_url); WebContents* newtab; - ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetSelectedWebContents(), + ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetActiveWebContents(), start_url.Resolve("newtab.html"), true, &newtab)); bool result = false; @@ -679,7 +679,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenInvalidExtension) { GURL start_url(std::string("chrome-extension://") + last_loaded_extension_id_ + "/test.html"); ui_test_utils::NavigateToURL(browser(), start_url); - ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetSelectedWebContents(), + ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetActiveWebContents(), GURL("chrome-extension://thisissurelynotavalidextensionid/newtab.html"), false, NULL)); @@ -696,7 +696,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenNoPrivileges) { ui_test_utils::NavigateToURL(browser(), GURL("about:blank")); WebContents* newtab; - ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetSelectedWebContents(), + ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetActiveWebContents(), GURL(std::string("chrome-extension://") + last_loaded_extension_id_ + "/newtab.html"), false, &newtab)); @@ -731,7 +731,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, MAYBE_PluginLoadUnload) { ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(extension_dir.AppendASCII("test.html"))); - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); // With no extensions, the plugin should not be loaded. bool result = false; @@ -768,8 +768,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, MAYBE_PluginLoadUnload) { ui_test_utils::WindowedNotificationObserver observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); browser()->Reload(CURRENT_TAB); observer.Wait(); } @@ -800,7 +799,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, MAYBE_PluginPrivate) { // Load the test page through the extension URL, and the plugin should work. ui_test_utils::NavigateToURL(browser(), extension->GetResourceURL("test.html")); - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); bool result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( tab->GetRenderViewHost(), L"", L"testPluginWorks()", &result)); @@ -844,7 +843,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_OptionsPage) { ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIExtensionsURL)); TabStripModel* tab_strip = browser()->tab_strip_model(); ASSERT_TRUE(ui_test_utils::ExecuteJavaScript( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", jscript_click_option_button)); // If the options page hasn't already come up, wait for it. diff --git a/chrome/browser/extensions/extension_context_menu_browsertest.cc b/chrome/browser/extensions/extension_context_menu_browsertest.cc index 8045e2a..a44ea2b 100644 --- a/chrome/browser/extensions/extension_context_menu_browsertest.cc +++ b/chrome/browser/extensions/extension_context_menu_browsertest.cc @@ -143,7 +143,7 @@ class ExtensionContextMenuBrowserTest : public ExtensionBrowserTest { const GURL& page_url, const GURL& link_url, const GURL& frame_url) { - WebContents* web_contents = browser->GetSelectedWebContents(); + WebContents* web_contents = browser->GetActiveWebContents(); WebContextMenuData data; content::ContextMenuParams params(data); params.page_url = page_url; diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc index 2341cf2..e1f2bc2 100644 --- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc +++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc @@ -16,7 +16,7 @@ #include "chrome/browser/notifications/notification_ui_manager.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/ui_test_utils.h" #include "content/public/browser/navigation_controller.h" @@ -175,7 +175,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest, ReloadIndependently) { SCOPED_TRACE("after reloading"); CheckExtensionConsistency(first_extension_id_); - WebContents* current_tab = browser()->GetSelectedWebContents(); + WebContents* current_tab = browser()->GetActiveWebContents(); ASSERT_TRUE(current_tab); // The balloon should automatically hide after the extension is successfully @@ -190,13 +190,13 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest, CrashExtension(first_extension_id_); ASSERT_EQ(size_before, GetExtensionService()->extensions()->size()); - WebContents* original_tab = browser()->GetSelectedWebContents(); + WebContents* original_tab = browser()->GetActiveWebContents(); ASSERT_TRUE(original_tab); ASSERT_EQ(1U, CountBalloons()); // Open a new tab, but the balloon will still be there. browser()->NewTab(); - WebContents* new_current_tab = browser()->GetSelectedWebContents(); + WebContents* new_current_tab = browser()->GetActiveWebContents(); ASSERT_TRUE(new_current_tab); ASSERT_NE(new_current_tab, original_tab); ASSERT_EQ(1U, CountBalloons()); @@ -218,7 +218,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest, CrashExtension(first_extension_id_); ASSERT_EQ(size_before, GetExtensionService()->extensions()->size()); - WebContents* current_tab = browser()->GetSelectedWebContents(); + WebContents* current_tab = browser()->GetActiveWebContents(); ASSERT_TRUE(current_tab); ASSERT_EQ(1U, CountBalloons()); @@ -391,7 +391,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest, { SCOPED_TRACE("first: reload"); - WebContents* current_tab = browser()->GetSelectedWebContents(); + WebContents* current_tab = browser()->GetActiveWebContents(); ASSERT_TRUE(current_tab); // At the beginning we should have one balloon displayed for each extension. ASSERT_EQ(2U, CountBalloons()); @@ -484,8 +484,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest, ui_test_utils::WindowedNotificationObserver observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); browser()->Reload(CURRENT_TAB); observer.Wait(); } diff --git a/chrome/browser/extensions/extension_debugger_api.cc b/chrome/browser/extensions/extension_debugger_api.cc index 5a72dd7..6e59f22 100644 --- a/chrome/browser/extensions/extension_debugger_api.cc +++ b/chrome/browser/extensions/extension_debugger_api.cc @@ -22,7 +22,7 @@ #include "chrome/browser/infobars/infobar_tab_helper.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/tab_contents/confirm_infobar_delegate.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" @@ -181,8 +181,7 @@ ExtensionDevToolsClientHost::ExtensionDevToolsClientHost( DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(agent, this); InfoBarTabHelper* infobar_helper = - TabContentsWrapper::GetCurrentWrapperForContents(web_contents_)-> - infobar_tab_helper(); + TabContents::FromWebContents(web_contents_)->infobar_tab_helper(); infobar_delegate_ = new ExtensionDevToolsInfoBarDelegate(infobar_helper, extension_name); if (infobar_helper->AddInfoBar(infobar_delegate_)) { @@ -199,9 +198,8 @@ ExtensionDevToolsClientHost::~ExtensionDevToolsClientHost() { registrar_.RemoveAll(); if (infobar_delegate_) { - TabContentsWrapper* wrapper = - TabContentsWrapper::GetCurrentWrapperForContents(web_contents_); - InfoBarTabHelper* helper = wrapper->infobar_tab_helper(); + TabContents* tab_contents = TabContents::FromWebContents(web_contents_); + InfoBarTabHelper* helper = tab_contents->infobar_tab_helper(); if (helper) helper->RemoveInfoBar(infobar_delegate_); } @@ -363,18 +361,18 @@ bool DebuggerFunction::InitTabContents() { DictionaryValue* dict = static_cast<DictionaryValue*>(debuggee); EXTENSION_FUNCTION_VALIDATE(dict->GetInteger(keys::kTabIdKey, &tab_id_)); - // Find the TabContentsWrapper that contains this tab id. + // Find the TabContents that contains this tab id. contents_ = NULL; - TabContentsWrapper* wrapper = NULL; + TabContents* tab_contents = NULL; bool result = ExtensionTabUtil::GetTabById( - tab_id_, profile(), include_incognito(), NULL, NULL, &wrapper, NULL); - if (!result || !wrapper) { + tab_id_, profile(), include_incognito(), NULL, NULL, &tab_contents, NULL); + if (!result || !tab_contents) { error_ = ExtensionErrorUtils::FormatErrorMessage( keys::kNoTabError, base::IntToString(tab_id_)); return false; } - contents_ = wrapper->web_contents(); + contents_ = tab_contents->web_contents(); if (content::GetContentClient()->HasWebUIScheme( contents_->GetURL())) { diff --git a/chrome/browser/extensions/extension_devtools_bridge.cc b/chrome/browser/extensions/extension_devtools_bridge.cc index 7477b27f..bdd4f91 100644 --- a/chrome/browser/extensions/extension_devtools_bridge.cc +++ b/chrome/browser/extensions/extension_devtools_bridge.cc @@ -15,7 +15,7 @@ #include "chrome/browser/extensions/extension_system.h" #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/profiles/profile.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "content/public/browser/devtools_agent_host_registry.h" #include "content/public/browser/devtools_manager.h" #include "content/public/browser/web_contents.h" @@ -57,7 +57,7 @@ bool ExtensionDevToolsBridge::RegisterAsDevToolsClientHost() { Browser* browser; TabStripModel* tab_strip; - TabContentsWrapper* contents; + TabContents* contents; int tab_index; if (ExtensionTabUtil::GetTabById(tab_id_, profile_, true, &browser, &tab_strip, diff --git a/chrome/browser/extensions/extension_dom_clipboard_apitest.cc b/chrome/browser/extensions/extension_dom_clipboard_apitest.cc index 155207d..8e1cbd8 100644 --- a/chrome/browser/extensions/extension_dom_clipboard_apitest.cc +++ b/chrome/browser/extensions/extension_dom_clipboard_apitest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -66,7 +66,7 @@ bool ClipboardApiTest::ExecutePasteInSelectedTab(bool* result) { bool ClipboardApiTest::ExecuteScriptInSelectedTab(const std::wstring& script, bool* result) { if (!ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", script, result)) { diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc index 283cedcb..51cdaca 100644 --- a/chrome/browser/extensions/extension_host.cc +++ b/chrome/browser/extensions/extension_host.cc @@ -28,7 +28,7 @@ #include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/prefs/prefs_tab_helper.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/view_type_utils.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_notification_types.h" @@ -592,8 +592,8 @@ void ExtensionHost::AddNewContents(WebContents* source, Profile::FromBrowserContext(new_contents->GetBrowserContext()); Browser* browser = browser::FindTabbedBrowser( profile, false); // Match incognito exactly. - TabContentsWrapper* wrapper = new TabContentsWrapper(new_contents); - browser::NavigateParams params(browser, wrapper); + TabContents* tab_contents = new TabContents(new_contents); + browser::NavigateParams params(browser, tab_contents); // The extension_app_id parameter ends up as app_name in the Browser // which causes the Browser to return true for is_app(). This affects diff --git a/chrome/browser/extensions/extension_icon_source_apitest.cc b/chrome/browser/extensions/extension_icon_source_apitest.cc index f77be46..64f38182 100644 --- a/chrome/browser/extensions/extension_icon_source_apitest.cc +++ b/chrome/browser/extensions/extension_icon_source_apitest.cc @@ -34,7 +34,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoaded) { browser(), GURL("chrome-extension://gbmgkahjioeacddebbnengilkgbkhodg/index.html")); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Loaded"); @@ -45,7 +45,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoaded) { browser(), GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html")); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Not Loaded"); @@ -67,7 +67,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoadedIncognito) { Browser* otr_browser = browser::FindTabbedBrowser( browser()->profile()->GetOffTheRecordProfile(), false); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - otr_browser->GetSelectedWebContents()->GetRenderViewHost(), L"", + otr_browser->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Loaded"); @@ -78,7 +78,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoadedIncognito) { browser()->profile(), GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html")); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - otr_browser->GetSelectedWebContents()->GetRenderViewHost(), L"", + otr_browser->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Not Loaded"); diff --git a/chrome/browser/extensions/extension_incognito_apitest.cc b/chrome/browser/extensions/extension_incognito_apitest.cc index ddedd00..bee0332 100644 --- a/chrome/browser/extensions/extension_incognito_apitest.cc +++ b/chrome/browser/extensions/extension_incognito_apitest.cc @@ -33,7 +33,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoNoScript) { Browser* otr_browser = browser::FindTabbedBrowser( browser()->profile()->GetOffTheRecordProfile(), false); - WebContents* tab = otr_browser->GetSelectedWebContents(); + WebContents* tab = otr_browser->GetActiveWebContents(); // Verify the script didn't run. bool result = false; @@ -70,7 +70,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoYesScript) { Browser* otr_browser = browser::FindTabbedBrowser( browser()->profile()->GetOffTheRecordProfile(), false); - WebContents* tab = otr_browser->GetSelectedWebContents(); + WebContents* tab = otr_browser->GetActiveWebContents(); // Verify the script ran. bool result = false; diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc index be5cbc2..9ac5870 100644 --- a/chrome/browser/extensions/extension_install_prompt.cc +++ b/chrome/browser/extensions/extension_install_prompt.cc @@ -18,7 +18,7 @@ #include "chrome/browser/extensions/extension_install_ui.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser_navigator.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_icon_set.h" diff --git a/chrome/browser/extensions/extension_install_ui_browsertest.cc b/chrome/browser/extensions/extension_install_ui_browsertest.cc index 2ce29c7..e90fb96 100644 --- a/chrome/browser/extensions/extension_install_ui_browsertest.cc +++ b/chrome/browser/extensions/extension_install_ui_browsertest.cc @@ -10,7 +10,7 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_finder.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/webui/ntp/new_tab_ui.h" #include "chrome/browser/themes/theme_service_factory.h" #include "chrome/test/base/ui_test_utils.h" @@ -24,7 +24,7 @@ class ExtensionInstallUIBrowserTest : public ExtensionBrowserTest { // Checks that a theme info bar is currently visible and issues an undo to // revert to the previous theme. void VerifyThemeInfoBarAndUndoInstall() { - TabContentsWrapper* tab = browser()->GetSelectedTabContentsWrapper(); + TabContents* tab = browser()->GetActiveTabContents(); ASSERT_TRUE(tab); InfoBarTabHelper* infobar_helper = tab->infobar_tab_helper(); ASSERT_EQ(1U, infobar_helper->infobar_count()); @@ -111,7 +111,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallUIBrowserTest, if (NewTabUI::ShouldShowApps()) { EXPECT_EQ(num_tabs + 1, browser()->tab_count()); - WebContents* web_contents = browser()->GetSelectedWebContents(); + WebContents* web_contents = browser()->GetActiveWebContents(); ASSERT_TRUE(web_contents); EXPECT_TRUE(StartsWithASCII(web_contents->GetURL().spec(), "chrome://newtab/", false)); @@ -136,7 +136,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallUIBrowserTest, EXPECT_EQ(num_incognito_tabs, incognito_browser->tab_count()); if (NewTabUI::ShouldShowApps()) { EXPECT_EQ(num_normal_tabs + 1, browser()->tab_count()); - WebContents* web_contents = browser()->GetSelectedWebContents(); + WebContents* web_contents = browser()->GetActiveWebContents(); ASSERT_TRUE(web_contents); EXPECT_TRUE(StartsWithASCII(web_contents->GetURL().spec(), "chrome://newtab/", false)); diff --git a/chrome/browser/extensions/extension_install_ui_default.cc b/chrome/browser/extensions/extension_install_ui_default.cc index 885e85e..db426be 100644 --- a/chrome/browser/extensions/extension_install_ui_default.cc +++ b/chrome/browser/extensions/extension_install_ui_default.cc @@ -17,7 +17,7 @@ #include "chrome/browser/ui/browser_navigator.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/simple_message_box.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/webui/ntp/new_tab_ui.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/chrome_switches.h" @@ -130,7 +130,7 @@ void ExtensionInstallUIDefault::ShowThemeInfoBar( if (!browser) return; - TabContentsWrapper* tab_contents = browser->GetSelectedTabContentsWrapper(); + TabContents* tab_contents = browser->GetActiveTabContents(); if (!tab_contents) return; InfoBarTabHelper* infobar_helper = tab_contents->infobar_tab_helper(); @@ -163,7 +163,7 @@ void ExtensionInstallUIDefault::ShowThemeInfoBar( } InfoBarDelegate* ExtensionInstallUIDefault::GetNewThemeInstalledInfoBarDelegate( - TabContentsWrapper* tab_contents, + TabContents* tab_contents, const Extension* new_theme, const std::string& previous_theme_id, bool previous_using_native_theme) { diff --git a/chrome/browser/extensions/extension_install_ui_default.h b/chrome/browser/extensions/extension_install_ui_default.h index 5e37d06..ff2f87c 100644 --- a/chrome/browser/extensions/extension_install_ui_default.h +++ b/chrome/browser/extensions/extension_install_ui_default.h @@ -10,7 +10,6 @@ class InfoBarDelegate; class TabContents; -typedef TabContents TabContentsWrapper; class ExtensionInstallUIDefault : public ExtensionInstallUI { public: @@ -35,7 +34,7 @@ class ExtensionInstallUIDefault : public ExtensionInstallUI { // Returns the delegate to control the browser's info bar. This is // within its own function due to its platform-specific nature. static InfoBarDelegate* GetNewThemeInstalledInfoBarDelegate( - TabContentsWrapper* tab_contents, + TabContents* tab_contents, const extensions::Extension* new_theme, const std::string& previous_theme_id, bool previous_using_native_theme); diff --git a/chrome/browser/extensions/extension_keybinding_apitest.cc b/chrome/browser/extensions/extension_keybinding_apitest.cc index b00097d..49509d7 100644 --- a/chrome/browser/extensions/extension_keybinding_apitest.cc +++ b/chrome/browser/extensions/extension_keybinding_apitest.cc @@ -6,7 +6,7 @@ #include "chrome/browser/extensions/browser_action_test_util.h" #include "chrome/browser/sessions/restore_tab_helper.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_action.h" @@ -60,7 +60,7 @@ IN_PROC_BROWSER_TEST_F(KeybindingApiTest, Basic) { browser(), ui::VKEY_F, true, true, false, false)); // Verify the command worked. - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); bool result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( tab->GetRenderViewHost(), L"", @@ -101,7 +101,7 @@ IN_PROC_BROWSER_TEST_F(KeybindingApiTest, PageAction) { // Make sure it appears and is the right one. ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1)); - int tab_id = browser()->GetSelectedTabContentsWrapper()-> + int tab_id = browser()->GetActiveTabContents()-> restore_tab_helper()->session_id().id(); ExtensionAction* action = extension->page_action(); ASSERT_TRUE(action); @@ -112,7 +112,7 @@ IN_PROC_BROWSER_TEST_F(KeybindingApiTest, PageAction) { browser(), ui::VKEY_F, true, true, false, false)); // Verify the command worked (the page action turns the page red). - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); bool result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( tab->GetRenderViewHost(), L"", diff --git a/chrome/browser/extensions/extension_management_browsertest.cc b/chrome/browser/extensions/extension_management_browsertest.cc index 51e5620..25773a5 100644 --- a/chrome/browser/extensions/extension_management_browsertest.cc +++ b/chrome/browser/extensions/extension_management_browsertest.cc @@ -15,7 +15,7 @@ #include "chrome/browser/prefs/scoped_user_pref_update.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" diff --git a/chrome/browser/extensions/extension_message_service.cc b/chrome/browser/extensions/extension_message_service.cc index e8c9a2f..6f4a6cd 100644 --- a/chrome/browser/extensions/extension_message_service.cc +++ b/chrome/browser/extensions/extension_message_service.cc @@ -19,7 +19,7 @@ #include "chrome/browser/extensions/process_map.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/tab_contents/tab_util.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_messages.h" @@ -247,7 +247,7 @@ void ExtensionMessageService::OpenChannelToTab( return; Profile* profile = Profile::FromBrowserContext(source->GetBrowserContext()); - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; MessagePort receiver; if (ExtensionTabUtil::GetTabById(tab_id, profile, true, NULL, NULL, &contents, NULL)) { diff --git a/chrome/browser/extensions/extension_nacl_browsertest.cc b/chrome/browser/extensions/extension_nacl_browsertest.cc index 58ccfbb..8b564ce5 100644 --- a/chrome/browser/extensions/extension_nacl_browsertest.cc +++ b/chrome/browser/extensions/extension_nacl_browsertest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -99,7 +99,7 @@ class NaClExtensionTest : public ExtensionBrowserTest { bool embedded_plugin_created = false; bool content_handler_plugin_created = false; - WebContents* web_contents = browser()->GetSelectedWebContents(); + WebContents* web_contents = browser()->GetActiveWebContents(); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( web_contents->GetRenderViewHost(), L"", L"window.domAutomationController.send(EmbeddedPluginCreated());", diff --git a/chrome/browser/extensions/extension_override_apitest.cc b/chrome/browser/extensions/extension_override_apitest.cc index b71c856c..722d894 100644 --- a/chrome/browser/extensions/extension_override_apitest.cc +++ b/chrome/browser/extensions/extension_override_apitest.cc @@ -52,7 +52,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, OverrideNewtab) { // Navigate to the new tab page. The overridden new tab page // will call chrome.test.notifyPass() . ui_test_utils::NavigateToURL(browser(), GURL("chrome://newtab/")); - WebContents* tab = browser()->GetSelectedWebContents(); + WebContents* tab = browser()->GetActiveWebContents(); ASSERT_TRUE(tab->GetController().GetActiveEntry()); EXPECT_TRUE(tab->GetController().GetActiveEntry()->GetURL(). SchemeIs(chrome::kExtensionScheme)); @@ -79,7 +79,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, MAYBE_OverrideNewtabIncognito) { GURL("chrome://newtab/")); Browser* otr_browser = browser::FindTabbedBrowser( browser()->profile()->GetOffTheRecordProfile(), false); - WebContents* tab = otr_browser->GetSelectedWebContents(); + WebContents* tab = otr_browser->GetActiveWebContents(); ASSERT_TRUE(tab->GetController().GetActiveEntry()); EXPECT_FALSE(tab->GetController().GetActiveEntry()->GetURL(). SchemeIs(chrome::kExtensionScheme)); diff --git a/chrome/browser/extensions/extension_page_capture_api.cc b/chrome/browser/extensions/extension_page_capture_api.cc index 3ae91d0..d42dd0e 100644 --- a/chrome/browser/extensions/extension_page_capture_api.cc +++ b/chrome/browser/extensions/extension_page_capture_api.cc @@ -8,7 +8,7 @@ #include "base/file_util.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/extensions/extension_tab_util.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/extensions/extension_messages.h" #include "content/public/browser/child_process_security_policy.h" #include "content/public/browser/notification_details.h" @@ -186,11 +186,11 @@ void PageCaptureSaveAsMHTMLFunction::ReturnSuccess(int64 file_size) { WebContents* PageCaptureSaveAsMHTMLFunction::GetWebContents() { Browser* browser = NULL; - TabContentsWrapper* tab_contents_wrapper = NULL; + TabContents* tab_contents = NULL; if (!ExtensionTabUtil::GetTabById(tab_id_, profile(), include_incognito(), - &browser, NULL, &tab_contents_wrapper, NULL)) { + &browser, NULL, &tab_contents, NULL)) { return NULL; } - return tab_contents_wrapper->web_contents(); + return tab_contents->web_contents(); } diff --git a/chrome/browser/extensions/extension_process_manager.cc b/chrome/browser/extensions/extension_process_manager.cc index d5b6c8e..d96c33a 100644 --- a/chrome/browser/extensions/extension_process_manager.cc +++ b/chrome/browser/extensions/extension_process_manager.cc @@ -294,7 +294,7 @@ void ExtensionProcessManager::OpenOptionsPage(const Extension* extension, content::PAGE_TRANSITION_LINK, false); browser->OpenURL(params); browser->window()->Show(); - WebContents* web_contents = browser->GetSelectedWebContents(); + WebContents* web_contents = browser->GetActiveWebContents(); web_contents->GetDelegate()->ActivateContents(web_contents); } diff --git a/chrome/browser/extensions/extension_processes_api.cc b/chrome/browser/extensions/extension_processes_api.cc index fe86879..2e7a93e 100644 --- a/chrome/browser/extensions/extension_processes_api.cc +++ b/chrome/browser/extensions/extension_processes_api.cc @@ -20,7 +20,7 @@ #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/task_manager/task_manager.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension_error_utils.h" #include "content/public/browser/browser_thread.h" @@ -562,7 +562,7 @@ void GetProcessIdForTabFunction::Observe( } void GetProcessIdForTabFunction::GetProcessIdForTab() { - TabContentsWrapper* contents = NULL; + TabContents* contents = NULL; int tab_index = -1; if (!ExtensionTabUtil::GetTabById(tab_id_, profile(), include_incognito(), NULL, NULL, &contents, &tab_index)) { diff --git a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc index 3666708..6ac2078 100644 --- a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc +++ b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc @@ -47,7 +47,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, OriginPrivileges) { browser(), web_resource.ReplaceComponents(make_host_a_com)); std::string result; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Loaded"); @@ -59,7 +59,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, OriginPrivileges) { "non_existent_extension.html")); ui_test_utils::NavigateToURL(browser(), non_existent_extension); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Image failed to load"); @@ -73,7 +73,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, OriginPrivileges) { ui_test_utils::NavigateToURL(browser(), GURL(std::string("data:text/html;charset=utf-8,") + file_source)); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Loaded"); @@ -87,7 +87,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, OriginPrivileges) { browser(), GURL("chrome-extension://pbkkcbgdkliohhfaeefcijaghglkahja/index.html")); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ(result, "Loaded"); @@ -143,7 +143,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, "web_accessible/accessible_resource.html")); ui_test_utils::NavigateToURL(browser(), accessible_resource); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ("Loaded", result); @@ -155,7 +155,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, ui_test_utils::NavigateToURL( browser(), xhr_accessible_resource); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ("XHR completed with status: 200", result); @@ -167,7 +167,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, ui_test_utils::NavigateToURL( browser(), xhr_inaccessible_resource); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ("XHR failed to load resource", result); @@ -178,7 +178,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, "web_accessible/nonaccessible_resource.html")); ui_test_utils::NavigateToURL(browser(), nonaccessible_resource); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ("Image failed to load", result); @@ -189,7 +189,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, "web_accessible/nonexistent_resource.html")); ui_test_utils::NavigateToURL(browser(), nonexistent_resource); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ("Image failed to load", result); @@ -200,7 +200,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest, "web_accessible/nonaccessible_chrome_resource_scheme.html")); ui_test_utils::NavigateToURL(browser(), nonaccessible_cer_resource); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title)", &result)); EXPECT_EQ("Loading CER:// failed.", result); diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc index c35ff72..f78c609 100644 --- a/chrome/browser/extensions/extension_startup_browsertest.cc +++ b/chrome/browser/extensions/extension_startup_browsertest.cc @@ -117,7 +117,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest { bool result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(" L"document.defaultView.getComputedStyle(document.body, null)." L"getPropertyValue('background-color') == 'rgb(245, 245, 220)')", @@ -126,7 +126,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest { result = false; ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", L"window.domAutomationController.send(document.title == 'Modified')", &result)); EXPECT_EQ(expect_script, result); diff --git a/chrome/browser/extensions/extension_tab_helper.cc b/chrome/browser/extensions/extension_tab_helper.cc index 41936ac..0a57770 100644 --- a/chrome/browser/extensions/extension_tab_helper.cc +++ b/chrome/browser/extensions/extension_tab_helper.cc @@ -12,8 +12,8 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/sessions/restore_tab_helper.h" #include "chrome/browser/ui/browser.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension_action.h" #include "chrome/common/extensions/extension_constants.h" @@ -42,18 +42,19 @@ const char kPermissionError[] = "permission_error"; } // namespace -ExtensionTabHelper::ExtensionTabHelper(TabContentsWrapper* wrapper) - : content::WebContentsObserver(wrapper->web_contents()), +ExtensionTabHelper::ExtensionTabHelper(TabContents* tab_contents) + : content::WebContentsObserver(tab_contents->web_contents()), delegate_(NULL), extension_app_(NULL), ALLOW_THIS_IN_INITIALIZER_LIST( - extension_function_dispatcher_(wrapper->profile(), this)), - wrapper_(wrapper) { + extension_function_dispatcher_(tab_contents->profile(), this)), + tab_contents_(tab_contents) { if (extensions::switch_utils::IsActionBoxEnabled()) { - script_badge_controller_ = new ScriptBadgeController(wrapper); + script_badge_controller_ = new ScriptBadgeController(tab_contents); } else { - script_executor_.reset(new ScriptExecutorImpl(wrapper->web_contents())); - location_bar_controller_.reset(new PageActionController(wrapper)); + script_executor_.reset( + new ScriptExecutorImpl(tab_contents->web_contents())); + location_bar_controller_.reset(new PageActionController(tab_contents)); } } @@ -137,7 +138,7 @@ void ExtensionTabHelper::DidNavigateMainFrame( ExtensionAction* browser_action = (*it)->browser_action(); if (browser_action) { browser_action->ClearAllValuesForTab( - wrapper_->restore_tab_helper()->session_id().id()); + tab_contents_->restore_tab_helper()->session_id().id()); content::NotificationService::current()->Notify( chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED, content::Source<ExtensionAction>(browser_action), @@ -147,7 +148,7 @@ void ExtensionTabHelper::DidNavigateMainFrame( ExtensionAction* page_action = (*it)->page_action(); if (page_action) { page_action->ClearAllValuesForTab( - wrapper_->restore_tab_helper()->session_id().id()); + tab_contents_->restore_tab_helper()->session_id().id()); PageActionStateChanged(); } } @@ -177,12 +178,12 @@ void ExtensionTabHelper::OnDidGetApplicationInfo( web_app_info_ = info; if (delegate_) - delegate_->OnDidGetApplicationInfo(wrapper_, page_id); + delegate_->OnDidGetApplicationInfo(tab_contents_, page_id); } void ExtensionTabHelper::OnInstallApplication(const WebApplicationInfo& info) { if (delegate_) - delegate_->OnInstallApplication(wrapper_, info); + delegate_->OnInstallApplication(tab_contents_, info); } void ExtensionTabHelper::OnInlineWebstoreInstall( @@ -212,7 +213,7 @@ void ExtensionTabHelper::OnGetAppNotifyChannel( ExtensionService* extension_service = profile->GetExtensionService(); extensions::ProcessMap* process_map = extension_service->process_map(); content::RenderProcessHost* process = - tab_contents_wrapper()->web_contents()->GetRenderProcessHost(); + tab_contents()->web_contents()->GetRenderProcessHost(); const Extension* extension = extension_service->GetInstalledApp(requestor_url); @@ -236,7 +237,7 @@ void ExtensionTabHelper::OnGetAppNotifyChannel( } AppNotifyChannelUI* ui = new AppNotifyChannelUIImpl( - profile, tab_contents_wrapper(), extension->name(), + profile, tab_contents(), extension->name(), AppNotifyChannelUI::NOTIFICATION_INFOBAR); scoped_refptr<AppNotifyChannelSetup> channel_setup( diff --git a/chrome/browser/extensions/extension_tab_helper.h b/chrome/browser/extensions/extension_tab_helper.h index 66ed9f1..6aa2bca 100644 --- a/chrome/browser/extensions/extension_tab_helper.h +++ b/chrome/browser/extensions/extension_tab_helper.h @@ -19,7 +19,6 @@ class ExtensionTabHelperDelegate; class TabContents; -typedef TabContents TabContentsWrapper; struct WebApplicationInfo; namespace content { @@ -42,7 +41,7 @@ class ExtensionTabHelper public AppNotifyChannelSetup::Delegate, public base::SupportsWeakPtr<ExtensionTabHelper> { public: - explicit ExtensionTabHelper(TabContentsWrapper* wrapper); + explicit ExtensionTabHelper(TabContents* tab_contents); virtual ~ExtensionTabHelper(); // Copies the internal state from another ExtensionTabHelper. @@ -91,8 +90,8 @@ class ExtensionTabHelper // Extension::EXTENSION_ICON_SMALLISH). SkBitmap* GetExtensionAppIcon(); - TabContentsWrapper* tab_contents_wrapper() { - return wrapper_; + TabContents* tab_contents() { + return tab_contents_; } content::WebContents* web_contents() const { @@ -188,7 +187,7 @@ class ExtensionTabHelper // Cached web app info data. WebApplicationInfo web_app_info_; - TabContentsWrapper* wrapper_; + TabContents* tab_contents_; // Either script_executor/location_bar_controller will have values, or // script_badge_controller will have a value, depending on whether the action diff --git a/chrome/browser/extensions/extension_tab_helper_delegate.cc b/chrome/browser/extensions/extension_tab_helper_delegate.cc index 0f6a2db..8f121e4 100644 --- a/chrome/browser/extensions/extension_tab_helper_delegate.cc +++ b/chrome/browser/extensions/extension_tab_helper_delegate.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -9,10 +9,9 @@ ExtensionTabHelperDelegate::~ExtensionTabHelperDelegate() { // Notification when an application programmatically requests installation. void ExtensionTabHelperDelegate::OnInstallApplication( - TabContentsWrapper* source, - const WebApplicationInfo& app_info) { + TabContents* source, const WebApplicationInfo& app_info) { } void ExtensionTabHelperDelegate::OnDidGetApplicationInfo( - TabContentsWrapper* source, int32 page_id) { + TabContents* source, int32 page_id) { } diff --git a/chrome/browser/extensions/extension_tab_helper_delegate.h b/chrome/browser/extensions/extension_tab_helper_delegate.h index e7b0827..e9b74eb 100644 --- a/chrome/browser/extensions/extension_tab_helper_delegate.h +++ b/chrome/browser/extensions/extension_tab_helper_delegate.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -9,7 +9,6 @@ #include "base/basictypes.h" class TabContents; -typedef TabContents TabContentsWrapper; struct WebApplicationInfo; // Objects implement this interface to get notified about changes in the @@ -17,11 +16,11 @@ struct WebApplicationInfo; class ExtensionTabHelperDelegate { public: // Notification that a user's request to install an application has completed. - virtual void OnDidGetApplicationInfo(TabContentsWrapper* source, + virtual void OnDidGetApplicationInfo(TabContents* source, int32 page_id); // Notification when an application programmatically requests installation. - virtual void OnInstallApplication(TabContentsWrapper* source, + virtual void OnInstallApplication(TabContents* source, const WebApplicationInfo& app_info); protected: virtual ~ExtensionTabHelperDelegate(); diff --git a/chrome/browser/extensions/extension_tab_id_map.cc b/chrome/browser/extensions/extension_tab_id_map.cc index 5ede659..9948405 100644 --- a/chrome/browser/extensions/extension_tab_id_map.cc +++ b/chrome/browser/extensions/extension_tab_id_map.cc @@ -8,7 +8,7 @@ #include "base/bind_helpers.h" #include "chrome/browser/sessions/restore_tab_helper.h" #include "chrome/browser/tab_contents/retargeting_details.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/navigation_details.h" @@ -67,8 +67,7 @@ void ExtensionTabIdMap::TabObserver::Observe( switch (type) { case content::NOTIFICATION_RENDER_VIEW_HOST_CREATED_FOR_TAB: { WebContents* contents = content::Source<WebContents>(source).ptr(); - TabContentsWrapper* tab = - TabContentsWrapper::GetCurrentWrapperForContents(contents); + TabContents* tab = TabContents::FromWebContents(contents); if (!tab) break; RenderViewHost* host = content::Details<RenderViewHost>(details).ptr(); @@ -85,8 +84,8 @@ void ExtensionTabIdMap::TabObserver::Observe( break; } case chrome::NOTIFICATION_TAB_PARENTED: { - TabContentsWrapper* tab = - content::Source<TabContentsWrapper>(source).ptr(); + TabContents* tab = + content::Source<TabContents>(source).ptr(); RenderViewHost* host = tab->web_contents()->GetRenderViewHost(); BrowserThread::PostTask( BrowserThread::IO, FROM_HERE, @@ -102,8 +101,7 @@ void ExtensionTabIdMap::TabObserver::Observe( RetargetingDetails* retargeting_details = content::Details<RetargetingDetails>(details).ptr(); WebContents* contents = retargeting_details->target_web_contents; - TabContentsWrapper* tab = - TabContentsWrapper::GetCurrentWrapperForContents(contents); + TabContents* tab = TabContents::FromWebContents(contents); if (!tab) break; RenderViewHost* host = contents->GetRenderViewHost(); diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc index 24628d0..d2cd5b3 100644 --- a/chrome/browser/extensions/extension_tab_util.cc +++ b/chrome/browser/extensions/extension_tab_util.cc @@ -11,7 +11,7 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_manifest_constants.h" @@ -41,10 +41,9 @@ int ExtensionTabUtil::GetWindowIdOfTabStripModel( return -1; } -// TODO(sky): this function should really take a TabContentsWrapper. +// TODO(sky): this function should really take a TabContents. int ExtensionTabUtil::GetTabId(const WebContents* web_contents) { - const TabContentsWrapper* tab = - TabContentsWrapper::GetCurrentWrapperForContents(web_contents); + const TabContents* tab = TabContents::FromWebContents(web_contents); return tab ? tab->restore_tab_helper()->session_id().id() : -1; } @@ -52,10 +51,9 @@ std::string ExtensionTabUtil::GetTabStatusText(bool is_loading) { return is_loading ? keys::kStatusValueLoading : keys::kStatusValueComplete; } -// TODO(sky): this function should really take a TabContentsWrapper. +// TODO(sky): this function should really take a TabContents. int ExtensionTabUtil::GetWindowIdOfTab(const WebContents* web_contents) { - const TabContentsWrapper* tab = - TabContentsWrapper::GetCurrentWrapperForContents(web_contents); + const TabContents* tab = TabContents::FromWebContents(web_contents); return tab ? tab->restore_tab_helper()->window_id().id() : -1; } @@ -154,12 +152,12 @@ bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents, } bool ExtensionTabUtil::GetDefaultTab(Browser* browser, - TabContentsWrapper** contents, + TabContents** contents, int* tab_id) { DCHECK(browser); DCHECK(contents); - *contents = browser->GetSelectedTabContentsWrapper(); + *contents = browser->GetActiveTabContents(); if (*contents) { if (tab_id) *tab_id = ExtensionTabUtil::GetTabId((*contents)->web_contents()); @@ -174,7 +172,7 @@ bool ExtensionTabUtil::GetTabById(int tab_id, bool include_incognito, Browser** browser, TabStripModel** tab_strip, - TabContentsWrapper** contents, + TabContents** contents, int* tab_index) { Profile* incognito_profile = include_incognito && profile->HasOffTheRecordProfile() ? @@ -186,8 +184,7 @@ bool ExtensionTabUtil::GetTabById(int tab_id, target_browser->profile() == incognito_profile) { TabStripModel* target_tab_strip = target_browser->tab_strip_model(); for (int i = 0; i < target_tab_strip->count(); ++i) { - TabContentsWrapper* target_contents = - target_tab_strip->GetTabContentsAt(i); + TabContents* target_contents = target_tab_strip->GetTabContentsAt(i); if (target_contents->restore_tab_helper()->session_id().id() == tab_id) { if (browser) diff --git a/chrome/browser/extensions/extension_tab_util.h b/chrome/browser/extensions/extension_tab_util.h index 4fe0092..85b3848 100644 --- a/chrome/browser/extensions/extension_tab_util.h +++ b/chrome/browser/extensions/extension_tab_util.h @@ -12,7 +12,6 @@ class Browser; class GURL; class Profile; class TabContents; -typedef TabContents TabContentsWrapper; class TabStripModel; namespace base { @@ -56,14 +55,14 @@ class ExtensionTabUtil { TabStripModel** tab_strip_model, int* tab_index); static bool GetDefaultTab(Browser* browser, - TabContentsWrapper** contents, + TabContents** contents, int* tab_id); // Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may // be NULL and will not be set within the function. static bool GetTabById(int tab_id, Profile* profile, bool incognito_enabled, Browser** browser, TabStripModel** tab_strip, - TabContentsWrapper** contents, + TabContents** contents, int* tab_index); // Takes |url_string| and returns a GURL which is either valid and absolute diff --git a/chrome/browser/extensions/extension_toolbar_model.cc b/chrome/browser/extensions/extension_toolbar_model.cc index aeea4fae..d8e0ed0 100644 --- a/chrome/browser/extensions/extension_toolbar_model.cc +++ b/chrome/browser/extensions/extension_toolbar_model.cc @@ -11,7 +11,7 @@ #include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/pref_names.h" @@ -87,7 +87,7 @@ ExtensionToolbarModel::Action ExtensionToolbarModel::ExecuteBrowserAction( const Extension* extension, Browser* browser, GURL* popup_url_out) { - TabContentsWrapper* tab_contents = browser->GetSelectedTabContentsWrapper(); + TabContents* tab_contents = browser->GetActiveTabContents(); if (!tab_contents) return ACTION_NONE; diff --git a/chrome/browser/extensions/extension_url_rewrite_browsertest.cc b/chrome/browser/extensions/extension_url_rewrite_browsertest.cc index 4490ca3..3283be0 100644 --- a/chrome/browser/extensions/extension_url_rewrite_browsertest.cc +++ b/chrome/browser/extensions/extension_url_rewrite_browsertest.cc @@ -33,7 +33,7 @@ class ExtensionURLRewriteBrowserTest : public ExtensionBrowserTest { } content::NavigationController* GetNavigationController() const { - return &browser()->GetSelectedWebContents()->GetController(); + return &browser()->GetActiveWebContents()->GetController(); } NavigationEntry* GetNavigationEntry() const { diff --git a/chrome/browser/extensions/extension_web_ui.cc b/chrome/browser/extensions/extension_web_ui.cc index 3c19ed3..ac78082 100644 --- a/chrome/browser/extensions/extension_web_ui.cc +++ b/chrome/browser/extensions/extension_web_ui.cc @@ -16,8 +16,8 @@ #include "chrome/browser/prefs/scoped_user_pref_update.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_constants.h" @@ -170,8 +170,7 @@ ExtensionWebUI::ExtensionWebUI(content::WebUI* web_ui, const GURL& url) // Hack: A few things we specialize just for the bookmark manager. if (extension->id() == extension_misc::kBookmarkManagerId) { - TabContentsWrapper* tab = TabContentsWrapper::GetCurrentWrapperForContents( - web_ui->GetWebContents()); + TabContents* tab = TabContents::FromWebContents(web_ui->GetWebContents()); DCHECK(tab); bookmark_manager_extension_event_router_.reset( new BookmarkManagerExtensionEventRouter(profile, tab)); diff --git a/chrome/browser/extensions/isolated_app_browsertest.cc b/chrome/browser/extensions/isolated_app_browsertest.cc index a08f6c9..6e0373f 100644 --- a/chrome/browser/extensions/isolated_app_browsertest.cc +++ b/chrome/browser/extensions/isolated_app_browsertest.cc @@ -9,7 +9,7 @@ #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/ui_test_utils.h" @@ -123,8 +123,7 @@ IN_PROC_BROWSER_TEST_F(IsolatedAppTest, CookieIsolation) { ui_test_utils::WindowedNotificationObserver observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &browser()->GetSelectedTabContentsWrapper()->web_contents()-> - GetController())); + &browser()->GetActiveWebContents()->GetController())); browser()->Reload(CURRENT_TAB); observer.Wait(); EXPECT_TRUE(HasCookie(tab1, "app1=3")); diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc index 5142edb..5441af6 100644 --- a/chrome/browser/extensions/lazy_background_page_apitest.cc +++ b/chrome/browser/extensions/lazy_background_page_apitest.cc @@ -111,7 +111,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, BrowserActionCreateTab) { EXPECT_FALSE(pm->GetBackgroundHostForExtension(last_loaded_extension_id_)); EXPECT_EQ(num_tabs_before + 1, browser()->tab_count()); EXPECT_EQ("chrome://chrome/extensions/", - browser()->GetSelectedWebContents()->GetURL().spec()); + browser()->GetActiveWebContents()->GetURL().spec()); } IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, @@ -192,7 +192,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, WaitForView) { // The extension should've opened a new tab to an extension page. EXPECT_EQ(extension->GetResourceURL("extension_page.html").spec(), - browser()->GetSelectedWebContents()->GetURL().spec()); + browser()->GetActiveWebContents()->GetURL().spec()); // Lazy Background Page still exists, because the extension created a new tab // to an extension page. @@ -201,7 +201,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, WaitForView) { EXPECT_TRUE(pm->GetBackgroundHostForExtension(last_loaded_extension_id_)); // Close the new tab. - browser()->CloseTabContents(browser()->GetSelectedWebContents()); + browser()->CloseTabContents(browser()->GetActiveWebContents()); page_complete.Wait(); // Lazy Background Page has been shut down. diff --git a/chrome/browser/extensions/lazy_background_task_queue.cc b/chrome/browser/extensions/lazy_background_task_queue.cc index ce733a3..1dab546 100644 --- a/chrome/browser/extensions/lazy_background_task_queue.cc +++ b/chrome/browser/extensions/lazy_background_task_queue.cc @@ -14,7 +14,7 @@ #include "chrome/browser/extensions/process_map.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/tab_contents/tab_util.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_messages.h" diff --git a/chrome/browser/extensions/page_action_controller.cc b/chrome/browser/extensions/page_action_controller.cc index 39dcc7f..9ba6f54 100644 --- a/chrome/browser/extensions/page_action_controller.cc +++ b/chrome/browser/extensions/page_action_controller.cc @@ -4,11 +4,11 @@ #include "chrome/browser/extensions/page_action_controller.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" #include "chrome/browser/extensions/extension_browser_event_router.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_system.h" #include "chrome/browser/extensions/extension_tab_util.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/extensions/extension_set.h" #include "chrome/common/chrome_notification_types.h" #include "content/public/browser/notification_service.h" @@ -16,7 +16,7 @@ namespace extensions { -PageActionController::PageActionController(TabContentsWrapper* tab_contents) +PageActionController::PageActionController(TabContents* tab_contents) : tab_contents_(tab_contents) {} PageActionController::~PageActionController() {} diff --git a/chrome/browser/extensions/page_action_controller.h b/chrome/browser/extensions/page_action_controller.h index 3c7c770..6346e73 100644 --- a/chrome/browser/extensions/page_action_controller.h +++ b/chrome/browser/extensions/page_action_controller.h @@ -14,7 +14,6 @@ class ExtensionService; class TabContents; -typedef TabContents TabContentsWrapper; namespace extensions { @@ -22,7 +21,7 @@ namespace extensions { // on the page_action extension API. class PageActionController : public LocationBarController { public: - explicit PageActionController(TabContentsWrapper* tab_contents); + explicit PageActionController(TabContents* tab_contents); virtual ~PageActionController(); // LocationBarController implementation. @@ -35,7 +34,7 @@ class PageActionController : public LocationBarController { // Gets the ExtensionService for |tab_contents_|. ExtensionService* GetExtensionService(); - TabContentsWrapper* tab_contents_; + TabContents* tab_contents_; DISALLOW_COPY_AND_ASSIGN(PageActionController); }; diff --git a/chrome/browser/extensions/process_management_browsertest.cc b/chrome/browser/extensions/process_management_browsertest.cc index 9436e14..9eac07c 100644 --- a/chrome/browser/extensions/process_management_browsertest.cc +++ b/chrome/browser/extensions/process_management_browsertest.cc @@ -11,7 +11,7 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/ui_test_utils.h" diff --git a/chrome/browser/extensions/script_badge_controller.cc b/chrome/browser/extensions/script_badge_controller.cc index 5eb1066..eb3c28d 100644 --- a/chrome/browser/extensions/script_badge_controller.cc +++ b/chrome/browser/extensions/script_badge_controller.cc @@ -4,9 +4,9 @@ #include "chrome/browser/extensions/script_badge_controller.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_system.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_action.h" #include "chrome/common/extensions/extension_messages.h" @@ -21,7 +21,7 @@ namespace extensions { -ScriptBadgeController::ScriptBadgeController(TabContentsWrapper* tab_contents) +ScriptBadgeController::ScriptBadgeController(TabContents* tab_contents) : content::WebContentsObserver(tab_contents->web_contents()), script_executor_(tab_contents->web_contents()), tab_contents_(tab_contents) {} @@ -119,7 +119,7 @@ void ScriptBadgeController::Notify() { content::NotificationService::current()->Notify( chrome::NOTIFICATION_EXTENSION_LOCATION_BAR_UPDATED, content::Source<Profile>(tab_contents_->profile()), - content::Details<TabContentsWrapper>(tab_contents_)); + content::Details<TabContents>(tab_contents_)); } void ScriptBadgeController::DidNavigateMainFrame( diff --git a/chrome/browser/extensions/script_badge_controller.h b/chrome/browser/extensions/script_badge_controller.h index 7740be8..e40ae49 100644 --- a/chrome/browser/extensions/script_badge_controller.h +++ b/chrome/browser/extensions/script_badge_controller.h @@ -21,7 +21,6 @@ class ExtensionAction; class ExtensionService; class TabContents; -typedef TabContents TabContentsWrapper; namespace IPC { class Message; @@ -51,7 +50,7 @@ class ScriptBadgeController public ScriptExecutor, public content::WebContentsObserver { public: - explicit ScriptBadgeController(TabContentsWrapper* tab_contents); + explicit ScriptBadgeController(TabContents* tab_contents); // LocationBarController implementation. virtual scoped_ptr<std::vector<ExtensionAction*> > GetCurrentActions() @@ -102,8 +101,8 @@ class ScriptBadgeController // Delegate ScriptExecutorImpl for running ExecuteScript. ScriptExecutorImpl script_executor_; - // Our parent TabContentsWrapper. - TabContentsWrapper* tab_contents_; + // Our parent TabContents. + TabContents* tab_contents_; // The extensions that have called ExecuteScript on the current frame. std::set<std::string> extensions_executing_scripts_; diff --git a/chrome/browser/extensions/webstore_inline_install_browsertest.cc b/chrome/browser/extensions/webstore_inline_install_browsertest.cc index e2a5d8a..0570a9b 100644 --- a/chrome/browser/extensions/webstore_inline_install_browsertest.cc +++ b/chrome/browser/extensions/webstore_inline_install_browsertest.cc @@ -77,7 +77,7 @@ class WebstoreInlineInstallTest : public InProcessBrowserTest { std::string script = StringPrintf("%s('%s')", test_function_name.c_str(), test_gallery_url_.c_str()); ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool( - browser()->GetSelectedWebContents()->GetRenderViewHost(), L"", + browser()->GetActiveWebContents()->GetRenderViewHost(), L"", UTF8ToWide(script), &result)); EXPECT_TRUE(result); } @@ -142,7 +142,7 @@ IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallTest, InstallNotSupported) { if (browser()->tab_strip_model()->count() == 1) { ui_test_utils::WaitForNewTab(browser()); } - WebContents* web_contents = browser()->GetSelectedWebContents(); + WebContents* web_contents = browser()->GetActiveWebContents(); EXPECT_EQ(GURL("http://cws.com/show-me-the-money"), web_contents->GetURL()); } diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc index 93e5bf5..06232ea 100644 --- a/chrome/browser/extensions/webstore_installer.cc +++ b/chrome/browser/extensions/webstore_installer.cc @@ -20,7 +20,7 @@ #include "chrome/browser/extensions/crx_installer.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser_list.h" -#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" +#include "chrome/browser/ui/tab_contents/tab_contents.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/chrome_switches.h" diff --git a/chrome/browser/sessions/session_service.cc b/chrome/browser/sessions/session_service.cc index f1fb6b1..b97b6a2 100644 --- a/chrome/browser/sessions/session_service.cc +++ b/chrome/browser/sessions/session_service.cc @@ -680,11 +680,11 @@ void SessionService::Observe(int type, case chrome::NOTIFICATION_TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED: { ExtensionTabHelper* extension_tab_helper = content::Source<ExtensionTabHelper>(source).ptr(); - if (extension_tab_helper->tab_contents_wrapper()->profile() != profile()) + if (extension_tab_helper->tab_contents()->profile() != profile()) return; if (extension_tab_helper->extension_app()) { RestoreTabHelper* helper = - extension_tab_helper->tab_contents_wrapper()->restore_tab_helper(); + extension_tab_helper->tab_contents()->restore_tab_helper(); SetTabExtensionAppID(helper->window_id(), helper->session_id(), extension_tab_helper->extension_app()->id()); diff --git a/chrome/browser/sync/glue/session_change_processor.cc b/chrome/browser/sync/glue/session_change_processor.cc index 7e06e43..66c8248 100644 --- a/chrome/browser/sync/glue/session_change_processor.cc +++ b/chrome/browser/sync/glue/session_change_processor.cc @@ -188,7 +188,7 @@ void SessionChangeProcessor::Observe( return; } if (extension_tab_helper->extension_app()) { - modified_tabs.push_back(extension_tab_helper->tab_contents_wrapper()-> + modified_tabs.push_back(extension_tab_helper->tab_contents()-> synced_tab_delegate()); } DVLOG(1) << "Received TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED " |