diff options
| author | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-27 12:56:14 +0000 |
|---|---|---|
| committer | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-27 12:56:14 +0000 |
| commit | b66f792c9ad058a0004ed1c5a5fcaa2c30afc01a (patch) | |
| tree | a110973a02a76ad090898ff64f7d5970b0777586 | |
| parent | ab6da70632e0113110ec03c68fa7e366c238133d (diff) | |
| download | chromium_src-b66f792c9ad058a0004ed1c5a5fcaa2c30afc01a.zip chromium_src-b66f792c9ad058a0004ed1c5a5fcaa2c30afc01a.tar.gz chromium_src-b66f792c9ad058a0004ed1c5a5fcaa2c30afc01a.tar.bz2 | |
Remove janky Open/Save window initialization.
Before the web contents were loaded after setting the minimal size, but before setting the target size. Therefore, initially the Files.app was updating its size later after receiving an onResize event, instead of from beginning. This caused flickering.
This is 100% reproducible when launching an instance of Files.app first, then trying to fire the Save dialog.
TEST=Open a browser window on Chrome OS, hit CTRL-O.
BUG=249995
Review URL: https://chromiumcodereview.appspot.com/17535002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208905 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/ui/views/select_file_dialog_extension.cc | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/chrome/browser/ui/views/select_file_dialog_extension.cc b/chrome/browser/ui/views/select_file_dialog_extension.cc index 3efc148..c5f4d4f 100644 --- a/chrome/browser/ui/views/select_file_dialog_extension.cc +++ b/chrome/browser/ui/views/select_file_dialog_extension.cc @@ -37,12 +37,9 @@ using content::BrowserThread; namespace { -const int kFileManagerWidth = 954; // pixels +const int kFileManagerWidth = 972; // pixels const int kFileManagerHeight = 640; // pixels -const int kFileManagerMinimumWidth = kFileManagerWidth * 2 / 3; // pixels -const int kFileManagerMinimumHeight = kFileManagerHeight * 2 / 3; // pixels - // Holds references to file manager dialogs that have callbacks pending // to their listeners. class PendingDialog { @@ -354,8 +351,8 @@ void SelectFileDialogExtension::SelectFileImpl( ExtensionDialog* dialog = ExtensionDialog::Show(file_browser_url, base_window, profile_, web_contents, kFileManagerWidth, kFileManagerHeight, - kFileManagerMinimumWidth, - kFileManagerMinimumHeight, + kFileManagerWidth, + kFileManagerHeight, #if defined(USE_AURA) file_manager_util::GetTitleFromType(type), #else |