summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoreugenis@chromium.org <eugenis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-22 09:27:52 +0000
committereugenis@chromium.org <eugenis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-22 09:27:52 +0000
commitb772fcea82cc6572c0c36c3618e827e4a8b206bc (patch)
tree67201623d89db03292dc2c82688603561bf82112
parentd4e827f87e47a47b93a0c68ad8629820ec6e832b (diff)
downloadchromium_src-b772fcea82cc6572c0c36c3618e827e4a8b206bc.zip
chromium_src-b772fcea82cc6572c0c36c3618e827e4a8b206bc.tar.gz
chromium_src-b772fcea82cc6572c0c36c3618e827e4a8b206bc.tar.bz2
Remove -fomit-frame-pointer when building with any Sanitizer.
On Android/ARM we add -fomit-frame-pointer elsewhere in common.gypi. Simply adding -fno-omit-frame-pointer when building with sanitizers is not enough, because the former flag wins (it get added closer to the end of the command line). Therefore, we also remove all -fomit-frame-pointer flags under sanitizers. BUG=325685 TEST=wait for the next clang roll, run asan tests on android R=glider@chromium.org Review URL: https://codereview.chromium.org/143873009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246256 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--build/common.gypi3
1 files changed, 3 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi
index d005e6e..bb64044 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3426,6 +3426,9 @@
'-fno-omit-frame-pointer',
'-gline-tables-only',
],
+ 'cflags!': [
+ '-fomit-frame-pointer',
+ ],
'ldflags!': [
# Functions interposed by the sanitizers can make ld think
# that some libraries aren't needed when they actually are,