diff options
| author | mgiuca <mgiuca@chromium.org> | 2015-07-01 11:29:53 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-01 18:31:39 +0000 |
| commit | bb7eafcfeec81ff39fb4213993c8eb6967ef27b3 (patch) | |
| tree | f8a951004421a3cecd9d3e936667bba110f73bc5 | |
| parent | 4e6190e6239fac9078171c1cd0f7bd98618794d4 (diff) | |
| download | chromium_src-bb7eafcfeec81ff39fb4213993c8eb6967ef27b3.zip chromium_src-bb7eafcfeec81ff39fb4213993c8eb6967ef27b3.tar.gz chromium_src-bb7eafcfeec81ff39fb4213993c8eb6967ef27b3.tar.bz2 | |
service_resolver_64: Correctly check all the bytes of the service code.
Previously was only checking the first 8 bytes.
BUG=506049,505319
Review URL: https://codereview.chromium.org/1209033014
Cr-Commit-Position: refs/heads/master@{#337075}
| -rw-r--r-- | sandbox/win/src/service_resolver_64.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sandbox/win/src/service_resolver_64.cc b/sandbox/win/src/service_resolver_64.cc index 984cb38..8c0ae96 100644 --- a/sandbox/win/src/service_resolver_64.cc +++ b/sandbox/win/src/service_resolver_64.cc @@ -154,8 +154,8 @@ bool ServiceResolverThunk::IsFunctionAService(void* local_thunk) const { // See if it's the Win8 signature. ServiceEntryW8* w8_service = &function_code.original_w8; if (!IsService(&w8_service->mov_r10_rcx_mov_eax) || - w8_service->mov_1 != kMov1 || w8_service->mov_1 != kMov1 || - w8_service->mov_1 != kMov1) { + w8_service->mov_1 != kMov1 || w8_service->mov_2 != kMov2 || + w8_service->mov_3 != kMov3) { return false; } } |