diff options
author | primiano <primiano@chromium.org> | 2015-05-27 10:37:00 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-27 17:38:10 +0000 |
commit | be0bb6d0ee64a0e1244ee017d819e36d1e0101eb (patch) | |
tree | 4c04b4775678c8bf002e5154aa6e8274200e76d0 | |
parent | a37f59b9b90db9e33719c5a8e1ee1f35805f18f1 (diff) | |
download | chromium_src-be0bb6d0ee64a0e1244ee017d819e36d1e0101eb.zip chromium_src-be0bb6d0ee64a0e1244ee017d819e36d1e0101eb.tar.gz chromium_src-be0bb6d0ee64a0e1244ee017d819e36d1e0101eb.tar.bz2 |
Add 'explicit' qualifiers to single-arguments ctors
Just noticed that some single-arg ctors in the codebase missed the explicit qualifier.
BUG=
TBR=armansito
Review URL: https://codereview.chromium.org/1148943005
Cr-Commit-Position: refs/heads/master@{#331595}
19 files changed, 19 insertions, 19 deletions
diff --git a/android_webview/browser/aw_printing_message_filter.h b/android_webview/browser/aw_printing_message_filter.h index dac6548..f5c159c 100644 --- a/android_webview/browser/aw_printing_message_filter.h +++ b/android_webview/browser/aw_printing_message_filter.h @@ -13,7 +13,7 @@ namespace android_webview { // renderer process on the IPC thread. class AwPrintingMessageFilter : public content::BrowserMessageFilter { public: - AwPrintingMessageFilter(int render_process_id); + explicit AwPrintingMessageFilter(int render_process_id); // content::BrowserMessageFilter methods. void OverrideThreadForMessage(const IPC::Message& message, diff --git a/android_webview/browser/scoped_app_gl_state_restore.h b/android_webview/browser/scoped_app_gl_state_restore.h index b6d59c9..fdad735 100644 --- a/android_webview/browser/scoped_app_gl_state_restore.h +++ b/android_webview/browser/scoped_app_gl_state_restore.h @@ -25,7 +25,7 @@ class ScopedAppGLStateRestore { MODE_RESOURCE_MANAGEMENT, }; - ScopedAppGLStateRestore(CallMode mode); + explicit ScopedAppGLStateRestore(CallMode mode); ~ScopedAppGLStateRestore(); bool stencil_enabled() const; diff --git a/components/cloud_devices/common/printer_description.h b/components/cloud_devices/common/printer_description.h index c3ceee8..09c822b 100644 --- a/components/cloud_devices/common/printer_description.h +++ b/components/cloud_devices/common/printer_description.h @@ -313,7 +313,7 @@ struct Media { struct Interval { Interval(); Interval(int32 start, int32 end); - Interval(int32 start); + explicit Interval(int32 start); bool operator==(const Interval& other) const; bool operator!=(const Interval& other) const { return !(*this == other); } diff --git a/components/invalidation/invalidation_service_android.h b/components/invalidation/invalidation_service_android.h index 6bb79c6..19ba4b2 100644 --- a/components/invalidation/invalidation_service_android.h +++ b/components/invalidation/invalidation_service_android.h @@ -29,7 +29,7 @@ class InvalidationServiceAndroid : public base::NonThreadSafe, public InvalidationService { public: - InvalidationServiceAndroid(jobject context); + explicit InvalidationServiceAndroid(jobject context); ~InvalidationServiceAndroid() override; // InvalidationService implementation. diff --git a/content/browser/devtools/worker_devtools_agent_host.h b/content/browser/devtools/worker_devtools_agent_host.h index d252f56..ace0d29 100644 --- a/content/browser/devtools/worker_devtools_agent_host.h +++ b/content/browser/devtools/worker_devtools_agent_host.h @@ -38,7 +38,7 @@ class WorkerDevToolsAgentHost : public DevToolsAgentHostImpl, bool IsTerminated(); protected: - WorkerDevToolsAgentHost(WorkerId worker_id); + explicit WorkerDevToolsAgentHost(WorkerId worker_id); ~WorkerDevToolsAgentHost() override; enum WorkerState { diff --git a/content/browser/geofencing/mock_geofencing_service.h b/content/browser/geofencing/mock_geofencing_service.h index 4634b26..6ba9f0d 100644 --- a/content/browser/geofencing/mock_geofencing_service.h +++ b/content/browser/geofencing/mock_geofencing_service.h @@ -20,7 +20,7 @@ namespace content { // will behave as if the platform does not support geofencing. class MockGeofencingService : public GeofencingService { public: - MockGeofencingService(bool service_available); + explicit MockGeofencingService(bool service_available); ~MockGeofencingService() override; void SetMockPosition(double latitude, double longitude); diff --git a/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h b/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h index fe9790c..201dfcf 100644 --- a/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h +++ b/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h @@ -45,7 +45,7 @@ class CONTENT_EXPORT SyntheticSmoothMoveGestureParams { // to compensate for the touch slop. class CONTENT_EXPORT SyntheticSmoothMoveGesture : public SyntheticGesture { public: - SyntheticSmoothMoveGesture(SyntheticSmoothMoveGestureParams params); + explicit SyntheticSmoothMoveGesture(SyntheticSmoothMoveGestureParams params); ~SyntheticSmoothMoveGesture() override; // SyntheticGesture implementation: diff --git a/content/browser/renderer_host/legacy_render_widget_host_win.h b/content/browser/renderer_host/legacy_render_widget_host_win.h index a1e952d..70f6859 100644 --- a/content/browser/renderer_host/legacy_render_widget_host_win.h +++ b/content/browser/renderer_host/legacy_render_widget_host_win.h @@ -110,7 +110,7 @@ class CONTENT_EXPORT LegacyRenderWidgetHostHWND void OnFinalMessage(HWND hwnd) override; private: - LegacyRenderWidgetHostHWND(HWND parent); + explicit LegacyRenderWidgetHostHWND(HWND parent); ~LegacyRenderWidgetHostHWND() override; bool Init(); diff --git a/content/browser/renderer_host/media/peer_connection_tracker_host.h b/content/browser/renderer_host/media/peer_connection_tracker_host.h index 0d7b506..788af93 100644 --- a/content/browser/renderer_host/media/peer_connection_tracker_host.h +++ b/content/browser/renderer_host/media/peer_connection_tracker_host.h @@ -23,7 +23,7 @@ namespace content { class PeerConnectionTrackerHost : public BrowserMessageFilter, public base::PowerObserver { public: - PeerConnectionTrackerHost(int render_process_id); + explicit PeerConnectionTrackerHost(int render_process_id); // content::BrowserMessageFilter override. bool OnMessageReceived(const IPC::Message& message) override; diff --git a/content/common/gpu/media/vt_video_decode_accelerator.h b/content/common/gpu/media/vt_video_decode_accelerator.h index 7fbc888..61d0309 100644 --- a/content/common/gpu/media/vt_video_decode_accelerator.h +++ b/content/common/gpu/media/vt_video_decode_accelerator.h @@ -85,7 +85,7 @@ class VTVideoDecodeAccelerator : public media::VideoDecodeAccelerator { }; struct Frame { - Frame(int32_t bitstream_id); + explicit Frame(int32_t bitstream_id); ~Frame(); // ID of the bitstream buffer this Frame will be decoded from. diff --git a/content/public/browser/background_tracing_config.h b/content/public/browser/background_tracing_config.h index ffda09a..112a822 100644 --- a/content/public/browser/background_tracing_config.h +++ b/content/public/browser/background_tracing_config.h @@ -36,7 +36,7 @@ struct CONTENT_EXPORT BackgroundTracingConfig { base::DictionaryValue* dict); protected: - BackgroundTracingConfig(Mode mode); + explicit BackgroundTracingConfig(Mode mode); }; } // namespace content diff --git a/device/bluetooth/bluetooth_advertisement.h b/device/bluetooth/bluetooth_advertisement.h index 69e7121..f040e13 100644 --- a/device/bluetooth/bluetooth_advertisement.h +++ b/device/bluetooth/bluetooth_advertisement.h @@ -53,7 +53,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdvertisement // Structure that holds the data for an advertisement. class DEVICE_BLUETOOTH_EXPORT Data { public: - Data(AdvertisementType type); + explicit Data(AdvertisementType type); ~Data(); AdvertisementType type() { return type_; } diff --git a/native_client_sdk/src/libraries/nacl_io/pipe/pipe_event_emitter.h b/native_client_sdk/src/libraries/nacl_io/pipe/pipe_event_emitter.h index 66d091e..9aaaf06 100644 --- a/native_client_sdk/src/libraries/nacl_io/pipe/pipe_event_emitter.h +++ b/native_client_sdk/src/libraries/nacl_io/pipe/pipe_event_emitter.h @@ -22,7 +22,7 @@ typedef sdk_util::ScopedRef<PipeEventEmitter> ScopedPipeEventEmitter; class PipeEventEmitter : public StreamEventEmitter { public: - PipeEventEmitter(size_t size); + explicit PipeEventEmitter(size_t size); Error Read_Locked(char* data, size_t len, int* out_bytes); Error Write_Locked(const char* data, size_t len, int* out_bytes); diff --git a/net/base/chunked_upload_data_stream.h b/net/base/chunked_upload_data_stream.h index d17c8da..0db5b97 100644 --- a/net/base/chunked_upload_data_stream.h +++ b/net/base/chunked_upload_data_stream.h @@ -23,7 +23,7 @@ class IOBuffer; // seekable data, due to this buffering behavior. class NET_EXPORT ChunkedUploadDataStream : public UploadDataStream { public: - ChunkedUploadDataStream(int64 identifier); + explicit ChunkedUploadDataStream(int64 identifier); ~ChunkedUploadDataStream() override; diff --git a/net/base/upload_file_element_reader.h b/net/base/upload_file_element_reader.h index fc3f334..04ce928 100644 --- a/net/base/upload_file_element_reader.h +++ b/net/base/upload_file_element_reader.h @@ -71,7 +71,7 @@ class NET_EXPORT UploadFileElementReader : public UploadElementReader { // Sets an value to override the result for GetContentLength(). // Used for tests. struct NET_EXPORT_PRIVATE ScopedOverridingContentLengthForTests { - ScopedOverridingContentLengthForTests(uint64 value); + explicit ScopedOverridingContentLengthForTests(uint64 value); ~ScopedOverridingContentLengthForTests(); }; diff --git a/net/filter/gzip_filter.h b/net/filter/gzip_filter.h index 42dc320..2306c9b 100644 --- a/net/filter/gzip_filter.h +++ b/net/filter/gzip_filter.h @@ -73,7 +73,7 @@ class GZipFilter : public Filter { static const int kGZipFooterSize = 8; // Only to be instantiated by Filter::Factory. - GZipFilter(FilterType type); + explicit GZipFilter(FilterType type); friend class Filter; // Parses and verifies the GZip header. diff --git a/ppapi/cpp/view.h b/ppapi/cpp/view.h index 13c7a81..7abcac79 100644 --- a/ppapi/cpp/view.h +++ b/ppapi/cpp/view.h @@ -24,7 +24,7 @@ class View : public Resource { /// Creates a View resource, taking and holding an additional reference to /// the given resource handle. - View(PP_Resource view_resource); + explicit View(PP_Resource view_resource); /// GetRect() retrieves the rectangle of the module instance associated /// with a view changed notification relative to the upper-left of the browser diff --git a/remoting/host/audio_silence_detector.h b/remoting/host/audio_silence_detector.h index 83beec3..f02be31 100644 --- a/remoting/host/audio_silence_detector.h +++ b/remoting/host/audio_silence_detector.h @@ -15,7 +15,7 @@ class AudioSilenceDetector { public: // |threshold| is used to specify maximum absolute sample value that should // still be considered as silence. - AudioSilenceDetector(int threshold); + explicit AudioSilenceDetector(int threshold); ~AudioSilenceDetector(); void Reset(int sampling_rate, int channels); diff --git a/ui/ozone/common/display_util.h b/ui/ozone/common/display_util.h index f56ad12..6289fdd 100644 --- a/ui/ozone/common/display_util.h +++ b/ui/ozone/common/display_util.h @@ -22,7 +22,7 @@ class DisplaySnapshot; // find a display with |display_id| in std:: containers (ie: std::vector). class FindDisplayById { public: - FindDisplayById(int64_t display_id); + explicit FindDisplayById(int64_t display_id); bool operator()(const DisplaySnapshot_Params& display) const; |