summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordschuyler <dschuyler@chromium.org>2016-02-05 12:18:59 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-05 20:23:11 +0000
commitbef9fb22eb49860f454a3c5fdee54c79b33215d9 (patch)
tree66b88ef2ea62f460947c4356839d4b2ad7f2bce7
parenta3229f120a90b960dbba6520a434b65af7e57a35 (diff)
downloadchromium_src-bef9fb22eb49860f454a3c5fdee54c79b33215d9.zip
chromium_src-bef9fb22eb49860f454a3c5fdee54c79b33215d9.tar.gz
chromium_src-bef9fb22eb49860f454a3c5fdee54c79b33215d9.tar.bz2
[MD settings] updating side nav to match mocks
This CL contains updates to the UI made with Alan (to match the UI mocks). BUG=584478 Review URL: https://codereview.chromium.org/1665413002 Cr-Commit-Position: refs/heads/master@{#373893}
-rw-r--r--chrome/browser/resources/settings/settings_menu/settings_menu.css8
-rw-r--r--chrome/browser/resources/settings/settings_menu/settings_menu.html128
-rw-r--r--chrome/browser/resources/settings/settings_menu/settings_menu.js17
-rw-r--r--chrome/browser/resources/settings/settings_resources.grd3
4 files changed, 104 insertions, 52 deletions
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.css b/chrome/browser/resources/settings/settings_menu/settings_menu.css
deleted file mode 100644
index 598ff64..0000000
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.css
+++ /dev/null
@@ -1,8 +0,0 @@
-/* Copyright 2015 The Chromium Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file. */
-
-paper-menu {
- background-color: transparent;
- color: #5a5a5a;
-}
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html
index d615b8e..1921c50 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html
@@ -4,7 +4,6 @@
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/hardware-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/social-icons.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-icon-item.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submenu.html">
@@ -13,92 +12,141 @@
</if>
<dom-module id="settings-menu">
- <link rel="import" type="css" href="settings_menu.css">
<template>
+ <style>
+ iron-icon {
+ -webkit-margin-end: 16px;
+ height: 20px;
+ width: 20px;
+ }
+
+ .menu-trigger span {
+ -webkit-margin-end: 16px;
+ flex: 1;
+ }
+
+ paper-menu {
+ background-color: rgb(236, 239, 241);
+ color: #5a5a5a;
+ font-size: 13px;
+ --paper-menu-selected-item: {
+ font-weight: 500;
+ };
+ --paper-menu-focused-item-after: {
+ background: none;
+ };
+ }
+
+ paper-submenu {
+ --paper-menu-selected-item: {
+ font-weight: 500;
+ };
+ }
+
+ paper-submenu paper-menu {
+ --paper-menu-selected-item: {
+ color: #4285f4;
+ font-weight: 500;
+ };
+ padding: 0;
+ }
+
+ paper-submenu div {
+ @apply(--layout-center);
+ -webkit-margin-start: 24px;
+ display: flex;
+ font-size: 13px;
+ font-weight: 500;
+ min-height: 40px;
+ }
+ </style>
<paper-menu name="root-menu">
- <paper-submenu data-page="basic" on-tap="openPage_">
- <paper-icon-item class="menu-trigger">
- <iron-icon icon="expand-more" item-icon></iron-icon>
+ <paper-submenu opened="{{basicOpened_}}" data-page="basic"
+ on-tap="openPage_">
+ <div class="menu-trigger">
<span i18n-content="basicPageTitle"></span>
- </paper-icon-item>
+ <iron-icon icon="{{arrowState_(basicOpened_)}}" item-icon></iron-icon>
+ </div>
<paper-menu class="menu-content">
<if expr="chromeos">
- <paper-icon-item>
+ <div>
<iron-icon icon="settings-ethernet" item-icon></iron-icon>
<span i18n-content="internetPageTitle"></span>
- </paper-icon-item>
+ </div>
</if>
- <paper-icon-item>
+ <div>
<iron-icon icon="social:person" item-icon></iron-icon>
<span i18n-content="peoplePageTitle"></span>
- </paper-icon-item>
- <paper-icon-item>
+ </div>
+ <div>
<iron-icon icon="home" item-icon></iron-icon>
<span i18n-content="appearancePageTitle"></span>
- </paper-icon-item>
- <paper-icon-item>
+ </div>
+ <div>
<iron-icon icon="image:brightness-1" item-icon></iron-icon>
<span i18n-content="onStartup"></span>
- </paper-icon-item>
- <paper-icon-item>
+ </div>
+ <div>
<iron-icon icon="search" item-icon></iron-icon>
<span i18n-content="searchPageTitle"></span>
- </paper-icon-item>
+ </div>
<if expr="not chromeos">
- <paper-icon-item>
+ <div>
<iron-icon icon="open-in-browser" item-icon></iron-icon>
<span i18n-content="defaultBrowser"></span>
- </paper-icon-item>
+ </div>
</if>
</paper-menu>
</paper-submenu>
- <paper-submenu data-page="advanced" on-tap="openPage_">
- <paper-icon-item class="menu-trigger">
- <iron-icon icon="expand-more" item-icon></iron-icon>
+ <paper-submenu opened="{{advancedOpened_}}" data-page="advanced"
+ on-tap="openPage_">
+ <div class="menu-trigger">
<span i18n-content="advancedPageTitle"></span>
- </paper-icon-item>
+ <iron-icon icon="{{arrowState_(advancedOpened_)}}" item-icon>
+ </iron-icon>
+ </div>
<paper-menu class="menu-content">
- <paper-icon-item>
+ <div>
<iron-icon icon="communication:location-on" item-icon></iron-icon>
<span i18n-content="siteSettingsLocation"></span>
- </paper-icon-item>
+ </div>
<if expr="chromeos">
- <paper-icon-item>
+ <div>
<iron-icon icon="device:access-time" item-icon></iron-icon>
<span i18n-content="dateTimePageTitle"></span>
- </paper-icon-item>
+ </div>
</if>
- <paper-icon-item>
+ <div>
<iron-icon icon="hardware:security" item-icon></iron-icon>
<span i18n-content="privacyPageTitle"></span>
- </paper-icon-item>
+ </div>
<if expr="chromeos">
- <paper-icon-item>
+ <div>
<iron-icon icon="device:bluetooth" item-icon></iron-icon>
<span i18n-content="bluetoothPageTitle"></span>
- </paper-icon-item>
+ </div>
</if>
- <paper-icon-item>
+ <div>
<iron-icon icon="lock" item-icon></iron-icon>
<span i18n-content="passwordsAndAutofillPageTitle"></span>
- </paper-icon-item>
- <paper-icon-item>
+ </div>
+ <div>
<iron-icon icon="language" item-icon></iron-icon>
<span i18n-content="languagesPageTitle"></span>
- </paper-icon-item>
- <paper-icon-item>
+ </div>
+ <div>
<iron-icon icon="file-download" item-icon></iron-icon>
<span i18n-content="downloadsPageTitle"></span>
- </paper-icon-item>
- <paper-icon-item>
+ </div>
+ <div>
<iron-icon icon="settings-backup-restore" item-icon></iron-icon>
<span i18n-content="resetPageTitle"></span>
- </paper-icon-item>
+ </div>
<if expr="chromeos">
- <paper-icon-item>
+ <div>
<iron-icon icon="accessibility" item-icon></iron-icon>
<span i18n-content="a11yPageTitle"></span>
- </paper-icon-item>
+ </div>
</if>
</paper-menu>
</paper-submenu>
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 9c873a1..86141d9 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -18,6 +18,12 @@ Polymer({
is: 'settings-menu',
properties: {
+ /** @private */
+ advancedOpened_: Boolean,
+
+ /** @private */
+ basicOpened_: Boolean,
+
/**
* The current active route.
*/
@@ -46,5 +52,14 @@ Polymer({
subpage: [],
};
}
- }
+ },
+
+ /**
+ * @param {boolean} opened Whether the menu is expanded.
+ * @return {string} Which icon to use.
+ * @private
+ * */
+ arrowState_: function(opened) {
+ return opened ? 'arrow-drop-up' : 'arrow-drop-down';
+ },
});
diff --git a/chrome/browser/resources/settings/settings_resources.grd b/chrome/browser/resources/settings/settings_resources.grd
index 146c267..8c3492e 100644
--- a/chrome/browser/resources/settings/settings_resources.grd
+++ b/chrome/browser/resources/settings/settings_resources.grd
@@ -89,9 +89,6 @@
<structure name="IDR_SETTINGS_CR_SETTINGS_MAIN_JS"
file="settings_main/settings_main.js"
type="chrome_html" />
- <structure name="IDR_SETTINGS_CR_SETTINGS_MENU_CSS"
- file="settings_menu/settings_menu.css"
- type="chrome_html" />
<structure name="IDR_SETTINGS_CR_SETTINGS_MENU_HTML"
file="settings_menu/settings_menu.html"
type="chrome_html"