diff options
author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-18 15:02:22 +0000 |
---|---|---|
committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-18 15:02:22 +0000 |
commit | bf8ddf13a670f9977414377e1c19606932662568 (patch) | |
tree | fe2b11c93a179340cca96655856a40251d1a02f9 | |
parent | 8f0646c3d8a377f6744a4e2db303909596daf54e (diff) | |
download | chromium_src-bf8ddf13a670f9977414377e1c19606932662568.zip chromium_src-bf8ddf13a670f9977414377e1c19606932662568.tar.gz chromium_src-bf8ddf13a670f9977414377e1c19606932662568.tar.bz2 |
Remove two unused logging::LogMessage constructors.
(We could probably also get rid of a third one, namely the one used by
CHECK_EQ, etc. But I'd do that separately.)
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/340573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278066 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | base/logging.cc | 11 | ||||
-rw-r--r-- | base/logging.h | 26 |
2 files changed, 4 insertions, 33 deletions
diff --git a/base/logging.cc b/base/logging.cc index a1ba1b3..b2938f3 100644 --- a/base/logging.cc +++ b/base/logging.cc @@ -521,17 +521,6 @@ LogMessage::SaveLastError::~SaveLastError() { } #endif // defined(OS_WIN) -LogMessage::LogMessage(const char* file, int line, LogSeverity severity, - int ctr) - : severity_(severity), file_(file), line_(line) { - Init(file, line); -} - -LogMessage::LogMessage(const char* file, int line) - : severity_(LOG_INFO), file_(file), line_(line) { - Init(file, line); -} - LogMessage::LogMessage(const char* file, int line, LogSeverity severity) : severity_(severity), file_(file), line_(line) { Init(file, line); diff --git a/base/logging.h b/base/logging.h index b4851a5..bc97ae1 100644 --- a/base/logging.h +++ b/base/logging.h @@ -684,32 +684,14 @@ const LogSeverity LOG_DCHECK = LOG_INFO; // above. class BASE_EXPORT LogMessage { public: - LogMessage(const char* file, int line, LogSeverity severity, int ctr); - - // Two special constructors that generate reduced amounts of code at - // LOG call sites for common cases. - // - // Used for LOG(INFO): Implied are: - // severity = LOG_INFO, ctr = 0 - // - // Using this constructor instead of the more complex constructor above - // saves a couple of bytes per call site. - LogMessage(const char* file, int line); - - // Used for LOG(severity) where severity != INFO. Implied - // are: ctr = 0 - // - // Using this constructor instead of the more complex constructor above - // saves a couple of bytes per call site. + // Used for LOG(severity). LogMessage(const char* file, int line, LogSeverity severity); - // A special constructor used for check failures. Takes ownership - // of the given string. - // Implied severity = LOG_FATAL + // Used for CHECK_EQ(), etc. Takes ownership of the given string. + // Implied severity = LOG_FATAL. LogMessage(const char* file, int line, std::string* result); - // A special constructor used for check failures, with the option to - // specify severity. Takes ownership of the given string. + // Used for DCHECK_EQ(), etc. Takes ownership of the given string. LogMessage(const char* file, int line, LogSeverity severity, std::string* result); |