summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorxhwang@google.com <xhwang@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-01 11:41:24 +0000
committerxhwang@google.com <xhwang@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-01 11:41:24 +0000
commitbffe0a5b557d760806e4a01cccd952e303112316 (patch)
tree65324691c65fea366543846e3de5b61ac99df710
parentf51d035dbfa453b1de1e4bbb4f4b58424a50a2d7 (diff)
downloadchromium_src-bffe0a5b557d760806e4a01cccd952e303112316.zip
chromium_src-bffe0a5b557d760806e4a01cccd952e303112316.tar.gz
chromium_src-bffe0a5b557d760806e4a01cccd952e303112316.tar.bz2
Remove "using base::MessageLoop" from message_loop.h.
TBR=thestig@chromium.org BUG=236029 TEST=none Review URL: https://codereview.chromium.org/15660015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203599 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--base/message_loop.h6
-rw-r--r--chrome/browser/extensions/app_background_page_apitest.cc2
-rw-r--r--chrome/browser/extensions/app_process_apitest.cc4
-rw-r--r--chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc2
-rw-r--r--chrome/browser/password_manager/password_form_manager_unittest.cc2
-rw-r--r--chrome/test/chromedriver/chrome/adb_impl.cc2
6 files changed, 6 insertions, 12 deletions
diff --git a/base/message_loop.h b/base/message_loop.h
index 509d7fa..5013615 100644
--- a/base/message_loop.h
+++ b/base/message_loop.h
@@ -730,10 +730,4 @@ COMPILE_ASSERT(sizeof(MessageLoop) == sizeof(MessageLoopForIO),
} // namespace base
-// TODO(brettw) remove this when all users are updated to explicitly use the
-// namespace
-using base::MessageLoop;
-using base::MessageLoopForIO;
-using base::MessageLoopForUI;
-
#endif // BASE_MESSAGE_LOOP_H_
diff --git a/chrome/browser/extensions/app_background_page_apitest.cc b/chrome/browser/extensions/app_background_page_apitest.cc
index ba770cf..2247ec4 100644
--- a/chrome/browser/extensions/app_background_page_apitest.cc
+++ b/chrome/browser/extensions/app_background_page_apitest.cc
@@ -96,7 +96,7 @@ class AppBackgroundPageApiTest : public ExtensionApiTest {
}
void UnloadExtensionViaTask(const std::string& id) {
- MessageLoop::current()->PostTask(
+ base::MessageLoop::current()->PostTask(
FROM_HERE,
base::Bind(&AppBackgroundPageApiTest::UnloadExtension, this, id));
}
diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc
index b09c107..2ab4206 100644
--- a/chrome/browser/extensions/app_process_apitest.cc
+++ b/chrome/browser/extensions/app_process_apitest.cc
@@ -689,8 +689,8 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, ServerRedirectToAppFromExtension) {
// Wait for app tab to be created and loaded.
test_navigation_observer.WaitForObservation(
base::Bind(&content::RunMessageLoop),
- base::Bind(&MessageLoop::Quit,
- base::Unretained(MessageLoopForUI::current())));
+ base::Bind(&base::MessageLoop::Quit,
+ base::Unretained(base::MessageLoopForUI::current())));
// App has loaded, and chrome.app.isInstalled should be true.
bool is_installed = false;
diff --git a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc
index 023a078..11b1da8 100644
--- a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc
+++ b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc
@@ -44,7 +44,7 @@ class NotificationBitmapFetcherTestDelegate
// For async calls, we need to quit the message loop so the test can
// continue.
if (async_) {
- MessageLoop::current()->Quit();
+ base::MessageLoop::current()->Quit();
}
}
diff --git a/chrome/browser/password_manager/password_form_manager_unittest.cc b/chrome/browser/password_manager/password_form_manager_unittest.cc
index 676a3ec..f42f909 100644
--- a/chrome/browser/password_manager/password_form_manager_unittest.cc
+++ b/chrome/browser/password_manager/password_form_manager_unittest.cc
@@ -334,7 +334,7 @@ TEST_F(PasswordFormManagerTest, TestDynamicAction) {
TEST_F(PasswordFormManagerTest, TestAlternateUsername) {
// Need a MessageLoop for callbacks.
- MessageLoop message_loop;
+ base::MessageLoop message_loop;
PasswordStoreFactory::GetInstance()->SetTestingFactory(
profile(), &TestPasswordStore::Create);
scoped_refptr<TestPasswordStore> password_store =
diff --git a/chrome/test/chromedriver/chrome/adb_impl.cc b/chrome/test/chromedriver/chrome/adb_impl.cc
index a90792f..7bc2b53 100644
--- a/chrome/test/chromedriver/chrome/adb_impl.cc
+++ b/chrome/test/chromedriver/chrome/adb_impl.cc
@@ -32,7 +32,7 @@ void ReceiveAdbResponse(std::string* response_out, bool* success,
void ExecuteCommandOnIOThread(
const std::string& command, std::string* response, bool* success,
base::WaitableEvent* event) {
- CHECK(MessageLoop::current()->IsType(MessageLoop::TYPE_IO));
+ CHECK(base::MessageLoop::current()->IsType(base::MessageLoop::TYPE_IO));
AdbClientSocket::AdbQuery(kAdbPort, command,
base::Bind(&ReceiveAdbResponse, response, success, event));
}