diff options
| author | kelvinp@chromium.org <kelvinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-08 23:39:17 +0000 |
|---|---|---|
| committer | kelvinp@chromium.org <kelvinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-08 23:39:17 +0000 |
| commit | c00604f449d21386031ec3839dbda9c5a999e256 (patch) | |
| tree | bb012de2a28639c8f7b49c8753a0e2d22a7d6a74 | |
| parent | 51e6efd247934b09cd531428411f6ed377e5665d (diff) | |
| download | chromium_src-c00604f449d21386031ec3839dbda9c5a999e256.zip chromium_src-c00604f449d21386031ec3839dbda9c5a999e256.tar.gz chromium_src-c00604f449d21386031ec3839dbda9c5a999e256.tar.bz2 | |
Vertical align text for error messages
We would like single-line messages to center align with the icon and multi-line messages to top align with the icon.
In the existing implementation, we use a different CSS rule for multi-line messages to adjust the padding. This is undesirable as we can't predetermine whether a message would fit in one line before actually laying it out.
This change simplifies the CSS by vertical aligning text for error messages, which can achieve the desired behavior for both single and multi line messages.
Review URL: https://codereview.chromium.org/317013009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281885 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | remoting/webapp/html/dialog_client_host_needs_upgrade.html | 4 | ||||
| -rw-r--r-- | remoting/webapp/main.css | 9 |
2 files changed, 6 insertions, 7 deletions
diff --git a/remoting/webapp/html/dialog_client_host_needs_upgrade.html b/remoting/webapp/html/dialog_client_host_needs_upgrade.html index 3c26b48..abcdcd3 100644 --- a/remoting/webapp/html/dialog_client_host_needs_upgrade.html +++ b/remoting/webapp/html/dialog_client_host_needs_upgrade.html @@ -4,8 +4,8 @@ Use of this source code is governed by a BSD-style license that can be found in the LICENSE file. --> <div data-ui-mode="home.client.host-needs-upgrade"> - <div id="host-needs-update-message" - class="message error-state multi-line-error-state"> + <div class="message"> + <div id="host-needs-update-message" class="error-state"></div> </div> <div class="message"> <span i18n-content="HOST_NEEDS_UPDATE_DETAIL"></span> diff --git a/remoting/webapp/main.css b/remoting/webapp/main.css index 3f58aae..30ff3ae 100644 --- a/remoting/webapp/main.css +++ b/remoting/webapp/main.css @@ -389,13 +389,12 @@ section { background-repeat: no-repeat; background-position: top __MSG_@@bidi_start_edge__; padding-__MSG_@@bidi_start_edge__: 30px; - padding-top: 5px; color: #900; -} -.error-state.multi-line-error-state { - padding-top: 0; - min-height: 22px; + /* Vertical align the text*/ + display: table-cell; + vertical-align: middle; + height: 24px; } .expiring { |