test IWYU fixups for base

These are some of the suggestions from running include-what-you-use[1]
on the base target.

[1] https://code.google.com/p/include-what-you-use/

BUG=259043

Review URL: https://chromiumcodereview.appspot.com/23540009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221067 0039d316-1c4b-4281-b951-d872f2087c98

19 files changed, 50 insertions, 13 deletions

diff --git a/base/stl_util.h b/base/stl_util.h
index edd8803..ccad09d 100644
--- a/base/stl_util.h
+++ b/base/stl_util.h
@@ -9,6 +9,7 @@
 
 #include <algorithm>
 #include <functional>
+#include <iterator>
 #include <string>
 #include <vector>
 
diff --git a/base/time/time.cc b/base/time/time.cc
index 5f495e3..ce25dea 100644
--- a/base/time/time.cc
+++ b/base/time/time.cc
@@ -4,13 +4,13 @@
 
 #include "base/time/time.h"
 
-#include <math.h>
 #include <limits>
+#include <ostream>
 
 #include "base/float_util.h"
 #include "base/logging.h"
-#include "base/strings/sys_string_conversions.h"
 #include "base/third_party/nspr/prtime.h"
+#include "base/third_party/nspr/prtypes.h"
 
 namespace base {
 
diff --git a/base/time/time.h b/base/time/time.h
index af95700..eba6145 100644
--- a/base/time/time.h
+++ b/base/time/time.h
@@ -25,9 +25,9 @@
 
 #include <time.h>
 
-#include "base/atomicops.h"
 #include "base/base_export.h"
 #include "base/basictypes.h"
+#include "build/build_config.h"
 
 #if defined(OS_MACOSX)
 #include <CoreFoundation/CoreFoundation.h>
diff --git a/base/time/time_posix.cc b/base/time/time_posix.cc
index 16eb83c..39958f7 100644
--- a/base/time/time_posix.cc
+++ b/base/time/time_posix.cc
@@ -4,16 +4,21 @@
 
 #include "base/time/time.h"
 
+#include <stdint.h>
 #include <sys/time.h>
 #include <time.h>
 #if defined(OS_ANDROID)
 #include <time64.h>
 #endif
+#include <unistd.h>
 
 #include <limits>
+#include <ostream>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
+#include "base/port.h"
+#include "build/build_config.h"
 
 #if defined(OS_ANDROID)
 #include "base/os_compat_android.h"
diff --git a/base/timer/timer.cc b/base/timer/timer.cc
index ff1c087..aafc01e 100644
--- a/base/timer/timer.cc
+++ b/base/timer/timer.cc
@@ -4,7 +4,10 @@
 
 #include "base/timer/timer.h"
 
+#include <stddef.h>
+
 #include "base/logging.h"
+#include "base/memory/ref_counted.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/platform_thread.h"
diff --git a/base/timer/timer.h b/base/timer/timer.h
index 23b1d3c..f952d41 100644
--- a/base/timer/timer.h
+++ b/base/timer/timer.h
@@ -50,6 +50,7 @@
 // should be able to tell the difference.
 
 #include "base/base_export.h"
+#include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
@@ -59,7 +60,6 @@
 namespace base {
 
 class BaseTimerTaskInternal;
-class MessageLoop;
 
 //-----------------------------------------------------------------------------
 // This class wraps MessageLoop::PostDelayedTask to manage delayed and repeating
diff --git a/base/tracked_objects.cc b/base/tracked_objects.cc
index 38963c2..0847d5f 100644
--- a/base/tracked_objects.cc
+++ b/base/tracked_objects.cc
@@ -4,22 +4,24 @@
 
 #include "base/tracked_objects.h"
 
-#include <math.h>
+#include <limits.h>
 #include <stdlib.h>
 
 #include "base/compiler_specific.h"
 #include "base/debug/leak_annotations.h"
-#include "base/format_macros.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/port.h"
+#include "base/logging.h"
 #include "base/process/process_handle.h"
 #include "base/profiler/alternate_timer.h"
 #include "base/strings/stringprintf.h"
 #include "base/third_party/valgrind/memcheck.h"
-#include "base/threading/thread_restrictions.h"
+#include "base/tracking_info.h"
 
 using base::TimeDelta;
 
+namespace base {
+class TimeDelta;
+}
+
 namespace tracked_objects {
 
 namespace {
diff --git a/base/tracked_objects.h b/base/tracked_objects.h
index a4e971d..31ce4f5 100644
--- a/base/tracked_objects.h
+++ b/base/tracked_objects.h
@@ -13,6 +13,7 @@
 #include <vector>
 
 #include "base/base_export.h"
+#include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/lazy_instance.h"
 #include "base/location.h"
@@ -20,7 +21,10 @@
 #include "base/profiler/tracked_time.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_local_storage.h"
-#include "base/tracking_info.h"
+
+namespace base {
+struct TrackingInfo;
+}
 
 // TrackedObjects provides a database of stats about objects (generally Tasks)
 // that are tracked.  Tracking means their birth, death, duration, birth thread,
diff --git a/base/tracked_objects_unittest.cc b/base/tracked_objects_unittest.cc
index d2654c7..7cbce90 100644
--- a/base/tracked_objects_unittest.cc
+++ b/base/tracked_objects_unittest.cc
@@ -6,9 +6,12 @@
 
 #include "base/tracked_objects.h"
 
+#include <stddef.h>
+
 #include "base/memory/scoped_ptr.h"
 #include "base/process/process_handle.h"
 #include "base/time/time.h"
+#include "base/tracking_info.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 const int kLineNumber = 1776;
diff --git a/base/tracking_info.h b/base/tracking_info.h
index ba9585e..a1c6392 100644
--- a/base/tracking_info.h
+++ b/base/tracking_info.h
@@ -11,6 +11,7 @@
 #ifndef BASE_TRACKING_INFO_H_
 #define BASE_TRACKING_INFO_H_
 
+#include "base/base_export.h"
 #include "base/profiler/tracked_time.h"
 #include "base/time/time.h"
 
diff --git a/base/value_conversions.cc b/base/value_conversions.cc
index 2fd88f8..45cd619 100644
--- a/base/value_conversions.cc
+++ b/base/value_conversions.cc
@@ -4,6 +4,9 @@
 
 #include "base/value_conversions.h"
 
+#include <string>
+
+#include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/time/time.h"
diff --git a/base/values.cc b/base/values.cc
index adfb980..76e73a0 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -4,12 +4,15 @@
 
 #include "base/values.h"
 
+#include <string.h>
+
 #include <algorithm>
 #include <ostream>
 
 #include "base/float_util.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
+#include "base/move.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 
diff --git a/base/values.h b/base/values.h
index 4025c75..495d1fa 100644
--- a/base/values.h
+++ b/base/values.h
@@ -17,9 +17,12 @@
 #ifndef BASE_VALUES_H_
 #define BASE_VALUES_H_
 
-#include <iterator>
+#include <stddef.h>
+
+#include <iosfwd>
 #include <map>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/base_export.h"
@@ -35,7 +38,6 @@
 // http://crbug.com/88666
 namespace base {
 
-class BinaryValue;
 class DictionaryValue;
 class FundamentalValue;
 class ListValue;
diff --git a/base/version.cc b/base/version.cc
index 70d35c1..6318b35 100644
--- a/base/version.cc
+++ b/base/version.cc
@@ -4,6 +4,8 @@
 
 #include "base/version.h"
 
+#include <stddef.h>
+
 #include <algorithm>
 
 #include "base/logging.h"
diff --git a/base/vlog.cc b/base/vlog.cc
index 9465054..434a70e 100644
--- a/base/vlog.cc
+++ b/base/vlog.cc
@@ -4,6 +4,10 @@
 
 #include "base/vlog.h"
 
+#include <cstddef>
+#include <ostream>
+#include <utility>
+
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
diff --git a/base/vlog.h b/base/vlog.h
index 4ef173e..a32ed14 100644
--- a/base/vlog.h
+++ b/base/vlog.h
@@ -5,7 +5,6 @@
 #ifndef BASE_VLOG_H_
 #define BASE_VLOG_H_
 
-#include <cstddef>
 #include <string>
 #include <vector>
 
diff --git a/chrome/browser/extensions/blacklist.cc b/chrome/browser/extensions/blacklist.cc
index 902bbcd..905b67a 100644
--- a/chrome/browser/extensions/blacklist.cc
+++ b/chrome/browser/extensions/blacklist.cc
@@ -5,6 +5,7 @@
 #include "chrome/browser/extensions/blacklist.h"
 
 #include <algorithm>
+#include <iterator>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
diff --git a/cloud_print/service/win/cloud_print_service.cc b/cloud_print/service/win/cloud_print_service.cc
index 058cf54..32fbe80 100644
--- a/cloud_print/service/win/cloud_print_service.cc
+++ b/cloud_print/service/win/cloud_print_service.cc
@@ -7,6 +7,9 @@
 
 #include <iomanip>
 #include <iostream>
+#include <iterator>
+#include <string>
+#include <vector>
 
 #include "base/at_exit.h"
 #include "base/bind.h"
diff --git a/sync/notifier/p2p_invalidator.cc b/sync/notifier/p2p_invalidator.cc
index 05ec183..2468a51 100644
--- a/sync/notifier/p2p_invalidator.cc
+++ b/sync/notifier/p2p_invalidator.cc
@@ -5,6 +5,7 @@
 #include "sync/notifier/p2p_invalidator.h"
 
 #include <algorithm>
+#include <iterator>
 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"