diff options
author | sdefresne@chromium.org <sdefresne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-05 21:53:42 +0000 |
---|---|---|
committer | sdefresne@chromium.org <sdefresne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-05 21:53:42 +0000 |
commit | c07c92cff7e023a2aa630f933a198145e6f2aff3 (patch) | |
tree | d4b7fe725f0917ee9360715956cdd60cd83814e3 | |
parent | d88aa9bfd8ee52764cb8f8061ada6f623b1c295d (diff) | |
download | chromium_src-c07c92cff7e023a2aa630f933a198145e6f2aff3.zip chromium_src-c07c92cff7e023a2aa630f933a198145e6f2aff3.tar.gz chromium_src-c07c92cff7e023a2aa630f933a198145e6f2aff3.tar.bz2 |
Move bookmarks' test support file to the bookmarks component
Those files are used by a lot of tests and do not depends on chrome/
or content/ so they can be moved to the component in a new library
that will be used by the test (eventually components_unittests).
BUG=367839
Review URL: https://codereview.chromium.org/268673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268282 0039d316-1c4b-4281-b951-d872f2087c98
55 files changed, 81 insertions, 66 deletions
diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS index 276e134..1f2c0ba 100644 --- a/chrome/browser/DEPS +++ b/chrome/browser/DEPS @@ -14,6 +14,7 @@ include_rules = [ "+components/autofill/core/common", "+components/bookmarks/core/browser", "+components/bookmarks/core/common", + "+components/bookmarks/core/test", "+components/breakpad", "+components/cloud_devices/common", "+components/data_reduction_proxy", diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc b/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc index 8141bbb..a8caa96 100644 --- a/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc +++ b/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc @@ -8,9 +8,9 @@ #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread.h" #include "testing/gmock/include/gmock/gmock.h" diff --git a/chrome/browser/autocomplete/bookmark_provider_unittest.cc b/chrome/browser/autocomplete/bookmark_provider_unittest.cc index c2a2e04..79a87f0 100644 --- a/chrome/browser/autocomplete/bookmark_provider_unittest.cc +++ b/chrome/browser/autocomplete/bookmark_provider_unittest.cc @@ -16,10 +16,10 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/autocomplete/autocomplete_provider.h" #include "chrome/browser/autocomplete/autocomplete_provider_listener.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_match.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "testing/gtest/include/gtest/gtest.h" // The bookmark corpus against which we will simulate searches. diff --git a/chrome/browser/autocomplete/history_quick_provider_unittest.cc b/chrome/browser/autocomplete/history_quick_provider_unittest.cc index ab671fb..524aeac 100644 --- a/chrome/browser/autocomplete/history_quick_provider_unittest.cc +++ b/chrome/browser/autocomplete/history_quick_provider_unittest.cc @@ -21,7 +21,6 @@ #include "chrome/browser/autocomplete/autocomplete_result.h" #include "chrome/browser/autocomplete/history_url_provider.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/history/history_backend.h" #include "chrome/browser/history/history_database.h" #include "chrome/browser/history/history_service.h" @@ -35,6 +34,7 @@ #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread.h" #include "sql/transaction.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/bookmarks/bookmark_codec_unittest.cc b/chrome/browser/bookmarks/bookmark_codec_unittest.cc index 7eb76e9..2e35d24 100644 --- a/chrome/browser/bookmarks/bookmark_codec_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_codec_unittest.cc @@ -13,9 +13,9 @@ #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "base/values.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/common/chrome_paths.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "testing/gtest/include/gtest/gtest.h" using base::ASCIIToUTF16; diff --git a/chrome/browser/bookmarks/bookmark_expanded_state_tracker_unittest.cc b/chrome/browser/bookmarks/bookmark_expanded_state_tracker_unittest.cc index 19798c9..ce53cbb 100644 --- a/chrome/browser/bookmarks/bookmark_expanded_state_tracker_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_expanded_state_tracker_unittest.cc @@ -6,9 +6,9 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc b/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc index a7df2c3..2d44669 100644 --- a/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc @@ -13,7 +13,6 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/favicon/favicon_service.h" #include "chrome/browser/favicon/favicon_service_factory.h" #include "chrome/browser/history/history_service.h" @@ -23,6 +22,7 @@ #include "chrome/test/base/testing_profile.h" #include "chrome/utility/importer/bookmark_html_reader.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread_bundle.h" #include "grit/component_strings.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/bookmarks/bookmark_index_unittest.cc b/chrome/browser/bookmarks/bookmark_index_unittest.cc index 3814013..7217e28 100644 --- a/chrome/browser/bookmarks/bookmark_index_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_index_unittest.cc @@ -13,14 +13,14 @@ #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/browser/history/history_service.h" #include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/history/url_database.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_match.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/bookmarks/bookmark_model_unittest.cc b/chrome/browser/bookmarks/bookmark_model_unittest.cc index 122d4cd..8198b21 100644 --- a/chrome/browser/bookmarks/bookmark_model_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_model_unittest.cc @@ -20,11 +20,11 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model_observer.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/base/models/tree_node_iterator.h" diff --git a/chrome/browser/bookmarks/bookmark_node_data_unittest.cc b/chrome/browser/bookmarks/bookmark_node_data_unittest.cc index e2d8c6d..5c23cd3 100644 --- a/chrome/browser/bookmarks/bookmark_node_data_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_node_data_unittest.cc @@ -8,10 +8,10 @@ #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_node_data.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/base/dragdrop/os_exchange_data.h" diff --git a/chrome/browser/bookmarks/bookmark_utils_unittest.cc b/chrome/browser/bookmarks/bookmark_utils_unittest.cc index 97bfd32..1d547cf 100644 --- a/chrome/browser/bookmarks/bookmark_utils_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_utils_unittest.cc @@ -8,10 +8,10 @@ #include "base/message_loop/message_loop.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "components/bookmarks/core/browser/base_bookmark_model_observer.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_node_data.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/base/clipboard/clipboard.h" #include "ui/base/clipboard/scoped_clipboard_writer.h" diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc index f04d302..723f9e9 100644 --- a/chrome/browser/browser_commands_unittest.cc +++ b/chrome/browser/browser_commands_unittest.cc @@ -4,7 +4,6 @@ #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/ui/browser_command_controller.h" #include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/browser_finder.h" @@ -13,6 +12,7 @@ #include "chrome/test/base/browser_with_test_window_test.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/navigation_controller.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc index 726bfe1..ba2527d 100644 --- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc +++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc @@ -8,12 +8,12 @@ #include "base/prefs/pref_service.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/extensions/extension_apitest.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/common/pref_names.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "components/user_prefs/user_prefs.h" // Times out on win syzyasan, http://crbug.com/166026 diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc index 966a132..df7c73e 100644 --- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc +++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc @@ -7,10 +7,10 @@ #include "base/memory/scoped_ptr.h" #include "base/strings/utf_string_conversions.h" #include "base/values.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h" #include "chrome/common/extensions/api/bookmarks.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc index 0265b31..d57b770 100644 --- a/chrome/browser/extensions/lazy_background_page_apitest.cc +++ b/chrome/browser/extensions/lazy_background_page_apitest.cc @@ -6,7 +6,6 @@ #include "base/files/file_path.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/extensions/browser_action_test_util.h" #include "chrome/browser/extensions/extension_apitest.h" @@ -23,6 +22,7 @@ #include "chrome/test/base/ui_test_utils.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/web_contents.h" #include "content/public/test/browser_test_utils.h" diff --git a/chrome/browser/history/android/android_history_provider_service_unittest.cc b/chrome/browser/history/android/android_history_provider_service_unittest.cc index e97a748..a2647a2 100644 --- a/chrome/browser/history/android/android_history_provider_service_unittest.cc +++ b/chrome/browser/history/android/android_history_provider_service_unittest.cc @@ -7,12 +7,12 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/history/android/android_history_types.h" #include "chrome/common/chrome_constants.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc index c657709..3fcdf37 100644 --- a/chrome/browser/history/android/android_provider_backend_unittest.cc +++ b/chrome/browser/history/android/android_provider_backend_unittest.cc @@ -13,7 +13,6 @@ #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/favicon/favicon_changed_details.h" #include "chrome/browser/history/android/android_time.h" @@ -24,6 +23,7 @@ #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc b/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc index ce3fb63..d1c443a 100644 --- a/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc +++ b/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc @@ -7,7 +7,6 @@ #include "base/strings/utf_string_conversions.h" #include "base/synchronization/waitable_event.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/history/history_database.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/common/chrome_constants.h" @@ -15,6 +14,7 @@ #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/history/android/sqlite_cursor_unittest.cc b/chrome/browser/history/android/sqlite_cursor_unittest.cc index 48be49b..a0a2521 100644 --- a/chrome/browser/history/android/sqlite_cursor_unittest.cc +++ b/chrome/browser/history/android/sqlite_cursor_unittest.cc @@ -12,7 +12,6 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/history/android/android_history_provider_service.h" #include "chrome/browser/history/android/android_history_types.h" #include "chrome/browser/history/android/android_time.h" @@ -22,6 +21,7 @@ #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc index b1f3c87..405066e 100644 --- a/chrome/browser/history/expire_history_backend_unittest.cc +++ b/chrome/browser/history/expire_history_backend_unittest.cc @@ -16,7 +16,6 @@ #include "base/stl_util.h" #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/history/archived_database.h" #include "chrome/browser/history/expire_history_backend.h" @@ -29,6 +28,7 @@ #include "chrome/tools/profiles/thumbnail-inl.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "content/public/test/test_browser_thread.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/skia/include/core/SkBitmap.h" diff --git a/chrome/browser/history/history_backend_unittest.cc b/chrome/browser/history/history_backend_unittest.cc index 50c7157..b6230b3 100644 --- a/chrome/browser/history/history_backend_unittest.cc +++ b/chrome/browser/history/history_backend_unittest.cc @@ -21,8 +21,6 @@ #include "base/strings/string_number_conversions.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/history/history_notifications.h" #include "chrome/browser/history/history_service.h" @@ -36,6 +34,8 @@ #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" #include "content/public/test/test_browser_thread.h" diff --git a/chrome/browser/history/in_memory_url_index_unittest.cc b/chrome/browser/history/in_memory_url_index_unittest.cc index b6b34f3c..ba06b21 100644 --- a/chrome/browser/history/in_memory_url_index_unittest.cc +++ b/chrome/browser/history/in_memory_url_index_unittest.cc @@ -16,7 +16,6 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/autocomplete/autocomplete_provider.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/history/history_backend.h" #include "chrome/browser/history/history_database.h" @@ -29,6 +28,7 @@ #include "chrome/common/chrome_paths.h" #include "chrome/test/base/history_index_restore_observer.h" #include "chrome/test/base/testing_profile.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" #include "content/public/test/test_browser_thread.h" diff --git a/chrome/browser/importer/profile_writer_unittest.cc b/chrome/browser/importer/profile_writer_unittest.cc index c72874a..3ae714a 100644 --- a/chrome/browser/importer/profile_writer_unittest.cc +++ b/chrome/browser/importer/profile_writer_unittest.cc @@ -9,7 +9,6 @@ #include "base/message_loop/message_loop.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/history/history_service.h" #include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/history/history_types.h" @@ -19,6 +18,7 @@ #include "components/bookmarks/core/browser/bookmark_match.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc index 81b1cb1..fc5e1fa 100644 --- a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc +++ b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc @@ -12,7 +12,6 @@ #include "base/prefs/pref_service.h" #include "base/run_loop.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/bookmarks/chrome_bookmark_client.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/history/history_service.h" @@ -23,6 +22,7 @@ #include "chrome/common/pref_names.h" #include "chrome/test/base/profile_mock.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "components/keyed_service/content/refcounted_browser_context_keyed_service.h" #include "components/sync_driver/change_processor_mock.h" #include "components/sync_driver/data_type_controller_mock.h" diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc index 6d9145c..44a493f 100644 --- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc @@ -23,13 +23,13 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/sync/glue/bookmark_change_processor.h" #include "chrome/browser/sync/glue/bookmark_model_associator.h" #include "chrome/common/chrome_switches.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/base_bookmark_model_observer.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "components/sync_driver/data_type_error_handler.h" #include "components/sync_driver/data_type_error_handler_mock.h" #include "content/public/test/test_browser_thread.h" diff --git a/chrome/browser/sync/test/integration/sync_test.cc b/chrome/browser/sync/test/integration/sync_test.cc index 3c8b63a..cd16b7f 100644 --- a/chrome/browser/sync/test/integration/sync_test.cc +++ b/chrome/browser/sync/test/integration/sync_test.cc @@ -21,7 +21,6 @@ #include "base/threading/platform_thread.h" #include "base/values.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/google/google_url_tracker.h" #include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/invalidation/invalidation_service_factory.h" @@ -50,6 +49,7 @@ #include "chrome/common/chrome_switches.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/ui_test_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "components/os_crypt/os_crypt.h" #include "components/signin/core/browser/signin_manager.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/ui/bookmarks/bookmark_browsertest.cc b/chrome/browser/ui/bookmarks/bookmark_browsertest.cc index 12042ab..bd450eb 100644 --- a/chrome/browser/ui/bookmarks/bookmark_browsertest.cc +++ b/chrome/browser/ui/bookmarks/bookmark_browsertest.cc @@ -7,7 +7,6 @@ #include "base/timer/timer.h" #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/profiles/profile.h" @@ -20,6 +19,7 @@ #include "chrome/test/base/ui_test_utils.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/notification_service.h" #include "content/public/test/browser_test_utils.h" diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc index 1200582..66b4376 100644 --- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc +++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc @@ -11,11 +11,11 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/bookmarks/bookmark_utils.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/page_navigator.h" #include "content/public/test/test_browser_thread.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc index f050cc6..d62f405 100644 --- a/chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc +++ b/chrome/browser/ui/bookmarks/bookmark_editor_unittest.cc @@ -5,7 +5,7 @@ #include "chrome/browser/ui/bookmarks/bookmark_editor.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "testing/gtest/include/gtest/gtest.h" using base::ASCIIToUTF16; diff --git a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc index 36a06ab..292fbf8 100644 --- a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc +++ b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc @@ -5,9 +5,9 @@ #include "chrome/browser/ui/bookmarks/bookmark_utils.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/bookmarks/test_bookmark_client.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "testing/gtest/include/gtest/gtest.h" #if !defined(OS_ANDROID) && !defined(OS_IOS) diff --git a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc index 6385cc4..012ae2f 100644 --- a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc +++ b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc @@ -8,9 +8,9 @@ #include "base/message_loop/message_loop.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/base/models/combobox_model_observer.h" diff --git a/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm b/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm index d9a6a65..6d32c03 100644 --- a/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm +++ b/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm @@ -5,9 +5,9 @@ #import "chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" @implementation FakeAppDelegate diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm index ec1faa1..e76da16 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm @@ -12,7 +12,6 @@ #include "base/strings/sys_string_conversions.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/extensions/test_extension_system.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" @@ -28,6 +27,7 @@ #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "testing/gtest/include/gtest/gtest.h" #import "testing/gtest_mac.h" #include "testing/platform_test.h" diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm index 5ef90f3..4a9d8b2 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm @@ -6,7 +6,6 @@ #include "base/mac/scoped_nsobject.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h" @@ -17,6 +16,7 @@ #import "chrome/browser/ui/cocoa/view_resizer_pong.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "testing/gtest/include/gtest/gtest.h" #import "testing/gtest_mac.h" #include "testing/platform_test.h" diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm index 67d06c7..3622718 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm @@ -6,7 +6,6 @@ #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/profiles/profile.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h" @@ -17,6 +16,7 @@ #import "chrome/browser/ui/cocoa/url_drop_target.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/platform_test.h" #import "third_party/mozilla/NSPasteboard+Utils.h" diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm index eb2b090..c5d989a 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm @@ -6,7 +6,6 @@ #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/profiles/profile.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.h" @@ -18,6 +17,7 @@ #import "chrome/browser/ui/cocoa/url_drop_target.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/platform_test.h" #import "third_party/mozilla/NSPasteboard+Utils.h" diff --git a/chrome/browser/ui/cocoa/cocoa_profile_test.mm b/chrome/browser/ui/cocoa/cocoa_profile_test.mm index 52caf51..bc634ca 100644 --- a/chrome/browser/ui/cocoa/cocoa_profile_test.mm +++ b/chrome/browser/ui/cocoa/cocoa_profile_test.mm @@ -7,7 +7,6 @@ #include "base/run_loop.h" #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/search_engines/template_url_service_factory.h" #include "chrome/browser/ui/browser.h" @@ -17,6 +16,7 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread_bundle.h" CocoaProfileTest::CocoaProfileTest() diff --git a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm index 82cb81b..23b14c1 100644 --- a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm @@ -8,7 +8,6 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/managed_mode/managed_user_service.h" #include "chrome/browser/managed_mode/managed_user_service_factory.h" #include "chrome/browser/prefs/pref_service_syncable.h" @@ -23,6 +22,7 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_profile.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" class AvatarIconControllerTest : public CocoaProfileTest { public: diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm index f55a699..60bc4e0 100644 --- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm +++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm @@ -7,7 +7,6 @@ #include "base/prefs/pref_service.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/devtools/devtools_window.h" #include "chrome/browser/download/download_shelf.h" #include "chrome/browser/profiles/profile.h" @@ -20,6 +19,7 @@ #include "chrome/test/base/in_process_browser_test.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "extensions/common/switches.h" using content::OpenURLParams; diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc index 64dbaa2..1279447 100644 --- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc +++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc @@ -13,7 +13,6 @@ #include "chrome/browser/autocomplete/autocomplete_match.h" #include "chrome/browser/autocomplete/history_quick_provider.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/history/history_service.h" #include "chrome/browser/history/history_service_factory.h" @@ -36,6 +35,7 @@ #include "chrome/test/base/ui_test_utils.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/web_contents.h" #include "net/dns/mock_host_resolver.h" diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc index b479686..c01f4e30 100644 --- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc +++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc @@ -21,7 +21,6 @@ #include "chrome/browser/autocomplete/autocomplete_result.h" #include "chrome/browser/autocomplete/search_provider.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/extensions/extension_browsertest.h" #include "chrome/browser/extensions/extension_service.h" @@ -59,6 +58,7 @@ #include "chrome/test/base/interactive_test_utils.h" #include "chrome/test/base/ui_test_utils.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "components/sessions/serialized_navigation_entry.h" #include "content/public/browser/navigation_controller.h" #include "content/public/browser/navigation_entry.h" diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc index 13067c4..e9bfc44 100644 --- a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc +++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc @@ -20,7 +20,6 @@ #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/browser/history/history_service.h" @@ -30,6 +29,7 @@ #include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "components/user_prefs/pref_registry_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc index 7333fe7..1f693b0 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc @@ -10,7 +10,6 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/chrome_content_browser_client.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/profiles/profile.h" @@ -30,6 +29,7 @@ #include "chrome/test/base/ui_test_utils.h" #include "chrome/test/base/view_event_test_base.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/page_navigator.h" #include "content/public/test/test_browser_thread.h" diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc index ee36ee1..d833edc 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc @@ -6,7 +6,6 @@ #include "base/prefs/pref_service.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/search_engines/template_url_service.h" #include "chrome/browser/search_engines/template_url_service_factory.h" @@ -16,6 +15,7 @@ #include "chrome/test/base/browser_with_test_window_test.h" #include "chrome/test/base/scoped_testing_local_state.h" #include "chrome/test/base/testing_browser_process.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "ui/views/controls/button/text_button.h" class BookmarkBarViewInstantExtendedTest : public BrowserWithTestWindowTest { diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc index 3238243..02f720c 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc @@ -8,12 +8,12 @@ #include "base/memory/scoped_ptr.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/signin/fake_signin_manager.h" #include "chrome/browser/signin/signin_manager_factory.h" #include "chrome/browser/ui/bookmarks/bookmark_bubble_delegate.h" #include "chrome/test/base/browser_with_test_window_test.h" #include "components/bookmarks/core/browser/bookmark_utils.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "components/signin/core/browser/signin_manager.h" namespace { diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc index 2821d12..07ff4d4 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc @@ -13,11 +13,11 @@ #include "base/threading/sequenced_worker_pool.h" #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/bookmarks/bookmark_utils.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/browser/page_navigator.h" #include "content/public/test/test_browser_thread.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc index 3c780f5..ae68e7b 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc @@ -10,10 +10,10 @@ #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/profiles/profile.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/views/controls/textfield/textfield.h" diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc index 8a7dba6..fa2ba82 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc @@ -7,11 +7,11 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/bookmarks/bookmark_stats.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/profiles/profile.h" #include "chrome/test/base/browser_with_test_window_test.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "ui/views/controls/menu/menu_item_view.h" #include "ui/views/controls/menu/menu_runner.h" #include "ui/views/controls/menu/submenu_view.h" diff --git a/chrome/browser/undo/bookmark_undo_service_test.cc b/chrome/browser/undo/bookmark_undo_service_test.cc index 0161a0e..d29626d 100644 --- a/chrome/browser/undo/bookmark_undo_service_test.cc +++ b/chrome/browser/undo/bookmark_undo_service_test.cc @@ -6,10 +6,10 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" #include "chrome/browser/undo/bookmark_undo_service_factory.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/core/browser/bookmark_model.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi index 680772a..52b8ace 100644 --- a/chrome/chrome_tests_unit.gypi +++ b/chrome/chrome_tests_unit.gypi @@ -21,7 +21,7 @@ '../components/components.gyp:password_manager_core_browser_test_support', '../components/components.gyp:signin_core_browser_test_support', '../components/components.gyp:sync_driver_test_support', - '../components/components.gyp:sync_driver_test_support', + '../components/components.gyp:bookmarks_core_test_support', '../content/content.gyp:content_app_both', '../content/content_shell_and_tests.gyp:test_support_content', '../net/net.gyp:net', @@ -48,10 +48,6 @@ 'browser/android/bookmarks/partner_bookmarks_shim_unittest.cc', 'browser/android/mock_google_location_settings_helper.cc', 'browser/android/mock_google_location_settings_helper.h', - 'browser/bookmarks/bookmark_test_helpers.cc', - 'browser/bookmarks/bookmark_test_helpers.h', - 'browser/bookmarks/test_bookmark_client.cc', - 'browser/bookmarks/test_bookmark_client.h', 'browser/browsing_data/mock_browsing_data_appcache_helper.cc', 'browser/browsing_data/mock_browsing_data_appcache_helper.h', 'browser/browsing_data/mock_browsing_data_cookie_helper.cc', diff --git a/components/bookmarks.gypi b/components/bookmarks.gypi index 3681ff8..40b5703 100644 --- a/components/bookmarks.gypi +++ b/components/bookmarks.gypi @@ -72,5 +72,23 @@ 'bookmarks/core/common/bookmark_pref_names.h', ], }, + { + 'target_name': 'bookmarks_core_test_support', + 'type': 'static_library', + 'include_dirs': [ + '..', + ], + 'dependencies': [ + '../base/base.gyp:base', + '../url/url.gyp:url_lib', + 'bookmarks_core_browser', + ], + 'sources': [ + 'bookmarks/core/test/bookmark_test_helpers.cc', + 'bookmarks/core/test/bookmark_test_helpers.h', + 'bookmarks/core/test/test_bookmark_client.cc', + 'bookmarks/core/test/test_bookmark_client.h', + ], + }, ], } diff --git a/chrome/browser/bookmarks/bookmark_test_helpers.cc b/components/bookmarks/core/test/bookmark_test_helpers.cc index 424febd..86d9ee2 100644 --- a/chrome/browser/bookmarks/bookmark_test_helpers.cc +++ b/components/bookmarks/core/test/bookmark_test_helpers.cc @@ -1,8 +1,8 @@ -// Copyright 2013 The Chromium Authors. All rights reserved. +// Copyright 2014 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/bookmarks/bookmark_test_helpers.h" +#include "components/bookmarks/core/test/bookmark_test_helpers.h" #include "base/basictypes.h" #include "base/callback.h" diff --git a/chrome/browser/bookmarks/bookmark_test_helpers.h b/components/bookmarks/core/test/bookmark_test_helpers.h index eccdd78..a6467fa 100644 --- a/chrome/browser/bookmarks/bookmark_test_helpers.h +++ b/components/bookmarks/core/test/bookmark_test_helpers.h @@ -1,9 +1,9 @@ -// Copyright 2013 The Chromium Authors. All rights reserved. +// Copyright 2014 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_TEST_HELPERS_H_ -#define CHROME_BROWSER_BOOKMARKS_BOOKMARK_TEST_HELPERS_H_ +#ifndef COMPONENTS_BOOKMARKS_CORE_TEST_BOOKMARK_TEST_HELPERS_H_ +#define COMPONENTS_BOOKMARKS_CORE_TEST_BOOKMARK_TEST_HELPERS_H_ #include <string> @@ -42,4 +42,4 @@ void AddNodesFromModelString(BookmarkModel* model, const std::string& model_string); } // namespace test -#endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_TEST_HELPERS_H_ +#endif // COMPONENTS_BOOKMARKS_CORE_TEST_BOOKMARK_TEST_HELPERS_H_ diff --git a/chrome/browser/bookmarks/test_bookmark_client.cc b/components/bookmarks/core/test/test_bookmark_client.cc index ce93c0c..4ae073a 100644 --- a/chrome/browser/bookmarks/test_bookmark_client.cc +++ b/components/bookmarks/core/test/test_bookmark_client.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/bookmarks/test_bookmark_client.h" +#include "components/bookmarks/core/test/test_bookmark_client.h" #include "components/bookmarks/core/browser/bookmark_model.h" #include "components/bookmarks/core/browser/bookmark_storage.h" diff --git a/chrome/browser/bookmarks/test_bookmark_client.h b/components/bookmarks/core/test/test_bookmark_client.h index 67cdb84..12677f7f 100644 --- a/chrome/browser/bookmarks/test_bookmark_client.h +++ b/components/bookmarks/core/test/test_bookmark_client.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_BOOKMARKS_TEST_BOOKMARK_CLIENT_H_ -#define CHROME_BROWSER_BOOKMARKS_TEST_BOOKMARK_CLIENT_H_ +#ifndef COMPONENTS_BOOKMARKS_CORE_TEST_TEST_BOOKMARK_CLIENT_H_ +#define COMPONENTS_BOOKMARKS_CORE_TEST_TEST_BOOKMARK_CLIENT_H_ #include "base/memory/scoped_ptr.h" #include "components/bookmarks/core/browser/bookmark_client.h" @@ -40,4 +40,4 @@ class TestBookmarkClient : public BookmarkClient { } // namespace test -#endif // CHROME_BROWSER_BOOKMARKS_TEST_BOOKMARK_CLIENT_H_ +#endif // COMPONENTS_BOOKMARKS_CORE_TEST_TEST_BOOKMARK_CLIENT_H_ |