diff options
| author | nednguyen <nednguyen@google.com> | 2014-09-10 18:37:36 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-11 01:47:47 +0000 |
| commit | c1f585ef95231a5461958c3112e79bdbd4cfbc71 (patch) | |
| tree | 2014496b3e1f4443b1b8615dd46e2785383dc45d | |
| parent | fdda19490270c1b6d35b745b5ef16cc724bb7643 (diff) | |
| download | chromium_src-c1f585ef95231a5461958c3112e79bdbd4cfbc71.zip chromium_src-c1f585ef95231a5461958c3112e79bdbd4cfbc71.tar.gz chromium_src-c1f585ef95231a5461958c3112e79bdbd4cfbc71.tar.bz2 | |
Improve debugging message to show the number of running browsers upon failures.
BUG=412713
Review URL: https://codereview.chromium.org/560823003
Cr-Commit-Position: refs/heads/master@{#294286}
| -rw-r--r-- | tools/telemetry/telemetry/core/platform/tracing_controller_backend.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py index 3625fa7..87f3269 100644 --- a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py +++ b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py @@ -21,7 +21,8 @@ class TracingControllerBackend(object): assert isinstance(trace_options, tracing_options.TracingOptions) - if len(self.running_browser_backends) != 1: + num_running_browser_backends = len(self.running_browser_backends) + if num_running_browser_backends != 1: # Note: it is possible to implement tracing for both the case of 0 and >1. # For >1, we just need to merge the trace files at StopTracing. # @@ -31,7 +32,9 @@ class TracingControllerBackend(object): # the controller add in the trace-startup command, and then when we get # the Stop message or the DidStopBrowser(), issue the stop tracing command # on the right backend. - raise NotImplementedError() + raise NotImplementedError( + 'Start tracing does not support the case of %i running browser ' + 'instances' % num_running_browser_backends) self._current_trace_options = trace_options self._current_category_filter = category_filter |