summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrvargas <rvargas@chromium.org>2014-12-11 13:17:59 -0800
committerCommit bot <commit-bot@chromium.org>2014-12-11 21:18:14 +0000
commitc24c73520231bde2be7fdb24610873b75e797c58 (patch)
tree65300e55fdfd90f9c026142767d2473e60536b8a
parent7b70d6a6549a569892445a503a00286c70700051 (diff)
downloadchromium_src-c24c73520231bde2be7fdb24610873b75e797c58.zip
chromium_src-c24c73520231bde2be7fdb24610873b75e797c58.tar.gz
chromium_src-c24c73520231bde2be7fdb24610873b75e797c58.tar.bz2
Update sandbox_win and delegate_execute to use the new version of LaunchProcess.
BUG=417532 Review URL: https://codereview.chromium.org/790003002 Cr-Commit-Position: refs/heads/master@{#307978}
-rw-r--r--content/common/sandbox_win.cc8
-rw-r--r--win8/delegate_execute/command_execute_impl.cc2
2 files changed, 5 insertions, 5 deletions
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index 84ade1f..a3882d0 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -605,11 +605,11 @@ base::Process StartSandboxedProcess(
if ((delegate && !delegate->ShouldSandbox()) ||
browser_command_line.HasSwitch(switches::kNoSandbox) ||
cmd_line->HasSwitch(switches::kNoSandbox)) {
- base::ProcessHandle handle = 0;
- base::LaunchProcess(*cmd_line, base::LaunchOptions(), &handle);
+ base::Process process =
+ base::LaunchProcess(*cmd_line, base::LaunchOptions());
// TODO(rvargas) crbug.com/417532: Don't share a raw handle.
- g_broker_services->AddTargetPeer(handle);
- return base::Process(handle);
+ g_broker_services->AddTargetPeer(process.Handle());
+ return process.Pass();
}
sandbox::TargetPolicy* policy = g_broker_services->CreatePolicy();
diff --git a/win8/delegate_execute/command_execute_impl.cc b/win8/delegate_execute/command_execute_impl.cc
index 6aca5a1..e027078 100644
--- a/win8/delegate_execute/command_execute_impl.cc
+++ b/win8/delegate_execute/command_execute_impl.cc
@@ -102,7 +102,7 @@ bool LaunchChromeBrowserProcess() {
base::LaunchOptions launch_options;
launch_options.start_hidden = true;
- return base::LaunchProcess(cl, launch_options, NULL);
+ return base::LaunchProcess(cl, launch_options).IsValid();
}
} // namespace