summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-29 21:51:40 +0000
committerjvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-29 21:51:40 +0000
commitc28b0ec6a120ee085c9051f09767edfc3c2eaa5a (patch)
treeed8dfc48986931457da4bb2d6b440608a4fa83fb
parented152d32e3975a95e8166b47213f2149e59fa53a (diff)
downloadchromium_src-c28b0ec6a120ee085c9051f09767edfc3c2eaa5a.zip
chromium_src-c28b0ec6a120ee085c9051f09767edfc3c2eaa5a.tar.gz
chromium_src-c28b0ec6a120ee085c9051f09767edfc3c2eaa5a.tar.bz2
Make make_expectations allow floating point values (up to 4 decimal) in improve and regress bounds.
BUG= none TEST= none Review URL: http://codereview.chromium.org/8086007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103363 0039d316-1c4b-4281-b951-d872f2087c98
-rwxr-xr-xtools/perf_expectations/make_expectations.py26
1 files changed, 22 insertions, 4 deletions
diff --git a/tools/perf_expectations/make_expectations.py b/tools/perf_expectations/make_expectations.py
index f73383d..86929b4 100755
--- a/tools/perf_expectations/make_expectations.py
+++ b/tools/perf_expectations/make_expectations.py
@@ -267,6 +267,12 @@ def Main(args):
regress = float(trace_values[tracename]['high'])
improve = float(trace_values[tracename]['low'])
+ # Check if we started with round integers so we can keep them
+ # integers in the end.
+ bounds_were_integers = False
+ if regress == int(regress) and improve == int(improve):
+ bounds_were_integers = True
+
# At this point, regress > improve. If regress == improve, we adjust
# improve so it is just a little less than regress. I'm picking on improve
# so we keep the sizes assumptions in place for now.
@@ -282,11 +288,23 @@ def Main(args):
regress = improve
improve = temp
if regress < improve:
- regress = int(math.floor(regress - abs(regress*tolerance)))
- improve = int(math.ceil(improve + abs(improve*tolerance)))
+ regress = regress - abs(regress*tolerance)
+ improve = improve + abs(improve*tolerance)
+ if bounds_were_integers:
+ regress = '%d' % int(math.floor(regress))
+ improve = '%d' % int(math.ceil(improve))
+ else:
+ regress = '%.4f' % regress
+ improve = '%.4f' % improve
else:
- improve = int(math.floor(improve - abs(improve*tolerance)))
- regress = int(math.ceil(regress + abs(regress*tolerance)))
+ improve = improve - abs(improve*tolerance)
+ regress = regress + abs(regress*tolerance)
+ if bounds_were_integers:
+ improve = '%d' % int(math.floor(improve))
+ regress = '%d' % int(math.ceil(regress))
+ else:
+ regress = '%.4f' % regress
+ improve = '%.4f' % improve
# Calculate the new checksum to test if this is the only thing that may have
# changed.