diff options
author | ki.stfu <ki.stfu@gmail.com> | 2015-10-12 14:48:46 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-12 21:49:40 +0000 |
commit | c771afc1670c3a0799d89704509ac1403ec82d92 (patch) | |
tree | 5b4d72149e72fcaa113ece619a8c824c0022f988 | |
parent | 46018a0a2481a01d714811fa6e9c3f7c7f9f8c4f (diff) | |
download | chromium_src-c771afc1670c3a0799d89704509ac1403ec82d92.zip chromium_src-c771afc1670c3a0799d89704509ac1403ec82d92.tar.gz chromium_src-c771afc1670c3a0799d89704509ac1403ec82d92.tar.bz2 |
Don't use base::MessageLoop::{Quit,QuitClosure} in media/
This patch renames base::MessageLoop::{Quit,QuitClosure} to
base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}.
BUG=131220
R=ddorwin@chromium.org
Review URL: https://codereview.chromium.org/1396113004
Cr-Commit-Position: refs/heads/master@{#353600}
-rw-r--r-- | media/audio/android/audio_android_unittest.cc | 2 | ||||
-rw-r--r-- | media/audio/audio_input_controller_unittest.cc | 17 | ||||
-rw-r--r-- | media/audio/audio_input_unittest.cc | 7 | ||||
-rw-r--r-- | media/audio/audio_low_latency_input_output_unittest.cc | 3 | ||||
-rw-r--r-- | media/audio/audio_output_controller_unittest.cc | 2 | ||||
-rw-r--r-- | media/audio/audio_output_device_unittest.cc | 4 | ||||
-rw-r--r-- | media/audio/fake_audio_worker_unittest.cc | 2 | ||||
-rw-r--r-- | media/audio/win/audio_low_latency_input_win_unittest.cc | 2 | ||||
-rw-r--r-- | media/audio/win/audio_low_latency_output_win_unittest.cc | 10 | ||||
-rw-r--r-- | media/base/android/media_source_player_unittest.cc | 4 | ||||
-rw-r--r-- | media/cast/test/sender.cc | 2 | ||||
-rw-r--r-- | media/test/pipeline_integration_test_base.cc | 10 |
12 files changed, 33 insertions, 32 deletions
diff --git a/media/audio/android/audio_android_unittest.cc b/media/audio/android/audio_android_unittest.cc index a6f9421..c405c09 100644 --- a/media/audio/android/audio_android_unittest.cc +++ b/media/audio/android/audio_android_unittest.cc @@ -39,7 +39,7 @@ namespace { ACTION_P3(CheckCountAndPostQuitTask, count, limit, loop) { if (++*count >= limit) { - loop->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + loop->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } } diff --git a/media/audio/audio_input_controller_unittest.cc b/media/audio/audio_input_controller_unittest.cc index 05d12fc..3f14ae4 100644 --- a/media/audio/audio_input_controller_unittest.cc +++ b/media/audio/audio_input_controller_unittest.cc @@ -25,22 +25,23 @@ static const int kBitsPerSample = 16; static const ChannelLayout kChannelLayout = CHANNEL_LAYOUT_STEREO; static const int kSamplesPerPacket = kSampleRate / 10; -// Posts base::MessageLoop::QuitClosure() on specified message loop. +// Posts base::MessageLoop::QuitWhenIdleClosure() on specified message loop. ACTION_P(QuitMessageLoop, loop_or_proxy) { - loop_or_proxy->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + loop_or_proxy->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } -// Posts base::MessageLoop::QuitClosure() on specified message loop after a -// certain number of calls given by |limit|. +// Posts base::MessageLoop::QuitWhenIdleClosure() on specified message loop +// after a certain number of calls given by |limit|. ACTION_P3(CheckCountAndPostQuitTask, count, limit, loop_or_proxy) { if (++*count >= limit) { - loop_or_proxy->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + loop_or_proxy->PostTask(FROM_HERE, + base::MessageLoop::QuitWhenIdleClosure()); } } // Closes AudioOutputController synchronously. static void CloseAudioController(AudioInputController* controller) { - controller->Close(base::MessageLoop::QuitClosure()); + controller->Close(base::MessageLoop::QuitWhenIdleClosure()); base::MessageLoop::current()->Run(); } @@ -254,10 +255,10 @@ TEST_F(AudioInputControllerTest, CloseTwice) { controller->Record(); - controller->Close(base::MessageLoop::QuitClosure()); + controller->Close(base::MessageLoop::QuitWhenIdleClosure()); base::MessageLoop::current()->Run(); - controller->Close(base::MessageLoop::QuitClosure()); + controller->Close(base::MessageLoop::QuitWhenIdleClosure()); base::MessageLoop::current()->Run(); } diff --git a/media/audio/audio_input_unittest.cc b/media/audio/audio_input_unittest.cc index 97b7bf0..dc1f720 100644 --- a/media/audio/audio_input_unittest.cc +++ b/media/audio/audio_input_unittest.cc @@ -219,10 +219,9 @@ TEST_F(AudioInputTest, MAYBE_Record) { TestInputCallback test_callback; OpenAndStartAudioInputStreamOnAudioThread(&test_callback); - message_loop_.PostDelayedTask( - FROM_HERE, - base::MessageLoop::QuitClosure(), - base::TimeDelta::FromMilliseconds(500)); + message_loop_.PostDelayedTask(FROM_HERE, + base::MessageLoop::QuitWhenIdleClosure(), + base::TimeDelta::FromMilliseconds(500)); message_loop_.Run(); EXPECT_GE(test_callback.callback_count(), 2); EXPECT_FALSE(test_callback.had_error()); diff --git a/media/audio/audio_low_latency_input_output_unittest.cc b/media/audio/audio_low_latency_input_output_unittest.cc index 20a0d66..b24f501 100644 --- a/media/audio/audio_low_latency_input_output_unittest.cc +++ b/media/audio/audio_low_latency_input_output_unittest.cc @@ -419,7 +419,8 @@ TEST_F(AudioLowLatencyInputOutputTest, DISABLED_FullDuplexDelayMeasurement) { // in loop back during this time. At the same time, delay recordings are // performed and stored in the output text file. message_loop()->PostDelayedTask(FROM_HERE, - base::MessageLoop::QuitClosure(), TestTimeouts::action_timeout()); + base::MessageLoop::QuitWhenIdleClosure(), + TestTimeouts::action_timeout()); message_loop()->Run(); aos->Stop(); diff --git a/media/audio/audio_output_controller_unittest.cc b/media/audio/audio_output_controller_unittest.cc index dd7cb80..b68dea2 100644 --- a/media/audio/audio_output_controller_unittest.cc +++ b/media/audio/audio_output_controller_unittest.cc @@ -224,7 +224,7 @@ class AudioOutputControllerTest : public testing::Test { void Close() { EXPECT_CALL(mock_sync_reader_, Close()); - controller_->Close(base::MessageLoop::QuitClosure()); + controller_->Close(base::MessageLoop::QuitWhenIdleClosure()); base::MessageLoop::current()->Run(); } diff --git a/media/audio/audio_output_device_unittest.cc b/media/audio/audio_output_device_unittest.cc index 15ed4c3..e95efa2 100644 --- a/media/audio/audio_output_device_unittest.cc +++ b/media/audio/audio_output_device_unittest.cc @@ -83,7 +83,7 @@ ACTION_P2(SendPendingBytes, socket, pending_bytes) { // Used to terminate a loop from a different thread than the loop belongs to. // |task_runner| should be a SingleThreadTaskRunner. ACTION_P(QuitLoop, task_runner) { - task_runner->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + task_runner->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } } // namespace. @@ -234,7 +234,7 @@ void AudioOutputDeviceTest::ExpectRenderCallback() { void AudioOutputDeviceTest::WaitUntilRenderCallback() { // Don't hang the test if we never get the Render() callback. - io_loop_.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitClosure(), + io_loop_.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(), TestTimeouts::action_timeout()); io_loop_.Run(); } diff --git a/media/audio/fake_audio_worker_unittest.cc b/media/audio/fake_audio_worker_unittest.cc index 7d474eb..1cccf7e 100644 --- a/media/audio/fake_audio_worker_unittest.cc +++ b/media/audio/fake_audio_worker_unittest.cc @@ -76,7 +76,7 @@ class FakeAudioWorkerTest : public testing::Test { ASSERT_TRUE(message_loop_.task_runner()->BelongsToCurrentThread()); fake_worker_.Stop(); EXPECT_LE(callbacks, seen_callbacks_); - message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } protected: diff --git a/media/audio/win/audio_low_latency_input_win_unittest.cc b/media/audio/win/audio_low_latency_input_win_unittest.cc index 5b8f46e..6a8e8a9 100644 --- a/media/audio/win/audio_low_latency_input_win_unittest.cc +++ b/media/audio/win/audio_low_latency_input_win_unittest.cc @@ -32,7 +32,7 @@ namespace media { ACTION_P3(CheckCountAndPostQuitTask, count, limit, loop) { if (++*count >= limit) { - loop->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + loop->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } } diff --git a/media/audio/win/audio_low_latency_output_win_unittest.cc b/media/audio/win/audio_low_latency_output_win_unittest.cc index fae02bd..a981b33 100644 --- a/media/audio/win/audio_low_latency_output_win_unittest.cc +++ b/media/audio/win/audio_low_latency_output_win_unittest.cc @@ -59,7 +59,7 @@ MATCHER_P(HasValidDelay, value, "") { // Used to terminate a loop from a different thread than the loop belongs to. // |task_runner| should be a SingleThreadTaskRunner. ACTION_P(QuitLoop, task_runner) { - task_runner->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + task_runner->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } // This audio source implementation should be used for manual tests only since @@ -386,7 +386,7 @@ TEST(WASAPIAudioOutputStreamTest, ValidPacketSize) { Return(aosw.samples_per_packet()))); aos->Start(&source); - loop.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitClosure(), + loop.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(), TestTimeouts::action_timeout()); loop.Run(); aos->Stop(); @@ -580,7 +580,7 @@ TEST(WASAPIAudioOutputStreamTest, DISABLED_ExclusiveModeMinBufferSizeAt48kHz) { .WillRepeatedly(Return(aosw.samples_per_packet())); aos->Start(&source); - loop.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitClosure(), + loop.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(), TestTimeouts::action_timeout()); loop.Run(); aos->Stop(); @@ -614,8 +614,8 @@ TEST(WASAPIAudioOutputStreamTest, DISABLED_ExclusiveModeMinBufferSizeAt44kHz) { .WillRepeatedly(Return(aosw.samples_per_packet())); aos->Start(&source); - loop.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitClosure(), - TestTimeouts::action_timeout()); + loop.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(), + TestTimeouts::action_timeout()); loop.Run(); aos->Stop(); aos->Close(); diff --git a/media/base/android/media_source_player_unittest.cc b/media/base/android/media_source_player_unittest.cc index 65b40ec..fd4a725 100644 --- a/media/base/android/media_source_player_unittest.cc +++ b/media/base/android/media_source_player_unittest.cc @@ -68,7 +68,7 @@ class MockMediaPlayerManager : public MediaPlayerManager { void OnPlaybackComplete(int player_id) override { playback_completed_ = true; if (message_loop_->is_running()) - message_loop_->Quit(); + message_loop_->QuitWhenIdle(); } void OnMediaInterrupted(int player_id) override {} void OnBufferingUpdate(int player_id, int percentage) override {} @@ -131,7 +131,7 @@ class MockDemuxerAndroid : public DemuxerAndroid { void RequestDemuxerData(DemuxerStream::Type type) override { num_data_requests_++; if (message_loop_->is_running()) - message_loop_->Quit(); + message_loop_->QuitWhenIdle(); } void RequestDemuxerSeek(const base::TimeDelta& time_to_seek, bool is_browser_seek) override { diff --git a/media/cast/test/sender.cc b/media/cast/test/sender.cc index c7b8999..514bc74 100644 --- a/media/cast/test/sender.cc +++ b/media/cast/test/sender.cc @@ -104,7 +104,7 @@ void LogRawEvents( void QuitLoopOnInitializationResult(media::cast::OperationalStatus result) { CHECK(result == media::cast::STATUS_INITIALIZED) << "Cast sender uninitialized"; - base::MessageLoop::current()->Quit(); + base::MessageLoop::current()->QuitWhenIdle(); } net::IPEndPoint CreateUDPAddress(const std::string& ip_str, uint16 port) { diff --git a/media/test/pipeline_integration_test_base.cc b/media/test/pipeline_integration_test_base.cc index 7592ed8..ca9dee9 100644 --- a/media/test/pipeline_integration_test_base.cc +++ b/media/test/pipeline_integration_test_base.cc @@ -64,7 +64,7 @@ void PipelineIntegrationTestBase::OnSeeked(base::TimeDelta seek_time, void PipelineIntegrationTestBase::OnStatusCallback( PipelineStatus status) { pipeline_status_ = status; - message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } void PipelineIntegrationTestBase::DemuxerEncryptedMediaInitDataCB( @@ -79,7 +79,7 @@ void PipelineIntegrationTestBase::OnEnded() { DCHECK(!ended_); ended_ = true; pipeline_status_ = PIPELINE_OK; - message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } bool PipelineIntegrationTestBase::WaitUntilOnEnded() { @@ -100,7 +100,7 @@ PipelineStatus PipelineIntegrationTestBase::WaitUntilEndedOrError() { void PipelineIntegrationTestBase::OnError(PipelineStatus status) { DCHECK_NE(status, PIPELINE_OK); pipeline_status_ = status; - message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure()); } PipelineStatus PipelineIntegrationTestBase::Start(const std::string& filename) { @@ -175,7 +175,7 @@ bool PipelineIntegrationTestBase::Seek(base::TimeDelta seek_time) { void PipelineIntegrationTestBase::Stop() { DCHECK(pipeline_->IsRunning()); - pipeline_->Stop(base::MessageLoop::QuitClosure()); + pipeline_->Stop(base::MessageLoop::QuitWhenIdleClosure()); message_loop_.Run(); } @@ -183,7 +183,7 @@ void PipelineIntegrationTestBase::QuitAfterCurrentTimeTask( const base::TimeDelta& quit_time) { if (pipeline_->GetMediaTime() >= quit_time || pipeline_status_ != PIPELINE_OK) { - message_loop_.Quit(); + message_loop_.QuitWhenIdle(); return; } |