diff options
| author | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-29 16:11:56 +0000 |
|---|---|---|
| committer | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-29 16:11:56 +0000 |
| commit | c8386693c8e8cb4b9da464a62d1004cb3cc8efff (patch) | |
| tree | 3ee8c511998cfe4e3980d41151037edcdc58badd | |
| parent | 511b9d9ca250327441d8fe7720096038bc49210e (diff) | |
| download | chromium_src-c8386693c8e8cb4b9da464a62d1004cb3cc8efff.zip chromium_src-c8386693c8e8cb4b9da464a62d1004cb3cc8efff.tar.gz chromium_src-c8386693c8e8cb4b9da464a62d1004cb3cc8efff.tar.bz2 | |
Clean up some HttpAuth nits.
BUG=None
TEST=net_unittests
Review URL: http://codereview.chromium.org/4193007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64431 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | net/http/http_auth.h | 3 | ||||
| -rw-r--r-- | net/http/http_auth_unittest.cc | 12 |
2 files changed, 8 insertions, 7 deletions
diff --git a/net/http/http_auth.h b/net/http/http_auth.h index 3611612..0034b1f 100644 --- a/net/http/http_auth.h +++ b/net/http/http_auth.h @@ -133,7 +133,8 @@ class HttpAuth { // // |headers| must be non-NULL and contain the new HTTP response. // - // |target| specifies whether the headers came from a server or proxy. + // |target| specifies whether the authentication challenge response came + // from a server or a proxy. // // |disabled_schemes| are the authentication schemes to ignore. // diff --git a/net/http/http_auth_unittest.cc b/net/http/http_auth_unittest.cc index 60f2b0e..63ae3b0 100644 --- a/net/http/http_auth_unittest.cc +++ b/net/http/http_auth_unittest.cc @@ -149,22 +149,22 @@ TEST(HttpAuthTest, ChooseBestChallenge) { TEST(HttpAuthTest, HandleChallengeResponse) { std::string challenge_used; - const char* kMockChallenge = + const char* const kMockChallenge = "HTTP/1.1 401 Unauthorized\n" "WWW-Authenticate: Mock token_here\n"; - const char* kBasicChallenge = + const char* const kBasicChallenge = "HTTP/1.1 401 Unauthorized\n" "WWW-Authenticate: Basic realm=\"happy\"\n"; - const char* kMissingChallenge = + const char* const kMissingChallenge = "HTTP/1.1 401 Unauthorized\n"; - const char* kEmptyChallenge = + const char* const kEmptyChallenge = "HTTP/1.1 401 Unauthorized\n" "WWW-Authenticate: \n"; - const char* kBasicAndMockChallenges = + const char* const kBasicAndMockChallenges = "HTTP/1.1 401 Unauthorized\n" "WWW-Authenticate: Basic realm=\"happy\"\n" "WWW-Authenticate: Mock token_here\n"; - const char* kTwoMockChallenges = + const char* const kTwoMockChallenges = "HTTP/1.1 401 Unauthorized\n" "WWW-Authenticate: Mock token_a\n" "WWW-Authenticate: Mock token_b\n"; |