summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoryang.gu <yang.gu@intel.com>2015-07-13 18:52:23 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-14 01:52:53 +0000
commitcd0ea9c552e554f44d66638937b4b8e001e96974 (patch)
tree4d572a28f24c0415b3c7e6d2b57bb25fd7c9b3e5
parentb7ee944d161beef402eb58058c0c9146dd3cff62 (diff)
downloadchromium_src-cd0ea9c552e554f44d66638937b4b8e001e96974.zip
chromium_src-cd0ea9c552e554f44d66638937b4b8e001e96974.tar.gz
chromium_src-cd0ea9c552e554f44d66638937b4b8e001e96974.tar.bz2
Add switch of chromedriver to disable build check
Chromedriver always checks the minimum Chrome number it supports. However, under some circumstance, we don't have concrete build number. For example, stock browser in aosp master just reports version "38.0.0.0", which results in an error and refuses to continue. This CL provides a switch to bypass this check. BUG=418404 Review URL: https://codereview.chromium.org/611843002 Cr-Commit-Position: refs/heads/master@{#338618}
-rw-r--r--chrome/test/chromedriver/chrome_launcher.cc9
1 files changed, 8 insertions, 1 deletions
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index 1bcda40..5a79d67 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -182,7 +182,14 @@ Status WaitForDevToolsAndCheckVersion(
Status status = client->Init(deadline - base::TimeTicks::Now());
if (status.IsError())
return status;
- if (client->browser_info()->build_no < kMinimumSupportedChromeBuildNo) {
+
+ base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
+ if (cmd_line->HasSwitch("disable-build-check")) {
+ LOG(WARNING) << "You are using an unsupported command-line switch: "
+ "--disable-build-check. Please don't report bugs that "
+ "cannot be reproduced with this switch removed.";
+ } else if (client->browser_info()->build_no <
+ kMinimumSupportedChromeBuildNo) {
return Status(kUnknownError, "Chrome version must be >= " +
GetMinimumSupportedChromeVersion());
}