diff options
| author | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-24 19:35:18 +0000 |
|---|---|---|
| committer | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-24 19:35:18 +0000 |
| commit | cd21aaeed16e1fb914d8409dd65c5db7ac01ff89 (patch) | |
| tree | 8ce1c70c975332288721ec73db24a39d49e2d3bd | |
| parent | be1f2d01182f21de6133236e6a9cd2801d6a5a76 (diff) | |
| download | chromium_src-cd21aaeed16e1fb914d8409dd65c5db7ac01ff89.zip chromium_src-cd21aaeed16e1fb914d8409dd65c5db7ac01ff89.tar.gz chromium_src-cd21aaeed16e1fb914d8409dd65c5db7ac01ff89.tar.bz2 | |
Fix for crasher on toast UI
- The order of:
radio_button = new views::RadioButton(..)
layout->AddView(radio_button)
radio_button->SetChecked(true);
Matters, if the last two statements are inverted we crash (??)
BUG=none
TEST=start chrome with --try-chrome-again=1 and it does not crash and you see a toast
Review URL: http://codereview.chromium.org/225019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27101 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/first_run_win.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/first_run_win.cc b/chrome/browser/first_run_win.cc index aedc7fb..379df70 100644 --- a/chrome/browser/first_run_win.cc +++ b/chrome/browser/first_run_win.cc @@ -800,8 +800,8 @@ class TryChromeDialog : public views::ButtonListener, layout->StartRowWithPadding(0, 1, 0, 10); try_chrome_ = new views::RadioButton( kGiveChromeATry[kDialogVersion[version_].try_index], 1); - try_chrome_->SetChecked(true); layout->AddView(try_chrome_); + try_chrome_->SetChecked(true); } // Third row views. if (kDialogVersion[version_].try_index >= 0) { |