diff options
author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-01 09:30:06 +0000 |
---|---|---|
committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-01 09:30:06 +0000 |
commit | cd295cff885814a751a7e78c559460965bb2e92c (patch) | |
tree | 2359f0a0b52f394ca6bc6b2367824c638103fcdb | |
parent | c454ef7e0282ae9910ef47f8b35287ee47fc8331 (diff) | |
download | chromium_src-cd295cff885814a751a7e78c559460965bb2e92c.zip chromium_src-cd295cff885814a751a7e78c559460965bb2e92c.tar.gz chromium_src-cd295cff885814a751a7e78c559460965bb2e92c.tar.bz2 |
Remove all uses of GG_UINT32_C.
We can use UINT32_C from <stdint.h>, since we force-define
__STDC_CONSTANT_MACROS.
As a "drive-by", also remove all the other uses of GG_... from
media/cast (since I'll do it later anyway).
R=hclam@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/219723003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260816 0039d316-1c4b-4281-b951-d872f2087c98
22 files changed, 70 insertions, 34 deletions
diff --git a/base/port.h b/base/port.h index b04ca29..307f257 100644 --- a/base/port.h +++ b/base/port.h @@ -20,7 +20,6 @@ // just use the regular (U)INTn_C macros from <stdint.h>. // TODO(viettrungluu): Remove the remaining GG_(U)INTn_C macros. #define GG_INT64_C(x) GG_LONGLONG(x) -#define GG_UINT32_C(x) (x ## U) #define GG_UINT64_C(x) GG_ULONGLONG(x) // It's possible for functions that use a va_list, such as StringPrintf, to diff --git a/media/cast/audio_receiver/audio_receiver_unittest.cc b/media/cast/audio_receiver/audio_receiver_unittest.cc index cd00e44..bf2c39c 100644 --- a/media/cast/audio_receiver/audio_receiver_unittest.cc +++ b/media/cast/audio_receiver/audio_receiver_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/bind.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" @@ -18,7 +20,7 @@ namespace media { namespace cast { -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); namespace { class FakeAudioClient { diff --git a/media/cast/audio_sender/audio_encoder_unittest.cc b/media/cast/audio_sender/audio_encoder_unittest.cc index 52b8e56..e2a467e 100644 --- a/media/cast/audio_sender/audio_encoder_unittest.cc +++ b/media/cast/audio_sender/audio_encoder_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include <sstream> #include <string> @@ -20,7 +22,7 @@ namespace media { namespace cast { -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); namespace { diff --git a/media/cast/audio_sender/audio_sender_unittest.cc b/media/cast/audio_sender/audio_sender_unittest.cc index ad0f3db..80443cb 100644 --- a/media/cast/audio_sender/audio_sender_unittest.cc +++ b/media/cast/audio_sender/audio_sender_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/bind.h" #include "base/bind_helpers.h" #include "base/memory/scoped_ptr.h" @@ -20,7 +22,7 @@ namespace media { namespace cast { -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); class TestPacketSender : public transport::PacketSender { public: diff --git a/media/cast/cast_defines.h b/media/cast/cast_defines.h index 8826e5d..802df18 100644 --- a/media/cast/cast_defines.h +++ b/media/cast/cast_defines.h @@ -5,6 +5,8 @@ #ifndef MEDIA_CAST_CAST_DEFINES_H_ #define MEDIA_CAST_CAST_DEFINES_H_ +#include <stdint.h> + #include <map> #include <set> @@ -21,7 +23,7 @@ const int64 kDontShowTimeoutMs = 33; const float kDefaultCongestionControlBackOff = 0.875f; const uint32 kVideoFrequency = 90000; const int64 kSkippedFramesCheckPeriodkMs = 10000; -const uint32 kStartFrameId = GG_UINT32_C(0xffffffff); +const uint32 kStartFrameId = UINT32_C(0xffffffff); // Number of skipped frames threshold in fps (as configured) per period above. const int kSkippedFramesThreshold = 3; @@ -81,7 +83,7 @@ typedef std::map<uint8, PacketIdSet> MissingFramesAndPacketsMap; // January 1970, in NTP seconds. // Network Time Protocol (NTP), which is in seconds relative to 0h UTC on // 1 January 1900. -static const int64 kUnixEpochInNtpSeconds = GG_INT64_C(2208988800); +static const int64 kUnixEpochInNtpSeconds = INT64_C(2208988800); // Magic fractional unit. Used to convert time (in microseconds) to/from // fractional NTP seconds. diff --git a/media/cast/congestion_control/congestion_control_unittest.cc b/media/cast/congestion_control/congestion_control_unittest.cc index edd1327..20e023e 100644 --- a/media/cast/congestion_control/congestion_control_unittest.cc +++ b/media/cast/congestion_control/congestion_control_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/test/simple_test_tick_clock.h" #include "media/cast/cast_defines.h" #include "media/cast/congestion_control/congestion_control.h" @@ -13,7 +15,7 @@ namespace cast { static const uint32 kMaxBitrateConfigured = 5000000; static const uint32 kMinBitrateConfigured = 500000; static const uint32 kStartBitrate = 2000000; -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); static const int64 kRttMs = 20; static const int64 kAckRateMs = 33; @@ -35,7 +37,7 @@ class CongestionControlTest : public ::testing::Test { int runtime_in_seconds) { const base::TimeDelta rtt = base::TimeDelta::FromMilliseconds(rtt_ms); const base::TimeDelta ack_rate = - base::TimeDelta::FromMilliseconds(GG_INT64_C(1000) / fps); + base::TimeDelta::FromMilliseconds(INT64_C(1000) / fps); uint32 new_bitrate = 0; EXPECT_FALSE(congestion_control_.OnAck(rtt, &new_bitrate)); @@ -160,21 +162,19 @@ TEST_F(CongestionControlTest, Timing) { } TEST_F(CongestionControlTest, Convergence24fps) { - EXPECT_GE(RunWithOneLossEventPerSecond(24, kRttMs, 100), - GG_UINT32_C(3000000)); + EXPECT_GE(RunWithOneLossEventPerSecond(24, kRttMs, 100), UINT32_C(3000000)); } TEST_F(CongestionControlTest, Convergence24fpsLongRtt) { - EXPECT_GE(RunWithOneLossEventPerSecond(24, 100, 100), GG_UINT32_C(500000)); + EXPECT_GE(RunWithOneLossEventPerSecond(24, 100, 100), UINT32_C(500000)); } TEST_F(CongestionControlTest, Convergence60fps) { - EXPECT_GE(RunWithOneLossEventPerSecond(60, kRttMs, 100), - GG_UINT32_C(3500000)); + EXPECT_GE(RunWithOneLossEventPerSecond(60, kRttMs, 100), UINT32_C(3500000)); } TEST_F(CongestionControlTest, Convergence60fpsLongRtt) { - EXPECT_GE(RunWithOneLossEventPerSecond(60, 100, 100), GG_UINT32_C(500000)); + EXPECT_GE(RunWithOneLossEventPerSecond(60, 100, 100), UINT32_C(500000)); } } // namespace cast diff --git a/media/cast/framer/cast_message_builder_unittest.cc b/media/cast/framer/cast_message_builder_unittest.cc index 445b04d..4c3e67bd 100644 --- a/media/cast/framer/cast_message_builder_unittest.cc +++ b/media/cast/framer/cast_message_builder_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/memory/scoped_ptr.h" #include "base/test/simple_test_tick_clock.h" #include "media/cast/framer/cast_message_builder.h" @@ -16,7 +18,7 @@ namespace { static const uint32 kSsrc = 0x1234; static const uint32 kShortTimeIncrementMs = 10; static const uint32 kLongTimeIncrementMs = 40; -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); typedef std::map<uint32, size_t> MissingPacketsMap; diff --git a/media/cast/logging/logging_impl_unittest.cc b/media/cast/logging/logging_impl_unittest.cc index d9a67dd..4aceecb 100644 --- a/media/cast/logging/logging_impl_unittest.cc +++ b/media/cast/logging/logging_impl_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include <vector> #include "base/rand_util.h" @@ -21,7 +23,7 @@ const int64 kIntervalTime1S = 1; // Test frame rate goal - 30fps. const int kFrameIntervalMs = 33; -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); class LoggingImplTest : public ::testing::Test { protected: diff --git a/media/cast/rtcp/rtcp_sender.cc b/media/cast/rtcp/rtcp_sender.cc index cb41c2f..1175945 100644 --- a/media/cast/rtcp/rtcp_sender.cc +++ b/media/cast/rtcp/rtcp_sender.cc @@ -4,6 +4,8 @@ #include "media/cast/rtcp/rtcp_sender.h" +#include <stdint.h> + #include <algorithm> #include <vector> @@ -21,7 +23,7 @@ namespace { // Max delta is 4095 milliseconds because we need to be able to encode it in // 12 bits. -const int64 kMaxWireFormatTimeDeltaMs = GG_INT64_C(0xfff); +const int64 kMaxWireFormatTimeDeltaMs = INT64_C(0xfff); // Converts a log event type to an integer value. // NOTE: We have only allocated 4 bits to represent the type of event over the diff --git a/media/cast/rtcp/rtcp_unittest.cc b/media/cast/rtcp/rtcp_unittest.cc index 628f0d2..bdc96bd 100644 --- a/media/cast/rtcp/rtcp_unittest.cc +++ b/media/cast/rtcp/rtcp_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/test/simple_test_tick_clock.h" #include "media/cast/cast_defines.h" #include "media/cast/cast_environment.h" @@ -24,7 +26,7 @@ static const uint32 kSenderSsrc = 0x10203; static const uint32 kReceiverSsrc = 0x40506; static const std::string kCName("test@10.1.1.1"); static const uint32 kRtcpIntervalMs = 500; -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); static const int64 kAddedDelay = 123; static const int64 kAddedShortDelay = 100; @@ -487,8 +489,8 @@ TEST_F(RtcpTest, RttWithPacketLoss) { } TEST_F(RtcpTest, NtpAndTime) { - const int64 kSecondsbetweenYear1900and2010 = GG_INT64_C(40176 * 24 * 60 * 60); - const int64 kSecondsbetweenYear1900and2030 = GG_INT64_C(47481 * 24 * 60 * 60); + const int64 kSecondsbetweenYear1900and2010 = INT64_C(40176 * 24 * 60 * 60); + const int64 kSecondsbetweenYear1900and2030 = INT64_C(47481 * 24 * 60 * 60); uint32 ntp_seconds_1 = 0; uint32 ntp_fractions_1 = 0; @@ -514,7 +516,7 @@ TEST_F(RtcpTest, NtpAndTime) { // Verify delta. EXPECT_EQ((out_2 - out_1), time_delta); - EXPECT_EQ((ntp_seconds_2 - ntp_seconds_1), GG_UINT32_C(1)); + EXPECT_EQ((ntp_seconds_2 - ntp_seconds_1), UINT32_C(1)); EXPECT_NEAR(ntp_fractions_2, ntp_fractions_1, 1); time_delta = base::TimeDelta::FromMilliseconds(500); diff --git a/media/cast/rtp_receiver/receiver_stats_unittest.cc b/media/cast/rtp_receiver/receiver_stats_unittest.cc index b2da051..eb4b589 100644 --- a/media/cast/rtp_receiver/receiver_stats_unittest.cc +++ b/media/cast/rtp_receiver/receiver_stats_unittest.cc @@ -4,6 +4,8 @@ #include <gtest/gtest.h> +#include <stdint.h> + #include "base/test/simple_test_tick_clock.h" #include "base/time/time.h" #include "media/cast/rtp_receiver/receiver_stats.h" @@ -12,7 +14,7 @@ namespace media { namespace cast { -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); static const uint32 kStdTimeIncrementMs = 33; class ReceiverStatsTest : public ::testing::Test { diff --git a/media/cast/test/encode_decode_test.cc b/media/cast/test/encode_decode_test.cc index 3151833..20b1348 100644 --- a/media/cast/test/encode_decode_test.cc +++ b/media/cast/test/encode_decode_test.cc @@ -7,6 +7,7 @@ // transport layer, and are targeted at validating the bit stream. #include <gtest/gtest.h> +#include <stdint.h> #include "base/bind.h" #include "base/memory/scoped_ptr.h" @@ -20,7 +21,7 @@ namespace media { namespace cast { -static const int64 kStartMillisecond = GG_INT64_C(1245); +static const int64 kStartMillisecond = INT64_C(1245); static const int kWidth = 1280; static const int kHeight = 720; static const int kStartbitrate = 4000000; @@ -123,7 +124,7 @@ TEST_F(EncodeDecodeTest, BasicEncodeDecode) { encoder_->Initialize(); // Encode frame. encoder_->Encode(video_frame_, &encoded_frame); - EXPECT_GT(encoded_frame.data.size(), GG_UINT64_C(0)); + EXPECT_GT(encoded_frame.data.size(), UINT64_C(0)); // Decode frame. decoder_->Decode(&encoded_frame, base::TimeTicks(), diff --git a/media/cast/test/end2end_unittest.cc b/media/cast/test/end2end_unittest.cc index b2037ab..7299501 100644 --- a/media/cast/test/end2end_unittest.cc +++ b/media/cast/test/end2end_unittest.cc @@ -10,6 +10,7 @@ // that moves across the screen #include <math.h> +#include <stdint.h> #include <functional> #include <list> @@ -44,7 +45,7 @@ namespace cast { namespace { -static const int64 kStartMillisecond = GG_INT64_C(1245); +static const int64 kStartMillisecond = INT64_C(1245); static const int kAudioChannels = 2; static const double kSoundFrequency = 314.15926535897; // Freq of sine wave. static const float kSoundVolume = 0.5f; diff --git a/media/cast/transport/cast_transport_defines.h b/media/cast/transport/cast_transport_defines.h index 252883d..328b4bd 100644 --- a/media/cast/transport/cast_transport_defines.h +++ b/media/cast/transport/cast_transport_defines.h @@ -5,6 +5,8 @@ #ifndef MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_DEFINES_H_ #define MEDIA_CAST_TRANSPORT_CAST_TRANSPORT_DEFINES_H_ +#include <stdint.h> + #include <map> #include <set> #include <string> @@ -142,7 +144,7 @@ class FrameIdWrapHelper { static const uint8 kLowRangeThreshold = 63; static const uint8 kHighRangeThreshold = 192; - static const uint32 kStartFrameId = GG_UINT32_C(0xffffffff); + static const uint32 kStartFrameId = UINT32_C(0xffffffff); bool first_; uint32 frame_id_wrap_count_; diff --git a/media/cast/transport/cast_transport_sender_impl_unittest.cc b/media/cast/transport/cast_transport_sender_impl_unittest.cc index 7077bf6..6df5304 100644 --- a/media/cast/transport/cast_transport_sender_impl_unittest.cc +++ b/media/cast/transport/cast_transport_sender_impl_unittest.cc @@ -3,6 +3,7 @@ // found in the LICENSE file. #include <gtest/gtest.h> +#include <stdint.h> #include "base/bind.h" #include "base/bind_helpers.h" @@ -21,7 +22,7 @@ namespace media { namespace cast { namespace transport { -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); class FakePacketSender : public transport::PacketSender { public: diff --git a/media/cast/transport/pacing/paced_sender_unittest.cc b/media/cast/transport/pacing/paced_sender_unittest.cc index bd558dc..16dcd0f 100644 --- a/media/cast/transport/pacing/paced_sender_unittest.cc +++ b/media/cast/transport/pacing/paced_sender_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/big_endian.h" #include "base/test/simple_test_tick_clock.h" #include "media/cast/logging/simple_event_subscriber.h" @@ -21,7 +23,7 @@ static const size_t kSize2 = 101; static const size_t kSize3 = 102; static const size_t kSize4 = 103; static const size_t kNackSize = 104; -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); static const uint32 kVideoSsrc = 0x1234; static const uint32 kAudioSsrc = 0x5678; diff --git a/media/cast/transport/rtp_sender/packet_storage/packet_storage_unittest.cc b/media/cast/transport/rtp_sender/packet_storage/packet_storage_unittest.cc index c83a528..73faad0 100644 --- a/media/cast/transport/rtp_sender/packet_storage/packet_storage_unittest.cc +++ b/media/cast/transport/rtp_sender/packet_storage/packet_storage_unittest.cc @@ -4,6 +4,8 @@ #include "media/cast/transport/rtp_sender/packet_storage/packet_storage.h" +#include <stdint.h> + #include <vector> #include "base/test/simple_test_tick_clock.h" @@ -18,7 +20,7 @@ static const int kMaxDeltaStoredMs = 500; static const base::TimeDelta kDeltaBetweenFrames = base::TimeDelta::FromMilliseconds(33); -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); class PacketStorageTest : public ::testing::Test { protected: diff --git a/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc b/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc index 8aa8fff..4b7d0966 100644 --- a/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc +++ b/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc @@ -4,6 +4,8 @@ #include "media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.h" +#include <stdint.h> + #include "base/memory/scoped_ptr.h" #include "base/test/simple_test_tick_clock.h" #include "media/cast/logging/simple_event_subscriber.h" @@ -25,7 +27,7 @@ static const int kMaxPacketLength = 1500; static const int kSsrc = 0x12345; static const unsigned int kFrameSize = 5000; static const int kMaxPacketStorageTimeMs = 300; -static const uint32 kStartFrameId = GG_UINT32_C(0xffffffff); +static const uint32 kStartFrameId = UINT32_C(0xffffffff); } class TestRtpPacketTransport : public PacketSender { diff --git a/media/cast/video_receiver/video_decoder.cc b/media/cast/video_receiver/video_decoder.cc index 230b6e1..f85e117 100644 --- a/media/cast/video_receiver/video_decoder.cc +++ b/media/cast/video_receiver/video_decoder.cc @@ -4,6 +4,8 @@ #include "media/cast/video_receiver/video_decoder.h" +#include <stdint.h> + #include "base/bind.h" #include "base/logging.h" #include "base/message_loop/message_loop.h" @@ -32,7 +34,7 @@ bool VideoDecoder::DecodeVideoFrame( const base::TimeTicks render_time, const VideoFrameDecodedCallback& frame_decoded_cb) { DCHECK(encoded_frame->codec == codec_) << "Invalid codec"; - DCHECK_GT(encoded_frame->data.size(), GG_UINT64_C(0)) << "Empty video frame"; + DCHECK_GT(encoded_frame->data.size(), UINT64_C(0)) << "Empty video frame"; return vp8_decoder_->Decode(encoded_frame, render_time, frame_decoded_cb); } diff --git a/media/cast/video_receiver/video_decoder_unittest.cc b/media/cast/video_receiver/video_decoder_unittest.cc index dd1c0e6..44de880 100644 --- a/media/cast/video_receiver/video_decoder_unittest.cc +++ b/media/cast/video_receiver/video_decoder_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/bind.h" #include "base/memory/scoped_ptr.h" #include "base/test/simple_test_tick_clock.h" @@ -20,7 +22,7 @@ namespace cast { using testing::_; // Random frame size for testing. -static const int64 kStartMillisecond = GG_INT64_C(1245); +static const int64 kStartMillisecond = INT64_C(1245); namespace { class DecodeTestFrameCallback diff --git a/media/cast/video_receiver/video_receiver_unittest.cc b/media/cast/video_receiver/video_receiver_unittest.cc index 94a7841..7bea501 100644 --- a/media/cast/video_receiver/video_receiver_unittest.cc +++ b/media/cast/video_receiver/video_receiver_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include "base/bind.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" @@ -15,7 +17,7 @@ #include "testing/gmock/include/gmock/gmock.h" static const int kPacketSize = 1500; -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); namespace media { namespace cast { diff --git a/media/cast/video_sender/video_sender_unittest.cc b/media/cast/video_sender/video_sender_unittest.cc index 1eafe40..56d38c0 100644 --- a/media/cast/video_sender/video_sender_unittest.cc +++ b/media/cast/video_sender/video_sender_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <stdint.h> + #include <vector> #include "base/bind.h" @@ -25,7 +27,7 @@ namespace media { namespace cast { namespace { -static const int64 kStartMillisecond = GG_INT64_C(12345678900000); +static const int64 kStartMillisecond = INT64_C(12345678900000); static const uint8 kPixelValue = 123; static const int kWidth = 320; static const int kHeight = 240; |