diff options
author | miket@chromium.org <miket@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-18 02:00:39 +0000 |
---|---|---|
committer | miket@chromium.org <miket@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-18 02:00:39 +0000 |
commit | d1282c219c49e2a8baa4326ac1b847f9c24e0c6d (patch) | |
tree | 6a5bfcdc7bdd0486b27ecc91a6d97b14c0b66498 | |
parent | 20512e18b7e9c13c689c7085b82b8cda54ec22f9 (diff) | |
download | chromium_src-d1282c219c49e2a8baa4326ac1b847f9c24e0c6d.zip chromium_src-d1282c219c49e2a8baa4326ac1b847f9c24e0c6d.tar.gz chromium_src-d1282c219c49e2a8baa4326ac1b847f9c24e0c6d.tar.bz2 |
Add another point at which we check for new external extensions.
The effect when multiple extensions appear is what we want (the bubble is
quickly replaced with the updated list as each extension's I/O completes),
but I feel that we're playing a bit fast and loose with the UI. It might be OK.
BUG=94494
TEST=manual.
Review URL: http://codereview.chromium.org/8329003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106000 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/extensions/extension_service.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc index 835064d..82b3ad4 100644 --- a/chrome/browser/extensions/extension_service.cc +++ b/chrome/browser/extensions/extension_service.cc @@ -2153,14 +2153,11 @@ void ExtensionService::OnExternalProviderReady() { if (Extension::IsExternalLocation(info->extension_location)) CheckExternalUninstall(info->extension_id); } - -#if 0 - // TODO(miket): enable upon completion of feature. IdentifyAlertableExtensions(); -#endif } void ExtensionService::IdentifyAlertableExtensions() { +#if 0 // TODO(miket): enable upon completion of feature. CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); // Build up the lists of extensions that require acknowledgment. @@ -2211,6 +2208,7 @@ void ExtensionService::IdentifyAlertableExtensions() { HandleExtensionAlertAccept(*global_error.get(), NULL); } } +#endif } void ExtensionService::ShowExtensionAlert(ExtensionGlobalError* global_error) { @@ -2405,6 +2403,7 @@ void ExtensionService::AddExtension(const Extension* extension) { extensions_.push_back(scoped_extension); SyncExtensionChangeIfNeeded(*extension); NotifyExtensionLoaded(extension); + IdentifyAlertableExtensions(); } void ExtensionService::InitializePermissions(const Extension* extension) { |