diff options
author | megjablon <megjablon@chromium.org> | 2016-03-03 17:12:44 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-04 01:14:06 +0000 |
commit | d285b019189141a8c235f9eed8764d6129043380 (patch) | |
tree | 902cdde7135288a4e90f4c56276ebf7e37f8d5a1 | |
parent | 93fefd7571856807e9f1f5c5bcec8cfbf58a0c9f (diff) | |
download | chromium_src-d285b019189141a8c235f9eed8764d6129043380.zip chromium_src-d285b019189141a8c235f9eed8764d6129043380.tar.gz chromium_src-d285b019189141a8c235f9eed8764d6129043380.tar.bz2 |
AGSA-initiated weblite intent URLs should be rewritten before Tab creation
BUG=584085
Review URL: https://codereview.chromium.org/1762563002
Cr-Commit-Position: refs/heads/master@{#379160}
-rw-r--r-- | chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java index 91dfd06..eee242a 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java @@ -579,13 +579,7 @@ public class DocumentActivity extends ChromeActivity { boolean isCreatedWithWebContents = asyncParams != null && asyncParams.getWebContents() != null; - if (params != null && params.getTabToReparent() != null) { - mTab = params.getTabToReparent(); - mTab.reparentToActivity(this, new DocumentTabDelegateFactory()); - } else { - mTab = createActivityTab(asyncParams); - } - + // URL modification must happen before the Tab is created. if (!isIncognito() && asyncParams != null) { LoadUrlParams loadUrlParams = asyncParams.getLoadUrlParams(); if (loadUrlParams != null && loadUrlParams.getUrl() != null) { @@ -594,6 +588,13 @@ public class DocumentActivity extends ChromeActivity { } } + if (params != null && params.getTabToReparent() != null) { + mTab = params.getTabToReparent(); + mTab.reparentToActivity(this, new DocumentTabDelegateFactory()); + } else { + mTab = createActivityTab(asyncParams); + } + if (asyncParams != null && asyncParams.getWebContents() != null) { Intent parentIntent = IntentUtils.safeGetParcelableExtra(getIntent(), IntentHandler.EXTRA_PARENT_INTENT); |