summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-01 16:14:55 +0000
committertimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-01 16:14:55 +0000
commitd5a5892a7d00af0d331a5697117e14101dd6a12c (patch)
tree00d583dbc653ae4fb164794fb00f5e2f2ce4e67d
parent45fb1467431370f35763e3077c1db2df7539f42c (diff)
downloadchromium_src-d5a5892a7d00af0d331a5697117e14101dd6a12c.zip
chromium_src-d5a5892a7d00af0d331a5697117e14101dd6a12c.tar.gz
chromium_src-d5a5892a7d00af0d331a5697117e14101dd6a12c.tar.bz2
Update Dr. Memory suppressions, runner (new options for 1.3.0) and analyzer (found a small bug)
Review URL: http://codereview.chromium.org/3326002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58181 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--tools/valgrind/drmemory/suppressions.txt57
-rwxr-xr-xtools/valgrind/drmemory_analyze.py2
-rwxr-xr-xtools/valgrind/valgrind_test.py1
3 files changed, 59 insertions, 1 deletions
diff --git a/tools/valgrind/drmemory/suppressions.txt b/tools/valgrind/drmemory/suppressions.txt
index 486545c..4908477 100644
--- a/tools/valgrind/drmemory/suppressions.txt
+++ b/tools/valgrind/drmemory/suppressions.txt
@@ -61,6 +61,27 @@ UNINITIALIZED READ
...
*!CreateWindow*
+# http://code.google.com/p/drmemory/issues/detail?id=18
+UNINITIALIZED READ
+...
+*!CoInitialize*
+
+UNINITIALIZED READ
+...
+*!CoCreateInstance*
+
+UNINITIALIZED READ
+...
+*!CoUninitialize*
+
+UNINITIALIZED READ
+...
+UxTheme.dll!*
+
+UNINITIALIZED READ
+...
+RPCRT4.dll!UuidCreate
+
# http://code.google.com/p/drmemory/issues/detail?id=36
UNINITIALIZED READ
system call NtContinue
@@ -94,6 +115,42 @@ UNINITIALIZED READ
...
ADVAPI32.dll!CryptAcquireContext*
+UNINITIALIZED READ
+...
+ntshrui.dll!IsPathSharedW
+
+UNINITIALIZED READ
+...
+*!NetApiBufferFree
+
+UNINITIALIZED READ
+...
+*!ShellExecute*
+
+UNADDRESSABLE ACCESS
+...
+*!SHParseDisplayName
+
+UNINITIALIZED READ
+...
+*!SHParseDisplayName
+
+UNINITIALIZED READ
+...
+*!GetCanonicalPathInfo*
+
+UNADDRESSABLE ACCESS
+...
+*!GetCanonicalPathInfo*
+
+UNINITIALIZED READ
+...
+SHELL32.dll!Ordinal*
+
+UNADDRESSABLE ACCESS
+...
+GDI32.dll!CreateDC*
+
############################
# Real issues in Chromium
diff --git a/tools/valgrind/drmemory_analyze.py b/tools/valgrind/drmemory_analyze.py
index c6046e9..05b9bd7 100755
--- a/tools/valgrind/drmemory_analyze.py
+++ b/tools/valgrind/drmemory_analyze.py
@@ -104,7 +104,7 @@ class DrMemoryAnalyze:
# DrMemory has finished working.
break
tmp = []
- match = re.search("Error #[0-9]+: (.*)", self.line_)
+ match = re.search("^Error #[0-9]+: (.*)", self.line_)
if match:
self.line_ = match.groups()[0].strip() + "\n"
tmp.extend(self.ReadSection())
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py
index 12293e7..c2a7160 100755
--- a/tools/valgrind/valgrind_test.py
+++ b/tools/valgrind/valgrind_test.py
@@ -756,6 +756,7 @@ class DrMemory(BaseTool):
proc += ["-logdir", (os.getcwd() + "\\" + self.TMP_DIR)]
proc += ["-batch", "-quiet"]
+ proc += ["-no_check_leaks", "-no_count_leaks"]
# Dr.Memory requires -- to separate tool flags from the executable name.
proc += ["--"]