summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-07 19:10:09 +0000
committermpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-07 19:10:09 +0000
commitd76cbd651f0880d9edb5e497f71717f47b5482d7 (patch)
tree88f6366529baa3b6d9f9b566e68bd11b0c903b0d
parent9548e6c0cdea562a1b5293b224fb1e10ff6fcfb2 (diff)
downloadchromium_src-d76cbd651f0880d9edb5e497f71717f47b5482d7.zip
chromium_src-d76cbd651f0880d9edb5e497f71717f47b5482d7.tar.gz
chromium_src-d76cbd651f0880d9edb5e497f71717f47b5482d7.tar.bz2
Temporary CL to debug test failure on the buildbot.
Review URL: http://codereview.chromium.org/1545023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43861 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/extensions/extension_browsertests_misc.cc18
-rw-r--r--chrome/browser/plugin_service.cc7
2 files changed, 23 insertions, 2 deletions
diff --git a/chrome/browser/extensions/extension_browsertests_misc.cc b/chrome/browser/extensions/extension_browsertests_misc.cc
index e45efd5..35ec8a6 100644
--- a/chrome/browser/extensions/extension_browsertests_misc.cc
+++ b/chrome/browser/extensions/extension_browsertests_misc.cc
@@ -678,9 +678,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenNoPrivileges) {
#define MAYBE_PluginLoadUnload DISABLED_PluginLoadUnload
#else
// TODO(mpcomplete): http://crbug.com/40588 reenable after fixing.
-#define MAYBE_PluginLoadUnload DISABLED_PluginLoadUnload
+#define MAYBE_PluginLoadUnload PluginLoadUnload
#endif
+#include <iostream>
+using namespace std;
+
// Tests that a renderer's plugin list is properly updated when we load and
// unload an extension that contains a plugin.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, MAYBE_PluginLoadUnload) {
@@ -699,7 +702,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, MAYBE_PluginLoadUnload) {
ExtensionsService* service = browser()->profile()->GetExtensionsService();
const size_t size_before = service->extensions()->size();
+ std::cout << "@@ LoadExtension1" << endl;
ASSERT_TRUE(LoadExtension(extension_dir));
+ std::cout << "@@ LoadExtension1e" << endl;
EXPECT_EQ(size_before + 1, service->extensions()->size());
// Now the plugin should be in the cache, but we have to reload the page for
// it to work.
@@ -713,7 +718,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, MAYBE_PluginLoadUnload) {
EXPECT_TRUE(result);
EXPECT_EQ(size_before + 1, service->extensions()->size());
+ std::cout << "@@ UnloadExtension" << endl;
UnloadExtension(service->extensions()->at(size_before)->id());
+ std::cout << "@@ UnloadExtensione" << endl;
EXPECT_EQ(size_before, service->extensions()->size());
// Now the plugin should be unloaded, and the page should be broken.
@@ -724,12 +731,19 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, MAYBE_PluginLoadUnload) {
// If we reload the extension and page, it should work again.
+ std::cout << "@@ LoadExtension2" << endl;
ASSERT_TRUE(LoadExtension(extension_dir));
+ std::cout << "@@ LoadExtension2e" << endl;
EXPECT_EQ(size_before + 1, service->extensions()->size());
+ std::cout << "@@ Reloading" << endl;
browser()->Reload();
+ std::cout << "@@ Waiting: " << tab << " vs " <<
+ browser()->GetSelectedTabContents() << endl;
ui_test_utils::WaitForNavigationInCurrentTab(browser());
- ui_test_utils::ExecuteJavaScriptAndExtractBool(
+ std::cout << "@@ Executing JS" << endl;
+ bool retval = ui_test_utils::ExecuteJavaScriptAndExtractBool(
tab->render_view_host(), L"", L"testPluginWorks()", &result);
+ std::cout << "@@ Executed: " << retval << endl;
EXPECT_TRUE(result);
}
diff --git a/chrome/browser/plugin_service.cc b/chrome/browser/plugin_service.cc
index f16108d..de7e744 100644
--- a/chrome/browser/plugin_service.cc
+++ b/chrome/browser/plugin_service.cc
@@ -1,6 +1,8 @@
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <iostream>
+using namespace std;
#include "build/build_config.h"
@@ -217,6 +219,8 @@ PluginProcessHost* PluginService::FindOrStartPluginProcess(
DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
PluginProcessHost *plugin_host = FindPluginProcess(plugin_path);
+ std::cout << "Starting plugin: " << plugin_path.ToWStringHack()
+ << " = " << plugin_host << endl;
if (plugin_host)
return plugin_host;
@@ -227,6 +231,8 @@ PluginProcessHost* PluginService::FindOrStartPluginProcess(
return NULL;
}
+ std::cout << "Starting plugin info: " << info.name << endl;
+
// This plugin isn't loaded by any plugin process, so create a new process.
plugin_host = new PluginProcessHost();
if (!plugin_host->Init(info, ui_locale_)) {
@@ -297,6 +303,7 @@ void PluginService::OnWaitableEventSignaled(
static void ForceShutdownPlugin(const FilePath& plugin_path) {
PluginProcessHost* plugin =
PluginService::GetInstance()->FindPluginProcess(plugin_path);
+ std::cout << "Shutting down:" << plugin << endl;
if (plugin)
plugin->ForceShutdown();
}