diff options
author | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-25 17:28:30 +0000 |
---|---|---|
committer | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-25 17:28:30 +0000 |
commit | d7e85c5dd9c2c8dfb38d1e7c6aacb1c3bd0bf590 (patch) | |
tree | 06979caf8ee32393147837cc02cd2ece6a03b796 | |
parent | cff9344d36ea0276fee4d0adf42c79fa263820d6 (diff) | |
download | chromium_src-d7e85c5dd9c2c8dfb38d1e7c6aacb1c3bd0bf590.zip chromium_src-d7e85c5dd9c2c8dfb38d1e7c6aacb1c3bd0bf590.tar.gz chromium_src-d7e85c5dd9c2c8dfb38d1e7c6aacb1c3bd0bf590.tar.bz2 |
Make bookmark_context_menu.cc and bookmark_drop_info.cc compile on Posix.
Review URL: http://codereview.chromium.org/28103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10343 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/bookmarks/bookmark_context_menu.cc | 36 | ||||
-rw-r--r-- | chrome/browser/bookmarks/bookmark_context_menu.h | 12 | ||||
-rw-r--r-- | chrome/browser/bookmarks/bookmark_drop_info.cc | 26 | ||||
-rw-r--r-- | chrome/browser/bookmarks/bookmark_drop_info.h | 8 | ||||
-rw-r--r-- | chrome/browser/bookmarks/bookmark_utils.cc | 1 | ||||
-rw-r--r-- | chrome/browser/bookmarks/bookmark_utils.h | 9 | ||||
-rw-r--r-- | chrome/browser/browser.scons | 2 | ||||
-rw-r--r-- | chrome/chrome.xcodeproj/project.pbxproj | 8 | ||||
-rw-r--r-- | chrome/common/temp_scaffolding_stubs.cc | 6 | ||||
-rw-r--r-- | chrome/common/temp_scaffolding_stubs.h | 79 |
10 files changed, 151 insertions, 36 deletions
diff --git a/chrome/browser/bookmarks/bookmark_context_menu.cc b/chrome/browser/bookmarks/bookmark_context_menu.cc index c4d067b..727d16a 100644 --- a/chrome/browser/bookmarks/bookmark_context_menu.cc +++ b/chrome/browser/bookmarks/bookmark_context_menu.cc @@ -11,16 +11,20 @@ #include "chrome/browser/metrics/user_metrics.h" #include "chrome/browser/profile.h" #include "chrome/browser/tab_contents/page_navigator.h" +#include "chrome/common/l10n_util.h" +#include "chrome/common/pref_names.h" +#include "chrome/common/pref_service.h" +#include "grit/generated_resources.h" + +// TODO(port): Port these files. +#if defined(OS_WIN) #include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/browser/views/bookmark_bar_view.h" #include "chrome/browser/views/bookmark_editor_view.h" #include "chrome/browser/views/bookmark_manager_view.h" #include "chrome/browser/views/input_window.h" -#include "chrome/common/l10n_util.h" -#include "chrome/common/pref_names.h" -#include "chrome/common/pref_service.h" #include "chrome/views/window.h" -#include "grit/generated_resources.h" +#endif namespace { @@ -52,19 +56,19 @@ class EditFolderController : public InputWindowDelegate, } static void Show(Profile* profile, - HWND hwnd, + gfx::NativeWindow wnd, BookmarkNode* node, bool is_new, bool show_in_manager) { // EditFolderController deletes itself when done. EditFolderController* controller = - new EditFolderController(profile, hwnd, node, is_new, show_in_manager); + new EditFolderController(profile, wnd, node, is_new, show_in_manager); controller->Show(); } private: EditFolderController(Profile* profile, - HWND hwnd, + gfx::NativeWindow wnd, BookmarkNode* node, bool is_new, bool show_in_manager) @@ -74,7 +78,7 @@ class EditFolderController : public InputWindowDelegate, is_new_(is_new), show_in_manager_(show_in_manager) { DCHECK(is_new_ || node); - window_ = CreateInputWindow(hwnd, this); + window_ = CreateInputWindow(wnd, this); model_->AddObserver(this); } @@ -209,14 +213,14 @@ class SelectOnCreationHandler : public BookmarkEditorView::Handler { // BookmarkContextMenu ------------------------------------------- BookmarkContextMenu::BookmarkContextMenu( - HWND hwnd, + gfx::NativeWindow wnd, Profile* profile, Browser* browser, PageNavigator* navigator, BookmarkNode* parent, const std::vector<BookmarkNode*>& selection, ConfigurationType configuration) - : hwnd_(hwnd), + : wnd_(wnd), profile_(profile), browser_(browser), navigator_(navigator), @@ -320,7 +324,7 @@ void BookmarkContextMenu::RunMenuAt(int x, int y) { views::MenuItemView::AnchorPosition anchor = (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) ? views::MenuItemView::TOPRIGHT : views::MenuItemView::TOPLEFT; - menu_->RunMenuAt(hwnd_, gfx::Rect(x, y, 0, 0), anchor, true); + menu_->RunMenuAt(wnd_, gfx::Rect(x, y, 0, 0), anchor, true); } void BookmarkContextMenu::ExecuteCommand(int id) { @@ -345,7 +349,7 @@ void BookmarkContextMenu::ExecuteCommand(int id) { L"BookmarkBar_ContextMenu_OpenAllIncognito", profile_); } - bookmark_utils::OpenAll(hwnd_, profile_, navigator, selection_, + bookmark_utils::OpenAll(wnd_, profile_, navigator, selection_, initial_disposition); break; } @@ -365,10 +369,10 @@ void BookmarkContextMenu::ExecuteCommand(int id) { editor_config = BookmarkEditorView::SHOW_TREE; else editor_config = BookmarkEditorView::NO_TREE; - BookmarkEditorView::Show(hwnd_, profile_, NULL, selection_[0], + BookmarkEditorView::Show(wnd_, profile_, NULL, selection_[0], editor_config, NULL); } else { - EditFolderController::Show(profile_, hwnd_, selection_[0], false, + EditFolderController::Show(profile_, wnd_, selection_[0], false, false); } break; @@ -397,7 +401,7 @@ void BookmarkContextMenu::ExecuteCommand(int id) { // This is owned by the BookmarkEditorView. handler = new SelectOnCreationHandler(profile_); } - BookmarkEditorView::Show(hwnd_, profile_, GetParentForNewNodes(), NULL, + BookmarkEditorView::Show(wnd_, profile_, GetParentForNewNodes(), NULL, editor_config, handler); break; } @@ -406,7 +410,7 @@ void BookmarkContextMenu::ExecuteCommand(int id) { UserMetrics::RecordAction(L"BookmarkBar_ContextMenu_NewFolder", profile_); - EditFolderController::Show(profile_, hwnd_, GetParentForNewNodes(), + EditFolderController::Show(profile_, wnd_, GetParentForNewNodes(), true, (configuration_ != BOOKMARK_BAR)); break; } diff --git a/chrome/browser/bookmarks/bookmark_context_menu.h b/chrome/browser/bookmarks/bookmark_context_menu.h index 80769ff..f0408f3 100644 --- a/chrome/browser/bookmarks/bookmark_context_menu.h +++ b/chrome/browser/bookmarks/bookmark_context_menu.h @@ -7,8 +7,16 @@ #include <vector> +#include "base/basictypes.h" +#include "base/gfx/native_widget_types.h" #include "chrome/browser/bookmarks/bookmark_model.h" + +// TODO(port): Port this file. +#if defined(OS_WIN) #include "chrome/views/chrome_menu.h" +#else +#include "chrome/common/temp_scaffolding_stubs.h" +#endif class Browser; class PageNavigator; @@ -40,7 +48,7 @@ class BookmarkContextMenu : public views::MenuDelegate, // |parent| is the parent for newly created nodes if |selection| is empty. // |selection| is the nodes the context menu operates on and may be empty. // |configuration| determines which items to show. - BookmarkContextMenu(HWND hwnd, + BookmarkContextMenu(gfx::NativeWindow hwnd, Profile* profile, Browser* browser, PageNavigator* navigator, @@ -96,7 +104,7 @@ class BookmarkContextMenu : public views::MenuDelegate, // parent_ is returned. BookmarkNode* GetParentForNewNodes() const; - HWND hwnd_; + gfx::NativeWindow wnd_; Profile* profile_; Browser* browser_; PageNavigator* navigator_; diff --git a/chrome/browser/bookmarks/bookmark_drop_info.cc b/chrome/browser/bookmarks/bookmark_drop_info.cc index 646b35b..0e39cd7 100644 --- a/chrome/browser/bookmarks/bookmark_drop_info.cc +++ b/chrome/browser/bookmarks/bookmark_drop_info.cc @@ -4,15 +4,20 @@ #include "chrome/browser/bookmarks/bookmark_drop_info.h" +#if defined(OS_WIN) +#include <windows.h> +#endif + +#include "base/basictypes.h" #include "chrome/views/event.h" #include "chrome/views/view_constants.h" -BookmarkDropInfo::BookmarkDropInfo(HWND hwnd, int top_margin) +BookmarkDropInfo::BookmarkDropInfo(gfx::NativeWindow wnd, int top_margin) : source_operations_(0), is_control_down_(false), last_y_(0), drop_operation_(0), - hwnd_(hwnd), + wnd_(wnd), top_margin_(top_margin), scroll_up_(false) { } @@ -22,10 +27,16 @@ void BookmarkDropInfo::Update(const views::DropTargetEvent& event) { is_control_down_ = event.IsControlDown(); last_y_ = event.y(); +#if defined(OS_WIN) RECT client_rect; - GetClientRect(hwnd_, &client_rect); - scroll_up_ = (last_y_ <= top_margin_ + views::kAutoscrollSize); + GetClientRect(wnd_, &client_rect); bool scroll_down = (last_y_ >= client_rect.bottom - views::kAutoscrollSize); +#else + // TODO(port): Get the dimensions of the appropriate view/widget. + NOTIMPLEMENTED(); + bool scroll_down = false; +#endif + scroll_up_ = (last_y_ <= top_margin_ + views::kAutoscrollSize); if (scroll_up_ || scroll_down) { if (!scroll_timer_.IsRunning()) { scroll_timer_.Start( @@ -39,6 +50,11 @@ void BookmarkDropInfo::Update(const views::DropTargetEvent& event) { } void BookmarkDropInfo::Scroll() { - SendMessage(hwnd_, WM_VSCROLL, scroll_up_ ? SB_LINEUP : SB_LINEDOWN, NULL); +#if defined(OS_WIN) + SendMessage(wnd_, WM_VSCROLL, scroll_up_ ? SB_LINEUP : SB_LINEDOWN, NULL); Scrolled(); +#else + // TODO(port): Scroll the appropriate view/widget. + NOTIMPLEMENTED(); +#endif } diff --git a/chrome/browser/bookmarks/bookmark_drop_info.h b/chrome/browser/bookmarks/bookmark_drop_info.h index f4daf89..b7dc643 100644 --- a/chrome/browser/bookmarks/bookmark_drop_info.h +++ b/chrome/browser/bookmarks/bookmark_drop_info.h @@ -5,8 +5,8 @@ #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_DROP_INFO_H_ #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_DROP_INFO_H_ -#include <windows.h> - +#include "base/basictypes.h" +#include "base/gfx/native_widget_types.h" #include "base/timer.h" #include "chrome/browser/bookmarks/bookmark_drag_data.h" @@ -20,7 +20,7 @@ class DropTargetEvent; // BookmarksFolderTreeView. class BookmarkDropInfo { public: - BookmarkDropInfo(HWND hwnd, int top_margin); + BookmarkDropInfo(gfx::NativeWindow hwnd, int top_margin); virtual ~BookmarkDropInfo() {} // Invoke this from OnDragUpdated. It resets source_operations, @@ -67,7 +67,7 @@ class BookmarkDropInfo { int drop_operation_; - HWND hwnd_; + gfx::NativeWindow wnd_; // Margin in addition to views::kAutoscrollSize that the mouse is allowed to // be over before we autoscroll. diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc index 8c7f731d..45e7c6d 100644 --- a/chrome/browser/bookmarks/bookmark_utils.cc +++ b/chrome/browser/bookmarks/bookmark_utils.cc @@ -5,7 +5,6 @@ #include "chrome/browser/bookmarks/bookmark_utils.h" #include "base/basictypes.h" -#include "base/gfx/native_widget_types.h" #include "base/string_util.h" #include "base/time.h" #include "chrome/browser/bookmarks/bookmark_drag_data.h" diff --git a/chrome/browser/bookmarks/bookmark_utils.h b/chrome/browser/bookmarks/bookmark_utils.h index b41542b..9419731 100644 --- a/chrome/browser/bookmarks/bookmark_utils.h +++ b/chrome/browser/bookmarks/bookmark_utils.h @@ -7,6 +7,7 @@ #include <vector> +#include "base/gfx/native_widget_types.h" #include "chrome/browser/bookmarks/bookmark_drag_data.h" #include "chrome/browser/history/snippet.h" #include "webkit/glue/window_open_disposition.h" @@ -42,27 +43,23 @@ void CloneDragData(BookmarkModel* model, BookmarkNode* parent, int index_to_add_at); -#if defined(OS_WIN) -// TODO(port): Make OpenAll portable (remove HWND). - // Recursively opens all bookmarks. |initial_disposition| dictates how the // first URL is opened, all subsequent URLs are opened as background tabs. // |navigator| is used to open the URLs. If |navigator| is NULL the last // tabbed browser with the profile |profile| is used. If there is no browser // with the specified profile a new one is created. -void OpenAll(HWND parent, +void OpenAll(gfx::NativeWindow parent, Profile* profile, PageNavigator* navigator, const std::vector<BookmarkNode*>& nodes, WindowOpenDisposition initial_disposition); // Convenience for opening a single BookmarkNode. -void OpenAll(HWND parent, +void OpenAll(gfx::NativeWindow parent, Profile* profile, PageNavigator* navigator, BookmarkNode* node, WindowOpenDisposition initial_disposition); -#endif // defined(OS_WIN) // Copies nodes onto the clipboard. If |remove_nodes| is true the nodes are // removed after copied to the clipboard. The nodes are copied in such a way diff --git a/chrome/browser/browser.scons b/chrome/browser/browser.scons index 1079f91..4ef5838 100644 --- a/chrome/browser/browser.scons +++ b/chrome/browser/browser.scons @@ -670,8 +670,6 @@ if not env.Bit('windows'): 'automation/automation_provider.cc', 'automation/automation_provider_list.cc', 'automation/ui_controls.cc', - 'bookmarks/bookmark_context_menu.cc', - 'bookmarks/bookmark_drop_info.cc', 'browser_accessibility.cc', 'browser_accessibility_manager.cc', 'chrome_plugin_host.cc', diff --git a/chrome/chrome.xcodeproj/project.pbxproj b/chrome/chrome.xcodeproj/project.pbxproj index 68b6dcc..1edaef7 100644 --- a/chrome/chrome.xcodeproj/project.pbxproj +++ b/chrome/chrome.xcodeproj/project.pbxproj @@ -83,11 +83,13 @@ 0FF05474D5345CABC5C85B5F /* save_package_unittest.cc in Sources */ = {isa = PBXBuildFile; fileRef = 4D7BF9DC0E9D48CE009A6919 /* save_package_unittest.cc */; }; 12E687ED55D418FEE894F824 /* history_url_provider.cc in Sources */ = {isa = PBXBuildFile; fileRef = D3C3DAA911D390A33D06B0B0 /* history_url_provider.cc */; }; 1647A33CB5B4B14087BFF5C8 /* dns_global.cc in Sources */ = {isa = PBXBuildFile; fileRef = 4D7BFA680E9D4981009A6919 /* dns_global.cc */; }; + 198C49FE557624088F83497A /* bookmark_context_menu.cc in Sources */ = {isa = PBXBuildFile; fileRef = 90BF0D1189BB7158BD7F1600 /* bookmark_context_menu.cc */; }; 1C284EB767D0E3D302AC675C /* tab_restore_service.cc in Sources */ = {isa = PBXBuildFile; fileRef = B020A11D500D7519E54F2957 /* tab_restore_service.cc */; }; 1FFE452BCABBD0158B029D4D /* plugin_process_host.cc in Sources */ = {isa = PBXBuildFile; fileRef = 4D7BF8DD0E9D4839009A6919 /* plugin_process_host.cc */; }; 2760C4346D6AB3AD94E9CF05 /* url_fixer_upper.cc in Sources */ = {isa = PBXBuildFile; fileRef = B5D16EF40F2145C600861FAC /* url_fixer_upper.cc */; }; 28283DBE4B6DB2B0F9893676 /* dns_master.cc in Sources */ = {isa = PBXBuildFile; fileRef = 4D7BFA6D0E9D4981009A6919 /* dns_master.cc */; }; 2DF2A9EB8AF96926EE9B6B02 /* ipc_logging.cc in Sources */ = {isa = PBXBuildFile; fileRef = 4D7BFBAE0E9D4C9F009A6919 /* ipc_logging.cc */; }; + 3257B6150A16A88F55E5AE34 /* bookmark_drop_info.cc in Sources */ = {isa = PBXBuildFile; fileRef = 12F137DA942221A44BFA0967 /* bookmark_drop_info.cc */; }; 331218220F3BFF32006CB2B0 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 331B93A90F3BF2B9008B1C46 /* QuartzCore.framework */; }; 331218230F3BFF36006CB2B0 /* Carbon.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 331B93AB0F3BF2DA008B1C46 /* Carbon.framework */; }; 331218290F3C007A006CB2B0 /* renderer_glue.cc in Sources */ = {isa = PBXBuildFile; fileRef = 4D640CD80EAE868600EBCFC0 /* renderer_glue.cc */; }; @@ -1875,6 +1877,7 @@ 0114EE7E1097BDFBF94057E6 /* search_provider.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = search_provider.cc; path = browser/autocomplete/search_provider.cc; sourceTree = SOURCE_ROOT; }; 05C9D404FC8116984CCCEDED /* base_session_service.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = base_session_service.cc; path = sessions/base_session_service.cc; sourceTree = "<group>"; }; 0B7CC9C105E90E0665852528 /* url_fetcher_protect.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = url_fetcher_protect.cc; sourceTree = "<group>"; }; + 12F137DA942221A44BFA0967 /* bookmark_drop_info.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = bookmark_drop_info.cc; path = browser/bookmarks/bookmark_drop_info.cc; sourceTree = SOURCE_ROOT; }; 1F43A7C85092C58AAF011F78 /* greasemonkey_api_unittest.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = greasemonkey_api_unittest.cc; path = extensions/greasemonkey_api_unittest.cc; sourceTree = "<group>"; }; 269003C4E493789D82B6B0F9 /* history_publisher.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = history_publisher.cc; sourceTree = "<group>"; }; 26D97CE692D919FEB1521E43 /* ssl_error_info.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = ssl_error_info.cc; path = ssl/ssl_error_info.cc; sourceTree = "<group>"; }; @@ -2493,6 +2496,7 @@ 844EA0810F3E0C1000B0EF26 /* debugger_window.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = debugger_window.h; path = debugger/debugger_window.h; sourceTree = "<group>"; }; 844EA0820F3E0C1000B0EF26 /* debugger_wrapper.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = debugger_wrapper.cc; path = debugger/debugger_wrapper.cc; sourceTree = "<group>"; }; 844EA0830F3E0C1000B0EF26 /* debugger_wrapper.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = debugger_wrapper.h; path = debugger/debugger_wrapper.h; sourceTree = "<group>"; }; + 90BF0D1189BB7158BD7F1600 /* bookmark_context_menu.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = bookmark_context_menu.cc; path = browser/bookmarks/bookmark_context_menu.cc; sourceTree = SOURCE_ROOT; }; A2FC5EE73E0DE8BF6C1C4C0F /* bookmark_utils.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = bookmark_utils.cc; path = browser/bookmarks/bookmark_utils.cc; sourceTree = SOURCE_ROOT; }; A54612D90EE9957000A8EE5D /* extensions_service.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = extensions_service.cc; sourceTree = "<group>"; }; A54612DA0EE9957000A8EE5D /* extensions_service.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = extensions_service.h; sourceTree = "<group>"; }; @@ -3195,6 +3199,8 @@ 0114EE7E1097BDFBF94057E6 /* search_provider.cc */, A2FC5EE73E0DE8BF6C1C4C0F /* bookmark_utils.cc */, E7FDE61828F151056D975855 /* bookmark_drag_data.cc */, + 12F137DA942221A44BFA0967 /* bookmark_drop_info.cc */, + 90BF0D1189BB7158BD7F1600 /* bookmark_context_menu.cc */, ); sourceTree = "<group>"; }; @@ -5481,7 +5487,9 @@ 82BB330A0F44B57C00761F43 /* base_view.mm in Sources */, 4D7BFAEE0E9D49E5009A6919 /* bloom_filter.cc in Sources */, E45075B20F1505C0003BE099 /* bookmark_codec.cc in Sources */, + 198C49FE557624088F83497A /* bookmark_context_menu.cc in Sources */, F58A0570E84AA76543E0C5CA /* bookmark_drag_data.cc in Sources */, + 3257B6150A16A88F55E5AE34 /* bookmark_drop_info.cc in Sources */, E40CC5F20F2E34EE00708647 /* bookmark_folder_tree_model.cc in Sources */, E45075B40F1505C9003BE099 /* bookmark_html_writer.cc in Sources */, 81E4783DE6F497B9BCC5B9F6 /* bookmark_model.cc in Sources */, diff --git a/chrome/common/temp_scaffolding_stubs.cc b/chrome/common/temp_scaffolding_stubs.cc index 3515580..8d444c3 100644 --- a/chrome/common/temp_scaffolding_stubs.cc +++ b/chrome/common/temp_scaffolding_stubs.cc @@ -416,3 +416,9 @@ DownloadRequestDialogDelegate* DownloadRequestDialogDelegate::Create( DOMMessageHandler::~DOMMessageHandler() { NOTIMPLEMENTED(); } + +views::Window* CreateInputWindow(gfx::NativeWindow parent_hwnd, + InputWindowDelegate* delegate) { + NOTIMPLEMENTED(); + return new views::Window(); +} diff --git a/chrome/common/temp_scaffolding_stubs.h b/chrome/common/temp_scaffolding_stubs.h index 3013b70..b1bd95e 100644 --- a/chrome/common/temp_scaffolding_stubs.h +++ b/chrome/common/temp_scaffolding_stubs.h @@ -20,6 +20,7 @@ #include "base/ref_counted.h" #include "base/gfx/native_widget_types.h" #include "base/gfx/rect.h" +#include "chrome/browser/bookmarks/bookmark_model.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/cache_manager_host.h" #include "chrome/browser/cancelable_request.h" @@ -53,6 +54,7 @@ #include "webkit/glue/webplugin.h" #include "webkit/glue/window_open_disposition.h" +class BookmarkContextMenu; class Browser; class CommandLine; class ConstrainedWindow; @@ -286,14 +288,91 @@ class TableModel { virtual int RowCount() = 0; }; +class MenuItemView { + public: + enum Type { + NORMAL, + SUBMENU, + CHECKBOX, + RADIO, + SEPARATOR + }; + enum AnchorPosition { + TOPLEFT, + TOPRIGHT + }; + MenuItemView(BookmarkContextMenu*) { NOTIMPLEMENTED(); } + void RunMenuAt(gfx::NativeWindow parent, const gfx::Rect& bounds, + AnchorPosition anchor, bool has_mnemonics) { + NOTIMPLEMENTED(); + } + void Cancel() { NOTIMPLEMENTED(); } + void AppendMenuItem(int item_id, const std::wstring& label, Type type) { + NOTIMPLEMENTED(); + } + void AppendMenuItemWithLabel(int item_id, const std::wstring& label) { + NOTIMPLEMENTED(); + } + void AppendSeparator() { NOTIMPLEMENTED(); } +}; + +class MenuDelegate { +}; + +class Window { + public: + void Show() { NOTIMPLEMENTED(); } + virtual void Close() { NOTIMPLEMENTED(); } +}; + } // namespace views +class InputWindowDelegate { +}; + class Menu { public: class Delegate { }; }; +views::Window* CreateInputWindow(gfx::NativeWindow parent_hwnd, + InputWindowDelegate* delegate); + +class BookmarkManagerView { + public: + static BookmarkManagerView* current() { + NOTIMPLEMENTED(); + return NULL; + } + static void Show(Profile* profile) { NOTIMPLEMENTED(); } + void SelectInTree(BookmarkNode* node) { NOTIMPLEMENTED(); } + Profile* profile() const { + NOTIMPLEMENTED(); + return NULL; + } +}; + +class BookmarkEditorView { + public: + class Handler { + }; + enum Configuration { + SHOW_TREE, + NO_TREE + }; + static void Show(gfx::NativeWindow parent_window, Profile* profile, + BookmarkNode* parent, BookmarkNode* node, + Configuration configuration, Handler* handler) { + NOTIMPLEMENTED(); + } +}; + +class BookmarkBarView { + public: + static void ToggleWhenVisible(Profile* profile) { NOTIMPLEMENTED(); } +}; + //--------------------------------------------------------------------------- // These stubs are for Browser |