diff options
| author | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-25 06:43:01 +0000 |
|---|---|---|
| committer | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-25 06:43:01 +0000 |
| commit | d851d064ee06e6835b7ef153ec4afe5c3aeb77ee (patch) | |
| tree | 6451decd1cf8cd2d63c68c03ec56155178496698 | |
| parent | b208f96775c3fa1a3b4696a1d80b8db216fc7a4e (diff) | |
| download | chromium_src-d851d064ee06e6835b7ef153ec4afe5c3aeb77ee.zip chromium_src-d851d064ee06e6835b7ef153ec4afe5c3aeb77ee.tar.gz chromium_src-d851d064ee06e6835b7ef153ec4afe5c3aeb77ee.tar.bz2 | |
Remove Net.URLRequest_SetReferrer_IsEmptyOrValid histogram.
According to internal stats, this was the top 5 histogram
that's taking up space in UMA and it was never documented
in histograms.xml, which means no one has ever looked at
its data. Delete it so that it stop taking resources without
providing value.
Document it in histograms.xml so that previous data can
still be viewed on the dashboard, if needed.
BUG=387734
Review URL: https://codereview.chromium.org/331343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279639 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | net/url_request/url_request.cc | 3 | ||||
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 8 |
2 files changed, 8 insertions, 3 deletions
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc index 72f5c32..5466be1 100644 --- a/net/url_request/url_request.cc +++ b/net/url_request/url_request.cc @@ -12,7 +12,6 @@ #include "base/lazy_instance.h" #include "base/memory/singleton.h" #include "base/message_loop/message_loop.h" -#include "base/metrics/histogram.h" #include "base/metrics/stats_counters.h" #include "base/metrics/user_metrics.h" #include "base/stl_util.h" @@ -595,8 +594,6 @@ std::string URLRequest::ComputeMethodForRedirect( void URLRequest::SetReferrer(const std::string& referrer) { DCHECK(!is_pending_); GURL referrer_url(referrer); - UMA_HISTOGRAM_BOOLEAN("Net.URLRequest_SetReferrer_IsEmptyOrValid", - referrer_url.is_empty() || referrer_url.is_valid()); if (referrer_url.is_valid()) { referrer_ = referrer_url.GetAsReferrer().spec(); } else { diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 6e009c4..cfa152a 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -15948,6 +15948,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. <summary>The time spent in closesocket call in UDPSocketWin::Close.</summary> </histogram> +<histogram name="Net.URLRequest_SetReferrer_IsEmptyOrValid" enum="Boolean"> + <obsolete> + Deprecated 6/23/2014. No longer tracked. + </obsolete> + <owner>Please list the metric's owners. Add more owner tags as needed.</owner> + <summary>True if a URLRequest's referrer is empty or valid when set.</summary> +</histogram> + <histogram name="Net.WebSocket.DeflateMode" enum="WebSocketNewPerMessageDeflateContextTakeoverMode"> <owner>yhirano@chromium.org</owner> |