summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormaruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-15 14:19:44 +0000
committermaruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-15 14:19:44 +0000
commitd8b50bece6058f921006bc734bd045fa55ff49be (patch)
treef30ebf8254552e5bf6e39080e2aada3a06396b78
parent10d9994d02822e0cd99349d01414792eca69ac6d (diff)
downloadchromium_src-d8b50bece6058f921006bc734bd045fa55ff49be.zip
chromium_src-d8b50bece6058f921006bc734bd045fa55ff49be.tar.gz
chromium_src-d8b50bece6058f921006bc734bd045fa55ff49be.tar.bz2
Simplify the author check.
2 lines removed! R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7144016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89182 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--PRESUBMIT.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 6fface8..b11ed8d 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -111,9 +111,7 @@ def _CheckAuthorizedAuthor(input_api, output_api):
valid_authors = [item.group(1).lower() for item in valid_authors if item]
if input_api.verbose:
print 'Valid authors are %s' % ', '.join(valid_authors)
- if not any(
- True for valid in valid_authors
- if fnmatch.fnmatch(author.lower(), valid)):
+ if not any(fnmatch.fnmatch(author.lower(), valid) for valid in valid_authors):
return [output_api.PresubmitPromptWarning(
('%s is not in AUTHORS file. If you are a new contributor, please visit'
'\n'