diff options
| author | boliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 08:05:21 +0000 |
|---|---|---|
| committer | boliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 08:05:21 +0000 |
| commit | de874b474abb19016f89231f5cd8ef009004659e (patch) | |
| tree | d6fadfdeafc7b1806f50576f714e4fedc638cf1c | |
| parent | e283d027e305f681c490fc99d9eff452e9863eb8 (diff) | |
| download | chromium_src-de874b474abb19016f89231f5cd8ef009004659e.zip chromium_src-de874b474abb19016f89231f5cd8ef009004659e.tar.gz chromium_src-de874b474abb19016f89231f5cd8ef009004659e.tar.bz2 | |
base: Default android version to 4.4.99
Under-development Android versions do not have a numeric
version, so falls back to a "default version".
Using a real released Android version like 4.3.0 will
incorrectly trigger code paths, such has version-specific
gpu blacklists.
First attempt at fixing this was using 0.0.0, which caused
websites parsing Android version in the user agent to break.
So this is the second attempt, use the latest public major
version and minor version, and use a higher bug release
version to avoid conflicts with the gpu blacklist.
BUG=387179
Review URL: https://codereview.chromium.org/381813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282281 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | base/sys_info_android.cc | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/base/sys_info_android.cc b/base/sys_info_android.cc index ab7c05d..92eefef 100644 --- a/base/sys_info_android.cc +++ b/base/sys_info_android.cc @@ -17,11 +17,12 @@ namespace { // Default version of Android to fall back to when actual version numbers -// cannot be acquired. This is an obviously invalid version number. Code -// doing version comparison should treat it as so and fail all comparisons. -const int kDefaultAndroidMajorVersion = 0; -const int kDefaultAndroidMinorVersion = 0; -const int kDefaultAndroidBugfixVersion = 0; +// cannot be acquired. Use the latest Android release with a higher bug fix +// version to avoid unnecessarily comparison errors with the latest release. +// This should be manually kept up-to-date on each Android release. +const int kDefaultAndroidMajorVersion = 4; +const int kDefaultAndroidMinorVersion = 4; +const int kDefaultAndroidBugfixVersion = 99; // Parse out the OS version numbers from the system properties. void ParseOSVersionNumbers(const char* os_version_str, |