summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordavidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-14 23:27:09 +0000
committerdavidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-14 23:27:09 +0000
commitde900c86488cedacb8b83fccdce721d66d37a19e (patch)
treebfc49ba59f9a9603d24b8fe27a6ea25eea97f02d
parent7a7e08546c85dd5a039c8dd0e57bae1cd384fc44 (diff)
downloadchromium_src-de900c86488cedacb8b83fccdce721d66d37a19e.zip
chromium_src-de900c86488cedacb8b83fccdce721d66d37a19e.tar.gz
chromium_src-de900c86488cedacb8b83fccdce721d66d37a19e.tar.bz2
Remove RenderViewImpl::didStartProvisionalLoad.
Now that WebTestProxy is in Chromium rather than Blink, this is pretty easy. BUG=304341 Review URL: https://codereview.chromium.org/236023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263745 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--content/renderer/render_view_impl.cc3
-rw-r--r--content/renderer/render_view_impl.h1
-rw-r--r--content/shell/renderer/test_runner/WebTestProxy.h5
3 files changed, 0 insertions, 9 deletions
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index ca1bb65..4dfcd4f8 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2348,9 +2348,6 @@ void RenderViewImpl::ProcessViewLayoutFlags(const CommandLine& command_line) {
webview()->setPageScaleFactorLimits(1, maxPageScaleFactor);
}
-// TODO(nasko): Remove this method once WebTestProxy in Blink is fixed.
-void RenderViewImpl::didStartProvisionalLoad(WebLocalFrame* frame) {}
-
void RenderViewImpl::didFailProvisionalLoad(WebLocalFrame* frame,
const WebURLError& error) {
// Notify the browser that we failed a provisional load with an error.
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index a784940..6276d92 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -516,7 +516,6 @@ class CONTENT_EXPORT RenderViewImpl
const blink::WebFormElement& form);
virtual void didCreateDataSource(blink::WebLocalFrame* frame,
blink::WebDataSource* datasource);
- virtual void didStartProvisionalLoad(blink::WebLocalFrame* frame);
virtual void didFailProvisionalLoad(blink::WebLocalFrame* frame,
const blink::WebURLError& error);
virtual void didClearWindowObject(blink::WebLocalFrame* frame, int world_id);
diff --git a/content/shell/renderer/test_runner/WebTestProxy.h b/content/shell/renderer/test_runner/WebTestProxy.h
index ff59506..a2197d5 100644
--- a/content/shell/renderer/test_runner/WebTestProxy.h
+++ b/content/shell/renderer/test_runner/WebTestProxy.h
@@ -358,11 +358,6 @@ public:
WebTestProxyBase::resetInputMethod();
}
- virtual void didStartProvisionalLoad(blink::WebLocalFrame* frame)
- {
- WebTestProxyBase::didStartProvisionalLoad(frame);
- Base::didStartProvisionalLoad(frame);
- }
virtual void didReceiveServerRedirectForProvisionalLoad(blink::WebLocalFrame* frame)
{
WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad(frame);