diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-20 22:00:44 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-20 22:00:44 +0000 |
| commit | e08a579d8d6701fa48eac6945248855bbb5a70a6 (patch) | |
| tree | d9174ff8675a56111218862145896d746b7b0651 | |
| parent | 2fd8bf4d23e774eeb215991590569c2220bb65be (diff) | |
| download | chromium_src-e08a579d8d6701fa48eac6945248855bbb5a70a6.zip chromium_src-e08a579d8d6701fa48eac6945248855bbb5a70a6.tar.gz chromium_src-e08a579d8d6701fa48eac6945248855bbb5a70a6.tar.bz2 | |
Fix DCHECK in DownloadRequestDialogDelegateWin::DeleteDelegate
This DCHECK occurs when we click Allow on the "This webpage is trying to download multiple files" dialog.
When...
DownloadRequestDialogDelegate
... and ...
DownloadRequestDialogDelegateWin
... were created, both classes by accident contained a host_ member.
This causes a DCHECK in...
DownloadRequestDialogDelegateWin::DeleteDelegate()
... because the host_ in the child class is never initialized. I
believe the intent is to check the host_ of the parent class, so
I deleted the definition of host from xxxDelegateWin.
Review URL: http://codereview.chromium.org/50072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12220 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/download/download_request_dialog_delegate_win.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/download/download_request_dialog_delegate_win.h b/chrome/browser/download/download_request_dialog_delegate_win.h index 89c6812..7e5f83f 100644 --- a/chrome/browser/download/download_request_dialog_delegate_win.h +++ b/chrome/browser/download/download_request_dialog_delegate_win.h @@ -38,9 +38,6 @@ class DownloadRequestDialogDelegateWin : public DownloadRequestDialogDelegate, } virtual void DeleteDelegate(); - // The TabDownloadState we're displaying the dialog for. May be null. - DownloadRequestManager::TabDownloadState* host_; - MessageBoxView* message_view_; ConstrainedWindow* window_; |