diff options
author | mnaganov <mnaganov@chromium.org> | 2015-12-30 09:14:41 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-30 17:15:39 +0000 |
commit | e305ad32f496d61cf9b38575e3ba02db882e61c2 (patch) | |
tree | c7c28588de0e7a0f9a62809cbf455623f241353f | |
parent | 34e0e082ff62320a32a56d8b4e61eca1101bb9a5 (diff) | |
download | chromium_src-e305ad32f496d61cf9b38575e3ba02db882e61c2.zip chromium_src-e305ad32f496d61cf9b38575e3ba02db882e61c2.tar.gz chromium_src-e305ad32f496d61cf9b38575e3ba02db882e61c2.tar.bz2 |
[Android] Call DevToolsServer.destroy where needed
[Aw]DevToolsServer is initialized in AwShellActivity, ChromeApplication,
and WebViewChromiumFactoryProvider. Make sure it is destroyed in the first
two instances. WebView lacks shutdown path, thus we can't do much there.
BUG=368171
Review URL: https://codereview.chromium.org/1559433002
Cr-Commit-Position: refs/heads/master@{#367159}
-rw-r--r-- | android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java | 9 | ||||
-rw-r--r-- | chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java | 4 |
2 files changed, 13 insertions, 0 deletions
diff --git a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java index 3ed04908..deb0ccb 100644 --- a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java +++ b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java @@ -119,6 +119,15 @@ public class AwShellActivity extends Activity { } } + @Override + public void onDestroy() { + if (mDevToolsServer != null) { + mDevToolsServer.destroy(); + mDevToolsServer = null; + } + super.onDestroy(); + } + private AwTestContainerView createAwTestContainerView() { AwBrowserProcess.start(this); AwTestContainerView testContainerView = new AwTestContainerView(this, true); diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java index db9d33a..c6b483d 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java @@ -327,6 +327,10 @@ public class ChromeApplication extends ContentApplication { private void onForegroundActivityDestroyed() { if (ApplicationStatus.isEveryActivityDestroyed()) { mBackgroundProcessing.onDestroy(); + if (mDevToolsServer != null) { + mDevToolsServer.destroy(); + mDevToolsServer = null; + } stopApplicationActivityTracker(); PartnerBrowserCustomizations.destroy(); ShareHelper.clearSharedImages(this); |