diff options
| author | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-15 11:55:52 +0000 |
|---|---|---|
| committer | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-15 11:55:52 +0000 |
| commit | e47c53d4c0a7dd696b0193fb79c2925ba6416818 (patch) | |
| tree | b436126298a2ebb065c4d3d7d58b51c349f1325c | |
| parent | 6c069aa5a2eeb995fcfd4122b6fa411e09f4fb6b (diff) | |
| download | chromium_src-e47c53d4c0a7dd696b0193fb79c2925ba6416818.zip chromium_src-e47c53d4c0a7dd696b0193fb79c2925ba6416818.tar.gz chromium_src-e47c53d4c0a7dd696b0193fb79c2925ba6416818.tar.bz2 | |
Show the speech input bubble immediately after user clicks.
Earlier we were waiting for background noise estimation to complete (in a few hundred milliseconds)
before displaying the bubble. Based on UX feedback I'm removing that wait now.
BUG=none
TEST=manual, check that bubble shows up instantly on clicking the mic button.
Review URL: http://codereview.chromium.org/6673043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78196 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/speech/speech_input_manager.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/chrome/browser/speech/speech_input_manager.cc b/chrome/browser/speech/speech_input_manager.cc index 09836d4..fe2676c 100644 --- a/chrome/browser/speech/speech_input_manager.cc +++ b/chrome/browser/speech/speech_input_manager.cc @@ -247,6 +247,7 @@ void SpeechInputManagerImpl::StartRecognitionForRequest(int caller_id) { recording_caller_id_ = caller_id; requests_[caller_id].is_active = true; requests_[caller_id].recognizer->StartRecording(); + bubble_controller_->SetBubbleRecordingMode(caller_id); } } @@ -336,10 +337,6 @@ void SpeechInputManagerImpl::OnRecognizerError( void SpeechInputManagerImpl::DidCompleteEnvironmentEstimation(int caller_id) { DCHECK(HasPendingRequest(caller_id)); DCHECK(recording_caller_id_ == caller_id); - - // Speech recognizer has gathered enough background audio so we can ask the - // user to start speaking. - bubble_controller_->SetBubbleRecordingMode(caller_id); } void SpeechInputManagerImpl::SetInputVolume(int caller_id, float volume, |