diff options
author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-19 00:06:24 +0000 |
---|---|---|
committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-19 00:06:24 +0000 |
commit | e490cf10ce9e9490667edfadd7fa656f4abddade (patch) | |
tree | 8d2ca4dca1ad678b94237132d5fcf726ad110f24 | |
parent | b03f2cc7908c67f23c95ed42b4b892fdae497631 (diff) | |
download | chromium_src-e490cf10ce9e9490667edfadd7fa656f4abddade.zip chromium_src-e490cf10ce9e9490667edfadd7fa656f4abddade.tar.gz chromium_src-e490cf10ce9e9490667edfadd7fa656f4abddade.tar.bz2 |
PRESUBMIT doesn't need to check for old callback system
It's officially dead since Jan. 10 2012
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9423025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122702 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | PRESUBMIT.py | 30 |
1 files changed, 0 insertions, 30 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index e6ef99b..d0305ee 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -182,35 +182,6 @@ def _CheckNoFRIEND_TEST(input_api, output_api): 'FRIEND_TEST_ALL_PREFIXES() instead.\n' + '\n'.join(problems))] -def _CheckNoNewOldCallback(input_api, output_api): - """Checks to make sure we don't introduce new uses of old callbacks.""" - - def HasOldCallbackKeywords(line): - """Returns True if a line of text contains keywords that indicate the use - of the old callback system. - """ - return ('NewRunnableMethod' in line or - 'NewCallback' in line or - input_api.re.search(r'\bCallback\d<', line) or - input_api.re.search(r'\bpublic Task\b', line) or - 'public CancelableTask' in line) - - problems = [] - file_filter = lambda f: f.LocalPath().endswith(('.cc', '.h')) - for f in input_api.AffectedFiles(file_filter=file_filter): - if not any(HasOldCallbackKeywords(line) for line in f.NewContents()): - continue - for line_num, line in f.ChangedContents(): - if HasOldCallbackKeywords(line): - problems.append(' %s:%d' % (f.LocalPath(), line_num)) - - if not problems: - return [] - return [output_api.PresubmitPromptWarning('The old callback system is ' - 'deprecated. If possible, use base::Bind and base::Callback instead.\n' + - '\n'.join(problems))] - - def _CommonChecks(input_api, output_api): """Checks common to both upload and commit.""" results = [] @@ -224,7 +195,6 @@ def _CommonChecks(input_api, output_api): results.extend(_CheckNoNewWStrings(input_api, output_api)) results.extend(_CheckNoDEPSGIT(input_api, output_api)) results.extend(_CheckNoFRIEND_TEST(input_api, output_api)) - results.extend(_CheckNoNewOldCallback(input_api, output_api)) return results |