diff options
| author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-31 09:05:10 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-31 09:05:10 +0000 |
| commit | ebfa161e59a2c2481c4830aa54a693bcb8db04d6 (patch) | |
| tree | bd242015b92fdf744f85e9032d59b5fd8d24c755 | |
| parent | 5a145436666621448c8eafab5006413986137934 (diff) | |
| download | chromium_src-ebfa161e59a2c2481c4830aa54a693bcb8db04d6.zip chromium_src-ebfa161e59a2c2481c4830aa54a693bcb8db04d6.tar.gz chromium_src-ebfa161e59a2c2481c4830aa54a693bcb8db04d6.tar.bz2 | |
Fix memory leak in BrowserThemePack.
BUG=37866
TEST=Linux/CrOS Valgrind unit goes green.
TBR=estade,erg
Review URL: http://codereview.chromium.org/1551008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43191 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/browser_theme_pack.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/browser_theme_pack.cc b/chrome/browser/browser_theme_pack.cc index bfa022d..5f6ca25 100644 --- a/chrome/browser/browser_theme_pack.cc +++ b/chrome/browser/browser_theme_pack.cc @@ -964,6 +964,8 @@ void BrowserThemePack::GenerateTintedButtons( for (std::set<int>::const_iterator it = idr_ids.begin(); it != idr_ids.end(); ++it) { int prs_id = GetPersistentIDByIDR(*it); + if (prs_id < 0) + continue; // Fetch the image by IDR... scoped_ptr<SkBitmap> button(new SkBitmap(*rb.GetBitmapNamed(*it))); |