diff options
| author | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-12 13:56:17 +0000 |
|---|---|---|
| committer | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-12 13:56:17 +0000 |
| commit | ee7df8f58f9172500fd14af56d0e13f2fd37c33a (patch) | |
| tree | 90f302f35f0053d70c9e8c47b0920d1b35af5056 | |
| parent | dad248cdd01397572694d2d4a2780dc35ae6cb56 (diff) | |
| download | chromium_src-ee7df8f58f9172500fd14af56d0e13f2fd37c33a.zip chromium_src-ee7df8f58f9172500fd14af56d0e13f2fd37c33a.tar.gz chromium_src-ee7df8f58f9172500fd14af56d0e13f2fd37c33a.tar.bz2 | |
Start renaming of CreateTabForTesting -> CreateNewTabForDevTools
This rename will require several CL in public and private repositories.
The first step is to add a declaration for the new method to be used
by DevTools.
BUG=265806
Review URL: https://codereview.chromium.org/66533007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234502 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/ui/android/tab_model/tab_model.h | 6 | ||||
| -rw-r--r-- | chrome/browser/ui/android/tab_model/tab_model_unittest.cc | 4 |
2 files changed, 9 insertions, 1 deletions
diff --git a/chrome/browser/ui/android/tab_model/tab_model.h b/chrome/browser/ui/android/tab_model/tab_model.h index 129164a..60ac947 100644 --- a/chrome/browser/ui/android/tab_model/tab_model.h +++ b/chrome/browser/ui/android/tab_model/tab_model.h @@ -53,9 +53,13 @@ class TabModel : public content::NotificationObserver, // Used for restoring tabs from synced foreign sessions. virtual void CreateTab(content::WebContents* web_contents) = 0; - // Used for creating a new tab with a given URL. + // Used for creating a new tab with a given URL. DO NOT USE. virtual content::WebContents* CreateTabForTesting(const GURL& url) = 0; + // Used by Developer Tools to create a new tab with a given URL. + // Replaces CreateTabForTesting. + virtual content::WebContents* CreateNewTabForDevTools(const GURL& url) = 0; + // Return true if we are currently restoring sessions asynchronously. virtual bool IsSessionRestoreInProgress() const = 0; diff --git a/chrome/browser/ui/android/tab_model/tab_model_unittest.cc b/chrome/browser/ui/android/tab_model/tab_model_unittest.cc index bcddf79..b399b1f 100644 --- a/chrome/browser/ui/android/tab_model/tab_model_unittest.cc +++ b/chrome/browser/ui/android/tab_model/tab_model_unittest.cc @@ -38,6 +38,10 @@ class TestTabModel : public TabModel { virtual content::WebContents* CreateTabForTesting(const GURL& url) OVERRIDE { return NULL; } + virtual content::WebContents* CreateNewTabForDevTools(const GURL& url) + OVERRIDE { + return NULL; + } virtual bool IsSessionRestoreInProgress() const OVERRIDE { return false; } virtual void OpenClearBrowsingData() const OVERRIDE {} virtual TabAndroid* GetTabAt(int index) const OVERRIDE { |