diff options
| author | asvitkine <asvitkine@chromium.org> | 2015-05-05 13:29:20 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-05 20:29:57 +0000 |
| commit | f65686cdf2a36ae94d4a39dbf5ec8d50ff7c8e4f (patch) | |
| tree | 36a4f178eebb5ed53971458e2d6ba6d51f7b18af | |
| parent | 2ac89dd3c312af5fb7950803594986b50dcc5c91 (diff) | |
| download | chromium_src-f65686cdf2a36ae94d4a39dbf5ec8d50ff7c8e4f.zip chromium_src-f65686cdf2a36ae94d4a39dbf5ec8d50ff7c8e4f.tar.gz chromium_src-f65686cdf2a36ae94d4a39dbf5ec8d50ff7c8e4f.tar.bz2 | |
Delete unused FilterURLTermiate_* actions.
These actions currently account for about 5% of Android
UMA data (most taken by FilterURLTermiate_About) and also:
a) do not have any owners, b) have typo in the name and
c) are not even actual user actions (i.e. not directly user
initiated).
If this data is interesting to someone, the metrics can
be re-added with a histogram, which doesn't carry timing
info and thus would be much more efficient.
BUG=387734
Review URL: https://codereview.chromium.org/1125893003
Cr-Commit-Position: refs/heads/master@{#328393}
| -rw-r--r-- | content/browser/renderer_host/render_process_host_impl.cc | 3 | ||||
| -rw-r--r-- | tools/metrics/actions/actions.xml | 3 |
2 files changed, 3 insertions, 3 deletions
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc index 56c8de8..081ff73 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc @@ -1812,7 +1812,6 @@ void RenderProcessHostImpl::FilterURL(RenderProcessHost* rph, // navigation to the home page. This is often a privileged page // (chrome://newtab/) which is exactly what we don't want. *url = GURL(url::kAboutBlankURL); - RecordAction(base::UserMetricsAction("FilterURLTermiate_Invalid")); return; } @@ -1820,7 +1819,6 @@ void RenderProcessHostImpl::FilterURL(RenderProcessHost* rph, // The renderer treats all URLs in the about: scheme as being about:blank. // Canonicalize about: URLs to about:blank. *url = GURL(url::kAboutBlankURL); - RecordAction(base::UserMetricsAction("FilterURLTermiate_About")); } // Do not allow browser plugin guests to navigate to non-web URLs, since they @@ -1834,7 +1832,6 @@ void RenderProcessHostImpl::FilterURL(RenderProcessHost* rph, // later. VLOG(1) << "Blocked URL " << url->spec(); *url = GURL(url::kAboutBlankURL); - RecordAction(base::UserMetricsAction("FilterURLTermiate_Blocked")); } } diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml index 9a859e9..2c47d08 100644 --- a/tools/metrics/actions/actions.xml +++ b/tools/metrics/actions/actions.xml @@ -2784,16 +2784,19 @@ should be able to be added at any place in this file. <action name="FilterURLTermiate_About"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> <description>Please enter the description of this user action.</description> + <obsolete>Removed in M44.</obsolete> </action> <action name="FilterURLTermiate_Blocked"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> <description>Please enter the description of this user action.</description> + <obsolete>Removed in M44.</obsolete> </action> <action name="FilterURLTermiate_Invalid"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> <description>Please enter the description of this user action.</description> + <obsolete>Removed in M44.</obsolete> </action> <action name="Find"> |