diff options
author | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-29 01:06:37 +0000 |
---|---|---|
committer | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-29 01:06:37 +0000 |
commit | f6e50a30b69e57cff3accdb328c22a3912e6f14f (patch) | |
tree | 740dc545f640a83c2e59b8096d65fc124ef3cbed | |
parent | c7eea418d7736a4cbbd85e2c20fb535f29731a48 (diff) | |
download | chromium_src-f6e50a30b69e57cff3accdb328c22a3912e6f14f.zip chromium_src-f6e50a30b69e57cff3accdb328c22a3912e6f14f.tar.gz chromium_src-f6e50a30b69e57cff3accdb328c22a3912e6f14f.tar.bz2 |
Delete long-expired GlobalSdch field trial.
BUG=229940
Review URL: https://chromiumcodereview.appspot.com/16115002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202728 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/chrome_browser_main.cc | 18 | ||||
-rw-r--r-- | chrome/renderer/page_load_histograms.cc | 39 |
2 files changed, 0 insertions, 57 deletions
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc index cfb1378..b832799 100644 --- a/chrome/browser/chrome_browser_main.cc +++ b/chrome/browser/chrome_browser_main.cc @@ -1402,24 +1402,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() { if (!sdch_enabled) net::SdchManager::EnableSdchSupport(false); } - if (sdch_enabled) { - // Perform A/B test to measure global impact of SDCH support. - // Set up a field trial to see what disabling SDCH does to latency of page - // layout globally. - base::FieldTrial::Probability kSDCH_DIVISOR = 1000; - base::FieldTrial::Probability kSDCH_DISABLE_PROBABILITY = 1; // 0.1% prob. - // After March 31, 2012 builds, it will always be in default group. - int sdch_enabled_group = -1; - scoped_refptr<base::FieldTrial> sdch_trial( - base::FieldTrialList::FactoryGetFieldTrial( - "GlobalSdch", kSDCH_DIVISOR, "global_enable_sdch", 2012, 3, 31, - &sdch_enabled_group)); - - sdch_trial->AppendGroup("global_disable_sdch", - kSDCH_DISABLE_PROBABILITY); - if (sdch_enabled_group != sdch_trial->group()) - net::SdchManager::EnableSdchSupport(false); - } if (parsed_command_line().HasSwitch(switches::kEnableWatchdog)) InstallJankometer(parsed_command_line()); diff --git a/chrome/renderer/page_load_histograms.cc b/chrome/renderer/page_load_histograms.cc index 6c5747a..26f798b 100644 --- a/chrome/renderer/page_load_histograms.cc +++ b/chrome/renderer/page_load_histograms.cc @@ -411,45 +411,6 @@ void PageLoadHistograms::Dump(WebFrame* frame) { begin_to_finish_all_loads); } - // Histograms to determine if SDCH has an impact. - // TODO(jar): Consider removing per-link load types and the enumeration. - static const bool use_sdch_histogram = - base::FieldTrialList::TrialExists("GlobalSdch"); - if (use_sdch_histogram) { - UMA_HISTOGRAM_ENUMERATION( - base::FieldTrial::MakeName("PLT.LoadType", "GlobalSdch"), - load_type, DocumentState::kLoadTypeMax); - switch (load_type) { - case DocumentState::NORMAL_LOAD: - PLT_HISTOGRAM(base::FieldTrial::MakeName( - "PLT.BeginToFinish_NormalLoad", "GlobalSdch"), - begin_to_finish_all_loads); - break; - case DocumentState::LINK_LOAD_NORMAL: - PLT_HISTOGRAM(base::FieldTrial::MakeName( - "PLT.BeginToFinish_LinkLoadNormal", "GlobalSdch"), - begin_to_finish_all_loads); - break; - case DocumentState::LINK_LOAD_RELOAD: - PLT_HISTOGRAM(base::FieldTrial::MakeName( - "PLT.BeginToFinish_LinkLoadReload", "GlobalSdch"), - begin_to_finish_all_loads); - break; - case DocumentState::LINK_LOAD_CACHE_STALE_OK: - PLT_HISTOGRAM(base::FieldTrial::MakeName( - "PLT.BeginToFinish_LinkLoadStaleOk", "GlobalSdch"), - begin_to_finish_all_loads); - break; - case DocumentState::LINK_LOAD_CACHE_ONLY: - PLT_HISTOGRAM(base::FieldTrial::MakeName( - "PLT.BeginToFinish_LinkLoadCacheOnly", "GlobalSdch"), - begin_to_finish_all_loads); - break; - default: - break; - } - } - // TODO(mpcomplete): remove the extension-related histograms after we collect // enough data. http://crbug.com/100411 const bool use_adblock_histogram = |