summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNico Weber <thakis@chromium.org>2015-11-12 13:03:03 -0800
committerNico Weber <thakis@chromium.org>2015-11-12 21:05:23 +0000
commitf911237bfc4f8b4e1cf3c772c8e1fa9bd1c3c417 (patch)
treed7ee7a050a954ac460c0bebd6db4dc591cd27d29
parent5251c29d5e7dd2dc399419d6e1a638b1e4765954 (diff)
downloadchromium_src-f911237bfc4f8b4e1cf3c772c8e1fa9bd1c3c417.zip
chromium_src-f911237bfc4f8b4e1cf3c772c8e1fa9bd1c3c417.tar.gz
chromium_src-f911237bfc4f8b4e1cf3c772c8e1fa9bd1c3c417.tar.bz2
Give tools/ a real OWNERS file.
See "[chromium-dev] Adding a real OWNERS file for tools/" https://groups.google.com/a/chromium.org/d/msg/chromium-dev/qYrZ2_Y-2dI/S0TsAnTDEQAJ This allows removing several `set noparent`s and makes it unnecessary to add more of those in other places (e.g. tools/grit, tools/clang, ...). The idea is that tools is still a good place to put your one-off scripts that you want to share with others and this shouldn't add any friction for adding More Stuff, so it's ok to TBR for new tools/ subfolders. But existing tools/ should be reviewed by the folks who wrote them (or you can say OWNERS=* in your subfolder). I added per-file OWNERS for most files that live directly in tools/, and an OWNERS file for grit now that it lives in src. Some tools/ subfolders currently lack OWNERS files, please add those as required. BUG=none R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1437683006 . Cr-Commit-Position: refs/heads/master@{#359384}
-rw-r--r--tools/OWNERS52
-rw-r--r--tools/copyright_scanner/OWNERS1
-rw-r--r--tools/cros/OWNERS3
-rw-r--r--tools/grit/OWNERS5
-rw-r--r--tools/memory/OWNERS1
-rw-r--r--tools/metrics/OWNERS2
-rw-r--r--tools/perf/OWNERS1
-rw-r--r--tools/telemetry/OWNERS3
-rw-r--r--tools/valgrind/OWNERS1
-rw-r--r--tools/variations/OWNERS1
10 files changed, 56 insertions, 14 deletions
diff --git a/tools/OWNERS b/tools/OWNERS
index 72e8ffc..2cc9976 100644
--- a/tools/OWNERS
+++ b/tools/OWNERS
@@ -1 +1,51 @@
-*
+# You can add new small tools to this directory at your desire, feel free
+# to owners-TBR new folders (assuming you have a regular review already,
+# of course). Include an OWNERS file with at least two people for your new
+# folder.
+# If you're changing existing tools, have your change reviewed by the
+# OWNERS of the existing tool.
+
+scottmg@chromium.org
+thakis@chromium.org
+
+
+per-file bisect*.py=rsesek@chromium.org
+per-file bisect*.py=rmcilroy@chromium.org
+per-file run-bisect*.py=rmcilroy@chromium.org
+per-file prepare-bisect*.py=simonhatch@chromium.org
+per-file prepare-bisect*.py=rmcilroy@chromium.org
+
+per-file boilerplate.py=rmcilroy@chromium.org
+
+per-file check_git_config.py=iannucci@chromium.org
+per-file check_git_config.py=vadimsh@chromium.org
+
+per-file check_grd_for_unused_strings.py=estade@chromium.org
+
+per-file gyp-explain.py=thakis@chromium.org
+
+per-file gypv8shy.py=jochen@chromium.org
+
+per-file include_tracer.py=thakis@chromium.org
+
+per-file ipc_messages_log.py=yfriedman@chromium.org
+
+per-file isolate_driver.py=maruel@chromium.org
+per-file isolate_driver.py=vadimsh@chromium.org
+
+per-file licenses.py=file://tools/copyright_scanner/OWNERS
+
+per-file profile_chrome.py=alokp@chromium.org
+per-file profile_chrome_startup.py=alokp@chromium.org
+
+per-file remove_stale_pyc_files.py=dtu@chromium.org
+
+per-file roll_angle.py=kjellander@chromium.org
+per-file roll_webrtc.py=kjellander@chromium.org
+
+per-file safely-roll-deps.py=borenet@chromium.org
+
+per-file sort-headers.py=satorux@chromium.org
+per-file sort-sources.py=satorux@chromium.org
+per-file yes_no.py=satorux@chromium.org
+
diff --git a/tools/copyright_scanner/OWNERS b/tools/copyright_scanner/OWNERS
index 5341782..bf52737 100644
--- a/tools/copyright_scanner/OWNERS
+++ b/tools/copyright_scanner/OWNERS
@@ -1,4 +1,3 @@
-set noparent
mnaganov@chromium.org
phajdan.jr@chromium.org
torne@chromium.org
diff --git a/tools/cros/OWNERS b/tools/cros/OWNERS
index 4bb8766..9dc4e19 100644
--- a/tools/cros/OWNERS
+++ b/tools/cros/OWNERS
@@ -1,9 +1,6 @@
# For more information about telemetry development, please see:
# http://dev.chromium.org/developers/telemetry/telemetry-feature-guidelines
-# The set noparent is temporary until src/OWNERS isn't *.
-set noparent
-
achuith@chromium.org
tbarzic@chromium.org
tengs@chromium.org
diff --git a/tools/grit/OWNERS b/tools/grit/OWNERS
new file mode 100644
index 0000000..765485d
--- /dev/null
+++ b/tools/grit/OWNERS
@@ -0,0 +1,5 @@
+flackr@chromium.org
+mnissler@chromium.org
+newt@chromium.org
+thakis@chromium.org
+thestig@chromium.org
diff --git a/tools/memory/OWNERS b/tools/memory/OWNERS
index 00ab082..2351a9f 100644
--- a/tools/memory/OWNERS
+++ b/tools/memory/OWNERS
@@ -1,4 +1,3 @@
-set noparent
bruening@chromium.org
glider@chromium.org
thestig@chromium.org
diff --git a/tools/metrics/OWNERS b/tools/metrics/OWNERS
index 10c75d5..d38b77e 100644
--- a/tools/metrics/OWNERS
+++ b/tools/metrics/OWNERS
@@ -1,5 +1,3 @@
-set noparent
-
asvitkine@chromium.org
isherman@chromium.org
jar@chromium.org
diff --git a/tools/perf/OWNERS b/tools/perf/OWNERS
index 0827cf2..05852f6 100644
--- a/tools/perf/OWNERS
+++ b/tools/perf/OWNERS
@@ -1,4 +1,3 @@
-set noparent
achuith@chromium.org
aiolos@chromium.org
dtu@chromium.org
diff --git a/tools/telemetry/OWNERS b/tools/telemetry/OWNERS
index e467def..3303ce3 100644
--- a/tools/telemetry/OWNERS
+++ b/tools/telemetry/OWNERS
@@ -1,9 +1,6 @@
# For more information about telemetry development, please see:
# http://dev.chromium.org/developers/telemetry/telemetry-feature-guidelines
-# The set noparent is temporary until src/OWNERS isn't *.
-set noparent
-
# For CrOS-related changes.
achuith@chromium.org
diff --git a/tools/valgrind/OWNERS b/tools/valgrind/OWNERS
index e1a653b..2989131 100644
--- a/tools/valgrind/OWNERS
+++ b/tools/valgrind/OWNERS
@@ -1,4 +1,3 @@
-set noparent
bruening@chromium.org
glider@chromium.org
thestig@chromium.org
diff --git a/tools/variations/OWNERS b/tools/variations/OWNERS
index 257e61a..5468518 100644
--- a/tools/variations/OWNERS
+++ b/tools/variations/OWNERS
@@ -1,3 +1,2 @@
-set noparent
asvitkine@chromium.org
danduong@chromium.org