summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-21 07:01:10 +0000
committerdmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-21 07:01:10 +0000
commitfb7ec648730a491a9342fe4200bc5304cd72bbc4 (patch)
tree757e2f6f1a3d6f2e2defc828c6e335ecc05f3122
parent102d4efc86b9a546dfba16b9eb781ad2de03bed6 (diff)
downloadchromium_src-fb7ec648730a491a9342fe4200bc5304cd72bbc4.zip
chromium_src-fb7ec648730a491a9342fe4200bc5304cd72bbc4.tar.gz
chromium_src-fb7ec648730a491a9342fe4200bc5304cd72bbc4.tar.bz2
PPAPI: Remove out-dated or unnecessary TODOs from public files.
BUG= TEST= Review URL: http://codereview.chromium.org/9731003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127918 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--ppapi/api/ppb_file_system.idl5
-rw-r--r--ppapi/api/ppb_graphics_2d.idl7
-rw-r--r--ppapi/c/ppb_file_system.h6
-rw-r--r--ppapi/c/ppb_graphics_2d.h8
-rw-r--r--ppapi/cpp/var.cc5
5 files changed, 2 insertions, 29 deletions
diff --git a/ppapi/api/ppb_file_system.idl b/ppapi/api/ppb_file_system.idl
index 20d43bf..1675d30 100644
--- a/ppapi/api/ppb_file_system.idl
+++ b/ppapi/api/ppb_file_system.idl
@@ -52,11 +52,6 @@ interface PPB_FileSystem {
*
* @return An int32_t containing an error code from <code>pp_errors.h</code>.
*/
-
- /*
- * TODO(brettw) clarify whether this must have completed before a file can
- * be opened in it. Clarify what it means to be "completed."
- */
int32_t Open([in] PP_Resource file_system,
[in] int64_t expected_size,
[in] PP_CompletionCallback callback);
diff --git a/ppapi/api/ppb_graphics_2d.idl b/ppapi/api/ppb_graphics_2d.idl
index 0e0649e..938f428 100644
--- a/ppapi/api/ppb_graphics_2d.idl
+++ b/ppapi/api/ppb_graphics_2d.idl
@@ -239,13 +239,6 @@ interface PPB_Graphics2D {
* not issued its callback yet. In the failure case, nothing will be updated
* and no callback will be scheduled.
*/
-
- /* TODO(darin): We should ensure that the completion callback always runs, so
- * that it is easier for consumers to manage memory referenced by a callback.
- *
- * TODO(): Add back in the synchronous mode description once we have support
- * for it.
- */
int32_t Flush(
[in] PP_Resource graphics_2d,
[in] PP_CompletionCallback callback);
diff --git a/ppapi/c/ppb_file_system.h b/ppapi/c/ppb_file_system.h
index a018538..8eb94a1 100644
--- a/ppapi/c/ppb_file_system.h
+++ b/ppapi/c/ppb_file_system.h
@@ -3,7 +3,7 @@
* found in the LICENSE file.
*/
-/* From ppb_file_system.idl modified Wed Feb 15 13:55:58 2012. */
+/* From ppb_file_system.idl modified Mon Mar 19 11:36:09 2012. */
#ifndef PPAPI_C_PPB_FILE_SYSTEM_H_
#define PPAPI_C_PPB_FILE_SYSTEM_H_
@@ -68,10 +68,6 @@ struct PPB_FileSystem_1_0 {
*
* @return An int32_t containing an error code from <code>pp_errors.h</code>.
*/
- /*
- * TODO(brettw) clarify whether this must have completed before a file can
- * be opened in it. Clarify what it means to be "completed."
- */
int32_t (*Open)(PP_Resource file_system,
int64_t expected_size,
struct PP_CompletionCallback callback);
diff --git a/ppapi/c/ppb_graphics_2d.h b/ppapi/c/ppb_graphics_2d.h
index 9224d1b..6c41f3f 100644
--- a/ppapi/c/ppb_graphics_2d.h
+++ b/ppapi/c/ppb_graphics_2d.h
@@ -3,7 +3,7 @@
* found in the LICENSE file.
*/
-/* From ppb_graphics_2d.idl modified Tue Jan 24 16:03:48 2012. */
+/* From ppb_graphics_2d.idl modified Mon Mar 19 11:35:04 2012. */
#ifndef PPAPI_C_PPB_GRAPHICS_2D_H_
#define PPAPI_C_PPB_GRAPHICS_2D_H_
@@ -245,12 +245,6 @@ struct PPB_Graphics2D_1_0 {
* not issued its callback yet. In the failure case, nothing will be updated
* and no callback will be scheduled.
*/
- /* TODO(darin): We should ensure that the completion callback always runs, so
- * that it is easier for consumers to manage memory referenced by a callback.
- *
- * TODO(): Add back in the synchronous mode description once we have support
- * for it.
- */
int32_t (*Flush)(PP_Resource graphics_2d,
struct PP_CompletionCallback callback);
};
diff --git a/ppapi/cpp/var.cc b/ppapi/cpp/var.cc
index 7748ff2..881ce32 100644
--- a/ppapi/cpp/var.cc
+++ b/ppapi/cpp/var.cc
@@ -219,9 +219,6 @@ std::string Var::DebugString() const {
} else if (is_bool()) {
snprintf(buf, sizeof(buf), AsBool() ? "Var(true)" : "Var(false)");
} else if (is_int()) {
- // Note that the following static_cast is necessary because
- // NativeClient's int32_t is actually "long".
- // TODO(sehr,polina): remove this after newlib is changed.
snprintf(buf, sizeof(buf), "Var(%d)", static_cast<int>(AsInt()));
} else if (is_double()) {
snprintf(buf, sizeof(buf), "Var(%f)", AsDouble());
@@ -236,8 +233,6 @@ std::string Var::DebugString() const {
}
snprintf(buf, sizeof(buf), format, str.c_str());
} else if (is_array_buffer()) {
- // TODO(dmichael): We could make this dump hex. Maybe DebugString should be
- // virtual?
snprintf(buf, sizeof(buf), "Var(ARRAY_BUFFER)");
} else if (is_object()) {
snprintf(buf, sizeof(buf), "Var(OBJECT)");