diff options
| author | lipalani@chromium.org <lipalani@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-05 18:23:39 +0000 |
|---|---|---|
| committer | lipalani@chromium.org <lipalani@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-05 18:23:39 +0000 |
| commit | fc7ddae208d668473b8a2a794e7a4e04ccd1a7c1 (patch) | |
| tree | 2acca0a522630b0eafc20eb530700a284d5027a5 | |
| parent | 3e05914b82f1ceeb4aebacd2a4fdec9372fb6f22 (diff) | |
| download | chromium_src-fc7ddae208d668473b8a2a794e7a4e04ccd1a7c1.zip chromium_src-fc7ddae208d668473b8a2a794e7a4e04ccd1a7c1.tar.gz chromium_src-fc7ddae208d668473b8a2a794e7a4e04ccd1a7c1.tar.bz2 | |
Introduce a button to toggle hiding/showing of the details in the events tab.
BUG=314863
R=kjiwa@google.com, rlarocque@chromium.org
Review URL: https://codereview.chromium.org/53153010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233031 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/resources/sync_internals/events.html | 4 | ||||
| -rw-r--r-- | chrome/browser/resources/sync_internals/events.js | 21 |
2 files changed, 23 insertions, 2 deletions
diff --git a/chrome/browser/resources/sync_internals/events.html b/chrome/browser/resources/sync_internals/events.html index b1883e7..6fed9d2 100644 --- a/chrome/browser/resources/sync_internals/events.html +++ b/chrome/browser/resources/sync_internals/events.html @@ -12,6 +12,10 @@ #sync-events > tr { vertical-align: top; } + +.hidden { + display: none; +} </style> <table id="sync-events-table"> diff --git a/chrome/browser/resources/sync_internals/events.js b/chrome/browser/resources/sync_internals/events.js index 0cda086..e05510b 100644 --- a/chrome/browser/resources/sync_internals/events.js +++ b/chrome/browser/resources/sync_internals/events.js @@ -3,7 +3,17 @@ // found in the LICENSE file. (function() { -function makeLogEntryNode(entry) { +'use strict'; +var toggleDisplay = function() { + var detailsNode = this.parentNode.getElementsByClassName('details')[0]; + if (detailsNode.classList.contains('hidden')) { + detailsNode.classList.remove('hidden'); + } else { + detailsNode.classList.add('hidden'); + } +} + +var makeLogEntryNode = function(entry) { var timeNode = document.createElement('td'); timeNode.textContent = entry.date; @@ -15,7 +25,14 @@ function makeLogEntryNode(entry) { var details = document.createElement('pre'); details.textContent = JSON.stringify(entry.details, null, 2); + details.className = 'details'; + details.classList.add('details'); + details.classList.add('hidden'); + var detailsToggleButton = document.createElement('button'); + detailsToggleButton.addEventListener('click', toggleDisplay, false); + detailsToggleButton.textContent = 'Show/Hide Details'; var detailsNode = document.createElement('td'); + detailsNode.appendChild(detailsToggleButton); detailsNode.appendChild(details); var node = document.createElement('tr'); @@ -27,7 +44,7 @@ function makeLogEntryNode(entry) { return node; } -var syncEvents = document.getElementById('sync-events'); +var syncEvents = $('sync-events'); var entries = chrome.sync.log.entries; for (var i = 0; i < entries.length; ++i) { |